[INFO] crate rawloader 0.35.3 is already in cache [INFO] extracting crate rawloader 0.35.3 into work/ex/clippy-test-run/sources/stable/reg/rawloader/0.35.3 [INFO] extracting crate rawloader 0.35.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rawloader/0.35.3 [INFO] validating manifest of rawloader-0.35.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rawloader-0.35.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rawloader-0.35.3 [INFO] finished frobbing rawloader-0.35.3 [INFO] frobbed toml for rawloader-0.35.3 written to work/ex/clippy-test-run/sources/stable/reg/rawloader/0.35.3/Cargo.toml [INFO] started frobbing rawloader-0.35.3 [INFO] finished frobbing rawloader-0.35.3 [INFO] frobbed toml for rawloader-0.35.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rawloader/0.35.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rawloader-0.35.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rawloader/0.35.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0decb483823c814b45236924fbec670564892b81228aa3d02fc32a723847d47e [INFO] running `"docker" "start" "-a" "0decb483823c814b45236924fbec670564892b81228aa3d02fc32a723847d47e"` [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling serde v1.0.85 [INFO] [stderr] Compiling num-integer v0.1.39 [INFO] [stderr] Compiling proc-macro2 v0.4.26 [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Compiling num-iter v0.1.37 [INFO] [stderr] Compiling num-rational v0.2.1 [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Compiling quote v0.6.11 [INFO] [stderr] Compiling toml v0.4.10 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Compiling rawloader v0.35.3 (/opt/crater/workdir) [INFO] [stderr] Compiling serde_derive v1.0.85 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:84:7 [INFO] [stderr] | [INFO] [stderr] 84 | wb_coeffs: wb_coeffs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wb_coeffs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pumps.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:87:7 [INFO] [stderr] | [INFO] [stderr] 87 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:96:7 [INFO] [stderr] | [INFO] [stderr] 96 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | huffval: huffval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `huffval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:105:7 [INFO] [stderr] | [INFO] [stderr] 105 | dng_bug: dng_bug, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dng_bug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:84:7 [INFO] [stderr] | [INFO] [stderr] 84 | wb_coeffs: wb_coeffs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wb_coeffs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | csfix: csfix, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `csfix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pumps.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:183:7 [INFO] [stderr] | [INFO] [stderr] 183 | sof: sof, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:87:7 [INFO] [stderr] | [INFO] [stderr] 87 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:186:7 [INFO] [stderr] | [INFO] [stderr] 186 | dhts: dhts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dhts` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:96:7 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 96 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | huffval: huffval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `huffval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:105:7 [INFO] [stderr] | [INFO] [stderr] 105 | dng_bug: dng_bug, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dng_bug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:91:7 [INFO] [stderr] | [INFO] [stderr] 91 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:144:7 [INFO] [stderr] | [INFO] [stderr] 144 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:185:7 [INFO] [stderr] | [INFO] [stderr] 185 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:188:7 [INFO] [stderr] | [INFO] [stderr] 188 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | csfix: csfix, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `csfix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:236:7 [INFO] [stderr] | [INFO] [stderr] 236 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:237:7 [INFO] [stderr] | [INFO] [stderr] 237 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:239:7 [INFO] [stderr] | [INFO] [stderr] 239 | start_offset: start_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:183:7 [INFO] [stderr] | [INFO] [stderr] 183 | sof: sof, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sof` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:186:7 [INFO] [stderr] | [INFO] [stderr] 186 | dhts: dhts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dhts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:342:7 [INFO] [stderr] | [INFO] [stderr] 342 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:415:7 [INFO] [stderr] | [INFO] [stderr] 415 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:416:7 [INFO] [stderr] | [INFO] [stderr] 416 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:91:7 [INFO] [stderr] | [INFO] [stderr] 91 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:417:7 [INFO] [stderr] | [INFO] [stderr] 417 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/decoders/tiff.rs:418:7 [INFO] [stderr] | [INFO] [stderr] 418 | parent_offset: parent_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:419:7 [INFO] [stderr] | [INFO] [stderr] 419 | doffset: doffset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `doffset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:144:7 [INFO] [stderr] | [INFO] [stderr] 144 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:78:7 [INFO] [stderr] | [INFO] [stderr] 78 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:116:7 [INFO] [stderr] | [INFO] [stderr] 116 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:185:7 [INFO] [stderr] | [INFO] [stderr] 185 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:117:7 [INFO] [stderr] | [INFO] [stderr] 117 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:188:7 [INFO] [stderr] | [INFO] [stderr] 188 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | bytesize: bytesize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bytesize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | data_offset: data_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:120:7 [INFO] [stderr] | [INFO] [stderr] 120 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:236:7 [INFO] [stderr] | [INFO] [stderr] 236 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:237:7 [INFO] [stderr] | [INFO] [stderr] 237 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:60:7 [INFO] [stderr] | [INFO] [stderr] 60 | data_offset: data_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/decoders/mrw.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | raw_width: raw_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:239:7 [INFO] [stderr] --> src/decoders/mrw.rs:62:7 [INFO] [stderr] | [INFO] [stderr] 239 | start_offset: start_offset, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_offset` [INFO] [stderr] 62 | raw_height: raw_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | packed: packed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `packed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:64:7 [INFO] [stderr] | [INFO] [stderr] 64 | wb_vals: wb_vals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `wb_vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:342:7 [INFO] [stderr] | [INFO] [stderr] 342 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/decoders/mrw.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:415:7 [INFO] [stderr] | [INFO] [stderr] 415 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:416:7 [INFO] [stderr] | [INFO] [stderr] 416 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/arw.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:417:7 [INFO] [stderr] | [INFO] [stderr] 417 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/decoders/tiff.rs:418:7 [INFO] [stderr] | [INFO] [stderr] 418 | parent_offset: parent_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:419:7 [INFO] [stderr] | [INFO] [stderr] 419 | doffset: doffset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `doffset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/arw.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:78:7 [INFO] [stderr] | [INFO] [stderr] 78 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:116:7 [INFO] [stderr] | [INFO] [stderr] 116 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/decoders/mef.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:117:7 [INFO] [stderr] | [INFO] [stderr] 117 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mef.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | bytesize: bytesize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bytesize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | data_offset: data_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:120:7 [INFO] [stderr] | [INFO] [stderr] 120 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/orf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/orf.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/decoders/mrw.rs:60:7 [INFO] [stderr] | [INFO] [stderr] 60 | data_offset: data_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | raw_width: raw_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:62:7 [INFO] [stderr] | [INFO] [stderr] 62 | raw_height: raw_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | packed: packed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `packed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:64:7 [INFO] [stderr] | [INFO] [stderr] 64 | wb_vals: wb_vals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `wb_vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/arw.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/srw.rs:19:7 [INFO] [stderr] --> src/decoders/arw.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/srw.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mef.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mef.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/orf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/orf.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/erf.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/erf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/kdc.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/kdc.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/srw.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/srw.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcs.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcs.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] | [INFO] [stderr] --> src/decoders/erf.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/erf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | split: split, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `split` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/kdc.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/kdc.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcs.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/decoders/dcs.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:74:9 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 74 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | split: split, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `split` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcr.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcr.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcr.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:65:7 [INFO] [stderr] | [INFO] [stderr] 65 | make: make, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `make` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcr.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | clean_make: clean_make, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_make` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | clean_model: clean_model, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_model` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:65:7 [INFO] [stderr] | [INFO] [stderr] 65 | make: make, [INFO] [stderr] --> src/decoders/dng.rs:70:7 [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `make` [INFO] [stderr] | [INFO] [stderr] 70 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | cpp: cpp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:79:7 [INFO] [stderr] | [INFO] [stderr] 79 | orientation: orientation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | clean_make: clean_make, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_make` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | clean_model: clean_model, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | cpp: cpp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pef.rs:19:7 [INFO] [stderr] --> src/decoders/dng.rs:79:7 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 79 | orientation: orientation, [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orientation` [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pef.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:43:7 [INFO] [stderr] | [INFO] [stderr] 43 | tbl: tbl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tbl` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pef.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pef.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:132:7 [INFO] [stderr] | [INFO] [stderr] 132 | ciff: ciff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ciff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:133:7 [INFO] [stderr] | [INFO] [stderr] 133 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:43:7 [INFO] [stderr] | [INFO] [stderr] 43 | tbl: tbl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tbl` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:132:7 [INFO] [stderr] | [INFO] [stderr] 132 | ciff: ciff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ciff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nkd.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:133:7 [INFO] [stderr] | [INFO] [stderr] 133 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mos.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nkd.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mos.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mos.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/iiq.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mos.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/iiq.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/iiq.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/iiq.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tfr.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tfr.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tfr.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tfr.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nef.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nef.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nef.rs:94:7 [INFO] [stderr] | [INFO] [stderr] 94 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nef.rs:94:7 [INFO] [stderr] | [INFO] [stderr] 94 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nrw.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nrw.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nrw.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cr2.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] --> src/decoders/cr2.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nrw.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ari.rs:19:7 [INFO] [stderr] | [INFO] [stderr] --> src/decoders/cr2.rs:19:7 [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cr2.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | dirs: dirs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dirs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ari.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mod.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] [INFO] [stderr] --> src/decoders/x3f.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | dirs: dirs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dirs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mod.rs:337:7 [INFO] [stderr] | [INFO] [stderr] 337 | naked: naked, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `naked` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mod.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mod.rs:337:7 [INFO] [stderr] | [INFO] [stderr] 337 | naked: naked, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `naked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:81:7 [INFO] [stderr] | [INFO] [stderr] 81 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/image.rs:84:7 [INFO] [stderr] | [INFO] [stderr] 84 | wb_coeffs: wb_coeffs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `wb_coeffs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pumps.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:87:7 [INFO] [stderr] | [INFO] [stderr] 87 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:96:7 [INFO] [stderr] | [INFO] [stderr] 96 | bits: bits, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:97:7 [INFO] [stderr] | [INFO] [stderr] 97 | huffval: huffval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `huffval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | precision: precision, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `precision` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:105:7 [INFO] [stderr] | [INFO] [stderr] 105 | dng_bug: dng_bug, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `dng_bug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | csfix: csfix, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `csfix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:81:9 [INFO] [stderr] | [INFO] [stderr] 81 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:183:7 [INFO] [stderr] | [INFO] [stderr] 183 | sof: sof, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `sof` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:186:7 [INFO] [stderr] | [INFO] [stderr] 186 | dhts: dhts, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dhts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:91:7 [INFO] [stderr] | [INFO] [stderr] 91 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:92:7 [INFO] [stderr] | [INFO] [stderr] 92 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cfa.rs:144:7 [INFO] [stderr] | [INFO] [stderr] 144 | pattern: pattern, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `pattern` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:185:7 [INFO] [stderr] | [INFO] [stderr] 185 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:188:7 [INFO] [stderr] | [INFO] [stderr] 188 | endian: endian, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `endian` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:236:7 [INFO] [stderr] | [INFO] [stderr] 236 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:237:7 [INFO] [stderr] | [INFO] [stderr] 237 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:239:7 [INFO] [stderr] | [INFO] [stderr] 239 | start_offset: start_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:342:7 [INFO] [stderr] | [INFO] [stderr] 342 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:415:7 [INFO] [stderr] | [INFO] [stderr] 415 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:416:7 [INFO] [stderr] | [INFO] [stderr] 416 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:417:7 [INFO] [stderr] | [INFO] [stderr] 417 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:418:7 [INFO] [stderr] | [INFO] [stderr] 418 | parent_offset: parent_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tiff.rs:419:7 [INFO] [stderr] | [INFO] [stderr] 419 | doffset: doffset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `doffset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:77:7 [INFO] [stderr] | [INFO] [stderr] 77 | entries: entries, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:78:7 [INFO] [stderr] | [INFO] [stderr] 78 | subifds: subifds, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `subifds` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:115:7 [INFO] [stderr] | [INFO] [stderr] 115 | tag: tag, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:116:7 [INFO] [stderr] | [INFO] [stderr] 116 | typ: typ, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:117:7 [INFO] [stderr] | [INFO] [stderr] 117 | count: count, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:118:7 [INFO] [stderr] | [INFO] [stderr] 118 | bytesize: bytesize, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `bytesize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:119:7 [INFO] [stderr] | [INFO] [stderr] 119 | data_offset: data_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ciff.rs:120:7 [INFO] [stderr] | [INFO] [stderr] 120 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:60:7 [INFO] [stderr] | [INFO] [stderr] 60 | data_offset: data_offset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `data_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:61:7 [INFO] [stderr] | [INFO] [stderr] 61 | raw_width: raw_width, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:62:7 [INFO] [stderr] | [INFO] [stderr] 62 | raw_height: raw_height, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:63:7 [INFO] [stderr] | [INFO] [stderr] 63 | packed: packed, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `packed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:64:7 [INFO] [stderr] | [INFO] [stderr] 64 | wb_vals: wb_vals, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `wb_vals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mrw.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/arw.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/arw.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mef.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mef.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/orf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/orf.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/srw.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/srw.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/erf.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/erf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/kdc.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/kdc.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcs.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcs.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/rw2.rs:143:7 [INFO] [stderr] | [INFO] [stderr] 143 | split: split, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `split` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:73:9 [INFO] [stderr] | [INFO] [stderr] 73 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/raf.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcr.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dcr.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:21:7 [INFO] [stderr] | [INFO] [stderr] 21 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:65:7 [INFO] [stderr] | [INFO] [stderr] 65 | make: make, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `make` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:66:7 [INFO] [stderr] | [INFO] [stderr] 66 | model: model, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:67:7 [INFO] [stderr] | [INFO] [stderr] 67 | clean_make: clean_make, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_make` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:68:7 [INFO] [stderr] | [INFO] [stderr] 68 | clean_model: clean_model, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `clean_model` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:70:7 [INFO] [stderr] | [INFO] [stderr] 70 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | cpp: cpp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/dng.rs:79:7 [INFO] [stderr] | [INFO] [stderr] 79 | orientation: orientation, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `orientation` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pef.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/pef.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:43:7 [INFO] [stderr] | [INFO] [stderr] 43 | tbl: tbl, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tbl` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:132:7 [INFO] [stderr] | [INFO] [stderr] 132 | ciff: ciff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `ciff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/crw.rs:133:7 [INFO] [stderr] | [INFO] [stderr] 133 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nkd.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mos.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mos.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/iiq.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/iiq.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tfr.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/tfr.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nef.rs:93:7 [INFO] [stderr] | [INFO] [stderr] 93 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nef.rs:94:7 [INFO] [stderr] | [INFO] [stderr] 94 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nrw.rs:17:7 [INFO] [stderr] | [INFO] [stderr] 17 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/nrw.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cr2.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | tiff: tiff, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tiff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/cr2.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/ari.rs:19:7 [INFO] [stderr] | [INFO] [stderr] 19 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | dirs: dirs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `dirs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:69:7 [INFO] [stderr] | [INFO] [stderr] 69 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | rawloader: rawloader, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `rawloader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/x3f.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | dir: dir, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mod.rs:90:7 [INFO] [stderr] | [INFO] [stderr] 90 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoders/mod.rs:337:7 [INFO] [stderr] | [INFO] [stderr] 337 | naked: naked, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `naked` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/decoders/packed.rs:185:31 [INFO] [stderr] | [INFO] [stderr] 185 | let second_field_offset = ((half*width*3/2 >> 11) + 1) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(half*width*3/2) >> 11` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pumps.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | (self.bits & (0x0ffffffffu64 >> (32-num))) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | const HUFF_BITMASK: [u32;32] = [0xffffffff, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | const HUFF_BITMASK: [u32;32] = [0xffffffff, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | 0x3fffffff, 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | 0x3fffffff, 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | 0x0fffffff, 0x07ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | 0x0fffffff, 0x07ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | 0x03ffffff, 0x01ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:45:45 [INFO] [stderr] | [INFO] [stderr] 45 | 0x03ffffff, 0x01ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | 0x00ffffff, 0x007fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | 0x00ffffff, 0x007fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | 0x003fffff, 0x001fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | 0x003fffff, 0x001fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | 0x000fffff, 0x0007ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:48:45 [INFO] [stderr] | [INFO] [stderr] 48 | 0x000fffff, 0x0007ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0003ffff, 0x0001ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0003ffff, 0x0001ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | 0x0000ffff, 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | 0x0000ffff, 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | 0x00003fff, 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_3fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | 0x00003fff, 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | 0x00000fff, 0x000007ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | 0x00000fff, 0x000007ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_07ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | 0x000003ff, 0x000001ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_03ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | 0x000003ff, 0x000001ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_01ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | 0x000000ff, 0x0000007f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | 0x000000ff, 0x0000007f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_007f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | 0x0000003f, 0x0000001f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_003f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | 0x0000003f, 0x0000001f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | 0x0000000f, 0x00000007, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | 0x0000000f, 0x00000007, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0007` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | 0x00000003, 0x00000001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:57:45 [INFO] [stderr] | [INFO] [stderr] 57 | 0x00000003, 0x00000001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:299:7 [INFO] [stderr] | [INFO] [stderr] 299 | return Err(format!("ljpeg: bad Huffman code: {}", l).to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: bad Huffman code: {}", l).to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:301:7 [INFO] [stderr] | [INFO] [stderr] 301 | / return Ok(self.huffval[ [INFO] [stderr] 302 | | self.valptr[l] as usize + [INFO] [stderr] 303 | | (code - (self.mincode[l] as usize)) as usize [INFO] [stderr] 304 | | ]); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 301 | Ok(self.huffval[ [INFO] [stderr] 302 | self.valptr[l] as usize + [INFO] [stderr] 303 | (code - (self.mincode[l] as usize)) as usize [INFO] [stderr] 304 | ]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:260:16 [INFO] [stderr] | [INFO] [stderr] 260 | c => return Err(format!("ljpeg: {} component files not supported", c).to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: {} component files not supported", c).to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:264:12 [INFO] [stderr] | [INFO] [stderr] 264 | p => return Err(format!("ljpeg: predictor {} not supported", p).to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: predictor {} not supported", p).to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/decoders/tiff.rs:299:6 [INFO] [stderr] | [INFO] [stderr] 299 | } if data[off..off+2] == b"MM"[..] { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | BEu32(buf,0) == 0x004D524D [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x004D_524D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | 0x505244 => { // PRD [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0050_5244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | 0x574247 => { // WBG [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0057_4247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | 0x545457 => { // TTW [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0054_5457` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | if tag == 0x574247 { // WBG [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0057_4247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | let off: usize = 862144; [INFO] [stderr] | ^^^^^^ help: consider: `862_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | let key_off: usize = 200896; [INFO] [stderr] | ^^^^^^ help: consider: `200_896` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let head_off: usize = 164600; [INFO] [stderr] | ^^^^^^ help: consider: `164_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:251:32 [INFO] [stderr] | [INFO] [stderr] 251 | mkey = mkey.wrapping_mul(48828125).wrapping_add(1); [INFO] [stderr] | ^^^^^^^^ help: consider: `48_828_125` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoders/orf.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | if left_minus_nw.abs() > up_minus_nw.abs() { left[s] } else { up } [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_____________^ help: try: `if left_minus_nw.abs() > up_minus_nw.abs() { left[s] } else { up }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/rw2.rs:159:41 [INFO] [stderr] | [INFO] [stderr] 159 | (bits >> ((self.nbits-num) & 7)) & (0x0ffffffffu32 >> (32-num)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:23 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:23 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:23 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pef.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | let mut sm_val: u32 = 0xfffffff; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pef.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | v2[sm_num as usize]=0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/iiq.rs:78:28 [INFO] [stderr] | [INFO] [stderr] 78 | if col >= (width & 0xfffffff8) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoders/nef.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 120 | | if compression == 1 || size == width*height*bps/8 { [INFO] [stderr] 121 | | match bps { [INFO] [stderr] 122 | | 14 => if self.tiff.little_endian() { [INFO] [stderr] ... | [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 119 | } else if compression == 1 || size == width*height*bps/8 { [INFO] [stderr] 120 | match bps { [INFO] [stderr] 121 | 14 => if self.tiff.little_endian() { [INFO] [stderr] 122 | decode_14le_unpacked(src, width, height) [INFO] [stderr] 123 | } else { [INFO] [stderr] 124 | decode_14be_unpacked(src, width, height) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:338:51 [INFO] [stderr] | [INFO] [stderr] 338 | let r = SNEF_CURVE.dither(clampbits((y1 + 1.370705 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.370_705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:339:51 [INFO] [stderr] | [INFO] [stderr] 339 | let g = SNEF_CURVE.dither(clampbits((y1 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.337_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:339:67 [INFO] [stderr] | [INFO] [stderr] 339 | let g = SNEF_CURVE.dither(clampbits((y1 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.698_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:340:51 [INFO] [stderr] | [INFO] [stderr] 340 | let b = SNEF_CURVE.dither(clampbits((y1 + 1.732446 * cb) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.732_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:346:51 [INFO] [stderr] | [INFO] [stderr] 346 | let r = SNEF_CURVE.dither(clampbits((y2 + 1.370705 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.370_705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:347:51 [INFO] [stderr] | [INFO] [stderr] 347 | let g = SNEF_CURVE.dither(clampbits((y2 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.337_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:347:67 [INFO] [stderr] | [INFO] [stderr] 347 | let g = SNEF_CURVE.dither(clampbits((y2 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.698_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:348:51 [INFO] [stderr] | [INFO] [stderr] 348 | let b = SNEF_CURVE.dither(clampbits((y2 + 1.732446 * cb) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.732_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/x3f.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | if version < 0x00020000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/x3f.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | return Err("X3F decoding not implemented yet".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("X3F decoding not implemented yet".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/decoders/packed.rs:185:31 [INFO] [stderr] | [INFO] [stderr] 185 | let second_field_offset = ((half*width*3/2 >> 11) + 1) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(half*width*3/2) >> 11` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pumps.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | (self.bits & (0x0ffffffffu64 >> (32-num))) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | const HUFF_BITMASK: [u32;32] = [0xffffffff, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | const HUFF_BITMASK: [u32;32] = [0xffffffff, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | 0x3fffffff, 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | 0x3fffffff, 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | 0x0fffffff, 0x07ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | 0x0fffffff, 0x07ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | 0x03ffffff, 0x01ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:45:45 [INFO] [stderr] | [INFO] [stderr] 45 | 0x03ffffff, 0x01ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | 0x00ffffff, 0x007fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | 0x00ffffff, 0x007fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | 0x003fffff, 0x001fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | 0x003fffff, 0x001fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | 0x000fffff, 0x0007ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:48:45 [INFO] [stderr] | [INFO] [stderr] 48 | 0x000fffff, 0x0007ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0003ffff, 0x0001ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0003ffff, 0x0001ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | 0x0000ffff, 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | 0x0000ffff, 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | 0x00003fff, 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_3fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | 0x00003fff, 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | 0x00000fff, 0x000007ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | 0x00000fff, 0x000007ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_07ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | 0x000003ff, 0x000001ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_03ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | 0x000003ff, 0x000001ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_01ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | 0x000000ff, 0x0000007f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | 0x000000ff, 0x0000007f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_007f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | 0x0000003f, 0x0000001f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_003f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | 0x0000003f, 0x0000001f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | 0x0000000f, 0x00000007, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | 0x0000000f, 0x00000007, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0007` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | 0x00000003, 0x00000001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:57:45 [INFO] [stderr] | [INFO] [stderr] 57 | 0x00000003, 0x00000001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:299:7 [INFO] [stderr] | [INFO] [stderr] 299 | return Err(format!("ljpeg: bad Huffman code: {}", l).to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: bad Huffman code: {}", l).to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:301:7 [INFO] [stderr] | [INFO] [stderr] 301 | / return Ok(self.huffval[ [INFO] [stderr] 302 | | self.valptr[l] as usize + [INFO] [stderr] 303 | | (code - (self.mincode[l] as usize)) as usize [INFO] [stderr] 304 | | ]); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 301 | Ok(self.huffval[ [INFO] [stderr] 302 | self.valptr[l] as usize + [INFO] [stderr] 303 | (code - (self.mincode[l] as usize)) as usize [INFO] [stderr] 304 | ]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:260:16 [INFO] [stderr] | [INFO] [stderr] 260 | c => return Err(format!("ljpeg: {} component files not supported", c).to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: {} component files not supported", c).to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:264:12 [INFO] [stderr] | [INFO] [stderr] 264 | p => return Err(format!("ljpeg: predictor {} not supported", p).to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: predictor {} not supported", p).to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/decoders/tiff.rs:299:6 [INFO] [stderr] | [INFO] [stderr] 299 | } if data[off..off+2] == b"MM"[..] { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | BEu32(buf,0) == 0x004D524D [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x004D_524D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | 0x505244 => { // PRD [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0050_5244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | 0x574247 => { // WBG [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0057_4247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | 0x545457 => { // TTW [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0054_5457` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | if tag == 0x574247 { // WBG [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0057_4247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | let off: usize = 862144; [INFO] [stderr] | ^^^^^^ help: consider: `862_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | let key_off: usize = 200896; [INFO] [stderr] | ^^^^^^ help: consider: `200_896` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let head_off: usize = 164600; [INFO] [stderr] | ^^^^^^ help: consider: `164_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:251:32 [INFO] [stderr] | [INFO] [stderr] 251 | mkey = mkey.wrapping_mul(48828125).wrapping_add(1); [INFO] [stderr] | ^^^^^^^^ help: consider: `48_828_125` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoders/orf.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | if left_minus_nw.abs() > up_minus_nw.abs() { left[s] } else { up } [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_____________^ help: try: `if left_minus_nw.abs() > up_minus_nw.abs() { left[s] } else { up }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/rw2.rs:159:41 [INFO] [stderr] | [INFO] [stderr] 159 | (bits >> ((self.nbits-num) & 7)) & (0x0ffffffffu32 >> (32-num)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:23 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:23 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:23 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pef.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | let mut sm_val: u32 = 0xfffffff; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pef.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | v2[sm_num as usize]=0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/iiq.rs:78:28 [INFO] [stderr] | [INFO] [stderr] 78 | if col >= (width & 0xfffffff8) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoders/nef.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 120 | | if compression == 1 || size == width*height*bps/8 { [INFO] [stderr] 121 | | match bps { [INFO] [stderr] 122 | | 14 => if self.tiff.little_endian() { [INFO] [stderr] ... | [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 119 | } else if compression == 1 || size == width*height*bps/8 { [INFO] [stderr] 120 | match bps { [INFO] [stderr] 121 | 14 => if self.tiff.little_endian() { [INFO] [stderr] 122 | decode_14le_unpacked(src, width, height) [INFO] [stderr] 123 | } else { [INFO] [stderr] 124 | decode_14be_unpacked(src, width, height) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:338:51 [INFO] [stderr] | [INFO] [stderr] 338 | let r = SNEF_CURVE.dither(clampbits((y1 + 1.370705 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.370_705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:339:51 [INFO] [stderr] | [INFO] [stderr] 339 | let g = SNEF_CURVE.dither(clampbits((y1 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.337_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:339:67 [INFO] [stderr] | [INFO] [stderr] 339 | let g = SNEF_CURVE.dither(clampbits((y1 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.698_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:340:51 [INFO] [stderr] | [INFO] [stderr] 340 | let b = SNEF_CURVE.dither(clampbits((y1 + 1.732446 * cb) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.732_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:346:51 [INFO] [stderr] | [INFO] [stderr] 346 | let r = SNEF_CURVE.dither(clampbits((y2 + 1.370705 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.370_705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:347:51 [INFO] [stderr] | [INFO] [stderr] 347 | let g = SNEF_CURVE.dither(clampbits((y2 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.337_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:347:67 [INFO] [stderr] | [INFO] [stderr] 347 | let g = SNEF_CURVE.dither(clampbits((y2 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.698_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:348:51 [INFO] [stderr] | [INFO] [stderr] 348 | let b = SNEF_CURVE.dither(clampbits((y2 + 1.732446 * cb) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.732_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:116:29 [INFO] [stderr] | [INFO] [stderr] 116 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:19 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:117:29 [INFO] [stderr] | [INFO] [stderr] 117 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:19 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/image.rs:118:29 [INFO] [stderr] | [INFO] [stderr] 118 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/decoders/packed.rs:185:31 [INFO] [stderr] | [INFO] [stderr] 185 | let second_field_offset = ((half*width*3/2 >> 11) + 1) << 11; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(half*width*3/2) >> 11` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pumps.rs:123:19 [INFO] [stderr] | [INFO] [stderr] 123 | (self.bits & (0x0ffffffffu64 >> (32-num))) as u32 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:42:33 [INFO] [stderr] | [INFO] [stderr] 42 | const HUFF_BITMASK: [u32;32] = [0xffffffff, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | const HUFF_BITMASK: [u32;32] = [0xffffffff, 0x7fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:43:33 [INFO] [stderr] | [INFO] [stderr] 43 | 0x3fffffff, 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x3fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:43:45 [INFO] [stderr] | [INFO] [stderr] 43 | 0x3fffffff, 0x1fffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:44:33 [INFO] [stderr] | [INFO] [stderr] 44 | 0x0fffffff, 0x07ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:44:45 [INFO] [stderr] | [INFO] [stderr] 44 | 0x0fffffff, 0x07ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x07ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:45:33 [INFO] [stderr] | [INFO] [stderr] 45 | 0x03ffffff, 0x01ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:45:45 [INFO] [stderr] | [INFO] [stderr] 45 | 0x03ffffff, 0x01ffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | 0x00ffffff, 0x007fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:46:45 [INFO] [stderr] | [INFO] [stderr] 46 | 0x00ffffff, 0x007fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x007f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | 0x003fffff, 0x001fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x003f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:47:45 [INFO] [stderr] | [INFO] [stderr] 47 | 0x003fffff, 0x001fffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x001f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:48:33 [INFO] [stderr] | [INFO] [stderr] 48 | 0x000fffff, 0x0007ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x000f_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:48:45 [INFO] [stderr] | [INFO] [stderr] 48 | 0x000fffff, 0x0007ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0007_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0003ffff, 0x0001ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0003_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:49:45 [INFO] [stderr] | [INFO] [stderr] 49 | 0x0003ffff, 0x0001ffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0001_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:50:33 [INFO] [stderr] | [INFO] [stderr] 50 | 0x0000ffff, 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:50:45 [INFO] [stderr] | [INFO] [stderr] 50 | 0x0000ffff, 0x00007fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_7fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | 0x00003fff, 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_3fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:51:45 [INFO] [stderr] | [INFO] [stderr] 51 | 0x00003fff, 0x00001fff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_1fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:52:33 [INFO] [stderr] | [INFO] [stderr] 52 | 0x00000fff, 0x000007ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0fff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:52:45 [INFO] [stderr] | [INFO] [stderr] 52 | 0x00000fff, 0x000007ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_07ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | 0x000003ff, 0x000001ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_03ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | 0x000003ff, 0x000001ff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_01ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:54:33 [INFO] [stderr] | [INFO] [stderr] 54 | 0x000000ff, 0x0000007f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | 0x000000ff, 0x0000007f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_007f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | 0x0000003f, 0x0000001f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_003f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:55:45 [INFO] [stderr] | [INFO] [stderr] 55 | 0x0000003f, 0x0000001f, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_001f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:56:33 [INFO] [stderr] | [INFO] [stderr] 56 | 0x0000000f, 0x00000007, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_000f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:56:45 [INFO] [stderr] | [INFO] [stderr] 56 | 0x0000000f, 0x00000007, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0007` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:57:33 [INFO] [stderr] | [INFO] [stderr] 57 | 0x00000003, 0x00000001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:57:45 [INFO] [stderr] | [INFO] [stderr] 57 | 0x00000003, 0x00000001]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:299:7 [INFO] [stderr] | [INFO] [stderr] 299 | return Err(format!("ljpeg: bad Huffman code: {}", l).to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: bad Huffman code: {}", l).to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:301:7 [INFO] [stderr] | [INFO] [stderr] 301 | / return Ok(self.huffval[ [INFO] [stderr] 302 | | self.valptr[l] as usize + [INFO] [stderr] 303 | | (code - (self.mincode[l] as usize)) as usize [INFO] [stderr] 304 | | ]); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 301 | Ok(self.huffval[ [INFO] [stderr] 302 | self.valptr[l] as usize + [INFO] [stderr] 303 | (code - (self.mincode[l] as usize)) as usize [INFO] [stderr] 304 | ]) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:260:16 [INFO] [stderr] | [INFO] [stderr] 260 | c => return Err(format!("ljpeg: {} component files not supported", c).to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: {} component files not supported", c).to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:264:12 [INFO] [stderr] | [INFO] [stderr] 264 | p => return Err(format!("ljpeg: predictor {} not supported", p).to_string()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(format!("ljpeg: predictor {} not supported", p).to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this looks like an `else if` but the `else` is missing [INFO] [stderr] --> src/decoders/tiff.rs:299:6 [INFO] [stderr] | [INFO] [stderr] 299 | } if data[off..off+2] == b"MM"[..] { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::suspicious_else_formatting)] on by default [INFO] [stderr] = note: to remove this lint, add the missing `else` or add a new line before the second `if` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_else_formatting [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/x3f.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | if version < 0x00020000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/x3f.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | return Err("X3F decoding not implemented yet".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("X3F decoding not implemented yet".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | BEu32(buf,0) == 0x004D524D [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x004D_524D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | 0x505244 => { // PRD [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0050_5244` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | 0x574247 => { // WBG [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0057_4247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/mrw.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | 0x545457 => { // TTW [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0054_5457` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | if tag == 0x574247 { // WBG [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0057_4247` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:125:22 [INFO] [stderr] | [INFO] [stderr] 125 | let off: usize = 862144; [INFO] [stderr] | ^^^^^^ help: consider: `862_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:126:26 [INFO] [stderr] | [INFO] [stderr] 126 | let key_off: usize = 200896; [INFO] [stderr] | ^^^^^^ help: consider: `200_896` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:127:27 [INFO] [stderr] | [INFO] [stderr] 127 | let head_off: usize = 164600; [INFO] [stderr] | ^^^^^^ help: consider: `164_600` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/arw.rs:251:32 [INFO] [stderr] | [INFO] [stderr] 251 | mkey = mkey.wrapping_mul(48828125).wrapping_add(1); [INFO] [stderr] | ^^^^^^^^ help: consider: `48_828_125` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoders/orf.rs:147:20 [INFO] [stderr] | [INFO] [stderr] 147 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 148 | | if left_minus_nw.abs() > up_minus_nw.abs() { left[s] } else { up } [INFO] [stderr] 149 | | }; [INFO] [stderr] | |_____________^ help: try: `if left_minus_nw.abs() > up_minus_nw.abs() { left[s] } else { up }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/rw2.rs:159:41 [INFO] [stderr] | [INFO] [stderr] 159 | (bits >> ((self.nbits-num) & 7)) & (0x0ffffffffu32 >> (32-num)) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x0000_ffff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.412_453` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:23 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.357_580` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | [ 0.412453, 0.357580, 0.180423 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.180_423` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.212_671` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:23 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.715_160` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | [ 0.212671, 0.715160, 0.072169 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.072_169` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.019_334` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:23 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.119_193` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/dng.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | [ 0.019334, 0.119193, 0.950227 ], [INFO] [stderr] | ^^^^^^^^ help: consider: `0.950_227` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pef.rs:91:31 [INFO] [stderr] | [INFO] [stderr] 91 | let mut sm_val: u32 = 0xfffffff; [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x0fff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/pef.rs:100:29 [INFO] [stderr] | [INFO] [stderr] 100 | v2[sm_num as usize]=0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/iiq.rs:78:28 [INFO] [stderr] | [INFO] [stderr] 78 | if col >= (width & 0xfffffff8) { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fff8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/decoders/nef.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 120 | | if compression == 1 || size == width*height*bps/8 { [INFO] [stderr] 121 | | match bps { [INFO] [stderr] 122 | | 14 => if self.tiff.little_endian() { [INFO] [stderr] ... | [INFO] [stderr] 141 | | } [INFO] [stderr] 142 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 119 | } else if compression == 1 || size == width*height*bps/8 { [INFO] [stderr] 120 | match bps { [INFO] [stderr] 121 | 14 => if self.tiff.little_endian() { [INFO] [stderr] 122 | decode_14le_unpacked(src, width, height) [INFO] [stderr] 123 | } else { [INFO] [stderr] 124 | decode_14be_unpacked(src, width, height) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:338:51 [INFO] [stderr] | [INFO] [stderr] 338 | let r = SNEF_CURVE.dither(clampbits((y1 + 1.370705 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.370_705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:339:51 [INFO] [stderr] | [INFO] [stderr] 339 | let g = SNEF_CURVE.dither(clampbits((y1 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.337_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:339:67 [INFO] [stderr] | [INFO] [stderr] 339 | let g = SNEF_CURVE.dither(clampbits((y1 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.698_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:340:51 [INFO] [stderr] | [INFO] [stderr] 340 | let b = SNEF_CURVE.dither(clampbits((y1 + 1.732446 * cb) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.732_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:346:51 [INFO] [stderr] | [INFO] [stderr] 346 | let r = SNEF_CURVE.dither(clampbits((y2 + 1.370705 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.370_705` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:347:51 [INFO] [stderr] | [INFO] [stderr] 347 | let g = SNEF_CURVE.dither(clampbits((y2 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.337_633` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:347:67 [INFO] [stderr] | [INFO] [stderr] 347 | let g = SNEF_CURVE.dither(clampbits((y2 - 0.337633 * cb - 0.698001 * cr) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `0.698_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/nef.rs:348:51 [INFO] [stderr] | [INFO] [stderr] 348 | let b = SNEF_CURVE.dither(clampbits((y2 + 1.732446 * cb) as i32, 12) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^ help: consider: `1.732_446` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/decoders/x3f.rs:38:18 [INFO] [stderr] | [INFO] [stderr] 38 | if version < 0x00020000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0002_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/decoders/x3f.rs:148:5 [INFO] [stderr] | [INFO] [stderr] 148 | return Err("X3F decoding not implemented yet".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("X3F decoding not implemented yet".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/image.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | avg[color] += image[row*width+col] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image[row*width+col])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/image.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | avg[color] += image[row*width+col] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image[row*width+col])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/decoders/image.rs:107:6 [INFO] [stderr] | [INFO] [stderr] 107 | neutralwb[1]/neutralwb[1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rgb_to_cam` [INFO] [stderr] --> src/decoders/image.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (i, ) in rgb_to_cam.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `rgb_to_xyz` [INFO] [stderr] --> src/decoders/image.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | for k in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 126 | for (k, ) in rgb_to_xyz.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `cam_to_rgb` [INFO] [stderr] --> src/decoders/image.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | for k in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 155 | for (k, ) in cam_to_rgb.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `temp` [INFO] [stderr] --> src/decoders/image.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for (i, ) in temp.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `inm`. [INFO] [stderr] --> src/decoders/image.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | for k in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in &inm { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `inm` [INFO] [stderr] --> src/decoders/image.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for (i, ) in inm.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn ri32(&self, buf: &[u8], pos: usize) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn ru32(&self, buf: &[u8], pos: usize) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:41:15 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn ru16(&self, buf: &[u8], pos: usize) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn little(&self) -> bool { !self.big } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/basics.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | let base = sbase as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(sbase)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/basics.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | let delta = sdelta as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(sdelta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | o[0] = tbl.dither(i[0] as u16, &mut random); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | let g4: u16 = i[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | let g5: u16 = i[4] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | let g6: u16 = i[5] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | let g7: u16 = i[6] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let g8: u16 = i[7] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let g9: u16 = i[8] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | let g10: u16 = i[9] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let g4: u16 = i[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | let g5: u16 = i[4] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | let g4: u16 = i[ 3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let g5: u16 = i[ 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | let g6: u16 = i[ 5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:102:22 [INFO] [stderr] | [INFO] [stderr] 102 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | let g4: u16 = i[ 3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | let g5: u16 = i[ 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | let g6: u16 = i[ 5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | let g7: u16 = i[ 6] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | let g8: u16 = i[ 7] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:123:20 [INFO] [stderr] | [INFO] [stderr] 123 | let g9: u16 = i[ 8] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | let g10: u16 = i[ 9] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | let g11: u16 = i[10] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | let g12: u16 = i[11] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:171:23 [INFO] [stderr] | [INFO] [stderr] 171 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:172:23 [INFO] [stderr] | [INFO] [stderr] 172 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:212:21 [INFO] [stderr] | [INFO] [stderr] 212 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:213:21 [INFO] [stderr] | [INFO] [stderr] 213 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:227:21 [INFO] [stderr] | [INFO] [stderr] 227 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:229:21 [INFO] [stderr] | [INFO] [stderr] 229 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | let inbits: u64 = LEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | let inbits: u64 = BEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | let inbits: u64 = LEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.pos` [INFO] [stderr] --> src/decoders/pumps.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | self.buffer[self.pos+0] != 0xff && [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:174:27 [INFO] [stderr] | [INFO] [stderr] 174 | let inbits: u64 = BEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:199:42 [INFO] [stderr] | [INFO] [stderr] 199 | self.bits = (self.bits << 8) | (byte as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | for _ in 1..((self.bits[l] as usize)+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=(self.bits[l] as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | let mut si: u32 = huffsize[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(huffsize[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | while (huffsize[p] as u32) == si { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(huffsize[p])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:159:27 [INFO] [stderr] | [INFO] [stderr] 159 | self.maxcode[l] = huffcode[p - 1] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(huffcode[p - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | let ll: i32 = (code << (8 - size)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code << (8 - size))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | for i in ll..(ul+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `ll..=ul` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:192:38 [INFO] [stderr] | [INFO] [stderr] 192 | self.numbits[i as usize] = (size as u32) | ((value as u32) << 4); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:212:27 [INFO] [stderr] | [INFO] [stderr] 212 | let mut code: i32 = (input >> 8) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:220:27 [INFO] [stderr] | [INFO] [stderr] 220 | let temp: i32 = (input >> (15 - l) & 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> (15 - l) & 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | (code - (self.mincode[l as usize] as i32)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.mincode[l as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | let mut x = (input >> (16 - (l as i32) - rv) & ((1 << rv) - 1)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> (16 - (l as i32) - rv) & ((1 << rv) - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:12:7 [INFO] [stderr] | [INFO] [stderr] 12 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:34:34 [INFO] [stderr] | [INFO] [stderr] 34 | out[row*stripwidth+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | out[row*stripwidth+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:56:7 [INFO] [stderr] | [INFO] [stderr] 56 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | out[row*stripwidth+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | out[row*stripwidth+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | out[row*stripwidth+col+2] = ((p3 as i32) + diff3) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:102:7 [INFO] [stderr] | [INFO] [stderr] 102 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | let ref htable4 = ljpeg.dhts[ljpeg.sof.components[3].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable4 = &ljpeg.dhts[ljpeg.sof.components[3].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:131:29 [INFO] [stderr] | [INFO] [stderr] 131 | out[row*width+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:132:31 [INFO] [stderr] | [INFO] [stderr] 132 | out[row*width+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:133:31 [INFO] [stderr] | [INFO] [stderr] 133 | out[row*width+col+2] = ((p3 as i32) + diff3) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:134:31 [INFO] [stderr] | [INFO] [stderr] 134 | out[row*width+col+3] = ((p4 as i32) + diff4) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:148:1 [INFO] [stderr] | [INFO] [stderr] 148 | / fn set_yuv_420(out: &mut [u16], row: usize, col: usize, width: usize, y1: i32, y2: i32, y3: i32, y4: i32, cb: i32, cr: i32) { [INFO] [stderr] 149 | | let pix1 = row*width+col; [INFO] [stderr] 150 | | let pix2 = pix1+3; [INFO] [stderr] 151 | | let pix3 = (row+1)*width+col; [INFO] [stderr] ... | [INFO] [stderr] 165 | | out[pix4+2] = cr as u16; [INFO] [stderr] 166 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix1` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:154:7 [INFO] [stderr] | [INFO] [stderr] 154 | out[pix1+0] = y1 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix2` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:157:7 [INFO] [stderr] | [INFO] [stderr] 157 | out[pix2+0] = y2 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix3` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | out[pix3+0] = y3 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix4` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:163:7 [INFO] [stderr] | [INFO] [stderr] 163 | out[pix4+0] = y4 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:175:7 [INFO] [stderr] | [INFO] [stderr] 175 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:176:7 [INFO] [stderr] | [INFO] [stderr] 176 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:177:7 [INFO] [stderr] | [INFO] [stderr] 177 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | let y1 = (py as i32) + try!(htable1.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | let cb = (pcb as i32) + try!(htable2.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | let cr = (pcr as i32) + try!(htable3.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:214:1 [INFO] [stderr] | [INFO] [stderr] 214 | / fn set_yuv_422(out: &mut [u16], row: usize, col: usize, width: usize, y1: i32, y2: i32, cb: i32, cr: i32) { [INFO] [stderr] 215 | | let pix1 = row*width+col; [INFO] [stderr] 216 | | let pix2 = pix1+3; [INFO] [stderr] 217 | | [INFO] [stderr] ... | [INFO] [stderr] 223 | | out[pix2+2] = cr as u16; [INFO] [stderr] 224 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix1` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:218:7 [INFO] [stderr] | [INFO] [stderr] 218 | out[pix1+0] = y1 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix2` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:221:7 [INFO] [stderr] | [INFO] [stderr] 221 | out[pix2+0] = y2 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:232:7 [INFO] [stderr] | [INFO] [stderr] 232 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:234:7 [INFO] [stderr] | [INFO] [stderr] 234 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:256:16 [INFO] [stderr] | [INFO] [stderr] 256 | let y1 = (py as i32) + try!(htable1.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:258:16 [INFO] [stderr] | [INFO] [stderr] 258 | let cb = (pcb as i32) + try!(htable2.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:259:16 [INFO] [stderr] | [INFO] [stderr] 259 | let cr = (pcr as i32) + try!(htable3.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:271:7 [INFO] [stderr] | [INFO] [stderr] 271 | let ref htable = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------- help: try: `let htable = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:307:31 [INFO] [stderr] | [INFO] [stderr] 307 | out[row*width+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:308:31 [INFO] [stderr] | [INFO] [stderr] 308 | out[row*width+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:223:25 [INFO] [stderr] | [INFO] [stderr] 223 | bits[th][i+1] = input.get_u8() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | huffval[th][i] = input.get_u8() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | / loop { [INFO] [stderr] 272 | | match LjpegDecompressor::get_next_marker(&mut input, true) { [INFO] [stderr] 273 | | Ok(marker) => { [INFO] [stderr] 274 | | if marker == m(Marker::EOI) { [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(marker) = LjpegDecompressor::get_next_marker(&mut input, true) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | let ref htable1 = self.dhts[self.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let htable1 = &self.dhts[self.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | let ref htable2 = self.dhts[self.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let htable2 = &self.dhts[self.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `pattern` [INFO] [stderr] --> src/decoders/cfa.rs:123:16 [INFO] [stderr] | [INFO] [stderr] 123 | for row in 0..48 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (row, ) in pattern.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is only used to index `pattern`. [INFO] [stderr] --> src/decoders/cfa.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | for row in 0..self.height { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 130 | for in pattern.iter().take(self.height) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `cpattern` [INFO] [stderr] --> src/decoders/cfa.rs:190:16 [INFO] [stderr] | [INFO] [stderr] 190 | for row in 0..48 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 190 | for (row, ) in cpattern.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/decoders/cfa.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | for col in 0..48 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `cpattern[row][..48].clone_from_slice(&self.pattern[row][..48])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/tiff.rs:148:7 [INFO] [stderr] | [INFO] [stderr] 148 | / match TiffIFD::new_fuji(buf, BEu32(buf, 92) as usize) { [INFO] [stderr] 149 | | Ok(val) => subifds.push(val), [INFO] [stderr] 150 | | Err(_) => {} [INFO] [stderr] 151 | | } [INFO] [stderr] | |_______^ help: try this: `if let Ok(val) = TiffIFD::new_fuji(buf, BEu32(buf, 92) as usize) { subifds.push(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/tiff.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | / match ifd.find_entry(tag) { [INFO] [stderr] 356 | | Some(x) => return Some(x), [INFO] [stderr] 357 | | None => {}, [INFO] [stderr] 358 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = ifd.find_entry(tag) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/tiff.rs:384:8 [INFO] [stderr] | [INFO] [stderr] 384 | if ifds.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ifds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/decoders/tiff.rs:426:20 [INFO] [stderr] | [INFO] [stderr] 426 | let mut copy = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/tiff.rs:442:29 [INFO] [stderr] | [INFO] [stderr] 442 | 1 => self.data[idx] as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[idx])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/tiff.rs:450:29 [INFO] [stderr] | [INFO] [stderr] 450 | 1 | 3 | 8 => self.get_u16(idx) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_u16(idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/ciff.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match ifd.find_entry(tag) { [INFO] [stderr] 88 | | Some(x) => return Some(x), [INFO] [stderr] 89 | | None => {}, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = ifd.find_entry(tag) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoders/ciff.rs:138:57 [INFO] [stderr] | [INFO] [stderr] 138 | String::from_utf8_lossy(self.data).split_terminator("\0").map(|x| x.to_string()).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ciff.rs:143:48 [INFO] [stderr] | [INFO] [stderr] 143 | 0x0000 | 0x8000 => self.data[idx] as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[idx])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ciff.rs:144:48 [INFO] [stderr] | [INFO] [stderr] 144 | 0x1000 => LEu16(self.data, idx*2) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LEu16(self.data, idx*2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `wb_vals` [INFO] [stderr] --> src/decoders/mrw.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for (i, ) in wb_vals.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | [self.wb_vals[2] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:85:8 [INFO] [stderr] | [INFO] [stderr] 85 | self.wb_vals[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:86:8 [INFO] [stderr] | [INFO] [stderr] 86 | self.wb_vals[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:89:8 [INFO] [stderr] | [INFO] [stderr] 89 | [self.wb_vals[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | self.wb_vals[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | self.wb_vals[3] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | wb_coeffs[0] = LEu16(buf, currpos+12) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+12))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | wb_coeffs[1] = LEu16(buf, currpos+14) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+14))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | wb_coeffs[2] = LEu16(buf, currpos+18) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+18))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:115:8 [INFO] [stderr] | [INFO] [stderr] 115 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/arw.rs:238:16 [INFO] [stderr] | [INFO] [stderr] 238 | for j in (curve[i]+1)..(curve[i+1]+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((curve[i]+1)..=curve[i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is only used to index `pad`. [INFO] [stderr] --> src/decoders/arw.rs:250:14 [INFO] [stderr] | [INFO] [stderr] 250 | for p in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 250 | for in pad.iter_mut().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is only used to index `pad`. [INFO] [stderr] --> src/decoders/arw.rs:258:14 [INFO] [stderr] | [INFO] [stderr] 258 | for p in 0..127 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 258 | for in pad.iter_mut().take(127) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/arw.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | for i in 0..(length/4+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=length/4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `output` [INFO] [stderr] --> src/decoders/arw.rs:267:17 [INFO] [stderr] | [INFO] [stderr] 267 | out.push(((output >> 0) & 0xff) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `bittable` [INFO] [stderr] --> src/decoders/orf.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..4096 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for (i, ) in bittable.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/decoders/orf.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | let sign: i32 = (b >> 14) * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/orf.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let mut high: i32 = bittable[(b&4095) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(bittable[(b&4095) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/orf.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | nw[s] = out[(row-2) * width + (col+s)] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(out[(row-2) * width + (col+s)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/orf.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | let up: i32 = out[(row-2) * width + (col+s)] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(out[(row-2) * width + (col+s)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/orf.rs:174:10 [INFO] [stderr] | [INFO] [stderr] 174 | if ifd.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ifd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/srw.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | out[img+col+c] = ((predictor as i32) + adj) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(predictor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/srw.rs:125:31 [INFO] [stderr] | [INFO] [stderr] 125 | out[img+col+c] = ((predictor as i32) + adj) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(predictor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `tab`. [INFO] [stderr] --> src/decoders/srw.rs:164:14 [INFO] [stderr] | [INFO] [stderr] 164 | for i in 0..14 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 164 | for in &tab { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/decoders/srw.rs:208:3 [INFO] [stderr] | [INFO] [stderr] 208 | / pub fn decode_srw3(buf: &[u8], width: usize, height: usize) -> Vec { [INFO] [stderr] 209 | | // Decoder for third generation compressed SRW files (NX1) [INFO] [stderr] 210 | | // Seriously Samsung just use lossless jpeg already, it compresses better too :) [INFO] [stderr] 211 | | [INFO] [stderr] ... | [INFO] [stderr] 374 | | out [INFO] [stderr] 375 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `diff_bits_mode`. [INFO] [stderr] --> src/decoders/srw.rs:268:16 [INFO] [stderr] | [INFO] [stderr] 268 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 268 | for in &mut diff_bits_mode { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/decoders/srw.rs:276:48 [INFO] [stderr] | [INFO] [stderr] 276 | scale = if (optflags & OPT_QP) == 0 && (col & 63) == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `col.trailing_zeros() >= 6` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/srw.rs:369:32 [INFO] [stderr] | [INFO] [stderr] 369 | out[pos] = clampbits((out[pos] as i32) + diff, bit_depth) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(out[pos])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/erf.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | let r = BEu16(levels.get_data(), 48) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(levels.get_data(), 48))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/erf.rs:44:15 [INFO] [stderr] | [INFO] [stderr] 44 | let b = BEu16(levels.get_data(), 50) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(levels.get_data(), 50))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/kdc.rs:76:19 [INFO] [stderr] | [INFO] [stderr] 76 | let r = BEu16(levels.get_data(), 148) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(levels.get_data(), 148))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/kdc.rs:77:19 [INFO] [stderr] | [INFO] [stderr] 77 | let b = BEu16(levels.get_data(), 150) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(levels.get_data(), 150))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/kdc.rs:92:30 [INFO] [stderr] | [INFO] [stderr] 92 | out[row*width+col] = src[row*width + ((col + shift) % 848)] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(src[row*width + ((col + shift) % 848)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t` [INFO] [stderr] --> src/decoders/dcs.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 37 | for (i, ) in t.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/rw2.rs:29:10 [INFO] [stderr] | [INFO] [stderr] 29 | if data.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/rw2.rs:158:16 [INFO] [stderr] | [INFO] [stderr] 158 | let bits = LEu16(self.buffer, byte as usize + self.pos - 0x4000) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LEu16(self.buffer, byte as usize + self.pos - 0x4000))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `col` is used to index `inb` [INFO] [stderr] --> src/decoders/raf.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | for col in 0..cropwidth { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 115 | for (col, ) in inb.iter().enumerate().take(cropwidth) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `col` is used to index `inb` [INFO] [stderr] --> src/decoders/raf.rs:130:20 [INFO] [stderr] | [INFO] [stderr] 130 | for col in 0..cropwidth { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 130 | for (col, ) in inb.iter().enumerate().take(cropwidth) { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/dcr.rs:54:20 [INFO] [stderr] | [INFO] [stderr] 54 | Ok([2048.0 / BEu16(levels,40) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(levels,40))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/dcr.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | 2048.0 / BEu16(levels,42) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(levels,42))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/dcr.rs:56:20 [INFO] [stderr] | [INFO] [stderr] 56 | 2048.0 / BEu16(levels,44) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(levels,44))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/decoders/dcr.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / let mut bits: usize = 0; [INFO] [stderr] 96 | | if (size & 7) == 4 { [INFO] [stderr] 97 | | bitbuf = (input.get_u8() as u64) << 8 | (input.get_u8() as u64); [INFO] [stderr] 98 | | bits = 16; [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let bits = if (size & 7) == 4 { ..; 16 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/dcr.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | bitbuf = (input.get_u8() as u64) << 8 | (input.get_u8() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/dcr.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | bitbuf = (input.get_u8() as u64) << 8 | (input.get_u8() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/dcr.rs:105:21 [INFO] [stderr] | [INFO] [stderr] 105 | bitbuf += (input.get_u8() as u64) << (bits+(j^8)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `points` [INFO] [stderr] --> src/decoders/dng.rs:167:20 [INFO] [stderr] | [INFO] [stderr] 167 | for i in 0..256 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for (i, ) in points.iter_mut().enumerate().take(256) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `v0`. [INFO] [stderr] --> src/decoders/pef.rs:73:16 [INFO] [stderr] | [INFO] [stderr] 73 | for i in 0..depth { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 73 | for in v0.iter_mut().take(depth) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pef.rs:74:17 [INFO] [stderr] | [INFO] [stderr] 74 | v0[i] = stream.get_u16() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream.get_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `v1`. [INFO] [stderr] --> src/decoders/pef.rs:78:16 [INFO] [stderr] | [INFO] [stderr] 78 | for i in 0..depth { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 78 | for in v1.iter_mut().take(depth) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pef.rs:79:17 [INFO] [stderr] | [INFO] [stderr] 79 | v1[i] = stream.get_u8() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(stream.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `v2` [INFO] [stderr] --> src/decoders/pef.rs:93:18 [INFO] [stderr] | [INFO] [stderr] 93 | for j in 0..depth { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 93 | for (j, ) in v2.iter().enumerate().take(depth) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `pentax_tree` [INFO] [stderr] --> src/decoders/pef.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for (i, ) in pentax_tree.iter().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pef.rs:108:28 [INFO] [stderr] | [INFO] [stderr] 108 | htable.bits[i+1] = pentax_tree[i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pentax_tree[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pef.rs:112:29 [INFO] [stderr] | [INFO] [stderr] 112 | htable.huffval[i] = pentax_tree[i+16] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(pentax_tree[i+16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `row*width` [INFO] [stderr] --> src/decoders/pef.rs:130:11 [INFO] [stderr] | [INFO] [stderr] 130 | out[row*width+0] = pred_left1 as u16; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `row*width+col` [INFO] [stderr] --> src/decoders/pef.rs:135:13 [INFO] [stderr] | [INFO] [stderr] 135 | out[row*width+col+0] = pred_left1 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/crw.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | for len in 1..(max+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `1..=max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | pump.consume_bits(len as u32); [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | leaf as u32 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(leaf)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/decoders/crw.rs:164:33 [INFO] [stderr] | [INFO] [stderr] 164 | return Ok([levels.get_f32(offset+0), levels.get_f32(offset+1), levels.get_f32(offset+3), NAN]) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:177:27 [INFO] [stderr] | [INFO] [stderr] 177 | return Ok([1024.0/(cinfo.get_force_u16(36) as f32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(cinfo.get_force_u16(36))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:178:27 [INFO] [stderr] | [INFO] [stderr] 178 | 1024.0/(cinfo.get_force_u16(37) as f32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(cinfo.get_force_u16(37))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:179:27 [INFO] [stderr] | [INFO] [stderr] 179 | 1024.0/(cinfo.get_force_u16(39) as f32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(cinfo.get_force_u16(39))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:184:18 [INFO] [stderr] | [INFO] [stderr] 184 | return Ok([(cinfo.get_force_u16(off+1)^key[1]) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(cinfo.get_force_u16(off+1)^key[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:185:18 [INFO] [stderr] | [INFO] [stderr] 185 | (cinfo.get_force_u16(off+0)^key[0]) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(cinfo.get_force_u16(off+0)^key[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `off` [INFO] [stderr] --> src/decoders/crw.rs:185:39 [INFO] [stderr] | [INFO] [stderr] 185 | (cinfo.get_force_u16(off+0)^key[0]) as f32, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:186:18 [INFO] [stderr] | [INFO] [stderr] 186 | (cinfo.get_force_u16(off+2)^key[0]) as f32, NAN]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(cinfo.get_force_u16(off+2)^key[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/crw.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | let ref htables = CRW_HUFF_TABLES[dectable]; [INFO] [stderr] | ----^^^^^^^^^^^----------------------------- help: try: `let htables = &CRW_HUFF_TABLES[dectable];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/crw.rs:212:13 [INFO] [stderr] | [INFO] [stderr] 212 | let ref tbl = htables[(i > 0) as usize]; [INFO] [stderr] | ----^^^^^^^----------------------------- help: try: `let tbl = &htables[(i > 0) as usize];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/crw.rs:247:17 [INFO] [stderr] | [INFO] [stderr] 247 | let c = self.buffer[26+i] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.buffer[26+i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoders/mos.rs:28:45 [INFO] [stderr] | [INFO] [stderr] 28 | let model = model_full.split_terminator("(").next().unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `'('` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoders/mos.rs:65:42 [INFO] [stderr] | [INFO] [stderr] 65 | .split_terminator("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decoders/mos.rs:82:58 [INFO] [stderr] | [INFO] [stderr] 82 | let start = try!(xmp.find(&format!("",tag)).ok_or(error.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decoders/mos.rs:83:59 [INFO] [stderr] | [INFO] [stderr] 83 | let end = try!(xmp.find(&format!("",tag)).ok_or(error.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| error.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/decoders/iiq.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if width <= 0 || height <= 0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using width == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/decoders/iiq.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | if width <= 0 || height <= 0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using height == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/decoders/iiq.rs:81:19 [INFO] [stderr] | [INFO] [stderr] 81 | } else if col&7 == 0 { [INFO] [stderr] | ^^^^^^^^^^ help: try: `col.trailing_zeros() >= 3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `len`. [INFO] [stderr] --> src/decoders/iiq.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | for i in 0..2 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 82 | for in &mut len { [INFO] [stderr] | ^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:161:36 [INFO] [stderr] | [INFO] [stderr] 161 | version = (version << 4) + (levels.get_data()[i]-b'0') as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(levels.get_data()[i]-b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:164:23 [INFO] [stderr] | [INFO] [stderr] 164 | 0x100 => Ok([levels.get_force_u16(36) as f32, levels.get_force_u16(38) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(36))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:164:56 [INFO] [stderr] | [INFO] [stderr] 164 | 0x100 => Ok([levels.get_force_u16(36) as f32, levels.get_force_u16(38) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(38))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:165:23 [INFO] [stderr] | [INFO] [stderr] 165 | levels.get_force_u16(37) as f32, NAN]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(37))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:166:23 [INFO] [stderr] | [INFO] [stderr] 166 | 0x103 => Ok([levels.get_force_u16(10) as f32, levels.get_force_u16(11) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(10))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:166:56 [INFO] [stderr] | [INFO] [stderr] 166 | 0x103 => Ok([levels.get_force_u16(10) as f32, levels.get_force_u16(11) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(11))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:167:23 [INFO] [stderr] | [INFO] [stderr] 167 | levels.get_force_u16(12) as f32, NAN]), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(12))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data`. [INFO] [stderr] --> src/decoders/nef.rs:172:20 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0..serial.count() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in data.iter().take(serial.count()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:191:20 [INFO] [stderr] | [INFO] [stderr] 191 | let ci = WB_SERIALMAP[serialno & 0xff] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(WB_SERIALMAP[serialno & 0xff])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:192:24 [INFO] [stderr] | [INFO] [stderr] 192 | let mut cj = WB_KEYMAP[keyno & 0xff] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(WB_KEYMAP[keyno & 0xff])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:202:15 [INFO] [stderr] | [INFO] [stderr] 202 | Ok([BEu16(&buf, off) as f32, BEu16(&buf, off+2) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(&buf, off))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:202:40 [INFO] [stderr] | [INFO] [stderr] 202 | Ok([BEu16(&buf, off) as f32, BEu16(&buf, off+2) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(&buf, off+2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:203:15 [INFO] [stderr] | [INFO] [stderr] 203 | BEu16(&buf, off+6) as f32, NAN]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(&buf, off+6))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:217:26 [INFO] [stderr] | [INFO] [stderr] 217 | htable.bits[i+1] = NIKON_TREE[num][i] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(NIKON_TREE[num][i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:223:27 [INFO] [stderr] | [INFO] [stderr] 223 | htable.huffval[i] = NIKON_TREE[num][i+16] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(NIKON_TREE[num][i+16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:255:34 [INFO] [stderr] | [INFO] [stderr] 255 | let mut pred_up1: [i32;2] = [stream.get_u16() as i32, stream.get_u16() as i32]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stream.get_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:255:59 [INFO] [stderr] | [INFO] [stderr] 255 | let mut pred_up1: [i32;2] = [stream.get_u16() as i32, stream.get_u16() as i32]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stream.get_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:256:34 [INFO] [stderr] | [INFO] [stderr] 256 | let mut pred_up2: [i32;2] = [stream.get_u16() as i32, stream.get_u16() as i32]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stream.get_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:256:59 [INFO] [stderr] | [INFO] [stderr] 256 | let mut pred_up2: [i32;2] = [stream.get_u16() as i32, stream.get_u16() as i32]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(stream.get_u16())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `points` [INFO] [stderr] --> src/decoders/nef.rs:260:14 [INFO] [stderr] | [INFO] [stderr] 260 | for i in 0..points.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 260 | for (i, ) in points.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `points`. [INFO] [stderr] --> src/decoders/nef.rs:281:16 [INFO] [stderr] | [INFO] [stderr] 281 | for i in 0..csize { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 281 | for in points.iter_mut().take(csize) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `row*width+col` [INFO] [stderr] --> src/decoders/nef.rs:305:13 [INFO] [stderr] | [INFO] [stderr] 305 | out[row*width+col+0] = curve.dither(clampbits(pred_left1,15) as u16, &mut random); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:326:23 [INFO] [stderr] | [INFO] [stderr] 326 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:327:23 [INFO] [stderr] | [INFO] [stderr] 327 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:328:23 [INFO] [stderr] | [INFO] [stderr] 328 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:329:23 [INFO] [stderr] | [INFO] [stderr] 329 | let g4: u16 = i[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:330:23 [INFO] [stderr] | [INFO] [stderr] 330 | let g5: u16 = i[4] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:331:23 [INFO] [stderr] | [INFO] [stderr] 331 | let g6: u16 = i[5] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:333:19 [INFO] [stderr] | [INFO] [stderr] 333 | let y1 = (g1 | ((g2 & 0x0f) << 8)) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(g1 | ((g2 & 0x0f) << 8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:334:19 [INFO] [stderr] | [INFO] [stderr] 334 | let y2 = ((g2 >> 4) | (g3 << 4)) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((g2 >> 4) | (g3 << 4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:335:18 [INFO] [stderr] | [INFO] [stderr] 335 | let cb = (g4 | ((g5 & 0x0f) << 8)) as f32 - 2048.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(g4 | ((g5 & 0x0f) << 8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:336:18 [INFO] [stderr] | [INFO] [stderr] 336 | let cr = ((g5 >> 4) | (g6 << 4)) as f32 - 2048.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from((g5 >> 4) | (g6 << 4))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:342:38 [INFO] [stderr] | [INFO] [stderr] 342 | o[0] = clampbits((inv_wb_r * r as i32 + (1<<9)) >> 10, 15) as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:344:38 [INFO] [stderr] | [INFO] [stderr] 344 | o[2] = clampbits((inv_wb_b * b as i32 + (1<<9)) >> 10, 15) as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:350:38 [INFO] [stderr] | [INFO] [stderr] 350 | o[3] = clampbits((inv_wb_r * r as i32 + (1<<9)) >> 10, 15) as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nef.rs:352:38 [INFO] [stderr] | [INFO] [stderr] 352 | o[5] = clampbits((inv_wb_b * b as i32 + (1<<9)) >> 10, 15) as u16; [INFO] [stderr] | ^^^^^^^^ help: try: `i32::from(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nrw.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | Ok([BEu16(data,1248) as f32, 256.0, BEu16(data,1250) as f32, NAN]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(data,1248))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/nrw.rs:70:45 [INFO] [stderr] | [INFO] [stderr] 70 | Ok([BEu16(data,1248) as f32, 256.0, BEu16(data,1250) as f32, NAN]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(BEu16(data,1250))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/image.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | avg[color] += image[row*width+col] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image[row*width+col])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/image.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | avg[color] += image[row*width+col] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image[row*width+col])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/decoders/image.rs:107:6 [INFO] [stderr] | [INFO] [stderr] 107 | neutralwb[1]/neutralwb[1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `t` [INFO] [stderr] --> src/decoders/cr2.rs:55:20 [INFO] [stderr] | [INFO] [stderr] 55 | for i in 0..t.len() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 55 | for (i, ) in t.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/cr2.rs:61:26 [INFO] [stderr] | [INFO] [stderr] 61 | let mut random = ljpegout[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(ljpegout[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rgb_to_cam` [INFO] [stderr] --> src/decoders/image.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (i, ) in rgb_to_cam.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/cr2.rs:162:11 [INFO] [stderr] | [INFO] [stderr] 162 | Ok([levels.get_force_u16(offset) as f32, levels.get_force_u16(offset+1) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(offset))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/cr2.rs:162:48 [INFO] [stderr] | [INFO] [stderr] 162 | Ok([levels.get_force_u16(offset) as f32, levels.get_force_u16(offset+1) as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(offset+1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/cr2.rs:163:11 [INFO] [stderr] | [INFO] [stderr] 163 | levels.get_force_u16(offset+3) as f32, NAN]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(levels.get_force_u16(offset+3))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `rgb_to_xyz` [INFO] [stderr] --> src/decoders/image.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | for k in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/cr2.rs:184:15 [INFO] [stderr] | [INFO] [stderr] 184 | let y = pix[0] as i32 - yoffset; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(pix[0])` [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 126 | for (k, ) in rgb_to_xyz.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/cr2.rs:185:16 [INFO] [stderr] | [INFO] [stderr] 185 | let cb = pix[1] as i32 - 16383; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(pix[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/cr2.rs:186:16 [INFO] [stderr] | [INFO] [stderr] 186 | let cr = pix[2] as i32 - 16383; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(pix[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `cam_to_rgb` [INFO] [stderr] --> src/decoders/image.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | for k in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 155 | for (k, ) in cam_to_rgb.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoders/ari.rs:29:79 [INFO] [stderr] | [INFO] [stderr] 29 | let model = String::from_utf8_lossy(&self.buffer[668..]).split_terminator("\0").next().unwrap_or("").to_string(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `temp` [INFO] [stderr] --> src/decoders/image.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for (i, ) in temp.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `inm`. [INFO] [stderr] --> src/decoders/image.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | for k in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in &inm { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `inm` [INFO] [stderr] --> src/decoders/image.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for (i, ) in inm.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn ri32(&self, buf: &[u8], pos: usize) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn ru32(&self, buf: &[u8], pos: usize) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:41:15 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn ru16(&self, buf: &[u8], pos: usize) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn little(&self) -> bool { !self.big } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decoders/x3f.rs:113:10 [INFO] [stderr] | [INFO] [stderr] 113 | .ok_or("X3F: Couldn't find camera info".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "X3F: Couldn't find camera info".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/decoders/x3f.rs:124:10 [INFO] [stderr] | [INFO] [stderr] 124 | .ok_or("X3F: Couldn't find image".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "X3F: Couldn't find image".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/basics.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | let base = sbase as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(sbase)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/basics.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | let delta = sdelta as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(sdelta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | o[0] = tbl.dither(i[0] as u16, &mut random); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | let g4: u16 = i[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | let g5: u16 = i[4] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | let g6: u16 = i[5] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | let g7: u16 = i[6] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let g8: u16 = i[7] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let g9: u16 = i[8] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | let g10: u16 = i[9] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let g4: u16 = i[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | let g5: u16 = i[4] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `decoders::Camera` [INFO] [stderr] --> src/decoders/mod.rs:175:3 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn new() -> Camera { [INFO] [stderr] 176 | | Camera { [INFO] [stderr] 177 | | make: "".to_string(), [INFO] [stderr] 178 | | model: "".to_string(), [INFO] [stderr] ... | [INFO] [stderr] 197 | | } [INFO] [stderr] 198 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | impl Default for decoders::Camera { [INFO] [stderr] 121 | fn default() -> Self { [INFO] [stderr] 122 | Self::new() [INFO] [stderr] 123 | } [INFO] [stderr] 124 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | let g4: u16 = i[ 3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let g5: u16 = i[ 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | let g6: u16 = i[ 5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:102:22 [INFO] [stderr] | [INFO] [stderr] 102 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | let g4: u16 = i[ 3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | let g5: u16 = i[ 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | let g6: u16 = i[ 5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | let g7: u16 = i[ 6] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | let g8: u16 = i[ 7] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:123:20 [INFO] [stderr] | [INFO] [stderr] 123 | let g9: u16 = i[ 8] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | let g10: u16 = i[ 9] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | let g11: u16 = i[10] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | let g12: u16 = i[11] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:171:23 [INFO] [stderr] | [INFO] [stderr] 171 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:172:23 [INFO] [stderr] | [INFO] [stderr] 172 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:212:21 [INFO] [stderr] | [INFO] [stderr] 212 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:213:21 [INFO] [stderr] | [INFO] [stderr] 213 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/decoders/mod.rs:147:34 [INFO] [stderr] | [INFO] [stderr] 147 | for (i, val) in matrix.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/decoders/mod.rs:153:37 [INFO] [stderr] | [INFO] [stderr] 153 | for (i, val) in crop_vals.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:227:21 [INFO] [stderr] | [INFO] [stderr] 227 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:229:21 [INFO] [stderr] | [INFO] [stderr] 229 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | let inbits: u64 = LEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | let inbits: u64 = BEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | let inbits: u64 = LEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.pos` [INFO] [stderr] --> src/decoders/pumps.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | self.buffer[self.pos+0] != 0xff && [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:174:27 [INFO] [stderr] | [INFO] [stderr] 174 | let inbits: u64 = BEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:199:42 [INFO] [stderr] | [INFO] [stderr] 199 | self.bits = (self.bits << 8) | (byte as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/mod.rs:249:19 [INFO] [stderr] | [INFO] [stderr] 249 | pub fn to_flips(&self) -> (bool, bool, bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | for _ in 1..((self.bits[l] as usize)+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=(self.bits[l] as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `decoders::RawLoader` [INFO] [stderr] --> src/decoders/mod.rs:283:3 [INFO] [stderr] | [INFO] [stderr] 283 | / pub fn new() -> RawLoader { [INFO] [stderr] 284 | | let toml = match CAMERAS_TOML.parse::() { [INFO] [stderr] 285 | | Ok(val) => val, [INFO] [stderr] 286 | | Err(e) => panic!(format!("Error parsing all.toml: {:?}", e)), [INFO] [stderr] ... | [INFO] [stderr] 338 | | } [INFO] [stderr] 339 | | } [INFO] [stderr] | |___^ [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | let mut si: u32 = huffsize[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(huffsize[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 276 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | while (huffsize[p] as u32) == si { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(huffsize[p])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:159:27 [INFO] [stderr] | [INFO] [stderr] 159 | self.maxcode[l] = huffcode[p - 1] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(huffcode[p - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | let ll: i32 = (code << (8 - size)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code << (8 - size))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | for i in ll..(ul+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `ll..=ul` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:192:38 [INFO] [stderr] | [INFO] [stderr] 192 | self.numbits[i as usize] = (size as u32) | ((value as u32) << 4); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:212:27 [INFO] [stderr] | [INFO] [stderr] 212 | let mut code: i32 = (input >> 8) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:220:27 [INFO] [stderr] | [INFO] [stderr] 220 | let temp: i32 = (input >> (15 - l) & 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> (15 - l) & 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | (code - (self.mincode[l as usize] as i32)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.mincode[l as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | let mut x = (input >> (16 - (l as i32) - rv) & ((1 << rv) - 1)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> (16 - (l as i32) - rv) & ((1 << rv) - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/image.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | avg[color] += image[row*width+col] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image[row*width+col])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/image.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | avg[color] += image[row*width+col] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(image[row*width+col])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/decoders/image.rs:107:6 [INFO] [stderr] | [INFO] [stderr] 107 | neutralwb[1]/neutralwb[1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `rgb_to_cam` [INFO] [stderr] --> src/decoders/image.rs:123:14 [INFO] [stderr] | [INFO] [stderr] 123 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (i, ) in rgb_to_cam.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `rgb_to_xyz` [INFO] [stderr] --> src/decoders/image.rs:126:18 [INFO] [stderr] | [INFO] [stderr] 126 | for k in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 126 | for (k, ) in rgb_to_xyz.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is used to index `cam_to_rgb` [INFO] [stderr] --> src/decoders/image.rs:155:18 [INFO] [stderr] | [INFO] [stderr] 155 | for k in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 155 | for (k, ) in cam_to_rgb.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `temp` [INFO] [stderr] --> src/decoders/image.rs:167:14 [INFO] [stderr] | [INFO] [stderr] 167 | for i in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for (i, ) in temp.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `k` is only used to index `inm`. [INFO] [stderr] --> src/decoders/image.rs:172:18 [INFO] [stderr] | [INFO] [stderr] 172 | for k in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in &inm { [INFO] [stderr] | ^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:12:7 [INFO] [stderr] | [INFO] [stderr] 12 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] warning: the loop variable `i` is used to index `inm` [INFO] [stderr] --> src/decoders/image.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for (i, ) in inm.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/decoders/mod.rs:342:3 [INFO] [stderr] | [INFO] [stderr] 342 | / pub fn get_decoder<'b>(&'b self, buf: &'b Buffer) -> Result, String> { [INFO] [stderr] 343 | | let buffer = &buf.buf; [INFO] [stderr] 344 | | [INFO] [stderr] 345 | | if mrw::is_mrw(buffer) { [INFO] [stderr] ... | [INFO] [stderr] 420 | | Err(format!("Couldn't find a decoder for this file.{}", SAMPLE).to_string()) [INFO] [stderr] 421 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:34:34 [INFO] [stderr] | [INFO] [stderr] 34 | out[row*stripwidth+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | out[row*stripwidth+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:25:15 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn ri32(&self, buf: &[u8], pos: usize) -> i32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn ru32(&self, buf: &[u8], pos: usize) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:41:15 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn ru16(&self, buf: &[u8], pos: usize) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/decoders/basics.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | pub fn little(&self) -> bool { !self.big } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:56:7 [INFO] [stderr] | [INFO] [stderr] 56 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | out[row*stripwidth+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | out[row*stripwidth+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | out[row*stripwidth+col+2] = ((p3 as i32) + diff3) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/basics.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | let base = sbase as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(sbase)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/basics.rs:132:17 [INFO] [stderr] | [INFO] [stderr] 132 | let delta = sdelta as u32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(sdelta)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:9:25 [INFO] [stderr] | [INFO] [stderr] 9 | o[0] = tbl.dither(i[0] as u16, &mut random); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:19:22 [INFO] [stderr] | [INFO] [stderr] 19 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:21:22 [INFO] [stderr] | [INFO] [stderr] 21 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | let g4: u16 = i[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | let g5: u16 = i[4] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:24:22 [INFO] [stderr] | [INFO] [stderr] 24 | let g6: u16 = i[5] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | let g7: u16 = i[6] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:26:22 [INFO] [stderr] | [INFO] [stderr] 26 | let g8: u16 = i[7] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:27:22 [INFO] [stderr] | [INFO] [stderr] 27 | let g9: u16 = i[8] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:28:22 [INFO] [stderr] | [INFO] [stderr] 28 | let g10: u16 = i[9] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:102:7 [INFO] [stderr] | [INFO] [stderr] 102 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | let ref htable4 = ljpeg.dhts[ljpeg.sof.components[3].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable4 = &ljpeg.dhts[ljpeg.sof.components[3].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:50:22 [INFO] [stderr] | [INFO] [stderr] 50 | let g4: u16 = i[3] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | let g5: u16 = i[4] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:131:29 [INFO] [stderr] | [INFO] [stderr] 131 | out[row*width+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:132:31 [INFO] [stderr] | [INFO] [stderr] 132 | out[row*width+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:133:31 [INFO] [stderr] | [INFO] [stderr] 133 | out[row*width+col+2] = ((p3 as i32) + diff3) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:66:21 [INFO] [stderr] | [INFO] [stderr] 66 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:134:31 [INFO] [stderr] | [INFO] [stderr] 134 | out[row*width+col+3] = ((p4 as i32) + diff4) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p4)` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:148:1 [INFO] [stderr] | [INFO] [stderr] 148 | / fn set_yuv_420(out: &mut [u16], row: usize, col: usize, width: usize, y1: i32, y2: i32, y3: i32, y4: i32, cb: i32, cr: i32) { [INFO] [stderr] 149 | | let pix1 = row*width+col; [INFO] [stderr] 150 | | let pix2 = pix1+3; [INFO] [stderr] 151 | | let pix3 = (row+1)*width+col; [INFO] [stderr] ... | [INFO] [stderr] 165 | | out[pix4+2] = cr as u16; [INFO] [stderr] 166 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:81:20 [INFO] [stderr] | [INFO] [stderr] 81 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | let g4: u16 = i[ 3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix1` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:154:7 [INFO] [stderr] | [INFO] [stderr] 154 | out[pix1+0] = y1 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:84:20 [INFO] [stderr] | [INFO] [stderr] 84 | let g5: u16 = i[ 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:85:20 [INFO] [stderr] | [INFO] [stderr] 85 | let g6: u16 = i[ 5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix2` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:157:7 [INFO] [stderr] | [INFO] [stderr] 157 | out[pix2+0] = y2 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix3` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | out[pix3+0] = y3 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix4` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:163:7 [INFO] [stderr] | [INFO] [stderr] 163 | out[pix4+0] = y4 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:102:22 [INFO] [stderr] | [INFO] [stderr] 102 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:103:22 [INFO] [stderr] | [INFO] [stderr] 103 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:115:20 [INFO] [stderr] | [INFO] [stderr] 115 | let g1: u16 = i[ 0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | let g2: u16 = i[ 1] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:117:20 [INFO] [stderr] | [INFO] [stderr] 117 | let g3: u16 = i[ 2] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:118:20 [INFO] [stderr] | [INFO] [stderr] 118 | let g4: u16 = i[ 3] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:119:20 [INFO] [stderr] | [INFO] [stderr] 119 | let g5: u16 = i[ 4] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | let g6: u16 = i[ 5] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:121:20 [INFO] [stderr] | [INFO] [stderr] 121 | let g7: u16 = i[ 6] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:122:20 [INFO] [stderr] | [INFO] [stderr] 122 | let g8: u16 = i[ 7] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:123:20 [INFO] [stderr] | [INFO] [stderr] 123 | let g9: u16 = i[ 8] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:124:20 [INFO] [stderr] | [INFO] [stderr] 124 | let g10: u16 = i[ 9] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[ 9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:125:20 [INFO] [stderr] | [INFO] [stderr] 125 | let g11: u16 = i[10] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[10])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | let g12: u16 = i[11] as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(i[11])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:175:7 [INFO] [stderr] | [INFO] [stderr] 175 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:176:7 [INFO] [stderr] | [INFO] [stderr] 176 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:177:7 [INFO] [stderr] | [INFO] [stderr] 177 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:152:23 [INFO] [stderr] | [INFO] [stderr] 152 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | let y1 = (py as i32) + try!(htable1.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:171:23 [INFO] [stderr] | [INFO] [stderr] 171 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:172:23 [INFO] [stderr] | [INFO] [stderr] 172 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | let cb = (pcb as i32) + try!(htable2.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | let cr = (pcr as i32) + try!(htable3.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:214:1 [INFO] [stderr] | [INFO] [stderr] 214 | / fn set_yuv_422(out: &mut [u16], row: usize, col: usize, width: usize, y1: i32, y2: i32, cb: i32, cr: i32) { [INFO] [stderr] 215 | | let pix1 = row*width+col; [INFO] [stderr] 216 | | let pix2 = pix1+3; [INFO] [stderr] 217 | | [INFO] [stderr] ... | [INFO] [stderr] 223 | | out[pix2+2] = cr as u16; [INFO] [stderr] 224 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix1` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:218:7 [INFO] [stderr] | [INFO] [stderr] 218 | out[pix1+0] = y1 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:194:21 [INFO] [stderr] | [INFO] [stderr] 194 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:106:45 [INFO] [stderr] | [INFO] [stderr] 106 | LOADER.decode_file(path.as_ref()).map_err(|err| RawLoaderError::new(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RawLoaderError::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix2` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:221:7 [INFO] [stderr] | [INFO] [stderr] 221 | out[pix2+0] = y2 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:120:33 [INFO] [stderr] | [INFO] [stderr] 120 | LOADER.decode(reader).map_err(|err| RawLoaderError::new(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RawLoaderError::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:212:21 [INFO] [stderr] | [INFO] [stderr] 212 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:213:21 [INFO] [stderr] | [INFO] [stderr] 213 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:214:21 [INFO] [stderr] | [INFO] [stderr] 214 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:227:21 [INFO] [stderr] | [INFO] [stderr] 227 | let g1: u16 = i[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | let g2: u16 = i[1] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/packed.rs:229:21 [INFO] [stderr] | [INFO] [stderr] 229 | let g3: u16 = i[2] as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u16::from(i[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:232:7 [INFO] [stderr] | [INFO] [stderr] 232 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:234:7 [INFO] [stderr] | [INFO] [stderr] 234 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:256:16 [INFO] [stderr] | [INFO] [stderr] 256 | let y1 = (py as i32) + try!(htable1.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:258:16 [INFO] [stderr] | [INFO] [stderr] 258 | let cb = (pcb as i32) + try!(htable2.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:259:16 [INFO] [stderr] | [INFO] [stderr] 259 | let cr = (pcr as i32) + try!(htable3.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:271:7 [INFO] [stderr] | [INFO] [stderr] 271 | let ref htable = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------- help: try: `let htable = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:307:31 [INFO] [stderr] | [INFO] [stderr] 307 | out[row*width+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:308:31 [INFO] [stderr] | [INFO] [stderr] 308 | out[row*width+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:118:25 [INFO] [stderr] | [INFO] [stderr] 118 | let inbits: u64 = LEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:135:25 [INFO] [stderr] | [INFO] [stderr] 135 | let inbits: u64 = BEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:152:25 [INFO] [stderr] | [INFO] [stderr] 152 | let inbits: u64 = LEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(LEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.pos` [INFO] [stderr] --> src/decoders/pumps.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | self.buffer[self.pos+0] != 0xff && [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:174:27 [INFO] [stderr] | [INFO] [stderr] 174 | let inbits: u64 = BEu32(self.buffer, self.pos) as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BEu32(self.buffer, self.pos))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/decoders/pumps.rs:199:42 [INFO] [stderr] | [INFO] [stderr] 199 | self.bits = (self.bits << 8) | (byte as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:223:25 [INFO] [stderr] | [INFO] [stderr] 223 | bits[th][i+1] = input.get_u8() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | huffval[th][i] = input.get_u8() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:119:16 [INFO] [stderr] | [INFO] [stderr] 119 | for _ in 1..((self.bits[l] as usize)+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `1..=(self.bits[l] as usize)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:133:23 [INFO] [stderr] | [INFO] [stderr] 133 | let mut si: u32 = huffsize[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(huffsize[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:137:13 [INFO] [stderr] | [INFO] [stderr] 137 | while (huffsize[p] as u32) == si { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(huffsize[p])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:159:27 [INFO] [stderr] | [INFO] [stderr] 159 | self.maxcode[l] = huffcode[p - 1] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(huffcode[p - 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:182:23 [INFO] [stderr] | [INFO] [stderr] 182 | let ll: i32 = (code << (8 - size)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(code << (8 - size))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | / loop { [INFO] [stderr] 272 | | match LjpegDecompressor::get_next_marker(&mut input, true) { [INFO] [stderr] 273 | | Ok(marker) => { [INFO] [stderr] 274 | | if marker == m(Marker::EOI) { [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(marker) = LjpegDecompressor::get_next_marker(&mut input, true) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | for i in ll..(ul+1) { [INFO] [stderr] | ^^^^^^^^^^ help: use: `ll..=ul` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:192:38 [INFO] [stderr] | [INFO] [stderr] 192 | self.numbits[i as usize] = (size as u32) | ((value as u32) << 4); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | let ref htable1 = self.dhts[self.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let htable1 = &self.dhts[self.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | let ref htable2 = self.dhts[self.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let htable2 = &self.dhts[self.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:212:27 [INFO] [stderr] | [INFO] [stderr] 212 | let mut code: i32 = (input >> 8) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> 8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:220:27 [INFO] [stderr] | [INFO] [stderr] 220 | let temp: i32 = (input >> (15 - l) & 1) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> (15 - l) & 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:232:21 [INFO] [stderr] | [INFO] [stderr] 232 | (code - (self.mincode[l as usize] as i32)) as usize [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.mincode[l as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/huffman.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | let mut x = (input >> (16 - (l as i32) - rv) & ((1 << rv) - 1)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(input >> (16 - (l as i32) - rv) & ((1 << rv) - 1))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `pattern` [INFO] [stderr] --> src/decoders/cfa.rs:123:16 [INFO] [stderr] | [INFO] [stderr] 123 | for row in 0..48 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (row, ) in pattern.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is only used to index `pattern`. [INFO] [stderr] --> src/decoders/cfa.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | for row in 0..self.height { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 130 | for in pattern.iter().take(self.height) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `cpattern` [INFO] [stderr] --> src/decoders/cfa.rs:190:16 [INFO] [stderr] | [INFO] [stderr] 190 | for row in 0..48 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 190 | for (row, ) in cpattern.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/decoders/cfa.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | for col in 0..48 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `cpattern[row][..48].clone_from_slice(&self.pattern[row][..48])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:12:7 [INFO] [stderr] | [INFO] [stderr] 12 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:13:7 [INFO] [stderr] | [INFO] [stderr] 13 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:34:34 [INFO] [stderr] | [INFO] [stderr] 34 | out[row*stripwidth+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | out[row*stripwidth+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:54:7 [INFO] [stderr] | [INFO] [stderr] 54 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:55:7 [INFO] [stderr] | [INFO] [stderr] 55 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:56:7 [INFO] [stderr] | [INFO] [stderr] 56 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:80:34 [INFO] [stderr] | [INFO] [stderr] 80 | out[row*stripwidth+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:81:36 [INFO] [stderr] | [INFO] [stderr] 81 | out[row*stripwidth+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | out[row*stripwidth+col+2] = ((p3 as i32) + diff3) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:101:7 [INFO] [stderr] | [INFO] [stderr] 101 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:102:7 [INFO] [stderr] | [INFO] [stderr] 102 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:103:7 [INFO] [stderr] | [INFO] [stderr] 103 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:104:7 [INFO] [stderr] | [INFO] [stderr] 104 | let ref htable4 = ljpeg.dhts[ljpeg.sof.components[3].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable4 = &ljpeg.dhts[ljpeg.sof.components[3].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: Could not compile `rawloader`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:131:29 [INFO] [stderr] | [INFO] [stderr] 131 | out[row*width+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:132:31 [INFO] [stderr] | [INFO] [stderr] 132 | out[row*width+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:133:31 [INFO] [stderr] | [INFO] [stderr] 133 | out[row*width+col+2] = ((p3 as i32) + diff3) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:134:31 [INFO] [stderr] | [INFO] [stderr] 134 | out[row*width+col+3] = ((p4 as i32) + diff4) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:148:1 [INFO] [stderr] | [INFO] [stderr] 148 | / fn set_yuv_420(out: &mut [u16], row: usize, col: usize, width: usize, y1: i32, y2: i32, y3: i32, y4: i32, cb: i32, cr: i32) { [INFO] [stderr] 149 | | let pix1 = row*width+col; [INFO] [stderr] 150 | | let pix2 = pix1+3; [INFO] [stderr] 151 | | let pix3 = (row+1)*width+col; [INFO] [stderr] ... | [INFO] [stderr] 165 | | out[pix4+2] = cr as u16; [INFO] [stderr] 166 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix1` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:154:7 [INFO] [stderr] | [INFO] [stderr] 154 | out[pix1+0] = y1 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix2` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:157:7 [INFO] [stderr] | [INFO] [stderr] 157 | out[pix2+0] = y2 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix3` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:160:7 [INFO] [stderr] | [INFO] [stderr] 160 | out[pix3+0] = y3 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix4` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:163:7 [INFO] [stderr] | [INFO] [stderr] 163 | out[pix4+0] = y4 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:175:7 [INFO] [stderr] | [INFO] [stderr] 175 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:176:7 [INFO] [stderr] | [INFO] [stderr] 176 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:177:7 [INFO] [stderr] | [INFO] [stderr] 177 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | let y1 = (py as i32) + try!(htable1.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:205:16 [INFO] [stderr] | [INFO] [stderr] 205 | let cb = (pcb as i32) + try!(htable2.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:206:16 [INFO] [stderr] | [INFO] [stderr] 206 | let cr = (pcr as i32) + try!(htable3.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:214:1 [INFO] [stderr] | [INFO] [stderr] 214 | / fn set_yuv_422(out: &mut [u16], row: usize, col: usize, width: usize, y1: i32, y2: i32, cb: i32, cr: i32) { [INFO] [stderr] 215 | | let pix1 = row*width+col; [INFO] [stderr] 216 | | let pix2 = pix1+3; [INFO] [stderr] 217 | | [INFO] [stderr] ... | [INFO] [stderr] 223 | | out[pix2+2] = cr as u16; [INFO] [stderr] 224 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix1` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:218:7 [INFO] [stderr] | [INFO] [stderr] 218 | out[pix1+0] = y1 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `pix2` [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:221:7 [INFO] [stderr] | [INFO] [stderr] 221 | out[pix2+0] = y2 as u16; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:232:7 [INFO] [stderr] | [INFO] [stderr] 232 | let ref htable1 = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable1 = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:233:7 [INFO] [stderr] | [INFO] [stderr] 233 | let ref htable2 = ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable2 = &ljpeg.dhts[ljpeg.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:234:7 [INFO] [stderr] | [INFO] [stderr] 234 | let ref htable3 = ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^-------------------------------------------------- help: try: `let htable3 = &ljpeg.dhts[ljpeg.sof.components[2].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:256:16 [INFO] [stderr] | [INFO] [stderr] 256 | let y1 = (py as i32) + try!(htable1.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(py)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:258:16 [INFO] [stderr] | [INFO] [stderr] 258 | let cb = (pcb as i32) + try!(htable2.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcb)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:259:16 [INFO] [stderr] | [INFO] [stderr] 259 | let cr = (pcr as i32) + try!(htable3.huff_decode(&mut pump)); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(pcr)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:271:7 [INFO] [stderr] | [INFO] [stderr] 271 | let ref htable = ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^-------------------------------------------------- help: try: `let htable = &ljpeg.dhts[ljpeg.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:307:31 [INFO] [stderr] | [INFO] [stderr] 307 | out[row*width+col] = ((p1 as i32) + diff1) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/decompressors.rs:308:31 [INFO] [stderr] | [INFO] [stderr] 308 | out[row*width+col+1] = ((p2 as i32) + diff2) as u16; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i32::from(p2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/tiff.rs:148:7 [INFO] [stderr] | [INFO] [stderr] 148 | / match TiffIFD::new_fuji(buf, BEu32(buf, 92) as usize) { [INFO] [stderr] 149 | | Ok(val) => subifds.push(val), [INFO] [stderr] 150 | | Err(_) => {} [INFO] [stderr] 151 | | } [INFO] [stderr] | |_______^ help: try this: `if let Ok(val) = TiffIFD::new_fuji(buf, BEu32(buf, 92) as usize) { subifds.push(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:223:25 [INFO] [stderr] | [INFO] [stderr] 223 | bits[th][i+1] = input.get_u8() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:237:26 [INFO] [stderr] | [INFO] [stderr] 237 | huffval[th][i] = input.get_u8() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(input.get_u8())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:271:5 [INFO] [stderr] | [INFO] [stderr] 271 | / loop { [INFO] [stderr] 272 | | match LjpegDecompressor::get_next_marker(&mut input, true) { [INFO] [stderr] 273 | | Ok(marker) => { [INFO] [stderr] 274 | | if marker == m(Marker::EOI) { [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_____^ help: try: `while let Ok(marker) = LjpegDecompressor::get_next_marker(&mut input, true) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:287:9 [INFO] [stderr] | [INFO] [stderr] 287 | let ref htable1 = self.dhts[self.sof.components[0].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let htable1 = &self.dhts[self.sof.components[0].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/decoders/ljpeg/mod.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | let ref htable2 = self.dhts[self.sof.components[1].dc_tbl_num]; [INFO] [stderr] | ----^^^^^^^^^^^------------------------------------------------ help: try: `let htable2 = &self.dhts[self.sof.components[1].dc_tbl_num];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/tiff.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | / match ifd.find_entry(tag) { [INFO] [stderr] 356 | | Some(x) => return Some(x), [INFO] [stderr] 357 | | None => {}, [INFO] [stderr] 358 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = ifd.find_entry(tag) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/tiff.rs:384:8 [INFO] [stderr] | [INFO] [stderr] 384 | if ifds.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ifds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/decoders/tiff.rs:426:20 [INFO] [stderr] | [INFO] [stderr] 426 | let mut copy = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/tiff.rs:442:29 [INFO] [stderr] | [INFO] [stderr] 442 | 1 => self.data[idx] as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[idx])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/tiff.rs:450:29 [INFO] [stderr] | [INFO] [stderr] 450 | 1 | 3 | 8 => self.get_u16(idx) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_u16(idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `pattern` [INFO] [stderr] --> src/decoders/cfa.rs:123:16 [INFO] [stderr] | [INFO] [stderr] 123 | for row in 0..48 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 123 | for (row, ) in pattern.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is only used to index `pattern`. [INFO] [stderr] --> src/decoders/cfa.rs:130:16 [INFO] [stderr] | [INFO] [stderr] 130 | for row in 0..self.height { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 130 | for in pattern.iter().take(self.height) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `row` is used to index `cpattern` [INFO] [stderr] --> src/decoders/cfa.rs:190:16 [INFO] [stderr] | [INFO] [stderr] 190 | for row in 0..48 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 190 | for (row, ) in cpattern.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/decoders/cfa.rs:191:18 [INFO] [stderr] | [INFO] [stderr] 191 | for col in 0..48 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `cpattern[row][..48].clone_from_slice(&self.pattern[row][..48])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/ciff.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match ifd.find_entry(tag) { [INFO] [stderr] 88 | | Some(x) => return Some(x), [INFO] [stderr] 89 | | None => {}, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = ifd.find_entry(tag) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoders/ciff.rs:138:57 [INFO] [stderr] | [INFO] [stderr] 138 | String::from_utf8_lossy(self.data).split_terminator("\0").map(|x| x.to_string()).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ciff.rs:143:48 [INFO] [stderr] | [INFO] [stderr] 143 | 0x0000 | 0x8000 => self.data[idx] as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[idx])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ciff.rs:144:48 [INFO] [stderr] | [INFO] [stderr] 144 | 0x1000 => LEu16(self.data, idx*2) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LEu16(self.data, idx*2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `wb_vals` [INFO] [stderr] --> src/decoders/mrw.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for (i, ) in wb_vals.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | [self.wb_vals[2] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:85:8 [INFO] [stderr] | [INFO] [stderr] 85 | self.wb_vals[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:86:8 [INFO] [stderr] | [INFO] [stderr] 86 | self.wb_vals[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:89:8 [INFO] [stderr] | [INFO] [stderr] 89 | [self.wb_vals[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | self.wb_vals[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | self.wb_vals[3] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/tiff.rs:148:7 [INFO] [stderr] | [INFO] [stderr] 148 | / match TiffIFD::new_fuji(buf, BEu32(buf, 92) as usize) { [INFO] [stderr] 149 | | Ok(val) => subifds.push(val), [INFO] [stderr] 150 | | Err(_) => {} [INFO] [stderr] 151 | | } [INFO] [stderr] | |_______^ help: try this: `if let Ok(val) = TiffIFD::new_fuji(buf, BEu32(buf, 92) as usize) { subifds.push(val) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | wb_coeffs[0] = LEu16(buf, currpos+12) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+12))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | wb_coeffs[1] = LEu16(buf, currpos+14) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+14))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | wb_coeffs[2] = LEu16(buf, currpos+18) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+18))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:115:8 [INFO] [stderr] | [INFO] [stderr] 115 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/tiff.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | / match ifd.find_entry(tag) { [INFO] [stderr] 356 | | Some(x) => return Some(x), [INFO] [stderr] 357 | | None => {}, [INFO] [stderr] 358 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = ifd.find_entry(tag) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/tiff.rs:384:8 [INFO] [stderr] | [INFO] [stderr] 384 | if ifds.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ifds.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/decoders/tiff.rs:426:20 [INFO] [stderr] | [INFO] [stderr] 426 | let mut copy = self.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/arw.rs:238:16 [INFO] [stderr] | [INFO] [stderr] 238 | for j in (curve[i]+1)..(curve[i+1]+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((curve[i]+1)..=curve[i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/decoders/tiff.rs:442:29 [INFO] [stderr] | [INFO] [stderr] 442 | 1 => self.data[idx] as u16, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.data[idx])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is only used to index `pad`. [INFO] [stderr] --> src/decoders/arw.rs:250:14 [INFO] [stderr] | [INFO] [stderr] 250 | for p in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 250 | for in pad.iter_mut().take(4) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/tiff.rs:450:29 [INFO] [stderr] | [INFO] [stderr] 450 | 1 | 3 | 8 => self.get_u16(idx) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.get_u16(idx))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is only used to index `pad`. [INFO] [stderr] --> src/decoders/arw.rs:258:14 [INFO] [stderr] | [INFO] [stderr] 258 | for p in 0..127 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 258 | for in pad.iter_mut().take(127) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/arw.rs:263:14 [INFO] [stderr] | [INFO] [stderr] 263 | for i in 0..(length/4+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: use: `0..=length/4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `output` [INFO] [stderr] --> src/decoders/arw.rs:267:17 [INFO] [stderr] | [INFO] [stderr] 267 | out.push(((output >> 0) & 0xff) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/decoders/ciff.rs:87:9 [INFO] [stderr] | [INFO] [stderr] 87 | / match ifd.find_entry(tag) { [INFO] [stderr] 88 | | Some(x) => return Some(x), [INFO] [stderr] 89 | | None => {}, [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(x) = ifd.find_entry(tag) { return Some(x) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/decoders/ciff.rs:138:57 [INFO] [stderr] | [INFO] [stderr] 138 | String::from_utf8_lossy(self.data).split_terminator("\0").map(|x| x.to_string()).collect() [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ciff.rs:143:48 [INFO] [stderr] | [INFO] [stderr] 143 | 0x0000 | 0x8000 => self.data[idx] as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.data[idx])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/ciff.rs:144:48 [INFO] [stderr] | [INFO] [stderr] 144 | 0x1000 => LEu16(self.data, idx*2) as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(LEu16(self.data, idx*2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `bittable` [INFO] [stderr] --> src/decoders/orf.rs:84:14 [INFO] [stderr] | [INFO] [stderr] 84 | for i in 0..4096 { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 84 | for (i, ) in bittable.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/decoders/orf.rs:108:27 [INFO] [stderr] | [INFO] [stderr] 108 | let sign: i32 = (b >> 14) * -1; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/orf.rs:110:31 [INFO] [stderr] | [INFO] [stderr] 110 | let mut high: i32 = bittable[(b&4095) as usize] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(bittable[(b&4095) as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `wb_vals` [INFO] [stderr] --> src/decoders/mrw.rs:44:20 [INFO] [stderr] | [INFO] [stderr] 44 | for i in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 44 | for (i, ) in wb_vals.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:84:8 [INFO] [stderr] | [INFO] [stderr] 84 | [self.wb_vals[2] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:85:8 [INFO] [stderr] | [INFO] [stderr] 85 | self.wb_vals[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:86:8 [INFO] [stderr] | [INFO] [stderr] 86 | self.wb_vals[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:89:8 [INFO] [stderr] | [INFO] [stderr] 89 | [self.wb_vals[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:90:8 [INFO] [stderr] | [INFO] [stderr] 90 | self.wb_vals[1] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/mrw.rs:91:8 [INFO] [stderr] | [INFO] [stderr] 91 | self.wb_vals[3] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.wb_vals[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/orf.rs:131:23 [INFO] [stderr] | [INFO] [stderr] 131 | nw[s] = out[(row-2) * width + (col+s)] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(out[(row-2) * width + (col+s)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/orf.rs:137:27 [INFO] [stderr] | [INFO] [stderr] 137 | let up: i32 = out[(row-2) * width + (col+s)] as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(out[(row-2) * width + (col+s)])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/orf.rs:174:10 [INFO] [stderr] | [INFO] [stderr] 174 | if ifd.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ifd.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:102:24 [INFO] [stderr] | [INFO] [stderr] 102 | wb_coeffs[0] = LEu16(buf, currpos+12) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+12))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:103:24 [INFO] [stderr] | [INFO] [stderr] 103 | wb_coeffs[1] = LEu16(buf, currpos+14) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+14))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/arw.rs:104:24 [INFO] [stderr] | [INFO] [stderr] 104 | wb_coeffs[2] = LEu16(buf, currpos+18) as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(LEu16(buf, currpos+18))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoders/arw.rs:115:8 [INFO] [stderr] | [INFO] [stderr] 115 | if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/decoders/arw.rs:238:16 [INFO] [stderr] | [INFO] [stderr] 238 | for j in (curve[i]+1)..(curve[i+1]+1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((curve[i]+1)..=curve[i+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/srw.rs:112:31 [INFO] [stderr] | [INFO] [stderr] 112 | out[img+col+c] = ((predictor as i32) + adj) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(predictor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/decoders/srw.rs:125:31 [INFO] [stderr] | [INFO] [stderr] 125 | out[img+col+c] = ((predictor as i32) + adj) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(predictor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is only used to index `pad`. [INFO] [stderr] --> src/decoders/arw.rs:250:14 [INFO] [stderr] | [INFO] [stderr] 250 | for p in 0..4 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 250 | for in pad.iter_mut().take(4) { [WARN] too many lines in the log, truncating it