[INFO] crate ravenlib 1.2.2 is already in cache
[INFO] extracting crate ravenlib 1.2.2 into work/ex/clippy-test-run/sources/stable/reg/ravenlib/1.2.2
[INFO] extracting crate ravenlib 1.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ravenlib/1.2.2
[INFO] validating manifest of ravenlib-1.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ravenlib-1.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ravenlib-1.2.2
[INFO] removed 1 missing tests
[INFO] finished frobbing ravenlib-1.2.2
[INFO] frobbed toml for ravenlib-1.2.2 written to work/ex/clippy-test-run/sources/stable/reg/ravenlib/1.2.2/Cargo.toml
[INFO] started frobbing ravenlib-1.2.2
[INFO] removed 1 missing tests
[INFO] finished frobbing ravenlib-1.2.2
[INFO] frobbed toml for ravenlib-1.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ravenlib/1.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ravenlib-1.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ravenlib/1.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bc296b84960972836cea6d9e5f1f4a64e62dc7439f3af6c2ac6a21f64f322ed5
[INFO] running `"docker" "start" "-a" "bc296b84960972836cea6d9e5f1f4a64e62dc7439f3af6c2ac6a21f64f322ed5"`
[INFO] [stderr]     Checking mustache v0.9.0
[INFO] [stderr]     Checking twoway v0.1.8
[INFO] [stderr]     Checking buf_redux v0.8.1
[INFO] [stderr]     Checking tiny_http v0.6.2
[INFO] [stderr]     Checking tokio v0.1.15
[INFO] [stderr]     Checking nickel v0.11.0
[INFO] [stderr]     Checking hyper v0.12.23
[INFO] [stderr]     Checking multipart v0.15.4
[INFO] [stderr]     Checking hyper-tls v0.3.1
[INFO] [stderr]     Checking reqwest v0.9.9
[INFO] [stderr]     Checking ravenlib v1.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ravenserver.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return String::from(home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(home_dir().unwrap().to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ravenserver.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return Ok(serde_json::from_str(&info)?);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(serde_json::from_str(&info)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:128:16
[INFO] [stderr]     |
[INFO] [stderr] 128 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 129 | |             if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 130 | |                 println!("You are trying to delete a user you are not. Bad!");
[INFO] [stderr] 131 | |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 141 | |             }
[INFO] [stderr] 142 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 128 |         } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 129 |     println!("You are trying to delete a user you are not. Bad!");
[INFO] [stderr] 130 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 131 | } else if res.status() == reqwest::StatusCode::UNAUTHORIZED {
[INFO] [stderr] 132 |     println!("You're trying to delete a user w/o providing authentication credentials");
[INFO] [stderr] 133 |     Err(ErrorKind::Server(RavenServerErrorKind::NotLoggedIn.into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ravenserver.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 |         return Ok(false);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:158:20
[INFO] [stderr]     |
[INFO] [stderr] 158 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 159 | |                 if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 160 | |                     println!("User already created. Pick a different name!");
[INFO] [stderr] 161 | |                     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 170 | |                 }
[INFO] [stderr] 171 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 158 |             } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 159 |     println!("User already created. Pick a different name!");
[INFO] [stderr] 160 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 161 | } else if res.status() == reqwest::StatusCode::PAYLOAD_TOO_LARGE {
[INFO] [stderr] 162 |     println!(
[INFO] [stderr] 163 |             "Either your username or password was too long. The limit is 20 characters for username, and 100 for password."
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:206:24
[INFO] [stderr]     |
[INFO] [stderr] 206 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 207 | |                     if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 208 | |                         println!("That theme already exists, and you are not its owner.");
[INFO] [stderr] 209 | |                         Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 213 | |                     }
[INFO] [stderr] 214 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 207 |     println!("That theme already exists, and you are not its owner.");
[INFO] [stderr] 208 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 209 | } else {
[INFO] [stderr] 210 |     println!("Server error. Code {:?}", res.status());
[INFO] [stderr] 211 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:233:16
[INFO] [stderr]     |
[INFO] [stderr] 233 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 234 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 235 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 236 | |             } else {
[INFO] [stderr] 237 | |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr] 238 | |             }
[INFO] [stderr] 239 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 233 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 234 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 235 | } else {
[INFO] [stderr] 236 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr] 237 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:266:16
[INFO] [stderr]     |
[INFO] [stderr] 266 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 267 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 268 | |                 println!("That theme hasn't been published");
[INFO] [stderr] 269 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 284 | |             }
[INFO] [stderr] 285 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 266 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 267 |     println!("That theme hasn't been published");
[INFO] [stderr] 268 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 269 | } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 270 |     println!("Can't edit the metadata of a theme that isn't yours");
[INFO] [stderr] 271 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:301:16
[INFO] [stderr]     |
[INFO] [stderr] 301 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 302 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 303 | |                 println!("Can't unpublish a nonexistent theme");
[INFO] [stderr] 304 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 314 | |             }
[INFO] [stderr] 315 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 301 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 302 |     println!("Can't unpublish a nonexistent theme");
[INFO] [stderr] 303 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 304 | } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 305 |     println!("Can't unpublish a theme that isn't yours");
[INFO] [stderr] 306 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:424:16
[INFO] [stderr]     |
[INFO] [stderr] 424 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 425 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 426 | |                 println!("Theme has not been uploaded");
[INFO] [stderr] 427 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 431 | |             }
[INFO] [stderr] 432 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 424 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 425 |     println!("Theme has not been uploaded");
[INFO] [stderr] 426 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 427 | } else {
[INFO] [stderr] 428 |     println!("Server error. Code {:?}", res.status());
[INFO] [stderr] 429 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:384:28
[INFO] [stderr]     |
[INFO] [stderr] 384 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 385 | |                         if !force {
[INFO] [stderr] 386 | |                             install_warning(false);
[INFO] [stderr] 387 | |                         }
[INFO] [stderr] 388 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 384 |                     } else if !force {
[INFO] [stderr] 385 |     install_warning(false);
[INFO] [stderr] 386 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:417:24
[INFO] [stderr]     |
[INFO] [stderr] 417 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 418 | |                     if !force {
[INFO] [stderr] 419 | |                         install_warning(false);
[INFO] [stderr] 420 | |                     }
[INFO] [stderr] 421 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 417 |                 } else if !force {
[INFO] [stderr] 418 |     install_warning(false);
[INFO] [stderr] 419 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:448:16
[INFO] [stderr]     |
[INFO] [stderr] 448 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 449 | |             if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 450 | |                 println!("Wrong login info. Try again!");
[INFO] [stderr] 451 | |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 455 | |             }
[INFO] [stderr] 456 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 448 |         } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 449 |     println!("Wrong login info. Try again!");
[INFO] [stderr] 450 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 451 | } else {
[INFO] [stderr] 452 |     println!("Server error. Code {:?}", res.status());
[INFO] [stderr] 453 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/themes.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return serde_json::to_string(self).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string(self).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return String::from(home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(home_dir().unwrap().to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `error::Error`
[INFO] [stderr]   --> src/ravenserver.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     error::Error
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ravenserver.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     return String::from(home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(home_dir().unwrap().to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/ravenserver.rs:37:9
[INFO] [stderr]    |
[INFO] [stderr] 37 |         return Ok(serde_json::from_str(&info)?);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(serde_json::from_str(&info)?)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:128:16
[INFO] [stderr]     |
[INFO] [stderr] 128 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 129 | |             if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 130 | |                 println!("You are trying to delete a user you are not. Bad!");
[INFO] [stderr] 131 | |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 141 | |             }
[INFO] [stderr] 142 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 128 |         } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 129 |     println!("You are trying to delete a user you are not. Bad!");
[INFO] [stderr] 130 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 131 | } else if res.status() == reqwest::StatusCode::UNAUTHORIZED {
[INFO] [stderr] 132 |     println!("You're trying to delete a user w/o providing authentication credentials");
[INFO] [stderr] 133 |     Err(ErrorKind::Server(RavenServerErrorKind::NotLoggedIn.into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/ravenserver.rs:175:9
[INFO] [stderr]     |
[INFO] [stderr] 175 |         return Ok(false);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:158:20
[INFO] [stderr]     |
[INFO] [stderr] 158 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 159 | |                 if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 160 | |                     println!("User already created. Pick a different name!");
[INFO] [stderr] 161 | |                     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 170 | |                 }
[INFO] [stderr] 171 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 158 |             } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 159 |     println!("User already created. Pick a different name!");
[INFO] [stderr] 160 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 161 | } else if res.status() == reqwest::StatusCode::PAYLOAD_TOO_LARGE {
[INFO] [stderr] 162 |     println!(
[INFO] [stderr] 163 |             "Either your username or password was too long. The limit is 20 characters for username, and 100 for password."
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:206:24
[INFO] [stderr]     |
[INFO] [stderr] 206 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 207 | |                     if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 208 | |                         println!("That theme already exists, and you are not its owner.");
[INFO] [stderr] 209 | |                         Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 213 | |                     }
[INFO] [stderr] 214 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 207 |     println!("That theme already exists, and you are not its owner.");
[INFO] [stderr] 208 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 209 | } else {
[INFO] [stderr] 210 |     println!("Server error. Code {:?}", res.status());
[INFO] [stderr] 211 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:233:16
[INFO] [stderr]     |
[INFO] [stderr] 233 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 234 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 235 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 236 | |             } else {
[INFO] [stderr] 237 | |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr] 238 | |             }
[INFO] [stderr] 239 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 233 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 234 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 235 | } else {
[INFO] [stderr] 236 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr] 237 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:266:16
[INFO] [stderr]     |
[INFO] [stderr] 266 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 267 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 268 | |                 println!("That theme hasn't been published");
[INFO] [stderr] 269 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 284 | |             }
[INFO] [stderr] 285 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 266 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 267 |     println!("That theme hasn't been published");
[INFO] [stderr] 268 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 269 | } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 270 |     println!("Can't edit the metadata of a theme that isn't yours");
[INFO] [stderr] 271 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:301:16
[INFO] [stderr]     |
[INFO] [stderr] 301 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 302 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 303 | |                 println!("Can't unpublish a nonexistent theme");
[INFO] [stderr] 304 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 314 | |             }
[INFO] [stderr] 315 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 301 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 302 |     println!("Can't unpublish a nonexistent theme");
[INFO] [stderr] 303 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 304 | } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 305 |     println!("Can't unpublish a theme that isn't yours");
[INFO] [stderr] 306 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:424:16
[INFO] [stderr]     |
[INFO] [stderr] 424 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 425 | |             if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 426 | |                 println!("Theme has not been uploaded");
[INFO] [stderr] 427 | |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 431 | |             }
[INFO] [stderr] 432 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 424 |         } else if res.status() == reqwest::StatusCode::NOT_FOUND {
[INFO] [stderr] 425 |     println!("Theme has not been uploaded");
[INFO] [stderr] 426 |     Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr] 427 | } else {
[INFO] [stderr] 428 |     println!("Server error. Code {:?}", res.status());
[INFO] [stderr] 429 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:384:28
[INFO] [stderr]     |
[INFO] [stderr] 384 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 385 | |                         if !force {
[INFO] [stderr] 386 | |                             install_warning(false);
[INFO] [stderr] 387 | |                         }
[INFO] [stderr] 388 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 384 |                     } else if !force {
[INFO] [stderr] 385 |     install_warning(false);
[INFO] [stderr] 386 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:417:24
[INFO] [stderr]     |
[INFO] [stderr] 417 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 418 | |                     if !force {
[INFO] [stderr] 419 | |                         install_warning(false);
[INFO] [stderr] 420 | |                     }
[INFO] [stderr] 421 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 417 |                 } else if !force {
[INFO] [stderr] 418 |     install_warning(false);
[INFO] [stderr] 419 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/ravenserver.rs:448:16
[INFO] [stderr]     |
[INFO] [stderr] 448 |           } else {
[INFO] [stderr]     |  ________________^
[INFO] [stderr] 449 | |             if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 450 | |                 println!("Wrong login info. Try again!");
[INFO] [stderr] 451 | |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] ...   |
[INFO] [stderr] 455 | |             }
[INFO] [stderr] 456 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 448 |         } else if res.status() == reqwest::StatusCode::FORBIDDEN {
[INFO] [stderr] 449 |     println!("Wrong login info. Try again!");
[INFO] [stderr] 450 |     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr] 451 | } else {
[INFO] [stderr] 452 |     println!("Server error. Code {:?}", res.status());
[INFO] [stderr] 453 |     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/themes.rs:66:9
[INFO] [stderr]    |
[INFO] [stderr] 66 |         return serde_json::to_string(self).unwrap();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `serde_json::to_string(self).unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         return String::from(home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from(home_dir().unwrap().to_str().unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ravenserver.rs:39:31
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Err(ErrorKind::Server(RavenServerErrorKind::NotLoggedIn.into()).into())
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::NotLoggedIn`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ravenserver.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             tname = tname + "/tmp/";
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tname += "/tmp/"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:131:39
[INFO] [stderr]     |
[INFO] [stderr] 131 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:134:39
[INFO] [stderr]     |
[INFO] [stderr] 134 |                 Err(ErrorKind::Server(RavenServerErrorKind::NotLoggedIn.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::NotLoggedIn`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:137:39
[INFO] [stderr]     |
[INFO] [stderr] 137 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(info.name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(info.name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:140:39
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:161:43
[INFO] [stderr]     |
[INFO] [stderr] 161 |                     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:166:47
[INFO] [stderr]     |
[INFO] [stderr] 166 |                         Err(ErrorKind::Server(RavenServerErrorKind::TooLarge.into()).into())
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::TooLarge`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:169:43
[INFO] [stderr]     |
[INFO] [stderr] 169 |                     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/ravenserver.rs:194:21
[INFO] [stderr]     |
[INFO] [stderr] 194 | /                     let mut up = false;
[INFO] [stderr] 195 | |                     if res.status() == reqwest::StatusCode::CREATED {
[INFO] [stderr] 196 | |                         println!("Theme successfully uploaded.");
[INFO] [stderr] 197 | |                         up = true;
[INFO] [stderr] 198 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> up = if res.status() == reqwest::StatusCode::CREATED { ..; true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:201:53
[INFO] [stderr]     |
[INFO] [stderr] 201 |                         pub_metadata(name.as_str(), "screen".into(), &theme_st.screenshot)?;
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"screen"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:209:47
[INFO] [stderr]     |
[INFO] [stderr] 209 |                         Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:212:47
[INFO] [stderr]     |
[INFO] [stderr] 212 |                         Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:235:39
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:237:39
[INFO] [stderr]     |
[INFO] [stderr] 237 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:269:39
[INFO] [stderr]     |
[INFO] [stderr] 269 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:272:39
[INFO] [stderr]     |
[INFO] [stderr] 272 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:275:39
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 Err(ErrorKind::Server(RavenServerErrorKind::PreConditionFailed("metadata type".to_string()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PreConditionFailed("metadata type".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:280:39
[INFO] [stderr]     |
[INFO] [stderr] 280 |                 Err(ErrorKind::Server(RavenServerErrorKind::TooLarge.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::TooLarge`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:283:39
[INFO] [stderr]     |
[INFO] [stderr] 283 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:304:39
[INFO] [stderr]     |
[INFO] [stderr] 304 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:307:39
[INFO] [stderr]     |
[INFO] [stderr] 307 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:310:39
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:313:39
[INFO] [stderr]     |
[INFO] [stderr] 313 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/ravenserver.rs:342:9
[INFO] [stderr]     |
[INFO] [stderr] 342 |         tname = tname + "/tmp/";
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tname += "/tmp/"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:427:39
[INFO] [stderr]     |
[INFO] [stderr] 427 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:430:39
[INFO] [stderr]     |
[INFO] [stderr] 430 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:451:39
[INFO] [stderr]     |
[INFO] [stderr] 451 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:454:39
[INFO] [stderr]     |
[INFO] [stderr] 454 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/themes.rs:129:17
[INFO] [stderr]     |
[INFO] [stderr] 129 |             let ref option = opt[len - i];
[INFO] [stderr]     |             ----^^^^^^^^^^---------------- help: try: `let option = &opt[len - i];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/themes.rs:188:39
[INFO] [stderr]     |
[INFO] [stderr] 188 |                     if line.ends_with(",") {
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/themes.rs:193:42
[INFO] [stderr]     |
[INFO] [stderr] 193 |                 } else if line.ends_with("}") && !patfound {
[INFO] [stderr]     |                                          ^^^ help: try using a char instead: `'}'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/themes.rs:591:12
[INFO] [stderr]     |
[INFO] [stderr] 591 |         if &new_themes.options[i] == &option {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 591 |         if new_themes.options[i] == option {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:142:25
[INFO] [stderr]     |
[INFO] [stderr] 142 |             .filter(|x| x.len() > 0)
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `error::Error`
[INFO] [stderr]   --> src/ravenserver.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     error::Error
[INFO] [stderr]    |     ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ravenserver.rs:39:31
[INFO] [stderr]    |
[INFO] [stderr] 39 |         Err(ErrorKind::Server(RavenServerErrorKind::NotLoggedIn.into()).into())
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::NotLoggedIn`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/ravenserver.rs:51:13
[INFO] [stderr]    |
[INFO] [stderr] 51 |             tname = tname + "/tmp/";
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tname += "/tmp/"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:131:39
[INFO] [stderr]     |
[INFO] [stderr] 131 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:134:39
[INFO] [stderr]     |
[INFO] [stderr] 134 |                 Err(ErrorKind::Server(RavenServerErrorKind::NotLoggedIn.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::NotLoggedIn`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:137:39
[INFO] [stderr]     |
[INFO] [stderr] 137 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(info.name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(info.name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:140:39
[INFO] [stderr]     |
[INFO] [stderr] 140 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:161:43
[INFO] [stderr]     |
[INFO] [stderr] 161 |                     Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:166:47
[INFO] [stderr]     |
[INFO] [stderr] 166 |                         Err(ErrorKind::Server(RavenServerErrorKind::TooLarge.into()).into())
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::TooLarge`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:169:43
[INFO] [stderr]     |
[INFO] [stderr] 169 |                     Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/ravenserver.rs:194:21
[INFO] [stderr]     |
[INFO] [stderr] 194 | /                     let mut up = false;
[INFO] [stderr] 195 | |                     if res.status() == reqwest::StatusCode::CREATED {
[INFO] [stderr] 196 | |                         println!("Theme successfully uploaded.");
[INFO] [stderr] 197 | |                         up = true;
[INFO] [stderr] 198 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> up = if res.status() == reqwest::StatusCode::CREATED { ..; true } else { false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:201:53
[INFO] [stderr]     |
[INFO] [stderr] 201 |                         pub_metadata(name.as_str(), "screen".into(), &theme_st.screenshot)?;
[INFO] [stderr]     |                                                     ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"screen"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:209:47
[INFO] [stderr]     |
[INFO] [stderr] 209 |                         Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:212:47
[INFO] [stderr]     |
[INFO] [stderr] 212 |                         Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:235:39
[INFO] [stderr]     |
[INFO] [stderr] 235 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:237:39
[INFO] [stderr]     |
[INFO] [stderr] 237 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:269:39
[INFO] [stderr]     |
[INFO] [stderr] 269 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:272:39
[INFO] [stderr]     |
[INFO] [stderr] 272 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:275:39
[INFO] [stderr]     |
[INFO] [stderr] 275 |                 Err(ErrorKind::Server(RavenServerErrorKind::PreConditionFailed("metadata type".to_string()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PreConditionFailed("metadata type".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:280:39
[INFO] [stderr]     |
[INFO] [stderr] 280 |                 Err(ErrorKind::Server(RavenServerErrorKind::TooLarge.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::TooLarge`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:283:39
[INFO] [stderr]     |
[INFO] [stderr] 283 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:304:39
[INFO] [stderr]     |
[INFO] [stderr] 304 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:307:39
[INFO] [stderr]     |
[INFO] [stderr] 307 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:310:39
[INFO] [stderr]     |
[INFO] [stderr] 310 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:313:39
[INFO] [stderr]     |
[INFO] [stderr] 313 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/ravenserver.rs:342:9
[INFO] [stderr]     |
[INFO] [stderr] 342 |         tname = tname + "/tmp/";
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tname += "/tmp/"`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:427:39
[INFO] [stderr]     |
[INFO] [stderr] 427 |                 Err(ErrorKind::Server(RavenServerErrorKind::DoesNotExist(name).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::DoesNotExist(name)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:430:39
[INFO] [stderr]     |
[INFO] [stderr] 430 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:451:39
[INFO] [stderr]     |
[INFO] [stderr] 451 |                 Err(ErrorKind::Server(RavenServerErrorKind::PermissionDenied.into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::PermissionDenied`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/ravenserver.rs:454:39
[INFO] [stderr]     |
[INFO] [stderr] 454 |                 Err(ErrorKind::Server(RavenServerErrorKind::ServerError(res.status()).into()).into())
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `RavenServerErrorKind::ServerError(res.status())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/themes.rs:129:17
[INFO] [stderr]     |
[INFO] [stderr] 129 |             let ref option = opt[len - i];
[INFO] [stderr]     |             ----^^^^^^^^^^---------------- help: try: `let option = &opt[len - i];`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/themes.rs:188:39
[INFO] [stderr]     |
[INFO] [stderr] 188 |                     if line.ends_with(",") {
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/themes.rs:193:42
[INFO] [stderr]     |
[INFO] [stderr] 193 |                 } else if line.ends_with("}") && !patfound {
[INFO] [stderr]     |                                          ^^^ help: try using a char instead: `'}'`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of both operands
[INFO] [stderr]    --> src/themes.rs:591:12
[INFO] [stderr]     |
[INFO] [stderr] 591 |         if &new_themes.options[i] == &option {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] help: use the values directly
[INFO] [stderr]     |
[INFO] [stderr] 591 |         if new_themes.options[i] == option {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^    ^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/lib.rs:142:25
[INFO] [stderr]     |
[INFO] [stderr] 142 |             .filter(|x| x.len() > 0)
[INFO] [stderr]     |                         ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 43.34s
[INFO] running `"docker" "inspect" "bc296b84960972836cea6d9e5f1f4a64e62dc7439f3af6c2ac6a21f64f322ed5"`
[INFO] running `"docker" "rm" "-f" "bc296b84960972836cea6d9e5f1f4a64e62dc7439f3af6c2ac6a21f64f322ed5"`
[INFO] [stdout] bc296b84960972836cea6d9e5f1f4a64e62dc7439f3af6c2ac6a21f64f322ed5