[INFO] crate ratsat 0.0.1 is already in cache
[INFO] extracting crate ratsat 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/ratsat/0.0.1
[INFO] extracting crate ratsat 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ratsat/0.0.1
[INFO] validating manifest of ratsat-0.0.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of ratsat-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing ratsat-0.0.1
[INFO] finished frobbing ratsat-0.0.1
[INFO] frobbed toml for ratsat-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/ratsat/0.0.1/Cargo.toml
[INFO] started frobbing ratsat-0.0.1
[INFO] finished frobbing ratsat-0.0.1
[INFO] frobbed toml for ratsat-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ratsat/0.0.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting ratsat-0.0.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ratsat/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 049a87c351adaa208a3796644056d1f7049d344f5aa23e53e21c356cf4efb89f
[INFO] running `"docker" "start" "-a" "049a87c351adaa208a3796644056d1f7049d344f5aa23e53e21c356cf4efb89f"`
[INFO] [stderr]     Checking ratsat v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/intmap.rs:247:13
[INFO] [stderr]     |
[INFO] [stderr] 247 |             comp: comp,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `comp`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/clause.rs:655:13
[INFO] [stderr]     |
[INFO] [stderr] 655 |             pred: pred,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `pred`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/core.rs:957:29
[INFO] [stderr]     |
[INFO] [stderr] 957 |                         let v = c[k].var();
[INFO] [stderr]     |                             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]     --> src/core.rs:1119:21
[INFO] [stderr]      |
[INFO] [stderr] 1119 |                 let w = Watcher::new(cr, first);
[INFO] [stderr]      |                     ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/intmap.rs:247:13
[INFO] [stderr]     |
[INFO] [stderr] 247 |             comp: comp,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `comp`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/clause.rs:655:13
[INFO] [stderr]     |
[INFO] [stderr] 655 |             pred: pred,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `pred`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/core.rs:957:29
[INFO] [stderr]     |
[INFO] [stderr] 957 |                         let v = c[k].var();
[INFO] [stderr]     |                             ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]     --> src/core.rs:1119:21
[INFO] [stderr]      |
[INFO] [stderr] 1119 |                 let w = Watcher::new(cr, first);
[INFO] [stderr]      |                     ^
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/clause.rs:202:18
[INFO] [stderr]     |
[INFO] [stderr] 202 |         let v = (0xF7F755F4_u32 >> sel) & 3;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: consider: `0xF7F7_55F4_u32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/clause.rs:223:18
[INFO] [stderr]     |
[INFO] [stderr] 223 |         let v = (0xFCFCF400_u32 >> sel) & 3;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: consider: `0xFCFC_F400_u32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1563:26
[INFO] [stderr]      |
[INFO] [stderr] 1563 |             random_seed: 91648253.0,
[INFO] [stderr]      |                          ^^^^^^^^^^ help: consider: `91_648_253.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/core.rs:1615:5
[INFO] [stderr]      |
[INFO] [stderr] 1615 |     return f64::powi(y, seq);
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f64::powi(y, seq)`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/core.rs:1623:5
[INFO] [stderr]      |
[INFO] [stderr] 1623 |     return *seed / 2147483647.0;
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*seed / 2147483647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1620:14
[INFO] [stderr]      |
[INFO] [stderr] 1620 |     *seed *= 1389796.0;
[INFO] [stderr]      |              ^^^^^^^^^ help: consider: `1_389_796.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1621:22
[INFO] [stderr]      |
[INFO] [stderr] 1621 |     let q = (*seed / 2147483647.0) as i32;
[INFO] [stderr]      |                      ^^^^^^^^^^^^ help: consider: `2_147_483_647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1622:25
[INFO] [stderr]      |
[INFO] [stderr] 1622 |     *seed -= q as f64 * 2147483647.0;
[INFO] [stderr]      |                         ^^^^^^^^^^^^ help: consider: `2_147_483_647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1623:20
[INFO] [stderr]      |
[INFO] [stderr] 1623 |     return *seed / 2147483647.0;
[INFO] [stderr]      |                    ^^^^^^^^^^^^ help: consider: `2_147_483_647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/clause.rs:202:18
[INFO] [stderr]     |
[INFO] [stderr] 202 |         let v = (0xF7F755F4_u32 >> sel) & 3;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: consider: `0xF7F7_55F4_u32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/clause.rs:223:18
[INFO] [stderr]     |
[INFO] [stderr] 223 |         let v = (0xFCFCF400_u32 >> sel) & 3;
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: consider: `0xFCFC_F400_u32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1563:26
[INFO] [stderr]      |
[INFO] [stderr] 1563 |             random_seed: 91648253.0,
[INFO] [stderr]      |                          ^^^^^^^^^^ help: consider: `91_648_253.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/core.rs:1615:5
[INFO] [stderr]      |
[INFO] [stderr] 1615 |     return f64::powi(y, seq);
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `f64::powi(y, seq)`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/core.rs:1623:5
[INFO] [stderr]      |
[INFO] [stderr] 1623 |     return *seed / 2147483647.0;
[INFO] [stderr]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `*seed / 2147483647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1620:14
[INFO] [stderr]      |
[INFO] [stderr] 1620 |     *seed *= 1389796.0;
[INFO] [stderr]      |              ^^^^^^^^^ help: consider: `1_389_796.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1621:22
[INFO] [stderr]      |
[INFO] [stderr] 1621 |     let q = (*seed / 2147483647.0) as i32;
[INFO] [stderr]      |                      ^^^^^^^^^^^^ help: consider: `2_147_483_647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1622:25
[INFO] [stderr]      |
[INFO] [stderr] 1622 |     *seed -= q as f64 * 2147483647.0;
[INFO] [stderr]      |                         ^^^^^^^^^^^^ help: consider: `2_147_483_647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]     --> src/core.rs:1623:20
[INFO] [stderr]      |
[INFO] [stderr] 1623 |     return *seed / 2147483647.0;
[INFO] [stderr]      |                    ^^^^^^^^^^^^ help: consider: `2_147_483_647.0`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: item `alloc::RegionAllocator<T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]   --> src/alloc.rs:32:1
[INFO] [stderr]    |
[INFO] [stderr] 32 | / impl<T: Copy + Default> RegionAllocator<T> {
[INFO] [stderr] 33 | |     pub fn new(start_cap: u32) -> Self {
[INFO] [stderr] 34 | |         Self {
[INFO] [stderr] 35 | |             vec: Vec::with_capacity(start_cap as usize),
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |     }
[INFO] [stderr] 60 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: item `intmap::IntSet<K>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/intmap.rs:181:1
[INFO] [stderr]     |
[INFO] [stderr] 181 | / impl<K: AsIndex> IntSet<K> {
[INFO] [stderr] 182 | |     pub fn new() -> Self {
[INFO] [stderr] 183 | |         Self::default()
[INFO] [stderr] 184 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 206 | |     }
[INFO] [stderr] 207 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:50:16
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn idx(&self) -> u32 {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:78:16
[INFO] [stderr]    |
[INFO] [stderr] 78 |     pub fn idx(&self) -> u32 {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:81:17
[INFO] [stderr]    |
[INFO] [stderr] 81 |     pub fn sign(&self) -> bool {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:84:16
[INFO] [stderr]    |
[INFO] [stderr] 84 |     pub fn var(&self) -> Var {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:166:18
[INFO] [stderr]     |
[INFO] [stderr] 166 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:472:17
[INFO] [stderr]     |
[INFO] [stderr] 472 |     pub fn mark(&self) -> u32 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:475:19
[INFO] [stderr]     |
[INFO] [stderr] 475 |     pub fn learnt(&self) -> bool {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:478:22
[INFO] [stderr]     |
[INFO] [stderr] 478 |     pub fn has_extra(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:481:20
[INFO] [stderr]     |
[INFO] [stderr] 481 |     pub fn reloced(&self) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:484:17
[INFO] [stderr]     |
[INFO] [stderr] 484 |     pub fn size(&self) -> u32 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `clause::ClauseAllocator` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/clause.rs:506:1
[INFO] [stderr]     |
[INFO] [stderr] 506 | / impl ClauseAllocator {
[INFO] [stderr] 507 | |     pub const UNIT_SIZE: u32 = 32;
[INFO] [stderr] 508 | |     pub fn with_start_cap(start_cap: u32) -> Self {
[INFO] [stderr] 509 | |         Self {
[INFO] [stderr] ...   |
[INFO] [stderr] 622 | |     }
[INFO] [stderr] 623 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `clause::ClauseAllocator`
[INFO] [stderr]    --> src/clause.rs:514:5
[INFO] [stderr]     |
[INFO] [stderr] 514 | /     pub fn new() -> Self {
[INFO] [stderr] 515 | |         Self::with_start_cap(1024 * 1024)
[INFO] [stderr] 516 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 506 | impl Default for clause::ClauseAllocator {
[INFO] [stderr] 507 |     fn default() -> Self {
[INFO] [stderr] 508 |         Self::new()
[INFO] [stderr] 509 |     }
[INFO] [stderr] 510 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `clause::OccListsData<K, V>`
[INFO] [stderr]    --> src/clause.rs:639:5
[INFO] [stderr]     |
[INFO] [stderr] 639 | /     pub fn new() -> Self {
[INFO] [stderr] 640 | |         Self {
[INFO] [stderr] 641 | |             occs: IntMap::new(),
[INFO] [stderr] 642 | |             dirty: IntMap::new(),
[INFO] [stderr] 643 | |             dirties: Vec::new(),
[INFO] [stderr] 644 | |         }
[INFO] [stderr] 645 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 632 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/dimacs.rs:37:36
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 return parse_error(format!("PARSE ERROR! Unexpected char: p"));
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"PARSE ERROR! Unexpected char: p".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/dimacs.rs:46:23
[INFO] [stderr]    |
[INFO] [stderr] 46 |           } else if let Some(_) = ch {
[INFO] [stderr]    |  ________________-      ^^^^^^^
[INFO] [stderr] 47 | |             read_clause(input, solver, &mut lits)?;
[INFO] [stderr] 48 | |             solver.add_clause_reuse(&mut lits);
[INFO] [stderr] 49 | |             num_read_clauses += 1;
[INFO] [stderr] 50 | |         } else {
[INFO] [stderr] 51 | |             break;
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________- help: try this: `if ch.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/dimacs.rs:55:28
[INFO] [stderr]    |
[INFO] [stderr] 55 |           return parse_error(format!(
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 56 | |             "PARSE ERROR! DIMACS header mismatch: wrong number of clauses"
[INFO] [stderr] 57 | |         ));
[INFO] [stderr]    | |_________^ help: consider using .to_string(): `"PARSE ERROR! DIMACS header mismatch: wrong number of clauses".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/dimacs.rs:95:28
[INFO] [stderr]    |
[INFO] [stderr] 95 |         return parse_error(format!("PARSE ERROR! Unexpected EOF"));
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"PARSE ERROR! Unexpected EOF".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/dimacs.rs:103:26
[INFO] [stderr]     |
[INFO] [stderr] 103 |         val = val * 10 + (ch - b'0') as i32;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ch - b'0')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/dimacs.rs:137:8
[INFO] [stderr]     |
[INFO] [stderr] 137 |     Ok(input.fill_buf()?.first().map(|&ch| ch))
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `input.fill_buf()?.first().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/core.rs:471:12
[INFO] [stderr]     |
[INFO] [stderr] 471 |         if clause.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `clause.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:609:62
[INFO] [stderr]     |
[INFO] [stderr] 609 |                             self.v.learnts_literals as f64 / self.num_learnts() as f64,
[INFO] [stderr]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_learnts())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:628:48
[INFO] [stderr]     |
[INFO] [stderr] 628 |                 if self.learnts.len() as f64 - self.v.num_assigns() as f64 >= self.max_learnts {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.v.num_assigns())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:680:28
[INFO] [stderr]     |
[INFO] [stderr] 680 |         self.max_learnts = self.num_clauses() as f64 * self.learntsize_factor;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_clauses())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:681:31
[INFO] [stderr]     |
[INFO] [stderr] 681 |         if self.max_learnts < self.min_learnts_lim as f64 {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.min_learnts_lim)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:682:32
[INFO] [stderr]     |
[INFO] [stderr] 682 |             self.max_learnts = self.min_learnts_lim as f64;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.min_learnts_lim)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:685:40
[INFO] [stderr]     |
[INFO] [stderr] 685 |         self.learntsize_adjust_confl = self.learntsize_adjust_start_confl as f64;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.learntsize_adjust_start_confl)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:712:44
[INFO] [stderr]     |
[INFO] [stderr] 712 |             let nof_clauses = (rest_base * self.restart_first as f64) as i32;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.restart_first)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:764:55
[INFO] [stderr]     |
[INFO] [stderr] 764 |                     && (i < self.learnts.len() / 2 || (c.activity() as f64) < extra_lim)
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.activity())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:841:40
[INFO] [stderr]     |
[INFO] [stderr] 841 |             self.v.learnts_literals += size as u64;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try: `u64::from(size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:844:40
[INFO] [stderr]     |
[INFO] [stderr] 844 |             self.v.clauses_literals += size as u64;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try: `u64::from(size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/core.rs:951:17
[INFO] [stderr]     |
[INFO] [stderr] 951 | /                 let mut retain = true;
[INFO] [stderr] 952 | |                 if reason == CRef::UNDEF {
[INFO] [stderr] 953 | |                     retain = true;
[INFO] [stderr] 954 | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 962 | |                     }
[INFO] [stderr] 963 | |                 }
[INFO] [stderr]     | |_________________^ help: it is more idiomatic to write: `let <mut> retain = if reason == CRef::UNDEF { true } else { ..; true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is only used to index `c`.
[INFO] [stderr]    --> src/core.rs:956:30
[INFO] [stderr]     |
[INFO] [stderr] 956 |                     for k in 1..c.size() {
[INFO] [stderr]     |                              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 956 |                     for <item> in c.iter().take(c.size()).skip(1) {
[INFO] [stderr]     |                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `out_learnt` manually
[INFO] [stderr]    --> src/core.rs:994:13
[INFO] [stderr]     |
[INFO] [stderr] 994 | /             let p = out_learnt[max_i];
[INFO] [stderr] 995 | |             out_learnt[max_i] = out_learnt[1];
[INFO] [stderr] 996 | |             out_learnt[1] = p;
[INFO] [stderr]     | |_____________________________^ help: try: `out_learnt.swap(max_i, 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `out_learnt`
[INFO] [stderr]    --> src/core.rs:986:22
[INFO] [stderr]     |
[INFO] [stderr] 986 |             for i in 2..out_learnt.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 986 |             for (i, <item>) in out_learnt.iter().enumerate().skip(2) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]     --> src/core.rs:1056:20
[INFO] [stderr]      |
[INFO] [stderr] 1056 |                 if stack.len() == 0 {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1163:30
[INFO] [stderr]      |
[INFO] [stderr] 1163 |         self.propagations += num_props as u64;
[INFO] [stderr]      |                              ^^^^^^^^^^^^^^^^ help: try: `u64::from(num_props)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1164:31
[INFO] [stderr]      |
[INFO] [stderr] 1164 |         self.simp_db_props -= num_props as i64;
[INFO] [stderr]      |                               ^^^^^^^^^^^^^^^^ help: try: `i64::from(num_props)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1170:12
[INFO] [stderr]      |
[INFO] [stderr] 1170 |         if self.ca.wasted() as f64 > self.ca.len() as f64 * self.garbage_frac {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ca.wasted())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1170:38
[INFO] [stderr]      |
[INFO] [stderr] 1170 |         if self.ca.wasted() as f64 > self.ca.len() as f64 * self.garbage_frac {
[INFO] [stderr]      |                                      ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ca.len())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: item `alloc::RegionAllocator<T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]   --> src/alloc.rs:32:1
[INFO] [stderr]    |
[INFO] [stderr] 32 | / impl<T: Copy + Default> RegionAllocator<T> {
[INFO] [stderr] 33 | |     pub fn new(start_cap: u32) -> Self {
[INFO] [stderr] 34 | |         Self {
[INFO] [stderr] 35 | |             vec: Vec::with_capacity(start_cap as usize),
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |     }
[INFO] [stderr] 60 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1193:23
[INFO] [stderr]      |
[INFO] [stderr] 1193 |         let f = 1.0 / self.num_vars() as f64;
[INFO] [stderr]      |                       ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_vars())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]     --> src/core.rs:1195:18
[INFO] [stderr]      |
[INFO] [stderr] 1195 |         for i in 0..self.v.decision_level() + 1 {
[INFO] [stderr]      |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.v.decision_level()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1206:50
[INFO] [stderr]      |
[INFO] [stderr] 1206 |             progress += f64::powi(f, i as i32) * (end - beg) as f64;
[INFO] [stderr]      |                                                  ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end - beg)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1209:20
[INFO] [stderr]      |
[INFO] [stderr] 1209 |         progress / self.num_vars() as f64
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_vars())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/core.rs:1270:20
[INFO] [stderr]      |
[INFO] [stderr] 1270 |                 if !is_removed!(self.ca, cr) {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `$ca.get_ref($cr).mark() != 1`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/core.rs:1293:20
[INFO] [stderr]      |
[INFO] [stderr] 1293 |                 if !is_removed!(self.ca, cr) {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `$ca.get_ref($cr).mark() != 1`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: item `intmap::IntSet<K>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/intmap.rs:181:1
[INFO] [stderr]     |
[INFO] [stderr] 181 | / impl<K: AsIndex> IntSet<K> {
[INFO] [stderr] 182 | |     pub fn new() -> Self {
[INFO] [stderr] 183 | |         Self::default()
[INFO] [stderr] 184 | |     }
[INFO] [stderr] ...   |
[INFO] [stderr] 206 | |     }
[INFO] [stderr] 207 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1381:38
[INFO] [stderr]      |
[INFO] [stderr] 1381 |             self.learnts_literals -= csize as u64;
[INFO] [stderr]      |                                      ^^^^^^^^^^^^ help: try: `u64::from(csize)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1384:38
[INFO] [stderr]      |
[INFO] [stderr] 1384 |             self.clauses_literals -= csize as u64;
[INFO] [stderr]      |                                      ^^^^^^^^^^^^ help: try: `u64::from(csize)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:50:16
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn idx(&self) -> u32 {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]     --> src/core.rs:1537:16
[INFO] [stderr]      |
[INFO] [stderr] 1537 |     fn is_seen(&self) -> bool {
[INFO] [stderr]      |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:78:16
[INFO] [stderr]    |
[INFO] [stderr] 78 |     pub fn idx(&self) -> u32 {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:81:17
[INFO] [stderr]    |
[INFO] [stderr] 81 |     pub fn sign(&self) -> bool {
[INFO] [stderr]    |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/clause.rs:84:16
[INFO] [stderr]    |
[INFO] [stderr] 84 |     pub fn var(&self) -> Var {
[INFO] [stderr]    |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]     --> src/core.rs:1612:9
[INFO] [stderr]      |
[INFO] [stderr] 1612 |         x = x % size;
[INFO] [stderr]      |         ^^^^^^^^^^^^ help: replace it with: `x %= size`
[INFO] [stderr] 
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1622:14
[INFO] [stderr]      |
[INFO] [stderr] 1622 |     *seed -= q as f64 * 2147483647.0;
[INFO] [stderr]      |              ^^^^^^^^ help: try: `f64::from(q)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1628:20
[INFO] [stderr]      |
[INFO] [stderr] 1628 |     (drand(seed) * size as f64) as i32
[INFO] [stderr]      |                    ^^^^^^^^^^^ help: try: `f64::from(size)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:166:18
[INFO] [stderr]     |
[INFO] [stderr] 166 |     pub fn to_u8(&self) -> u8 {
[INFO] [stderr]     |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:472:17
[INFO] [stderr]     |
[INFO] [stderr] 472 |     pub fn mark(&self) -> u32 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:475:19
[INFO] [stderr]     |
[INFO] [stderr] 475 |     pub fn learnt(&self) -> bool {
[INFO] [stderr]     |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:478:22
[INFO] [stderr]     |
[INFO] [stderr] 478 |     pub fn has_extra(&self) -> bool {
[INFO] [stderr]     |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:481:20
[INFO] [stderr]     |
[INFO] [stderr] 481 |     pub fn reloced(&self) -> bool {
[INFO] [stderr]     |                    ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/clause.rs:484:17
[INFO] [stderr]     |
[INFO] [stderr] 484 |     pub fn size(&self) -> u32 {
[INFO] [stderr]     |                 ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: item `clause::ClauseAllocator` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/clause.rs:506:1
[INFO] [stderr]     |
[INFO] [stderr] 506 | / impl ClauseAllocator {
[INFO] [stderr] 507 | |     pub const UNIT_SIZE: u32 = 32;
[INFO] [stderr] 508 | |     pub fn with_start_cap(start_cap: u32) -> Self {
[INFO] [stderr] 509 | |         Self {
[INFO] [stderr] ...   |
[INFO] [stderr] 622 | |     }
[INFO] [stderr] 623 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `clause::ClauseAllocator`
[INFO] [stderr]    --> src/clause.rs:514:5
[INFO] [stderr]     |
[INFO] [stderr] 514 | /     pub fn new() -> Self {
[INFO] [stderr] 515 | |         Self::with_start_cap(1024 * 1024)
[INFO] [stderr] 516 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 506 | impl Default for clause::ClauseAllocator {
[INFO] [stderr] 507 |     fn default() -> Self {
[INFO] [stderr] 508 |         Self::new()
[INFO] [stderr] 509 |     }
[INFO] [stderr] 510 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `clause::OccListsData<K, V>`
[INFO] [stderr]    --> src/clause.rs:639:5
[INFO] [stderr]     |
[INFO] [stderr] 639 | /     pub fn new() -> Self {
[INFO] [stderr] 640 | |         Self {
[INFO] [stderr] 641 | |             occs: IntMap::new(),
[INFO] [stderr] 642 | |             dirty: IntMap::new(),
[INFO] [stderr] 643 | |             dirties: Vec::new(),
[INFO] [stderr] 644 | |         }
[INFO] [stderr] 645 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 632 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/dimacs.rs:37:36
[INFO] [stderr]    |
[INFO] [stderr] 37 |                 return parse_error(format!("PARSE ERROR! Unexpected char: p"));
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"PARSE ERROR! Unexpected char: p".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/dimacs.rs:46:23
[INFO] [stderr]    |
[INFO] [stderr] 46 |           } else if let Some(_) = ch {
[INFO] [stderr]    |  ________________-      ^^^^^^^
[INFO] [stderr] 47 | |             read_clause(input, solver, &mut lits)?;
[INFO] [stderr] 48 | |             solver.add_clause_reuse(&mut lits);
[INFO] [stderr] 49 | |             num_read_clauses += 1;
[INFO] [stderr] 50 | |         } else {
[INFO] [stderr] 51 | |             break;
[INFO] [stderr] 52 | |         }
[INFO] [stderr]    | |_________- help: try this: `if ch.is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/dimacs.rs:55:28
[INFO] [stderr]    |
[INFO] [stderr] 55 |           return parse_error(format!(
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 56 | |             "PARSE ERROR! DIMACS header mismatch: wrong number of clauses"
[INFO] [stderr] 57 | |         ));
[INFO] [stderr]    | |_________^ help: consider using .to_string(): `"PARSE ERROR! DIMACS header mismatch: wrong number of clauses".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/dimacs.rs:95:28
[INFO] [stderr]    |
[INFO] [stderr] 95 |         return parse_error(format!("PARSE ERROR! Unexpected EOF"));
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"PARSE ERROR! Unexpected EOF".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]    --> src/dimacs.rs:103:26
[INFO] [stderr]     |
[INFO] [stderr] 103 |         val = val * 10 + (ch - b'0') as i32;
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ch - b'0')`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/dimacs.rs:137:8
[INFO] [stderr]     |
[INFO] [stderr] 137 |     Ok(input.fill_buf()?.first().map(|&ch| ch))
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `input.fill_buf()?.first().cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/core.rs:471:12
[INFO] [stderr]     |
[INFO] [stderr] 471 |         if clause.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `clause.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:609:62
[INFO] [stderr]     |
[INFO] [stderr] 609 |                             self.v.learnts_literals as f64 / self.num_learnts() as f64,
[INFO] [stderr]     |                                                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_learnts())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:628:48
[INFO] [stderr]     |
[INFO] [stderr] 628 |                 if self.learnts.len() as f64 - self.v.num_assigns() as f64 >= self.max_learnts {
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.v.num_assigns())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:680:28
[INFO] [stderr]     |
[INFO] [stderr] 680 |         self.max_learnts = self.num_clauses() as f64 * self.learntsize_factor;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_clauses())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:681:31
[INFO] [stderr]     |
[INFO] [stderr] 681 |         if self.max_learnts < self.min_learnts_lim as f64 {
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.min_learnts_lim)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:682:32
[INFO] [stderr]     |
[INFO] [stderr] 682 |             self.max_learnts = self.min_learnts_lim as f64;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.min_learnts_lim)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:685:40
[INFO] [stderr]     |
[INFO] [stderr] 685 |         self.learntsize_adjust_confl = self.learntsize_adjust_start_confl as f64;
[INFO] [stderr]     |                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.learntsize_adjust_start_confl)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:712:44
[INFO] [stderr]     |
[INFO] [stderr] 712 |             let nof_clauses = (rest_base * self.restart_first as f64) as i32;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.restart_first)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:764:55
[INFO] [stderr]     |
[INFO] [stderr] 764 |                     && (i < self.learnts.len() / 2 || (c.activity() as f64) < extra_lim)
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(c.activity())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:841:40
[INFO] [stderr]     |
[INFO] [stderr] 841 |             self.v.learnts_literals += size as u64;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try: `u64::from(size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/core.rs:844:40
[INFO] [stderr]     |
[INFO] [stderr] 844 |             self.v.clauses_literals += size as u64;
[INFO] [stderr]     |                                        ^^^^^^^^^^^ help: try: `u64::from(size)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/core.rs:951:17
[INFO] [stderr]     |
[INFO] [stderr] 951 | /                 let mut retain = true;
[INFO] [stderr] 952 | |                 if reason == CRef::UNDEF {
[INFO] [stderr] 953 | |                     retain = true;
[INFO] [stderr] 954 | |                 } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 962 | |                     }
[INFO] [stderr] 963 | |                 }
[INFO] [stderr]     | |_________________^ help: it is more idiomatic to write: `let <mut> retain = if reason == CRef::UNDEF { true } else { ..; true };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is only used to index `c`.
[INFO] [stderr]    --> src/core.rs:956:30
[INFO] [stderr]     |
[INFO] [stderr] 956 |                     for k in 1..c.size() {
[INFO] [stderr]     |                              ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 956 |                     for <item> in c.iter().take(c.size()).skip(1) {
[INFO] [stderr]     |                         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `out_learnt` manually
[INFO] [stderr]    --> src/core.rs:994:13
[INFO] [stderr]     |
[INFO] [stderr] 994 | /             let p = out_learnt[max_i];
[INFO] [stderr] 995 | |             out_learnt[max_i] = out_learnt[1];
[INFO] [stderr] 996 | |             out_learnt[1] = p;
[INFO] [stderr]     | |_____________________________^ help: try: `out_learnt.swap(max_i, 1)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `out_learnt`
[INFO] [stderr]    --> src/core.rs:986:22
[INFO] [stderr]     |
[INFO] [stderr] 986 |             for i in 2..out_learnt.len() {
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 986 |             for (i, <item>) in out_learnt.iter().enumerate().skip(2) {
[INFO] [stderr]     |                 ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]     --> src/core.rs:1056:20
[INFO] [stderr]      |
[INFO] [stderr] 1056 |                 if stack.len() == 0 {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `stack.is_empty()`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1163:30
[INFO] [stderr]      |
[INFO] [stderr] 1163 |         self.propagations += num_props as u64;
[INFO] [stderr]      |                              ^^^^^^^^^^^^^^^^ help: try: `u64::from(num_props)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1164:31
[INFO] [stderr]      |
[INFO] [stderr] 1164 |         self.simp_db_props -= num_props as i64;
[INFO] [stderr]      |                               ^^^^^^^^^^^^^^^^ help: try: `i64::from(num_props)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1170:12
[INFO] [stderr]      |
[INFO] [stderr] 1170 |         if self.ca.wasted() as f64 > self.ca.len() as f64 * self.garbage_frac {
[INFO] [stderr]      |            ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ca.wasted())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1170:38
[INFO] [stderr]      |
[INFO] [stderr] 1170 |         if self.ca.wasted() as f64 > self.ca.len() as f64 * self.garbage_frac {
[INFO] [stderr]      |                                      ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.ca.len())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1193:23
[INFO] [stderr]      |
[INFO] [stderr] 1193 |         let f = 1.0 / self.num_vars() as f64;
[INFO] [stderr]      |                       ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_vars())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]     --> src/core.rs:1195:18
[INFO] [stderr]      |
[INFO] [stderr] 1195 |         for i in 0..self.v.decision_level() + 1 {
[INFO] [stderr]      |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=self.v.decision_level()`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1206:50
[INFO] [stderr]      |
[INFO] [stderr] 1206 |             progress += f64::powi(f, i as i32) * (end - beg) as f64;
[INFO] [stderr]      |                                                  ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(end - beg)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1209:20
[INFO] [stderr]      |
[INFO] [stderr] 1209 |         progress / self.num_vars() as f64
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.num_vars())`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/core.rs:1270:20
[INFO] [stderr]      |
[INFO] [stderr] 1270 |                 if !is_removed!(self.ca, cr) {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `$ca.get_ref($cr).mark() != 1`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]     --> src/core.rs:1293:20
[INFO] [stderr]      |
[INFO] [stderr] 1293 |                 if !is_removed!(self.ca, cr) {
[INFO] [stderr]      |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `$ca.get_ref($cr).mark() != 1`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1381:38
[INFO] [stderr]      |
[INFO] [stderr] 1381 |             self.learnts_literals -= csize as u64;
[INFO] [stderr]      |                                      ^^^^^^^^^^^^ help: try: `u64::from(csize)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1384:38
[INFO] [stderr]      |
[INFO] [stderr] 1384 |             self.clauses_literals -= csize as u64;
[INFO] [stderr]      |                                      ^^^^^^^^^^^^ help: try: `u64::from(csize)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]     --> src/core.rs:1537:16
[INFO] [stderr]      |
[INFO] [stderr] 1537 |     fn is_seen(&self) -> bool {
[INFO] [stderr]      |                ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]     --> src/core.rs:1612:9
[INFO] [stderr]      |
[INFO] [stderr] 1612 |         x = x % size;
[INFO] [stderr]      |         ^^^^^^^^^^^^ help: replace it with: `x %= size`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1622:14
[INFO] [stderr]      |
[INFO] [stderr] 1622 |     *seed -= q as f64 * 2147483647.0;
[INFO] [stderr]      |              ^^^^^^^^ help: try: `f64::from(q)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]     --> src/core.rs:1628:20
[INFO] [stderr]      |
[INFO] [stderr] 1628 |     (drand(seed) * size as f64) as i32
[INFO] [stderr]      |                    ^^^^^^^^^^^ help: try: `f64::from(size)`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.21s
[INFO] running `"docker" "inspect" "049a87c351adaa208a3796644056d1f7049d344f5aa23e53e21c356cf4efb89f"`
[INFO] running `"docker" "rm" "-f" "049a87c351adaa208a3796644056d1f7049d344f5aa23e53e21c356cf4efb89f"`
[INFO] [stdout] 049a87c351adaa208a3796644056d1f7049d344f5aa23e53e21c356cf4efb89f