[INFO] crate rat 0.4.12 is already in cache [INFO] extracting crate rat 0.4.12 into work/ex/clippy-test-run/sources/stable/reg/rat/0.4.12 [INFO] extracting crate rat 0.4.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rat/0.4.12 [INFO] validating manifest of rat-0.4.12 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rat-0.4.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rat-0.4.12 [INFO] finished frobbing rat-0.4.12 [INFO] frobbed toml for rat-0.4.12 written to work/ex/clippy-test-run/sources/stable/reg/rat/0.4.12/Cargo.toml [INFO] started frobbing rat-0.4.12 [INFO] finished frobbing rat-0.4.12 [INFO] frobbed toml for rat-0.4.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rat/0.4.12/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rat-0.4.12 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rat/0.4.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c24949bd61812c1d8fb58374c38c1b929c32f4e8bbd4853ae6a5d4c2187d05d [INFO] running `"docker" "start" "-a" "0c24949bd61812c1d8fb58374c38c1b929c32f4e8bbd4853ae6a5d4c2187d05d"` [INFO] [stderr] Checking buf-read-ext v0.2.1 [INFO] [stderr] Checking webbrowser v0.2.2 [INFO] [stderr] Checking toml v0.3.2 [INFO] [stderr] Compiling serde_codegen_internals v0.14.2 [INFO] [stderr] Checking base64 v0.4.2 [INFO] [stderr] Checking clicolors-control v0.3.2 [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling string_cache_codegen v0.4.2 [INFO] [stderr] Compiling mime_guess v1.8.6 [INFO] [stderr] Checking indicatif v0.3.3 [INFO] [stderr] Compiling serde_derive v0.9.15 [INFO] [stderr] Checking textnonce v0.6.4 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking mime_multipart v0.5.1 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking rat v0.4.12 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:24:62 [INFO] [stderr] | [INFO] [stderr] 24 | Cache { cache_dir: config.general.cache_dir.clone(), filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/auth.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | open_browser: open_browser, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `open_browser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | }.header(Authorization(Bearer { token: token })); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | CollectionsResult { collections: collections } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:151:38 [INFO] [stderr] | [INFO] [stderr] 151 | let params = Documents { documents: documents }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `documents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:152:46 [INFO] [stderr] | [INFO] [stderr] 152 | DeleteAction { action: "delete", params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:413:35 [INFO] [stderr] | [INFO] [stderr] 413 | let filter = Filter { filenames: filenames, tags: tags }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filenames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:413:57 [INFO] [stderr] | [INFO] [stderr] 413 | let filter = Filter { filenames: filenames, tags: tags }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:415:35 [INFO] [stderr] | [INFO] [stderr] 415 | let params = Params { query: query, filter: filter, named: named }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:415:49 [INFO] [stderr] | [INFO] [stderr] 415 | let params = Params { query: query, filter: filter, named: named }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:415:65 [INFO] [stderr] | [INFO] [stderr] 415 | let params = Params { query: query, filter: filter, named: named }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `named` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:417:40 [INFO] [stderr] | [INFO] [stderr] 417 | Search { action: "search", params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:532:39 [INFO] [stderr] | [INFO] [stderr] 532 | let document = Document { filename: filename, size: size, title: title, author: None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:532:59 [INFO] [stderr] | [INFO] [stderr] 532 | let document = Document { filename: filename, size: size, title: title, author: None }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:532:71 [INFO] [stderr] | [INFO] [stderr] 532 | let document = Document { filename: filename, size: size, title: title, author: None }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:533:37 [INFO] [stderr] | [INFO] [stderr] 533 | let actions = Actions { tags: tags, collections: collections }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:533:49 [INFO] [stderr] | [INFO] [stderr] 533 | let actions = Actions { tags: tags, collections: collections }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:534:39 [INFO] [stderr] | [INFO] [stderr] 534 | let metadata = Metadata { document: document, actions: Some(actions) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `document` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:535:32 [INFO] [stderr] | [INFO] [stderr] 535 | DocumentMetadata { metadata: metadata } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/modules/centerdevice/collections.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | let _ = write!(&mut tw, "* {}:\t'{}'\t[{}]\n", c.id, c.name, visibility); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/client.rs:352:29 [INFO] [stderr] | [INFO] [stderr] 352 | ActionRequest { action: action, item_id: item_id } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/client.rs:352:45 [INFO] [stderr] | [INFO] [stderr] 352 | ActionRequest { action: action, item_id: item_id } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | sort: sort, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sort` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | search: search, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:23 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:45 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:55 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `t_added` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/slack/client.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | open_browser: open_browser, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `open_browser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/oauth.rs:101:51 [INFO] [stderr] | [INFO] [stderr] 101 | self.map(|code| CodeWithBasicAuthScheme { code: code, grant_type: GrantType::AuthorizationCode }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/oauth.rs:171:45 [INFO] [stderr] | [INFO] [stderr] 171 | self.map(|code| CodeWithUrlScheme { code: code }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | ReadWithProgress { read: read, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:113:44 [INFO] [stderr] | [INFO] [stderr] 113 | ReadWithProgress { read: read, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:113:56 [INFO] [stderr] | [INFO] [stderr] 113 | ReadWithProgress { read: read, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `progress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | WriteWithProgress { write: write, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:137:47 [INFO] [stderr] | [INFO] [stderr] 137 | WriteWithProgress { write: write, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:137:59 [INFO] [stderr] | [INFO] [stderr] 137 | WriteWithProgress { write: write, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `progress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:24:62 [INFO] [stderr] | [INFO] [stderr] 24 | Cache { cache_dir: config.general.cache_dir.clone(), filename: filename } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/auth.rs:52:9 [INFO] [stderr] | [INFO] [stderr] 52 | open_browser: open_browser, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `open_browser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | }.header(Authorization(Bearer { token: token })); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | CollectionsResult { collections: collections } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:151:38 [INFO] [stderr] | [INFO] [stderr] 151 | let params = Documents { documents: documents }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `documents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:152:46 [INFO] [stderr] | [INFO] [stderr] 152 | DeleteAction { action: "delete", params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:413:35 [INFO] [stderr] | [INFO] [stderr] 413 | let filter = Filter { filenames: filenames, tags: tags }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filenames` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:413:57 [INFO] [stderr] | [INFO] [stderr] 413 | let filter = Filter { filenames: filenames, tags: tags }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:415:35 [INFO] [stderr] | [INFO] [stderr] 415 | let params = Params { query: query, filter: filter, named: named }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `query` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:415:49 [INFO] [stderr] | [INFO] [stderr] 415 | let params = Params { query: query, filter: filter, named: named }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:415:65 [INFO] [stderr] | [INFO] [stderr] 415 | let params = Params { query: query, filter: filter, named: named }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `named` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:417:40 [INFO] [stderr] | [INFO] [stderr] 417 | Search { action: "search", params: params } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `params` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:532:39 [INFO] [stderr] | [INFO] [stderr] 532 | let document = Document { filename: filename, size: size, title: title, author: None }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:532:59 [INFO] [stderr] | [INFO] [stderr] 532 | let document = Document { filename: filename, size: size, title: title, author: None }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:532:71 [INFO] [stderr] | [INFO] [stderr] 532 | let document = Document { filename: filename, size: size, title: title, author: None }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:533:37 [INFO] [stderr] | [INFO] [stderr] 533 | let actions = Actions { tags: tags, collections: collections }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:533:49 [INFO] [stderr] | [INFO] [stderr] 533 | let actions = Actions { tags: tags, collections: collections }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `collections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:534:39 [INFO] [stderr] | [INFO] [stderr] 534 | let metadata = Metadata { document: document, actions: Some(actions) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `document` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/centerdevice/client.rs:535:32 [INFO] [stderr] | [INFO] [stderr] 535 | DocumentMetadata { metadata: metadata } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/modules/centerdevice/collections.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | let _ = write!(&mut tw, "* {}:\t'{}'\t[{}]\n", c.id, c.name, visibility); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/client.rs:352:29 [INFO] [stderr] | [INFO] [stderr] 352 | ActionRequest { action: action, item_id: item_id } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/client.rs:352:45 [INFO] [stderr] | [INFO] [stderr] 352 | ActionRequest { action: action, item_id: item_id } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `item_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | sort: sort, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sort` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | search: search, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `search` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:23 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `title` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:45 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `url` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/pocket/list.rs:154:55 [INFO] [stderr] | [INFO] [stderr] 154 | HumanOutput { id: id, title: title, url: url, t_added: t_added } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `t_added` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/modules/slack/client.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | open_browser: open_browser, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `open_browser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/oauth.rs:101:51 [INFO] [stderr] | [INFO] [stderr] 101 | self.map(|code| CodeWithBasicAuthScheme { code: code, grant_type: GrantType::AuthorizationCode }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/net/oauth.rs:171:45 [INFO] [stderr] | [INFO] [stderr] 171 | self.map(|code| CodeWithUrlScheme { code: code }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:113:32 [INFO] [stderr] | [INFO] [stderr] 113 | ReadWithProgress { read: read, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `read` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:113:44 [INFO] [stderr] | [INFO] [stderr] 113 | ReadWithProgress { read: read, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:113:56 [INFO] [stderr] | [INFO] [stderr] 113 | ReadWithProgress { read: read, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `progress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | WriteWithProgress { write: write, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `write` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:137:47 [INFO] [stderr] | [INFO] [stderr] 137 | WriteWithProgress { write: write, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/utils.rs:137:59 [INFO] [stderr] | [INFO] [stderr] 137 | WriteWithProgress { write: write, size: size, progress: progress } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `progress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/mod.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "centerdevice"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/auth.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | pub const NAME: &'static str = "auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/collections.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NAME: &'static str = "collections"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/delete.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "delete"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/download.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const NAME: &'static str = "download"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/refresh_token.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "refresh_token"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/search.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "search"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/status.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "status"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/upload.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | pub const NAME: &'static str = "upload"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/mod.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "pocket"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | pub const NAME_ARCHIVE: &'static str = "archive"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | pub const NAME_READD: &'static str = "readd"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub const NAME_FAVORITE: &'static str = "favorite"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NAME_UNFAVORITE: &'static str = "unfavorite"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | pub const NAME_DELETE: &'static str = "delete"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/auth.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/list.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NAME: &'static str = "list"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/slack/mod.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "slack"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/slack/auth.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/stocks/mod.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | pub const NAME: &'static str = "stocks"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/mod.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "centerdevice"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/auth.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | pub const NAME: &'static str = "auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/collections.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NAME: &'static str = "collections"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/delete.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "delete"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/download.rs:11:18 [INFO] [stderr] | [INFO] [stderr] 11 | pub const NAME: &'static str = "download"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/refresh_token.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "refresh_token"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/search.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "search"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/status.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | pub const NAME: &'static str = "status"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/centerdevice/upload.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | pub const NAME: &'static str = "upload"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/mod.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "pocket"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:11:26 [INFO] [stderr] | [INFO] [stderr] 11 | pub const NAME_ARCHIVE: &'static str = "archive"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | pub const NAME_READD: &'static str = "readd"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:14:27 [INFO] [stderr] | [INFO] [stderr] 14 | pub const NAME_FAVORITE: &'static str = "favorite"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:15:29 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NAME_UNFAVORITE: &'static str = "unfavorite"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/actions.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | pub const NAME_DELETE: &'static str = "delete"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/auth.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/pocket/list.rs:15:18 [INFO] [stderr] | [INFO] [stderr] 15 | pub const NAME: &'static str = "list"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/slack/mod.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "slack"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/slack/auth.rs:6:18 [INFO] [stderr] | [INFO] [stderr] 6 | pub const NAME: &'static str = "auth"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/modules/stocks/mod.rs:14:18 [INFO] [stderr] | [INFO] [stderr] 14 | pub const NAME: &'static str = "stocks"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/modules/centerdevice/client.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | / pub fn upload_document ()>( [INFO] [stderr] 540 | | api_base_url: &str, [INFO] [stderr] 541 | | access_token: &str, [INFO] [stderr] 542 | | file: &Path, [INFO] [stderr] ... | [INFO] [stderr] 551 | | .chain_err(|| ErrorKind::HttpUploadCallFailed) [INFO] [stderr] 552 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/modules/centerdevice/client.rs:554:5 [INFO] [stderr] | [INFO] [stderr] 554 | / fn do_upload_document ()>( [INFO] [stderr] 555 | | api_base_url: &str, [INFO] [stderr] 556 | | access_token: &str, [INFO] [stderr] 557 | | file: &Path, [INFO] [stderr] ... | [INFO] [stderr] 592 | | Ok(response_body) [INFO] [stderr] 593 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/collections.rs:79:31 [INFO] [stderr] | [INFO] [stderr] 79 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/delete.rs:56:31 [INFO] [stderr] | [INFO] [stderr] 56 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/download.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/modules/centerdevice/refresh_token.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | info(format!("Refreshing access token")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Refreshing access token".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/refresh_token.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/search.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/status.rs:174:31 [INFO] [stderr] | [INFO] [stderr] 174 | fn output(json: &str, format: &OutputFormat, details: bool) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/centerdevice/upload.rs:115:68 [INFO] [stderr] | [INFO] [stderr] 115 | let mut cs: Vec<&str> = collections.unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/upload.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/pocket/actions.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/modules/pocket/actions.rs:114:73 [INFO] [stderr] | [INFO] [stderr] 114 | let successful: usize = result.action_results.iter().filter(|b| **b).collect::>().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/pocket/list.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | fn output(json: &str, format: &OutputFormat, human_output: &HumanOutput) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/stocks/mod.rs:71:48 [INFO] [stderr] | [INFO] [stderr] 71 | fn output(stock_prices: &[StockPrice], format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/modules/stocks/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | for ref sp in stock_prices { [INFO] [stderr] | ^^^^^^ ------------ help: try: `let sp = &stock_prices;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/modules/stocks/mod.rs:90:11 [INFO] [stderr] | [INFO] [stderr] 90 | msgln(format!("{}", out_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `out_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/modules/centerdevice/client.rs:539:5 [INFO] [stderr] | [INFO] [stderr] 539 | / pub fn upload_document ()>( [INFO] [stderr] 540 | | api_base_url: &str, [INFO] [stderr] 541 | | access_token: &str, [INFO] [stderr] 542 | | file: &Path, [INFO] [stderr] ... | [INFO] [stderr] 551 | | .chain_err(|| ErrorKind::HttpUploadCallFailed) [INFO] [stderr] 552 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/modules/centerdevice/client.rs:554:5 [INFO] [stderr] | [INFO] [stderr] 554 | / fn do_upload_document ()>( [INFO] [stderr] 555 | | api_base_url: &str, [INFO] [stderr] 556 | | access_token: &str, [INFO] [stderr] 557 | | file: &Path, [INFO] [stderr] ... | [INFO] [stderr] 592 | | Ok(response_body) [INFO] [stderr] 593 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/collections.rs:79:31 [INFO] [stderr] | [INFO] [stderr] 79 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/delete.rs:56:31 [INFO] [stderr] | [INFO] [stderr] 56 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/download.rs:75:31 [INFO] [stderr] | [INFO] [stderr] 75 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/modules/centerdevice/refresh_token.rs:34:10 [INFO] [stderr] | [INFO] [stderr] 34 | info(format!("Refreshing access token")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Refreshing access token".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/refresh_token.rs:46:31 [INFO] [stderr] | [INFO] [stderr] 46 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/search.rs:77:31 [INFO] [stderr] | [INFO] [stderr] 77 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/status.rs:174:31 [INFO] [stderr] | [INFO] [stderr] 174 | fn output(json: &str, format: &OutputFormat, details: bool) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/modules/centerdevice/upload.rs:115:68 [INFO] [stderr] | [INFO] [stderr] 115 | let mut cs: Vec<&str> = collections.unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/centerdevice/upload.rs:161:31 [INFO] [stderr] | [INFO] [stderr] 161 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/pocket/actions.rs:93:31 [INFO] [stderr] | [INFO] [stderr] 93 | fn output(json: &str, format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/modules/pocket/actions.rs:114:73 [INFO] [stderr] | [INFO] [stderr] 114 | let successful: usize = result.action_results.iter().filter(|b| **b).collect::>().len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/pocket/list.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | fn output(json: &str, format: &OutputFormat, human_output: &HumanOutput) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/modules/stocks/comdirect.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(db.price, 14.16f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/modules/stocks/comdirect.rs:143:9 [INFO] [stderr] | [INFO] [stderr] 143 | assert_eq!(db.price, 14.16f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/modules/stocks/comdirect.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | assert_eq!(db.price, 1396.47f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/modules/stocks/comdirect.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | assert_eq!(db.price, 1396.47f32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/modules/stocks/mod.rs:71:48 [INFO] [stderr] | [INFO] [stderr] 71 | fn output(stock_prices: &[StockPrice], format: &OutputFormat) -> Result<()> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `OutputFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/modules/stocks/mod.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | for ref sp in stock_prices { [INFO] [stderr] | ^^^^^^ ------------ help: try: `let sp = &stock_prices;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/modules/stocks/mod.rs:90:11 [INFO] [stderr] | [INFO] [stderr] 90 | msgln(format!("{}", out_str)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `out_str.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rat`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:48:49 [INFO] [stderr] | [INFO] [stderr] 48 | let default_config_path = format!("{}/.{}", env::home_dir().unwrap().display(), DEFAULT_CONFIG_FILE); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:48:49 [INFO] [stderr] | [INFO] [stderr] 48 | let default_config_path = format!("{}/.{}", env::home_dir().unwrap().display(), DEFAULT_CONFIG_FILE); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0c24949bd61812c1d8fb58374c38c1b929c32f4e8bbd4853ae6a5d4c2187d05d"` [INFO] running `"docker" "rm" "-f" "0c24949bd61812c1d8fb58374c38c1b929c32f4e8bbd4853ae6a5d4c2187d05d"` [INFO] [stdout] 0c24949bd61812c1d8fb58374c38c1b929c32f4e8bbd4853ae6a5d4c2187d05d