[INFO] crate rangetree 0.1.2 is already in cache [INFO] extracting crate rangetree 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/rangetree/0.1.2 [INFO] extracting crate rangetree 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rangetree/0.1.2 [INFO] validating manifest of rangetree-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rangetree-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rangetree-0.1.2 [INFO] finished frobbing rangetree-0.1.2 [INFO] frobbed toml for rangetree-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/rangetree/0.1.2/Cargo.toml [INFO] started frobbing rangetree-0.1.2 [INFO] finished frobbing rangetree-0.1.2 [INFO] frobbed toml for rangetree-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rangetree/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rangetree-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rangetree/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f831fc5b01f809b4b8593835ac1ba7759a4e6d1491c8a3ef62570a26225e2e0c [INFO] running `"docker" "start" "-a" "f831fc5b01f809b4b8593835ac1ba7759a4e6d1491c8a3ef62570a26225e2e0c"` [INFO] [stderr] Checking rangetree v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | chunk_size: chunk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mempool_elem.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | chunk_size: chunk_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chunk_size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:809:13 [INFO] [stderr] | [INFO] [stderr] 809 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:828:13 [INFO] [stderr] | [INFO] [stderr] 828 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:809:13 [INFO] [stderr] | [INFO] [stderr] 809 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:828:13 [INFO] [stderr] | [INFO] [stderr] 828 | range: range, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `range` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | return chunk.data.last_mut().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk.data.last_mut().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | return unsafe { &mut *elem }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { &mut *elem }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | return chunk.data.last_mut().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk.data.last_mut().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | return unsafe { &mut *elem }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { &mut *elem }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return self.next; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | / if !node.is_null() { [INFO] [stderr] 340 | | if unsafe { (*node).color } == RED { [INFO] [stderr] 341 | | return true; [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 339 | if !node.is_null() && unsafe { (*node).color } == RED { [INFO] [stderr] 340 | return true; [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:351:9 [INFO] [stderr] | [INFO] [stderr] 351 | / return if key1 == key2 { [INFO] [stderr] 352 | | 0 [INFO] [stderr] 353 | | } else { [INFO] [stderr] 354 | | if key1 < key2 { [INFO] [stderr] ... | [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 351 | if key1 == key2 { [INFO] [stderr] 352 | 0 [INFO] [stderr] 353 | } else { [INFO] [stderr] 354 | if key1 < key2 { [INFO] [stderr] 355 | -1 [INFO] [stderr] 356 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:353:16 [INFO] [stderr] | [INFO] [stderr] 353 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 354 | | if key1 < key2 { [INFO] [stderr] 355 | | -1 [INFO] [stderr] 356 | | } else { [INFO] [stderr] 357 | | 1 [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 353 | } else if key1 < key2 { [INFO] [stderr] 354 | -1 [INFO] [stderr] 355 | } else { [INFO] [stderr] 356 | 1 [INFO] [stderr] 357 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return right; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:383:9 [INFO] [stderr] | [INFO] [stderr] 383 | return left; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:470:9 [INFO] [stderr] | [INFO] [stderr] 470 | return root; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:486:13 [INFO] [stderr] | [INFO] [stderr] 486 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:506:13 [INFO] [stderr] | [INFO] [stderr] 506 | return (fixup_remove(node), node_free); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(fixup_remove(node), node_free)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:575:9 [INFO] [stderr] | [INFO] [stderr] 575 | return root; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:566:13 [INFO] [stderr] | [INFO] [stderr] 566 | return fixup_remove(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fixup_remove(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:524:17 [INFO] [stderr] | [INFO] [stderr] 524 | / if !(*node).left.is_null() { [INFO] [stderr] 525 | | if (!is_red((*node).left)) && [INFO] [stderr] 526 | | (!is_red((*(*node).left).left)) [INFO] [stderr] 527 | | { [INFO] [stderr] 528 | | node = move_red_to_left(node); [INFO] [stderr] 529 | | } [INFO] [stderr] 530 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 524 | if !(*node).left.is_null() && (!is_red((*node).left)) && [INFO] [stderr] 525 | (!is_red((*(*node).left).left)) { [INFO] [stderr] 526 | node = move_red_to_left(node); [INFO] [stderr] 527 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:615:9 [INFO] [stderr] | [INFO] [stderr] 615 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:591:17 [INFO] [stderr] | [INFO] [stderr] 591 | return n; // exact match [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:601:17 [INFO] [stderr] | [INFO] [stderr] 601 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:606:17 [INFO] [stderr] | [INFO] [stderr] 606 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:656:9 [INFO] [stderr] | [INFO] [stderr] 656 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:632:17 [INFO] [stderr] | [INFO] [stderr] 632 | return n; // exact match [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:685:9 [INFO] [stderr] | [INFO] [stderr] 685 | return is_balanced_recursive(root, black); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_balanced_recursive(root, black)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / return is_balanced_recursive(unsafe { (*node).left }, black) && [INFO] [stderr] 674 | | is_balanced_recursive(unsafe { (*node).right }, black); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 673 | is_balanced_recursive(unsafe { (*node).left }, black) && [INFO] [stderr] 674 | is_balanced_recursive(unsafe { (*node).right }, black) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:706:9 [INFO] [stderr] | [INFO] [stderr] 706 | return self.node_pool.alloc_elem_from(node_data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.node_pool.alloc_elem_from(node_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:850:13 [INFO] [stderr] | [INFO] [stderr] 850 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:861:13 [INFO] [stderr] | [INFO] [stderr] 861 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:899:9 [INFO] [stderr] | [INFO] [stderr] 899 | return (ptr::null_mut(), ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(ptr::null_mut(), ptr::null_mut())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:873:16 [INFO] [stderr] | [INFO] [stderr] 873 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 874 | | if USE_BTREE { [INFO] [stderr] 875 | | let node_next = rb::get_or_upper(self.root, &value); [INFO] [stderr] 876 | | if !node_next.is_null() { [INFO] [stderr] ... | [INFO] [stderr] 897 | | } [INFO] [stderr] 898 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 873 | } else if USE_BTREE { [INFO] [stderr] 874 | let node_next = rb::get_or_upper(self.root, &value); [INFO] [stderr] 875 | if !node_next.is_null() { [INFO] [stderr] 876 | let node_next = unsafe { &mut *node_next }; [INFO] [stderr] 877 | let node_prev = unsafe { &mut *(*node_next).prev }; [INFO] [stderr] 878 | if (&node_prev.range[1] < value) && [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:914:9 [INFO] [stderr] | [INFO] [stderr] 914 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:980:13 [INFO] [stderr] | [INFO] [stderr] 980 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:982:13 [INFO] [stderr] | [INFO] [stderr] 982 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1000:13 [INFO] [stderr] | [INFO] [stderr] 1000 | return Some(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1002:13 [INFO] [stderr] | [INFO] [stderr] 1002 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1017:9 [INFO] [stderr] | [INFO] [stderr] 1017 | return !node.is_null(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!node.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1027:9 [INFO] [stderr] | [INFO] [stderr] 1027 | / return (self.list.first == self.list.last) && [INFO] [stderr] 1028 | | (unsafe { self.range[0] == (*self.list.first).range[0] }) && [INFO] [stderr] 1029 | | (unsafe { self.range[1] == (*self.list.first).range[1] }); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1027 | (self.list.first == self.list.last) && [INFO] [stderr] 1028 | (unsafe { self.range[0] == (*self.list.first).range[0] }) && [INFO] [stderr] 1029 | (unsafe { self.range[1] == (*self.list.first).range[1] }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1036:9 [INFO] [stderr] | [INFO] [stderr] 1036 | return self.list.first.is_null(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.first.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1149:9 [INFO] [stderr] | [INFO] [stderr] 1149 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1176:9 [INFO] [stderr] | [INFO] [stderr] 1176 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | return chunk.data.last_mut().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk.data.last_mut().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | return unsafe { &mut *elem }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { &mut *elem }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | return chunk.data.last_mut().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunk.data.last_mut().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mempool_elem.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | return unsafe { &mut *elem }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `unsafe { &mut *elem }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | return self.next; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.next` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:344:9 [INFO] [stderr] | [INFO] [stderr] 344 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:339:9 [INFO] [stderr] | [INFO] [stderr] 339 | / if !node.is_null() { [INFO] [stderr] 340 | | if unsafe { (*node).color } == RED { [INFO] [stderr] 341 | | return true; [INFO] [stderr] 342 | | } [INFO] [stderr] 343 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 339 | if !node.is_null() && unsafe { (*node).color } == RED { [INFO] [stderr] 340 | return true; [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:351:9 [INFO] [stderr] | [INFO] [stderr] 351 | / return if key1 == key2 { [INFO] [stderr] 352 | | 0 [INFO] [stderr] 353 | | } else { [INFO] [stderr] 354 | | if key1 < key2 { [INFO] [stderr] ... | [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 351 | if key1 == key2 { [INFO] [stderr] 352 | 0 [INFO] [stderr] 353 | } else { [INFO] [stderr] 354 | if key1 < key2 { [INFO] [stderr] 355 | -1 [INFO] [stderr] 356 | } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:353:16 [INFO] [stderr] | [INFO] [stderr] 353 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 354 | | if key1 < key2 { [INFO] [stderr] 355 | | -1 [INFO] [stderr] 356 | | } else { [INFO] [stderr] 357 | | 1 [INFO] [stderr] 358 | | } [INFO] [stderr] 359 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 353 | } else if key1 < key2 { [INFO] [stderr] 354 | -1 [INFO] [stderr] 355 | } else { [INFO] [stderr] 356 | 1 [INFO] [stderr] 357 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:371:9 [INFO] [stderr] | [INFO] [stderr] 371 | return right; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `right` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:383:9 [INFO] [stderr] | [INFO] [stderr] 383 | return left; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:410:9 [INFO] [stderr] | [INFO] [stderr] 410 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:423:9 [INFO] [stderr] | [INFO] [stderr] 423 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:470:9 [INFO] [stderr] | [INFO] [stderr] 470 | return root; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:462:13 [INFO] [stderr] | [INFO] [stderr] 462 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:486:13 [INFO] [stderr] | [INFO] [stderr] 486 | return node; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:506:13 [INFO] [stderr] | [INFO] [stderr] 506 | return (fixup_remove(node), node_free); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(fixup_remove(node), node_free)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:575:9 [INFO] [stderr] | [INFO] [stderr] 575 | return root; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:566:13 [INFO] [stderr] | [INFO] [stderr] 566 | return fixup_remove(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fixup_remove(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/lib.rs:524:17 [INFO] [stderr] | [INFO] [stderr] 524 | / if !(*node).left.is_null() { [INFO] [stderr] 525 | | if (!is_red((*node).left)) && [INFO] [stderr] 526 | | (!is_red((*(*node).left).left)) [INFO] [stderr] 527 | | { [INFO] [stderr] 528 | | node = move_red_to_left(node); [INFO] [stderr] 529 | | } [INFO] [stderr] 530 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 524 | if !(*node).left.is_null() && (!is_red((*node).left)) && [INFO] [stderr] 525 | (!is_red((*(*node).left).left)) { [INFO] [stderr] 526 | node = move_red_to_left(node); [INFO] [stderr] 527 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:615:9 [INFO] [stderr] | [INFO] [stderr] 615 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:591:17 [INFO] [stderr] | [INFO] [stderr] 591 | return n; // exact match [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:601:17 [INFO] [stderr] | [INFO] [stderr] 601 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:606:17 [INFO] [stderr] | [INFO] [stderr] 606 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:656:9 [INFO] [stderr] | [INFO] [stderr] 656 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:632:17 [INFO] [stderr] | [INFO] [stderr] 632 | return n; // exact match [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | return n; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:647:17 [INFO] [stderr] | [INFO] [stderr] 647 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:685:9 [INFO] [stderr] | [INFO] [stderr] 685 | return is_balanced_recursive(root, black); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_balanced_recursive(root, black)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:673:13 [INFO] [stderr] | [INFO] [stderr] 673 | / return is_balanced_recursive(unsafe { (*node).left }, black) && [INFO] [stderr] 674 | | is_balanced_recursive(unsafe { (*node).right }, black); [INFO] [stderr] | |__________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 673 | is_balanced_recursive(unsafe { (*node).left }, black) && [INFO] [stderr] 674 | is_balanced_recursive(unsafe { (*node).right }, black) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:706:9 [INFO] [stderr] | [INFO] [stderr] 706 | return self.node_pool.alloc_elem_from(node_data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.node_pool.alloc_elem_from(node_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:850:13 [INFO] [stderr] | [INFO] [stderr] 850 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:861:13 [INFO] [stderr] | [INFO] [stderr] 861 | return ptr::null_mut(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ptr::null_mut()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:899:9 [INFO] [stderr] | [INFO] [stderr] 899 | return (ptr::null_mut(), ptr::null_mut()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(ptr::null_mut(), ptr::null_mut())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:873:16 [INFO] [stderr] | [INFO] [stderr] 873 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 874 | | if USE_BTREE { [INFO] [stderr] 875 | | let node_next = rb::get_or_upper(self.root, &value); [INFO] [stderr] 876 | | if !node_next.is_null() { [INFO] [stderr] ... | [INFO] [stderr] 897 | | } [INFO] [stderr] 898 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 873 | } else if USE_BTREE { [INFO] [stderr] 874 | let node_next = rb::get_or_upper(self.root, &value); [INFO] [stderr] 875 | if !node_next.is_null() { [INFO] [stderr] 876 | let node_next = unsafe { &mut *node_next }; [INFO] [stderr] 877 | let node_prev = unsafe { &mut *(*node_next).prev }; [INFO] [stderr] 878 | if (&node_prev.range[1] < value) && [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:914:9 [INFO] [stderr] | [INFO] [stderr] 914 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:980:13 [INFO] [stderr] | [INFO] [stderr] 980 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:982:13 [INFO] [stderr] | [INFO] [stderr] 982 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1000:13 [INFO] [stderr] | [INFO] [stderr] 1000 | return Some(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1002:13 [INFO] [stderr] | [INFO] [stderr] 1002 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1017:9 [INFO] [stderr] | [INFO] [stderr] 1017 | return !node.is_null(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!node.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1027:9 [INFO] [stderr] | [INFO] [stderr] 1027 | / return (self.list.first == self.list.last) && [INFO] [stderr] 1028 | | (unsafe { self.range[0] == (*self.list.first).range[0] }) && [INFO] [stderr] 1029 | | (unsafe { self.range[1] == (*self.list.first).range[1] }); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 1027 | (self.list.first == self.list.last) && [INFO] [stderr] 1028 | (unsafe { self.range[0] == (*self.list.first).range[0] }) && [INFO] [stderr] 1029 | (unsafe { self.range[1] == (*self.list.first).range[1] }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1036:9 [INFO] [stderr] | [INFO] [stderr] 1036 | return self.list.first.is_null(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.list.first.is_null()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1149:9 [INFO] [stderr] | [INFO] [stderr] 1149 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1176:9 [INFO] [stderr] | [INFO] [stderr] 1176 | return ret; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/tests_rangetree.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | assert!(r.has((i * 2)) == false); [INFO] [stderr] | ^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/tests_rangetree.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | assert!(r.has((i * 2)) == false); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tests_mempool.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return self.link; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:593:31 [INFO] [stderr] | [INFO] [stderr] 593 | debug_assert!(key!(*n) <= &key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 333 | $body.range[0] [INFO] [stderr] 334 | } [INFO] [stderr] 335 | } [INFO] [stderr] 336 | [INFO] [stderr] 337 | fn is_red(node: *mut Node) -> bool [INFO] [stderr] 338 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:634:31 [INFO] [stderr] | [INFO] [stderr] 634 | debug_assert!(key!(*n) >= &key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 333 | $body.range[0] [INFO] [stderr] 334 | } [INFO] [stderr] 335 | } [INFO] [stderr] 336 | [INFO] [stderr] 337 | fn is_red(node: *mut Node) -> bool [INFO] [stderr] 338 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:844:20 [INFO] [stderr] | [INFO] [stderr] 844 | if (value >= &node.range[0]) && [INFO] [stderr] | ^^^^^^^^^^--------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `node.range[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:845:20 [INFO] [stderr] | [INFO] [stderr] 845 | (value <= &node.range[1]) [INFO] [stderr] | ^^^^^^^^^^--------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `node.range[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:879:24 [INFO] [stderr] | [INFO] [stderr] 879 | if (&node_prev.range[1] < value) && [INFO] [stderr] | ^-------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `node_prev.range[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:880:24 [INFO] [stderr] | [INFO] [stderr] 880 | (&node_next.range[0] > value) [INFO] [stderr] | ^-------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `node_next.range[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:889:32 [INFO] [stderr] | [INFO] [stderr] 889 | if unsafe {(&(*node_prev).range[1] < value) && [INFO] [stderr] | ^----------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `(*node_prev).range[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:890:32 [INFO] [stderr] | [INFO] [stderr] 890 | (&(*node_next).range[0] > value) } [INFO] [stderr] | ^----------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `(*node_next).range[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:593:31 [INFO] [stderr] | [INFO] [stderr] 593 | debug_assert!(key!(*n) <= &key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 333 | $body.range[0] [INFO] [stderr] 334 | } [INFO] [stderr] 335 | } [INFO] [stderr] 336 | [INFO] [stderr] 337 | fn is_red(node: *mut Node) -> bool [INFO] [stderr] 338 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:634:31 [INFO] [stderr] | [INFO] [stderr] 634 | debug_assert!(key!(*n) >= &key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 333 | $body.range[0] [INFO] [stderr] 334 | } [INFO] [stderr] 335 | } [INFO] [stderr] 336 | [INFO] [stderr] 337 | fn is_red(node: *mut Node) -> bool [INFO] [stderr] 338 | { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:844:20 [INFO] [stderr] | [INFO] [stderr] 844 | if (value >= &node.range[0]) && [INFO] [stderr] | ^^^^^^^^^^--------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `node.range[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:845:20 [INFO] [stderr] | [INFO] [stderr] 845 | (value <= &node.range[1]) [INFO] [stderr] | ^^^^^^^^^^--------------^ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `node.range[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:879:24 [INFO] [stderr] | [INFO] [stderr] 879 | if (&node_prev.range[1] < value) && [INFO] [stderr] | ^-------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `node_prev.range[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:880:24 [INFO] [stderr] | [INFO] [stderr] 880 | (&node_next.range[0] > value) [INFO] [stderr] | ^-------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `node_next.range[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:889:32 [INFO] [stderr] | [INFO] [stderr] 889 | if unsafe {(&(*node_prev).range[1] < value) && [INFO] [stderr] | ^----------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `(*node_prev).range[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:890:32 [INFO] [stderr] | [INFO] [stderr] 890 | (&(*node_next).range[0] > value) } [INFO] [stderr] | ^----------------------^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `(*node_next).range[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tests_rangetree.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | assert!(r.has(i) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!r.has(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tests_rangetree.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | assert!(r.has(i) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!r.has(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tests_rangetree.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | assert!(r.is_empty() == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `r.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tests_rangetree.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | assert!(r.is_empty() == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!r.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tests_rangetree.rs:64:17 [INFO] [stderr] | [INFO] [stderr] 64 | assert!(r.has((i * 2) + 1) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `r.has((i * 2) + 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tests_rangetree.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | assert!(r.has((i * 2)) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!r.has((i * 2))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tests_rangetree.rs:75:17 [INFO] [stderr] | [INFO] [stderr] 75 | assert!(r.is_empty() == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `r.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tests_rangetree.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | assert!(r.is_empty() == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `r.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "f831fc5b01f809b4b8593835ac1ba7759a4e6d1491c8a3ef62570a26225e2e0c"` [INFO] running `"docker" "rm" "-f" "f831fc5b01f809b4b8593835ac1ba7759a4e6d1491c8a3ef62570a26225e2e0c"` [INFO] [stdout] f831fc5b01f809b4b8593835ac1ba7759a4e6d1491c8a3ef62570a26225e2e0c