[INFO] crate ranged_set 0.4.1 is already in cache [INFO] extracting crate ranged_set 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/ranged_set/0.4.1 [INFO] extracting crate ranged_set 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ranged_set/0.4.1 [INFO] validating manifest of ranged_set-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ranged_set-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ranged_set-0.4.1 [INFO] finished frobbing ranged_set-0.4.1 [INFO] frobbed toml for ranged_set-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/ranged_set/0.4.1/Cargo.toml [INFO] started frobbing ranged_set-0.4.1 [INFO] finished frobbing ranged_set-0.4.1 [INFO] frobbed toml for ranged_set-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ranged_set/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ranged_set-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ranged_set/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b7c2521c396b04873fb9e8f8e9be61c294419dda5314485cbc0b979a2dbae779 [INFO] running `"docker" "start" "-a" "b7c2521c396b04873fb9e8f8e9be61c294419dda5314485cbc0b979a2dbae779"` [INFO] [stderr] Checking step v0.1.0 [INFO] [stderr] Checking ranged_set v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | (Some(p), None) => match v == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 45 | | true => Range(RangeInclusive::new(v, s)), [INFO] [stderr] 46 | | false => unimplemented!(), [INFO] [stderr] 47 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == p { Range(RangeInclusive::new(v, s)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:48:36 [INFO] [stderr] | [INFO] [stderr] 48 | (None, Some(n)) => match v == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 49 | | true => Range(RangeInclusive::new(s, v)), [INFO] [stderr] 50 | | false => unimplemented!(), [INFO] [stderr] 51 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == n { Range(RangeInclusive::new(s, v)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | (Some(p), None) => match v.end == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 62 | | true => Range(RangeInclusive::new(v.start, s)), [INFO] [stderr] 63 | | false => unimplemented!(), [INFO] [stderr] 64 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.end == p { Range(RangeInclusive::new(v.start, s)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | (None, Some(n)) => match v.start == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 66 | | true => Range(RangeInclusive::new(s, v.end)), [INFO] [stderr] 67 | | false => unimplemented!(), [INFO] [stderr] 68 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.start == n { Range(RangeInclusive::new(s, v.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | (Some(p), None) => match v == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 79 | | true => Range(RangeInclusive::new(v, r.end)), [INFO] [stderr] 80 | | false => unimplemented!(), [INFO] [stderr] 81 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == p { Range(RangeInclusive::new(v, r.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | (None, Some(n)) => match v == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 83 | | true => Range(RangeInclusive::new(r.start, v)), [INFO] [stderr] 84 | | false => unimplemented!(), [INFO] [stderr] 85 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == n { Range(RangeInclusive::new(r.start, v)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:95:36 [INFO] [stderr] | [INFO] [stderr] 95 | (Some(p), None) => match v.end == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 96 | | true => Range(RangeInclusive::new(v.start, r.end)), [INFO] [stderr] 97 | | false => unimplemented!(), [INFO] [stderr] 98 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.end == p { Range(RangeInclusive::new(v.start, r.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | (None, Some(n)) => match v.start == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 100 | | true => Range(RangeInclusive::new(r.start, v.end)), [INFO] [stderr] 101 | | false => unimplemented!(), [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.start == n { Range(RangeInclusive::new(r.start, v.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/element/mod.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match self { [INFO] [stderr] 110 | | &Element::Range(ref r) => match (value.prev(), value.next()) { [INFO] [stderr] 111 | | (Some(p), Some(n)) => { [INFO] [stderr] 112 | | let prev = if r.start == p { [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => unreachable!(), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | Element::Range(ref r) => match (value.prev(), value.next()) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/element/mod.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match self { [INFO] [stderr] 162 | | &Element::Single(ref s) => s.next(), [INFO] [stderr] 163 | | &Element::Range(ref r) => r.end.next(), [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 161 | match *self { [INFO] [stderr] 162 | Element::Single(ref s) => s.next(), [INFO] [stderr] 163 | Element::Range(ref r) => r.end.next(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/element/mod.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match self { [INFO] [stderr] 169 | | &Element::Single(ref s) => s.prev(), [INFO] [stderr] 170 | | &Element::Range(ref r) => r.start.prev(), [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 168 | match *self { [INFO] [stderr] 169 | Element::Single(ref s) => s.prev(), [INFO] [stderr] 170 | Element::Range(ref r) => r.start.prev(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `set::RangedSet` [INFO] [stderr] --> src/set/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> RangedSet { [INFO] [stderr] 55 | | RangedSet { [INFO] [stderr] 56 | | ranges: Vec::new(), [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/set/mod.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match self.find_index_for(value) { [INFO] [stderr] 77 | | Ok(_) => true, [INFO] [stderr] 78 | | Err(_) => false, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ help: try this: `self.find_index_for(value).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/set/mod.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / match self.take(value) { [INFO] [stderr] 250 | | Some(_) => true, [INFO] [stderr] 251 | | None => false, [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________^ help: try this: `self.take(value).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:44:36 [INFO] [stderr] | [INFO] [stderr] 44 | (Some(p), None) => match v == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 45 | | true => Range(RangeInclusive::new(v, s)), [INFO] [stderr] 46 | | false => unimplemented!(), [INFO] [stderr] 47 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == p { Range(RangeInclusive::new(v, s)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:48:36 [INFO] [stderr] | [INFO] [stderr] 48 | (None, Some(n)) => match v == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 49 | | true => Range(RangeInclusive::new(s, v)), [INFO] [stderr] 50 | | false => unimplemented!(), [INFO] [stderr] 51 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == n { Range(RangeInclusive::new(s, v)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:61:36 [INFO] [stderr] | [INFO] [stderr] 61 | (Some(p), None) => match v.end == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 62 | | true => Range(RangeInclusive::new(v.start, s)), [INFO] [stderr] 63 | | false => unimplemented!(), [INFO] [stderr] 64 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.end == p { Range(RangeInclusive::new(v.start, s)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | (None, Some(n)) => match v.start == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 66 | | true => Range(RangeInclusive::new(s, v.end)), [INFO] [stderr] 67 | | false => unimplemented!(), [INFO] [stderr] 68 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.start == n { Range(RangeInclusive::new(s, v.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:78:36 [INFO] [stderr] | [INFO] [stderr] 78 | (Some(p), None) => match v == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 79 | | true => Range(RangeInclusive::new(v, r.end)), [INFO] [stderr] 80 | | false => unimplemented!(), [INFO] [stderr] 81 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == p { Range(RangeInclusive::new(v, r.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:82:36 [INFO] [stderr] | [INFO] [stderr] 82 | (None, Some(n)) => match v == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 83 | | true => Range(RangeInclusive::new(r.start, v)), [INFO] [stderr] 84 | | false => unimplemented!(), [INFO] [stderr] 85 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v == n { Range(RangeInclusive::new(r.start, v)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:95:36 [INFO] [stderr] | [INFO] [stderr] 95 | (Some(p), None) => match v.end == p { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 96 | | true => Range(RangeInclusive::new(v.start, r.end)), [INFO] [stderr] 97 | | false => unimplemented!(), [INFO] [stderr] 98 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.end == p { Range(RangeInclusive::new(v.start, r.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/element/mod.rs:99:36 [INFO] [stderr] | [INFO] [stderr] 99 | (None, Some(n)) => match v.start == n { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 100 | | true => Range(RangeInclusive::new(r.start, v.end)), [INFO] [stderr] 101 | | false => unimplemented!(), [INFO] [stderr] 102 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if v.start == n { Range(RangeInclusive::new(r.start, v.end)) } else { unimplemented!() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/element/mod.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | / match self { [INFO] [stderr] 110 | | &Element::Range(ref r) => match (value.prev(), value.next()) { [INFO] [stderr] 111 | | (Some(p), Some(n)) => { [INFO] [stderr] 112 | | let prev = if r.start == p { [INFO] [stderr] ... | [INFO] [stderr] 156 | | _ => unreachable!(), [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 109 | match *self { [INFO] [stderr] 110 | Element::Range(ref r) => match (value.prev(), value.next()) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/element/mod.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | / match self { [INFO] [stderr] 162 | | &Element::Single(ref s) => s.next(), [INFO] [stderr] 163 | | &Element::Range(ref r) => r.end.next(), [INFO] [stderr] 164 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 161 | match *self { [INFO] [stderr] 162 | Element::Single(ref s) => s.next(), [INFO] [stderr] 163 | Element::Range(ref r) => r.end.next(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/element/mod.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | / match self { [INFO] [stderr] 169 | | &Element::Single(ref s) => s.prev(), [INFO] [stderr] 170 | | &Element::Range(ref r) => r.start.prev(), [INFO] [stderr] 171 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 168 | match *self { [INFO] [stderr] 169 | Element::Single(ref s) => s.prev(), [INFO] [stderr] 170 | Element::Range(ref r) => r.start.prev(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `set::RangedSet` [INFO] [stderr] --> src/set/mod.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> RangedSet { [INFO] [stderr] 55 | | RangedSet { [INFO] [stderr] 56 | | ranges: Vec::new(), [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 41 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/set/mod.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | / match self.find_index_for(value) { [INFO] [stderr] 77 | | Ok(_) => true, [INFO] [stderr] 78 | | Err(_) => false, [INFO] [stderr] 79 | | } [INFO] [stderr] | |_________^ help: try this: `self.find_index_for(value).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/set/mod.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | / match self.take(value) { [INFO] [stderr] 250 | | Some(_) => true, [INFO] [stderr] 251 | | None => false, [INFO] [stderr] 252 | | } [INFO] [stderr] | |_________^ help: try this: `self.take(value).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.39s [INFO] running `"docker" "inspect" "b7c2521c396b04873fb9e8f8e9be61c294419dda5314485cbc0b979a2dbae779"` [INFO] running `"docker" "rm" "-f" "b7c2521c396b04873fb9e8f8e9be61c294419dda5314485cbc0b979a2dbae779"` [INFO] [stdout] b7c2521c396b04873fb9e8f8e9be61c294419dda5314485cbc0b979a2dbae779