[INFO] crate range-encoding 0.1.9 is already in cache [INFO] extracting crate range-encoding 0.1.9 into work/ex/clippy-test-run/sources/stable/reg/range-encoding/0.1.9 [INFO] extracting crate range-encoding 0.1.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/range-encoding/0.1.9 [INFO] validating manifest of range-encoding-0.1.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of range-encoding-0.1.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing range-encoding-0.1.9 [INFO] finished frobbing range-encoding-0.1.9 [INFO] frobbed toml for range-encoding-0.1.9 written to work/ex/clippy-test-run/sources/stable/reg/range-encoding/0.1.9/Cargo.toml [INFO] started frobbing range-encoding-0.1.9 [INFO] finished frobbing range-encoding-0.1.9 [INFO] frobbed toml for range-encoding-0.1.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/range-encoding/0.1.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting range-encoding-0.1.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/range-encoding/0.1.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48e27d593e11ee9ce880942452eb4dd88ee4de02993fd97d7ed4fbbcae6f79e0 [INFO] running `"docker" "start" "-a" "48e27d593e11ee9ce880942452eb4dd88ee4de02993fd97d7ed4fbbcae6f79e0"` [INFO] [stderr] Checking range-encoding v0.1.9 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return n.wrapping_div(d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n.wrapping_div(d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return n / d; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `n / d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | (*_this).rng = 1u32 << (32i32 - 2i32) % 8i32 + 1i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << ((32i32 - 2i32) % 8i32 + 1i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:52:67 [INFO] [stderr] | [INFO] [stderr] 52 | libc::c_uint).wrapping_sub(((*_this).rem [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 53 | | >> [INFO] [stderr] 54 | | 8i32 - [INFO] [stderr] 55 | | ((32i32 [INFO] [stderr] ... | [INFO] [stderr] 60 | | + [INFO] [stderr] 61 | | 1i32)) [INFO] [stderr] | |____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 52 | libc::c_uint).wrapping_sub(((*_this).rem >> (8i32 - [INFO] [stderr] 53 | ((32i32 [INFO] [stderr] 54 | - [INFO] [stderr] 55 | 2i32) [INFO] [stderr] 56 | % [INFO] [stderr] 57 | 8i32 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:68:27 [INFO] [stderr] | [INFO] [stderr] 68 | while (*_this).rng <= 1u32 << 32i32 - 1i32 >> 8i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / (sym << 8i32 | (*_this).rem) >> [INFO] [stderr] 75 | | 8i32 - ((32i32 - 2i32) % 8i32 + 1i32); [INFO] [stderr] | |_____________________________________________________^ help: consider parenthesizing your expression: `(sym << 8i32 | (*_this).rem) >> (8i32 - ((32i32 - 2i32) % 8i32 + 1i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / return _ft.wrapping_sub(s.wrapping_add(1i32 as [INFO] [stderr] 105 | | libc::c_uint).wrapping_add(_ft.wrapping_sub(s.wrapping_add(1i32 [INFO] [stderr] 106 | | as [INFO] [stderr] 107 | | libc::c_uint)) [INFO] [stderr] ... | [INFO] [stderr] 116 | | as [INFO] [stderr] 117 | | libc::c_uint)); [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 104 | _ft.wrapping_sub(s.wrapping_add(1i32 as [INFO] [stderr] 105 | libc::c_uint).wrapping_add(_ft.wrapping_sub(s.wrapping_add(1i32 [INFO] [stderr] 106 | as [INFO] [stderr] 107 | libc::c_uint)) [INFO] [stderr] 108 | & [INFO] [stderr] 109 | -((_ft [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / return (1u32 << [INFO] [stderr] 126 | | _bits).wrapping_sub(s.wrapping_add(1u32).wrapping_add((1u32 << [INFO] [stderr] 127 | | _bits).wrapping_sub(s.wrapping_add(1u32)) [INFO] [stderr] 128 | | & [INFO] [stderr] ... | [INFO] [stderr] 136 | | as [INFO] [stderr] 137 | | libc::c_uint)); [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 125 | (1u32 << [INFO] [stderr] 126 | _bits).wrapping_sub(s.wrapping_add(1u32).wrapping_add((1u32 << [INFO] [stderr] 127 | _bits).wrapping_sub(s.wrapping_add(1u32)) [INFO] [stderr] 128 | & [INFO] [stderr] 129 | -((1u32 [INFO] [stderr] 130 | << [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_encode.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return n.wrapping_div(d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n.wrapping_div(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | while (*_this).rng <= 1u32 << 32i32 - 1i32 >> 8i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:84:27 [INFO] [stderr] | [INFO] [stderr] 84 | ((*_this).val >> 32i32 - 8i32 - 1i32) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(*_this).val >> (32i32 - 8i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_encode.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_encode.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | let mut msk = (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint) >> l; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:274:34 [INFO] [stderr] | [INFO] [stderr] 274 | ec_enc_carry_out(_this, (end >> 32i32 - 8i32 - 1i32) as libc::c_int)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `end >> (32i32 - 8i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:277:18 [INFO] [stderr] | [INFO] [stderr] 277 | (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | return n.wrapping_div(d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n.wrapping_div(d)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | return n / d; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `n / d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:48:20 [INFO] [stderr] | [INFO] [stderr] 48 | (*_this).rng = 1u32 << (32i32 - 2i32) % 8i32 + 1i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << ((32i32 - 2i32) % 8i32 + 1i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:52:67 [INFO] [stderr] | [INFO] [stderr] 52 | libc::c_uint).wrapping_sub(((*_this).rem [INFO] [stderr] | ___________________________________________________________________^ [INFO] [stderr] 53 | | >> [INFO] [stderr] 54 | | 8i32 - [INFO] [stderr] 55 | | ((32i32 [INFO] [stderr] ... | [INFO] [stderr] 60 | | + [INFO] [stderr] 61 | | 1i32)) [INFO] [stderr] | |____________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] help: consider parenthesizing your expression [INFO] [stderr] | [INFO] [stderr] 52 | libc::c_uint).wrapping_sub(((*_this).rem >> (8i32 - [INFO] [stderr] 53 | ((32i32 [INFO] [stderr] 54 | - [INFO] [stderr] 55 | 2i32) [INFO] [stderr] 56 | % [INFO] [stderr] 57 | 8i32 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:68:27 [INFO] [stderr] | [INFO] [stderr] 68 | while (*_this).rng <= 1u32 << 32i32 - 1i32 >> 8i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | / (sym << 8i32 | (*_this).rem) >> [INFO] [stderr] 75 | | 8i32 - ((32i32 - 2i32) % 8i32 + 1i32); [INFO] [stderr] | |_____________________________________________________^ help: consider parenthesizing your expression: `(sym << 8i32 | (*_this).rem) >> (8i32 - ((32i32 - 2i32) % 8i32 + 1i32))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_decode.rs:82:18 [INFO] [stderr] | [INFO] [stderr] 82 | (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:104:5 [INFO] [stderr] | [INFO] [stderr] 104 | / return _ft.wrapping_sub(s.wrapping_add(1i32 as [INFO] [stderr] 105 | | libc::c_uint).wrapping_add(_ft.wrapping_sub(s.wrapping_add(1i32 [INFO] [stderr] 106 | | as [INFO] [stderr] 107 | | libc::c_uint)) [INFO] [stderr] ... | [INFO] [stderr] 116 | | as [INFO] [stderr] 117 | | libc::c_uint)); [INFO] [stderr] | |_________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 104 | _ft.wrapping_sub(s.wrapping_add(1i32 as [INFO] [stderr] 105 | libc::c_uint).wrapping_add(_ft.wrapping_sub(s.wrapping_add(1i32 [INFO] [stderr] 106 | as [INFO] [stderr] 107 | libc::c_uint)) [INFO] [stderr] 108 | & [INFO] [stderr] 109 | -((_ft [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_decode.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | / return (1u32 << [INFO] [stderr] 126 | | _bits).wrapping_sub(s.wrapping_add(1u32).wrapping_add((1u32 << [INFO] [stderr] 127 | | _bits).wrapping_sub(s.wrapping_add(1u32)) [INFO] [stderr] 128 | | & [INFO] [stderr] ... | [INFO] [stderr] 136 | | as [INFO] [stderr] 137 | | libc::c_uint)); [INFO] [stderr] | |_____________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 125 | (1u32 << [INFO] [stderr] 126 | _bits).wrapping_sub(s.wrapping_add(1u32).wrapping_add((1u32 << [INFO] [stderr] 127 | _bits).wrapping_sub(s.wrapping_add(1u32)) [INFO] [stderr] 128 | & [INFO] [stderr] 129 | -((1u32 [INFO] [stderr] 130 | << [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_encode.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return n.wrapping_div(d); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `n.wrapping_div(d)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:82:27 [INFO] [stderr] | [INFO] [stderr] 82 | while (*_this).rng <= 1u32 << 32i32 - 1i32 >> 8i32 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:84:27 [INFO] [stderr] | [INFO] [stderr] 84 | ((*_this).val >> 32i32 - 8i32 - 1i32) as [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(*_this).val >> (32i32 - 8i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_encode.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/opus/imported_encode.rs:252:5 [INFO] [stderr] | [INFO] [stderr] 252 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:266:20 [INFO] [stderr] | [INFO] [stderr] 266 | let mut msk = (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint) >> l; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:274:34 [INFO] [stderr] | [INFO] [stderr] 274 | ec_enc_carry_out(_this, (end >> 32i32 - 8i32 - 1i32) as libc::c_int)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `end >> (32i32 - 8i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/opus/imported_encode.rs:277:18 [INFO] [stderr] | [INFO] [stderr] 277 | (1u32 << 32i32 - 1i32).wrapping_sub(1i32 as libc::c_uint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `1u32 << (32i32 - 1i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_decode.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | (*_this).rem = ec_read_byte(_this)? as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ec_read_byte(_this)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_decode.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | (*_this).rem = ec_read_byte(_this)? as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ec_read_byte(_this)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/opus/imported_decode.rs:182:12 [INFO] [stderr] | [INFO] [stderr] 182 | if !(d < s) { break ; } [INFO] [stderr] | ^^^^^^^^ help: try: `d >= s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_decode.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | s = r.wrapping_mul(*_icdf.offset(ret as isize) as libc::c_uint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*_icdf.offset(ret as isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/opus/imported_encode.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | if !((*_this).ext > 0i32 as libc::c_uint) { break ; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*_this).ext <= 0i32 as libc::c_uint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:174:86 [INFO] [stderr] | [INFO] [stderr] 174 | libc::c_uint).wrapping_add((*_this).rng.wrapping_sub(r.wrapping_mul(*_icdf.offset((_s [INFO] [stderr] | ______________________________________________________________________________________^ [INFO] [stderr] 175 | | - [INFO] [stderr] 176 | | 1i32) [INFO] [stderr] 177 | | as [INFO] [stderr] 178 | | isize) [INFO] [stderr] 179 | | as [INFO] [stderr] 180 | | libc::c_uint))) [INFO] [stderr] | |_____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | libc::c_uint).wrapping_add((*_this).rng.wrapping_sub(r.wrapping_mul(u32::from(*_icdf.offset((_s [INFO] [stderr] 175 | - [INFO] [stderr] 176 | 1i32) [INFO] [stderr] 177 | as [INFO] [stderr] 178 | isize))))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:183:29 [INFO] [stderr] | [INFO] [stderr] 183 | r.wrapping_mul((*_icdf.offset((_s - 1i32) as isize) as libc::c_int [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*_icdf.offset((_s - 1i32) as isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:184:35 [INFO] [stderr] | [INFO] [stderr] 184 | - *_icdf.offset(_s as isize) as libc::c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*_icdf.offset(_s as isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:189:60 [INFO] [stderr] | [INFO] [stderr] 189 | libc::c_uint).wrapping_sub(r.wrapping_mul(*_icdf.offset(_s as [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 190 | | isize) [INFO] [stderr] 191 | | as [INFO] [stderr] 192 | | libc::c_uint)) [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 189 | libc::c_uint).wrapping_sub(r.wrapping_mul(u32::from(*_icdf.offset(_s as [INFO] [stderr] 190 | isize)))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/opus/imported_encode.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | if !(used >= 8i32) { break ; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `used < 8i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:301:30 [INFO] [stderr] | [INFO] [stderr] 301 | ec_write_byte(_this, *byte as u32)?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `CumulativeDistributionFrequency` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / impl CumulativeDistributionFrequency { [INFO] [stderr] 71 | | pub fn new(probabilities: Vec) -> Self { [INFO] [stderr] 72 | | let mut segments = Vec::with_capacity(probabilities.len()); [INFO] [stderr] 73 | | let mut start = 0; [INFO] [stderr] ... | [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn at_index<'a>(&'a mut self, index: usize) -> Option<&'a mut Segment> { [INFO] [stderr] 121 | | if index >= self.segments.len() { [INFO] [stderr] 122 | | return None; [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | Some(&mut self.segments[index]) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_decode.rs:49:20 [INFO] [stderr] | [INFO] [stderr] 49 | (*_this).rem = ec_read_byte(_this)? as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ec_read_byte(_this)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_decode.rs:72:24 [INFO] [stderr] | [INFO] [stderr] 72 | (*_this).rem = ec_read_byte(_this)? as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(ec_read_byte(_this)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/opus/imported_decode.rs:182:12 [INFO] [stderr] | [INFO] [stderr] 182 | if !(d < s) { break ; } [INFO] [stderr] | ^^^^^^^^ help: try: `d >= s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_decode.rs:181:28 [INFO] [stderr] | [INFO] [stderr] 181 | s = r.wrapping_mul(*_icdf.offset(ret as isize) as libc::c_uint); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*_icdf.offset(ret as isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/opus/imported_encode.rs:113:20 [INFO] [stderr] | [INFO] [stderr] 113 | if !((*_this).ext > 0i32 as libc::c_uint) { break ; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(*_this).ext <= 0i32 as libc::c_uint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:174:86 [INFO] [stderr] | [INFO] [stderr] 174 | libc::c_uint).wrapping_add((*_this).rng.wrapping_sub(r.wrapping_mul(*_icdf.offset((_s [INFO] [stderr] | ______________________________________________________________________________________^ [INFO] [stderr] 175 | | - [INFO] [stderr] 176 | | 1i32) [INFO] [stderr] 177 | | as [INFO] [stderr] 178 | | isize) [INFO] [stderr] 179 | | as [INFO] [stderr] 180 | | libc::c_uint))) [INFO] [stderr] | |_____________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | libc::c_uint).wrapping_add((*_this).rng.wrapping_sub(r.wrapping_mul(u32::from(*_icdf.offset((_s [INFO] [stderr] 175 | - [INFO] [stderr] 176 | 1i32) [INFO] [stderr] 177 | as [INFO] [stderr] 178 | isize))))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:183:29 [INFO] [stderr] | [INFO] [stderr] 183 | r.wrapping_mul((*_icdf.offset((_s - 1i32) as isize) as libc::c_int [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*_icdf.offset((_s - 1i32) as isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:184:35 [INFO] [stderr] | [INFO] [stderr] 184 | - *_icdf.offset(_s as isize) as libc::c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(*_icdf.offset(_s as isize))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:189:60 [INFO] [stderr] | [INFO] [stderr] 189 | libc::c_uint).wrapping_sub(r.wrapping_mul(*_icdf.offset(_s as [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 190 | | isize) [INFO] [stderr] 191 | | as [INFO] [stderr] 192 | | libc::c_uint)) [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 189 | libc::c_uint).wrapping_sub(r.wrapping_mul(u32::from(*_icdf.offset(_s as [INFO] [stderr] 190 | isize)))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/opus/imported_encode.rs:240:16 [INFO] [stderr] | [INFO] [stderr] 240 | if !(used >= 8i32) { break ; } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `used < 8i32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/opus/imported_encode.rs:301:30 [INFO] [stderr] | [INFO] [stderr] 301 | ec_write_byte(_this, *byte as u32)?; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: item `CumulativeDistributionFrequency` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / impl CumulativeDistributionFrequency { [INFO] [stderr] 71 | | pub fn new(probabilities: Vec) -> Self { [INFO] [stderr] 72 | | let mut segments = Vec::with_capacity(probabilities.len()); [INFO] [stderr] 73 | | let mut start = 0; [INFO] [stderr] ... | [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn at_index<'a>(&'a mut self, index: usize) -> Option<&'a mut Segment> { [INFO] [stderr] 121 | | if index >= self.segments.len() { [INFO] [stderr] 122 | | return None; [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | Some(&mut self.segments[index]) [INFO] [stderr] 125 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> tests/simple.rs:11:62 [INFO] [stderr] | [INFO] [stderr] 11 | let probabilities = CumulativeDistributionFrequency::new(widths.iter().cloned().collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: The function/method `symbol` doesn't need a mutable reference [INFO] [stderr] --> tests/simple.rs:78:39 [INFO] [stderr] | [INFO] [stderr] 78 | let index = reader.symbol(&mut probabilities) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.44s [INFO] running `"docker" "inspect" "48e27d593e11ee9ce880942452eb4dd88ee4de02993fd97d7ed4fbbcae6f79e0"` [INFO] running `"docker" "rm" "-f" "48e27d593e11ee9ce880942452eb4dd88ee4de02993fd97d7ed4fbbcae6f79e0"` [INFO] [stdout] 48e27d593e11ee9ce880942452eb4dd88ee4de02993fd97d7ed4fbbcae6f79e0