[INFO] crate randselect 0.2.3 is already in cache [INFO] extracting crate randselect 0.2.3 into work/ex/clippy-test-run/sources/stable/reg/randselect/0.2.3 [INFO] extracting crate randselect 0.2.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/randselect/0.2.3 [INFO] validating manifest of randselect-0.2.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of randselect-0.2.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing randselect-0.2.3 [INFO] finished frobbing randselect-0.2.3 [INFO] frobbed toml for randselect-0.2.3 written to work/ex/clippy-test-run/sources/stable/reg/randselect/0.2.3/Cargo.toml [INFO] started frobbing randselect-0.2.3 [INFO] finished frobbing randselect-0.2.3 [INFO] frobbed toml for randselect-0.2.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/randselect/0.2.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting randselect-0.2.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/randselect/0.2.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13477e5f0f4b968d24e14c0bdacd2b3784052977e7a1187c7e1d4720d7b85072 [INFO] running `"docker" "start" "-a" "13477e5f0f4b968d24e14c0bdacd2b3784052977e7a1187c7e1d4720d7b85072"` [INFO] [stderr] Checking fern v0.5.7 [INFO] [stderr] Checking os_type v2.2.0 [INFO] [stderr] Checking human-panic v1.0.1 [INFO] [stderr] Checking randselect v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(vec_paths); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec_paths)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | return Ok(vec_paths); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(vec_paths)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:143:13 [INFO] [stderr] | [INFO] [stderr] 143 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/utils.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / let mut color_line_end = String::from("\x1B[0m"); [INFO] [stderr] 36 | | [INFO] [stderr] 37 | | // Clear colors if flag is set [INFO] [stderr] 38 | | if no_color { [INFO] [stderr] 39 | | color_line_start = String::from(""); [INFO] [stderr] 40 | | color_line_end = String::from(""); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let color_line_end = if no_color { ..; String::from("") } else { String::from("\x1B[0m") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = base_config.chain(stdout_config).apply() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 56 | | // Still return Ok, but warn the user. [INFO] [stderr] 57 | | warn!("Logger was already set and cannot be reset."); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____- help: try this: `if base_config.chain(stdout_config).apply().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/utils.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / let mut color_line_end = String::from("\x1B[0m"); [INFO] [stderr] 36 | | [INFO] [stderr] 37 | | // Clear colors if flag is set [INFO] [stderr] 38 | | if no_color { [INFO] [stderr] 39 | | color_line_start = String::from(""); [INFO] [stderr] 40 | | color_line_end = String::from(""); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let color_line_end = if no_color { ..; String::from("") } else { String::from("\x1B[0m") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = base_config.chain(stdout_config).apply() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 56 | | // Still return Ok, but warn the user. [INFO] [stderr] 57 | | warn!("Logger was already set and cannot be reset."); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____- help: try this: `if base_config.chain(stdout_config).apply().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/lib.rs:160:16 [INFO] [stderr] | [INFO] [stderr] 160 | if let Ok(_) = paths_are_valid(".", ".") { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 161 | | panic!("Should have failed with same paths"); [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________- help: try this: `if paths_are_valid(".", ".").is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | out_dir: out_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `out_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | num_files: num_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | no_color: no_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `no_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | out_dir: out_dir, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `out_dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | num_files: num_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:115:9 [INFO] [stderr] | [INFO] [stderr] 115 | no_color: no_color, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `no_color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> tests/integration_test.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if let Ok(_) = randselect::run(&mut test_args) { [INFO] [stderr] | _____- ^^^^^ [INFO] [stderr] 33 | | panic!("Should have failed.") [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____- help: try this: `if randselect::run(&mut test_args).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/utils.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / let mut color_line_end = String::from("\x1B[0m"); [INFO] [stderr] 36 | | [INFO] [stderr] 37 | | // Clear colors if flag is set [INFO] [stderr] 38 | | if no_color { [INFO] [stderr] 39 | | color_line_start = String::from(""); [INFO] [stderr] 40 | | color_line_end = String::from(""); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let color_line_end = if no_color { ..; String::from("") } else { String::from("\x1B[0m") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = base_config.chain(stdout_config).apply() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 56 | | // Still return Ok, but warn the user. [INFO] [stderr] 57 | | warn!("Logger was already set and cannot be reset."); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____- help: try this: `if base_config.chain(stdout_config).apply().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | if out_dir.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/utils.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / let mut color_line_end = String::from("\x1B[0m"); [INFO] [stderr] 36 | | [INFO] [stderr] 37 | | // Clear colors if flag is set [INFO] [stderr] 38 | | if no_color { [INFO] [stderr] 39 | | color_line_start = String::from(""); [INFO] [stderr] 40 | | color_line_end = String::from(""); [INFO] [stderr] 41 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let color_line_end = if no_color { ..; String::from("") } else { String::from("\x1B[0m") };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = base_config.chain(stdout_config).apply() { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 56 | | // Still return Ok, but warn the user. [INFO] [stderr] 57 | | warn!("Logger was already set and cannot be reset."); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____- help: try this: `if base_config.chain(stdout_config).apply().is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | if out_dir.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.18s [INFO] running `"docker" "inspect" "13477e5f0f4b968d24e14c0bdacd2b3784052977e7a1187c7e1d4720d7b85072"` [INFO] running `"docker" "rm" "-f" "13477e5f0f4b968d24e14c0bdacd2b3784052977e7a1187c7e1d4720d7b85072"` [INFO] [stdout] 13477e5f0f4b968d24e14c0bdacd2b3784052977e7a1187c7e1d4720d7b85072