[INFO] crate randomkit 0.1.1 is already in cache [INFO] extracting crate randomkit 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/randomkit/0.1.1 [INFO] extracting crate randomkit 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/randomkit/0.1.1 [INFO] validating manifest of randomkit-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of randomkit-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing randomkit-0.1.1 [INFO] finished frobbing randomkit-0.1.1 [INFO] frobbed toml for randomkit-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/randomkit/0.1.1/Cargo.toml [INFO] started frobbing randomkit-0.1.1 [INFO] finished frobbing randomkit-0.1.1 [INFO] frobbed toml for randomkit-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/randomkit/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting randomkit-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/randomkit/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 022e3b522adb018b5f6d91b505b150547e529cab797e89b7c1a7c17f0274311a [INFO] running `"docker" "start" "-a" "022e3b522adb018b5f6d91b505b150547e529cab797e89b7c1a7c17f0274311a"` [INFO] [stderr] Compiling randomkit v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(Randint { low: low, diff: diff }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:91:32 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(Randint { low: low, diff: diff }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | Ok(Dirichlet { alpha: alpha }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:285:26 [INFO] [stderr] | [INFO] [stderr] 285 | Ok(Multinomial { n: n, pvals: pvals }) [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:285:32 [INFO] [stderr] | [INFO] [stderr] 285 | Ok(Multinomial { n: n, pvals: pvals }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pvals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:427:22 [INFO] [stderr] | [INFO] [stderr] 427 | Ok(Uniform { low: low, scale: scale }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:427:32 [INFO] [stderr] | [INFO] [stderr] 427 | Ok(Uniform { low: low, scale: scale }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(Randint { low: low, diff: diff }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:91:32 [INFO] [stderr] | [INFO] [stderr] 91 | Ok(Randint { low: low, diff: diff }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `diff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:152:24 [INFO] [stderr] | [INFO] [stderr] 152 | Ok(Dirichlet { alpha: alpha }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alpha` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:285:26 [INFO] [stderr] | [INFO] [stderr] 285 | Ok(Multinomial { n: n, pvals: pvals }) [INFO] [stderr] | ^^^^ help: replace it with: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:285:32 [INFO] [stderr] | [INFO] [stderr] 285 | Ok(Multinomial { n: n, pvals: pvals }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `pvals` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:427:22 [INFO] [stderr] | [INFO] [stderr] 427 | Ok(Uniform { low: low, scale: scale }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `low` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dist.rs:427:32 [INFO] [stderr] | [INFO] [stderr] 427 | Ok(Uniform { low: low, scale: scale }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dist.rs:367:18 [INFO] [stderr] | [INFO] [stderr] 367 | need!(lam <= 9.2233720064847708e+18); // from mtrand.pyx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9.223_372_006_484_770_8e+18` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub static RK_MAX: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/dist.rs:367:18 [INFO] [stderr] | [INFO] [stderr] 367 | need!(lam <= 9.2233720064847708e+18); // from mtrand.pyx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `9.223_372_006_484_770_8e+18` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ffi.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | pub static RK_MAX: u32 = 0xffffffff; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::Gauss` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 69 | / distribution!(Gauss() -> f64, |self, rng| { [INFO] [stderr] 70 | | unsafe { rk_gauss(&mut rng.state) as f64 } [INFO] [stderr] 71 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::Rand` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | / distribution!(Rand() -> f64, |self, rng| { [INFO] [stderr] 79 | | unsafe { rk_double(&mut rng.state) as f64 } [INFO] [stderr] 80 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::StandardCauchy` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 104 | / distribution!(StandardCauchy() -> f64, |self, rng| { [INFO] [stderr] 105 | | unsafe { rk_standard_cauchy(&mut rng.state) as f64 } [INFO] [stderr] 106 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::StandardExponential` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 111 | / distribution!(StandardExponential() -> f64, |self, rng| { [INFO] [stderr] 112 | | unsafe { rk_standard_exponential(&mut rng.state) as f64 } [INFO] [stderr] 113 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 110 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 119 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 120 | need!(b > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `diric` [INFO] [stderr] --> src/dist.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | for j in 0..k { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 160 | for (j, ) in diric.iter_mut().enumerate().take(k) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `diric`. [INFO] [stderr] --> src/dist.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | for j in 0..k { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for in diric.iter_mut().take(k) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dist.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | diric[j] = diric[j] * invacc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `diric[j] *= invacc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 178 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 187 | need!(dfnum > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 188 | need!(dfden > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 197 | need!(shape > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 198 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 216 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 237 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 246 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | need!(sigma > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 264 | need!(p > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 265 | need!(p < 1.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | need!(kahan_sum(&pvals[..pvals.len()-1]) <= 1.0 + 1.0e-12, "need sum(pvals[:-1]) <= 1.0"); [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `multin` [INFO] [stderr] --> src/dist.rs:294:18 [INFO] [stderr] | [INFO] [stderr] 294 | for j in 0..d-1 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 294 | for (j, ) in multin.iter_mut().enumerate().take(d-1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 314 | need!(n > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 324 | need!(df >= 1.0); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | need!(nonc > 0.0); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 334 | need!(dfnum > 1.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 335 | need!(dfden > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 336 | need!(nonc >= 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 348 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 357 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 366 | need!(lam > 0.0); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 367 | need!(lam <= 9.2233720064847708e+18); // from mtrand.pyx [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/dist.rs:367:18 [INFO] [stderr] | [INFO] [stderr] 367 | need!(lam <= 9.2233720064847708e+18); // from mtrand.pyx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `9.223_372_006_484_771e18` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 376 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 385 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 394 | need!(shape > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | need!(df > 0.0); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | need!(left < right); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 440 | need!(kappa > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 449 | need!(mean > 0.0); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 450 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 459 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 468 | need!(a > 1.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | ffi::rk_seed(seed as c_ulong, &mut r.state); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(seed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::Gauss` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 69 | / distribution!(Gauss() -> f64, |self, rng| { [INFO] [stderr] 70 | | unsafe { rk_gauss(&mut rng.state) as f64 } [INFO] [stderr] 71 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::Rand` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 78 | / distribution!(Rand() -> f64, |self, rng| { [INFO] [stderr] 79 | | unsafe { rk_double(&mut rng.state) as f64 } [INFO] [stderr] 80 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::StandardCauchy` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 104 | / distribution!(StandardCauchy() -> f64, |self, rng| { [INFO] [stderr] 105 | | unsafe { rk_standard_cauchy(&mut rng.state) as f64 } [INFO] [stderr] 106 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 103 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `dist::StandardExponential` [INFO] [stderr] --> src/dist.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn new() -> $name { $name } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 111 | / distribution!(StandardExponential() -> f64, |self, rng| { [INFO] [stderr] 112 | | unsafe { rk_standard_exponential(&mut rng.state) as f64 } [INFO] [stderr] 113 | | }); [INFO] [stderr] | |___- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 110 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 119 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 120 | need!(b > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `diric` [INFO] [stderr] --> src/dist.rs:160:18 [INFO] [stderr] | [INFO] [stderr] 160 | for j in 0..k { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 160 | for (j, ) in diric.iter_mut().enumerate().take(k) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `diric`. [INFO] [stderr] --> src/dist.rs:167:18 [INFO] [stderr] | [INFO] [stderr] 167 | for j in 0..k { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 167 | for in diric.iter_mut().take(k) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/dist.rs:168:13 [INFO] [stderr] | [INFO] [stderr] 168 | diric[j] = diric[j] * invacc; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `diric[j] *= invacc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 178 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 187 | need!(dfnum > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 188 | need!(dfden > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 197 | need!(shape > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 198 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 216 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 237 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 246 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 255 | need!(sigma > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 264 | need!(p > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 265 | need!(p < 1.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 284 | need!(kahan_sum(&pvals[..pvals.len()-1]) <= 1.0 + 1.0e-12, "need sum(pvals[:-1]) <= 1.0"); [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `multin` [INFO] [stderr] --> src/dist.rs:294:18 [INFO] [stderr] | [INFO] [stderr] 294 | for j in 0..d-1 { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 294 | for (j, ) in multin.iter_mut().enumerate().take(d-1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 314 | need!(n > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 324 | need!(df >= 1.0); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | need!(nonc > 0.0); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 334 | need!(dfnum > 1.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 335 | need!(dfden > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 336 | need!(nonc >= 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 348 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 357 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 366 | need!(lam > 0.0); [INFO] [stderr] | ----------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 367 | need!(lam <= 9.2233720064847708e+18); // from mtrand.pyx [INFO] [stderr] | ------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/dist.rs:367:18 [INFO] [stderr] | [INFO] [stderr] 367 | need!(lam <= 9.2233720064847708e+18); // from mtrand.pyx [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `9.223_372_006_484_771e18` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 376 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 385 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 394 | need!(shape > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 403 | need!(df > 0.0); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 412 | need!(left < right); [INFO] [stderr] | -------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 440 | need!(kappa > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 449 | need!(mean > 0.0); [INFO] [stderr] | ------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 450 | need!(scale > 0.0); [INFO] [stderr] | ------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 459 | need!(a > 0.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/dist.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | if !($dom) { return Err($err); } [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 468 | need!(a > 1.0); [INFO] [stderr] | --------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:26 [INFO] [stderr] | [INFO] [stderr] 90 | ffi::rk_seed(seed as c_ulong, &mut r.state); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(seed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.89s [INFO] running `"docker" "inspect" "022e3b522adb018b5f6d91b505b150547e529cab797e89b7c1a7c17f0274311a"` [INFO] running `"docker" "rm" "-f" "022e3b522adb018b5f6d91b505b150547e529cab797e89b7c1a7c17f0274311a"` [INFO] [stdout] 022e3b522adb018b5f6d91b505b150547e529cab797e89b7c1a7c17f0274311a