[INFO] crate random_color 0.4.4 is already in cache
[INFO] extracting crate random_color 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/random_color/0.4.4
[INFO] extracting crate random_color 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/random_color/0.4.4
[INFO] validating manifest of random_color-0.4.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of random_color-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing random_color-0.4.4
[INFO] finished frobbing random_color-0.4.4
[INFO] frobbed toml for random_color-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/random_color/0.4.4/Cargo.toml
[INFO] started frobbing random_color-0.4.4
[INFO] finished frobbing random_color-0.4.4
[INFO] frobbed toml for random_color-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/random_color/0.4.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting random_color-0.4.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/random_color/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e1f684ca0eef87b1e86b437ea24ca94c372a49afe366d7959f2887e54efa9228
[INFO] running `"docker" "start" "-a" "e1f684ca0eef87b1e86b437ea24ca94c372a49afe366d7959f2887e54efa9228"`
[INFO] [stderr]     Checking random_color v0.4.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             range: range,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             lower_bounds: lower_bounds,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_bounds`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             saturation_range: saturation_range,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `saturation_range`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             value_range: value_range,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_range`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:162:17
[INFO] [stderr]     |
[INFO] [stderr] 162 |         let [r, g, b] = self.hsv_to_rgb(h, s, b);
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:247:13
[INFO] [stderr]     |
[INFO] [stderr] 247 |         let p = v * (1.0 - s);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:248:13
[INFO] [stderr]     |
[INFO] [stderr] 248 |         let q = v * (1.0 - f * s);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:249:13
[INFO] [stderr]     |
[INFO] [stderr] 249 |         let t = v * (1.0 - (1.0 - f) * s);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:251:14
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let (r, g, b) = match h_i as i64 {
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:251:17
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let (r, g, b) = match h_i as i64 {
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 10th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:251:20
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let (r, g, b) = match h_i as i64 {
[INFO] [stderr]     |                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |             range: range,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `range`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |             lower_bounds: lower_bounds,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lower_bounds`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |             saturation_range: saturation_range,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `saturation_range`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/color_dictionary.rs:26:13
[INFO] [stderr]    |
[INFO] [stderr] 26 |             value_range: value_range,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `value_range`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:162:17
[INFO] [stderr]     |
[INFO] [stderr] 162 |         let [r, g, b] = self.hsv_to_rgb(h, s, b);
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:247:13
[INFO] [stderr]     |
[INFO] [stderr] 247 |         let p = v * (1.0 - s);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:248:13
[INFO] [stderr]     |
[INFO] [stderr] 248 |         let q = v * (1.0 - f * s);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:249:13
[INFO] [stderr]     |
[INFO] [stderr] 249 |         let t = v * (1.0 - (1.0 - f) * s);
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 8th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:251:14
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let (r, g, b) = match h_i as i64 {
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 9th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:251:17
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let (r, g, b) = match h_i as i64 {
[INFO] [stderr]     |                 ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 10th binding whose name is just one char
[INFO] [stderr]    --> src/lib.rs:251:20
[INFO] [stderr]     |
[INFO] [stderr] 251 |         let (r, g, b) = match h_i as i64 {
[INFO] [stderr]     |                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:225:52
[INFO] [stderr]     |
[INFO] [stderr] 225 |                 let seed = (seed * 9301 + 49297) % 233280;
[INFO] [stderr]     |                                                    ^^^^^^ help: consider: `233_280`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:226:38
[INFO] [stderr]     |
[INFO] [stderr] 226 |                 let mut rnd = seed / 233280;
[INFO] [stderr]     |                                      ^^^^^^ help: consider: `233_280`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:225:52
[INFO] [stderr]     |
[INFO] [stderr] 225 |                 let seed = (seed * 9301 + 49297) % 233280;
[INFO] [stderr]     |                                                    ^^^^^^ help: consider: `233_280`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/lib.rs:226:38
[INFO] [stderr]     |
[INFO] [stderr] 226 |                 let mut rnd = seed / 233280;
[INFO] [stderr]     |                                      ^^^^^^ help: consider: `233_280`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/color_dictionary.rs:29:42
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn has_between_range(&self, hue: &i64) -> bool {
[INFO] [stderr]    |                                          ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/color_dictionary.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         hue >= &self.range[0] && hue <= &self.range[1]
[INFO] [stderr]    |         ^^^^^^^--------------
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the right value directly: `self.range[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/color_dictionary.rs:30:34
[INFO] [stderr]    |
[INFO] [stderr] 30 |         hue >= &self.range[0] && hue <= &self.range[1]
[INFO] [stderr]    |                                  ^^^^^^^--------------
[INFO] [stderr]    |                                         |
[INFO] [stderr]    |                                         help: use the right value directly: `self.range[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:143:44
[INFO] [stderr]     |
[INFO] [stderr] 143 |     pub fn get_saturation_range(self, hue: &i64) -> (i64, i64) {
[INFO] [stderr]     |                                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:148:41
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn get_minimum_value(self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                         ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:148:59
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn get_minimum_value(self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                                           ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/color_dictionary.rs:158:16
[INFO] [stderr]     |
[INFO] [stderr] 158 |             if saturation >= &s1 && saturation <= &s2 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^---
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: use the right value directly: `s1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/color_dictionary.rs:158:37
[INFO] [stderr]     |
[INFO] [stderr] 158 |             if saturation >= &s1 && saturation <= &s2 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^---
[INFO] [stderr]     |                                                   |
[INFO] [stderr]     |                                                   help: use the right value directly: `s2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:169:33
[INFO] [stderr]     |
[INFO] [stderr] 169 |     pub fn get_color(self, hue: &i64) -> ColorInformation {
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RandomColor`
[INFO] [stderr]   --> src/lib.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn new() -> RandomColor {
[INFO] [stderr] 56 | |         RandomColor {
[INFO] [stderr] 57 | |             hue: None,
[INFO] [stderr] 58 | |             luminosity: None,
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |         }
[INFO] [stderr] 62 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 43 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:181:36
[INFO] [stderr]     |
[INFO] [stderr] 181 |     fn pick_saturation(&self, hue: &i64) -> i64 {
[INFO] [stderr]     |                                    ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:197:36
[INFO] [stderr]     |
[INFO] [stderr] 197 |     fn pick_brightness(&self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                    ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:197:54
[INFO] [stderr]     |
[INFO] [stderr] 197 |     fn pick_brightness(&self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                                      ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |             max = max +  1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `max += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/color_dictionary.rs:29:42
[INFO] [stderr]    |
[INFO] [stderr] 29 |     pub fn has_between_range(&self, hue: &i64) -> bool {
[INFO] [stderr]    |                                          ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/color_dictionary.rs:30:9
[INFO] [stderr]    |
[INFO] [stderr] 30 |         hue >= &self.range[0] && hue <= &self.range[1]
[INFO] [stderr]    |         ^^^^^^^--------------
[INFO] [stderr]    |                |
[INFO] [stderr]    |                help: use the right value directly: `self.range[0]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/color_dictionary.rs:30:34
[INFO] [stderr]    |
[INFO] [stderr] 30 |         hue >= &self.range[0] && hue <= &self.range[1]
[INFO] [stderr]    |                                  ^^^^^^^--------------
[INFO] [stderr]    |                                         |
[INFO] [stderr]    |                                         help: use the right value directly: `self.range[1]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:143:44
[INFO] [stderr]     |
[INFO] [stderr] 143 |     pub fn get_saturation_range(self, hue: &i64) -> (i64, i64) {
[INFO] [stderr]     |                                            ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:148:41
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn get_minimum_value(self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                         ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:148:59
[INFO] [stderr]     |
[INFO] [stderr] 148 |     pub fn get_minimum_value(self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                                           ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/color_dictionary.rs:158:16
[INFO] [stderr]     |
[INFO] [stderr] 158 |             if saturation >= &s1 && saturation <= &s2 {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^---
[INFO] [stderr]     |                              |
[INFO] [stderr]     |                              help: use the right value directly: `s1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/color_dictionary.rs:158:37
[INFO] [stderr]     |
[INFO] [stderr] 158 |             if saturation >= &s1 && saturation <= &s2 {
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^---
[INFO] [stderr]     |                                                   |
[INFO] [stderr]     |                                                   help: use the right value directly: `s2`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/color_dictionary.rs:169:33
[INFO] [stderr]     |
[INFO] [stderr] 169 |     pub fn get_color(self, hue: &i64) -> ColorInformation {
[INFO] [stderr]     |                                 ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `RandomColor`
[INFO] [stderr]   --> src/lib.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 | /     pub fn new() -> RandomColor {
[INFO] [stderr] 56 | |         RandomColor {
[INFO] [stderr] 57 | |             hue: None,
[INFO] [stderr] 58 | |             luminosity: None,
[INFO] [stderr] ...  |
[INFO] [stderr] 61 | |         }
[INFO] [stderr] 62 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 43 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:181:36
[INFO] [stderr]     |
[INFO] [stderr] 181 |     fn pick_saturation(&self, hue: &i64) -> i64 {
[INFO] [stderr]     |                                    ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:197:36
[INFO] [stderr]     |
[INFO] [stderr] 197 |     fn pick_brightness(&self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                    ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/lib.rs:197:54
[INFO] [stderr]     |
[INFO] [stderr] 197 |     fn pick_brightness(&self, hue: &i64, saturation: &i64) -> i64 {
[INFO] [stderr]     |                                                      ^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/lib.rs:218:13
[INFO] [stderr]     |
[INFO] [stderr] 218 |             max = max +  1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `max += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.12s
[INFO] running `"docker" "inspect" "e1f684ca0eef87b1e86b437ea24ca94c372a49afe366d7959f2887e54efa9228"`
[INFO] running `"docker" "rm" "-f" "e1f684ca0eef87b1e86b437ea24ca94c372a49afe366d7959f2887e54efa9228"`
[INFO] [stdout] e1f684ca0eef87b1e86b437ea24ca94c372a49afe366d7959f2887e54efa9228