[INFO] crate random-pool 0.1.1 is already in cache [INFO] extracting crate random-pool 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/random-pool/0.1.1 [INFO] extracting crate random-pool 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/random-pool/0.1.1 [INFO] validating manifest of random-pool-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of random-pool-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing random-pool-0.1.1 [INFO] finished frobbing random-pool-0.1.1 [INFO] frobbed toml for random-pool-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/random-pool/0.1.1/Cargo.toml [INFO] started frobbing random-pool-0.1.1 [INFO] finished frobbing random-pool-0.1.1 [INFO] frobbed toml for random-pool-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/random-pool/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting random-pool-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/random-pool/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 36ed7e20773cc18b9b7aa73e1b85253eb56739f87162582d96d8812b2d151ff1 [INFO] running `"docker" "start" "-a" "36ed7e20773cc18b9b7aa73e1b85253eb56739f87162582d96d8812b2d151ff1"` [INFO] [stderr] Checking random-pool v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | elements: elements [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | elements: elements [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn try_get<'a>(&'a self) -> Option> { [INFO] [stderr] 63 | | [INFO] [stderr] 64 | | // Randomize the range that can be accessed [INFO] [stderr] 65 | | let mut range: Vec = (0..self.elements.len()).collect(); [INFO] [stderr] ... | [INFO] [stderr] 73 | | None // All caches are occupied [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / if let Some(c) = self.elements[i].try_lock().ok() { [INFO] [stderr] 70 | | return Some(c) // Found a cache that wasn't locked [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(c)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn get<'a>(&'a self) -> MutexGuard<'a, T> { [INFO] [stderr] 84 | | // Randomize the range that can be accessed [INFO] [stderr] 85 | | let mut range: Vec = (0..self.elements.len()).collect(); [INFO] [stderr] 86 | | thread_rng().shuffle(range.as_mut_slice()); [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn try_get<'a>(&'a self) -> Option> { [INFO] [stderr] 63 | | [INFO] [stderr] 64 | | // Randomize the range that can be accessed [INFO] [stderr] 65 | | let mut range: Vec = (0..self.elements.len()).collect(); [INFO] [stderr] ... | [INFO] [stderr] 73 | | None // All caches are occupied [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | / if let Some(c) = self.elements[i].try_lock().ok() { [INFO] [stderr] 70 | | return Some(c) // Found a cache that wasn't locked [INFO] [stderr] 71 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::if_let_some_result)] on by default [INFO] [stderr] = help: Consider matching on `Ok(c)` and removing the call to `ok` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:83:5 [INFO] [stderr] | [INFO] [stderr] 83 | / pub fn get<'a>(&'a self) -> MutexGuard<'a, T> { [INFO] [stderr] 84 | | // Randomize the range that can be accessed [INFO] [stderr] 85 | | let mut range: Vec = (0..self.elements.len()).collect(); [INFO] [stderr] 86 | | thread_rng().shuffle(range.as_mut_slice()); [INFO] [stderr] ... | [INFO] [stderr] 94 | | } [INFO] [stderr] 95 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "36ed7e20773cc18b9b7aa73e1b85253eb56739f87162582d96d8812b2d151ff1"` [INFO] running `"docker" "rm" "-f" "36ed7e20773cc18b9b7aa73e1b85253eb56739f87162582d96d8812b2d151ff1"` [INFO] [stdout] 36ed7e20773cc18b9b7aa73e1b85253eb56739f87162582d96d8812b2d151ff1