[INFO] crate rand_pcg 0.1.1 is already in cache [INFO] extracting crate rand_pcg 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/rand_pcg/0.1.1 [INFO] extracting crate rand_pcg 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rand_pcg/0.1.1 [INFO] validating manifest of rand_pcg-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rand_pcg-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rand_pcg-0.1.1 [INFO] finished frobbing rand_pcg-0.1.1 [INFO] frobbed toml for rand_pcg-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/rand_pcg/0.1.1/Cargo.toml [INFO] started frobbing rand_pcg-0.1.1 [INFO] finished frobbing rand_pcg-0.1.1 [INFO] frobbed toml for rand_pcg-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rand_pcg/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rand_pcg-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rand_pcg/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 12d10315d98034811deab76c13a78d30d6308d190c14d863d2cf9487a71a084d [INFO] running `"docker" "start" "-a" "12d10315d98034811deab76c13a78d30d6308d190c14d863d2cf9487a71a084d"` [INFO] [stderr] Compiling rand_pcg v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | const MULTIPLIER: u64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | const MULTIPLIER: u128 = 2549297995355413924u128 << 64 | 4865540595714422341; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `2_549_297_995_355_413_924u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:14:58 [INFO] [stderr] | [INFO] [stderr] 14 | const MULTIPLIER: u128 = 2549297995355413924u128 << 64 | 4865540595714422341; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `4_865_540_595_714_422_341` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/pcg64.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | Ok(self.fill_bytes(dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 139 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/pcg128.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | let state = (seed_u64[0] as u128) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(seed_u64[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/pcg128.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | (seed_u64[1] as u128) << 64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(seed_u64[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/pcg128.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | Ok(self.fill_bytes(dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 120 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | const MULTIPLIER: u64 = 6364136223846793005; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_364_136_223_846_793_005` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:153:37 [INFO] [stderr] | [INFO] [stderr] 153 | assert_eq!(rng1.next_u64(), 1204678643940597513); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `1_204_678_643_940_597_513` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:156:37 [INFO] [stderr] | [INFO] [stderr] 156 | assert_eq!(rng2.next_u64(), 12384929573776311845); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `12_384_929_573_776_311_845` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:159:37 [INFO] [stderr] | [INFO] [stderr] 159 | assert_eq!(rng3.next_u64(), 18195738587432868099); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_195_738_587_432_868_099` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:163:37 [INFO] [stderr] | [INFO] [stderr] 163 | assert_eq!(rng4.next_u64(), 18195738587432868099); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_195_738_587_432_868_099` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:173:35 [INFO] [stderr] | [INFO] [stderr] 173 | let expected: [u32; 6] = [0xa15c02b7, 0x7b47f409, 0xba1d3330, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa15c_02b7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:173:47 [INFO] [stderr] | [INFO] [stderr] 173 | let expected: [u32; 6] = [0xa15c02b7, 0x7b47f409, 0xba1d3330, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x7b47_f409` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:173:59 [INFO] [stderr] | [INFO] [stderr] 173 | let expected: [u32; 6] = [0xa15c02b7, 0x7b47f409, 0xba1d3330, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xba1d_3330` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | 0x83d2f293, 0xbfa4784b, 0xcbed606e]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x83d2_f293` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | 0x83d2f293, 0xbfa4784b, 0xcbed606e]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xbfa4_784b` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg64.rs:174:37 [INFO] [stderr] | [INFO] [stderr] 174 | 0x83d2f293, 0xbfa4784b, 0xcbed606e]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcbed_606e` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | const MULTIPLIER: u128 = 2549297995355413924u128 << 64 | 4865540595714422341; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `2_549_297_995_355_413_924u128` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:14:58 [INFO] [stderr] | [INFO] [stderr] 14 | const MULTIPLIER: u128 = 2549297995355413924u128 << 64 | 4865540595714422341; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `4_865_540_595_714_422_341` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:134:37 [INFO] [stderr] | [INFO] [stderr] 134 | assert_eq!(rng1.next_u64(), 7071994460355047496); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `7_071_994_460_355_047_496` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:137:37 [INFO] [stderr] | [INFO] [stderr] 137 | assert_eq!(rng2.next_u64(), 12300796107712034932); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `12_300_796_107_712_034_932` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:140:37 [INFO] [stderr] | [INFO] [stderr] 140 | assert_eq!(rng3.next_u64(), 6198063878555692194); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_198_063_878_555_692_194` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:144:37 [INFO] [stderr] | [INFO] [stderr] 144 | assert_eq!(rng4.next_u64(), 6198063878555692194); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `6_198_063_878_555_692_194` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:154:35 [INFO] [stderr] | [INFO] [stderr] 154 | let expected: [u64; 6] = [0x63b4a3a813ce700a, 0x382954200617ab24, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x63b4_a3a8_13ce_700a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:154:55 [INFO] [stderr] | [INFO] [stderr] 154 | let expected: [u64; 6] = [0x63b4a3a813ce700a, 0x382954200617ab24, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x3829_5420_0617_ab24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | 0xa7fd85ae3fe950ce, 0xd715286aa2887737, 0x60c92fee2e59f32c, 0x84c4e96beff30017]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa7fd_85ae_3fe9_50ce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:155:33 [INFO] [stderr] | [INFO] [stderr] 155 | 0xa7fd85ae3fe950ce, 0xd715286aa2887737, 0x60c92fee2e59f32c, 0x84c4e96beff30017]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xd715_286a_a288_7737` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:155:53 [INFO] [stderr] | [INFO] [stderr] 155 | 0xa7fd85ae3fe950ce, 0xd715286aa2887737, 0x60c92fee2e59f32c, 0x84c4e96beff30017]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x60c9_2fee_2e59_f32c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/pcg128.rs:155:73 [INFO] [stderr] | [INFO] [stderr] 155 | 0xa7fd85ae3fe950ce, 0xd715286aa2887737, 0x60c92fee2e59f32c, 0x84c4e96beff30017]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x84c4_e96b_eff3_0017` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/pcg64.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | Ok(self.fill_bytes(dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 139 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/pcg128.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | let state = (seed_u64[0] as u128) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(seed_u64[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/pcg128.rs:70:21 [INFO] [stderr] | [INFO] [stderr] 70 | (seed_u64[1] as u128) << 64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(seed_u64[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/pcg128.rs:120:12 [INFO] [stderr] | [INFO] [stderr] 120 | Ok(self.fill_bytes(dest)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 120 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.73s [INFO] running `"docker" "inspect" "12d10315d98034811deab76c13a78d30d6308d190c14d863d2cf9487a71a084d"` [INFO] running `"docker" "rm" "-f" "12d10315d98034811deab76c13a78d30d6308d190c14d863d2cf9487a71a084d"` [INFO] [stdout] 12d10315d98034811deab76c13a78d30d6308d190c14d863d2cf9487a71a084d