[INFO] crate ranagrams 0.2.2 is already in cache [INFO] extracting crate ranagrams 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/ranagrams/0.2.2 [INFO] extracting crate ranagrams 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ranagrams/0.2.2 [INFO] validating manifest of ranagrams-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ranagrams-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ranagrams-0.2.2 [INFO] finished frobbing ranagrams-0.2.2 [INFO] frobbed toml for ranagrams-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/ranagrams/0.2.2/Cargo.toml [INFO] started frobbing ranagrams-0.2.2 [INFO] finished frobbing ranagrams-0.2.2 [INFO] frobbed toml for ranagrams-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ranagrams/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ranagrams-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ranagrams/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 451e472cab22a002c761bf8e83cd669115937966c5ab17252a54ef184fb2b1e3 [INFO] running `"docker" "start" "-a" "451e472cab22a002c761bf8e83cd669115937966c5ab17252a54ef184fb2b1e3"` [INFO] [stderr] Checking mpmc v0.1.5 [INFO] [stderr] Checking ranagrams v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | powers_of_ten: powers_of_ten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `powers_of_ten` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | powers_of_ten: powers_of_ten, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `powers_of_ten` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trie.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | children: children, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `children` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/trie.rs:270:16 [INFO] [stderr] | [INFO] [stderr] 270 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 271 | | if let Some(&Some(ref child)) = self.children.get(word[0]) { [INFO] [stderr] 272 | | child.contains(&word[1..]) [INFO] [stderr] 273 | | } else { [INFO] [stderr] 274 | | false [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 270 | } else if let Some(&Some(ref child)) = self.children.get(word[0]) { [INFO] [stderr] 271 | child.contains(&word[1..]) [INFO] [stderr] 272 | } else { [INFO] [stderr] 273 | false [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return Some(translation); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(translation)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/trie.rs:270:16 [INFO] [stderr] | [INFO] [stderr] 270 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 271 | | if let Some(&Some(ref child)) = self.children.get(word[0]) { [INFO] [stderr] 272 | | child.contains(&word[1..]) [INFO] [stderr] 273 | | } else { [INFO] [stderr] 274 | | false [INFO] [stderr] 275 | | } [INFO] [stderr] 276 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 270 | } else if let Some(&Some(ref child)) = self.children.get(word[0]) { [INFO] [stderr] 271 | child.contains(&word[1..]) [INFO] [stderr] 272 | } else { [INFO] [stderr] 273 | false [INFO] [stderr] 274 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | return Some(translation); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(translation)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | pub cache: RwLock, Arc>, Arc)>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | empty_list: Arc>, Arc)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/trie.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | p = p * 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `p *= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | fn index(key: &[usize], sorted_list: &Arc>, Arc)>>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/trie.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | all_words: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/trie.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | let ref mut mutable = cc.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^-------------- help: try: `let mutable = &mut cc.clone();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:157:10 [INFO] [stderr] | [INFO] [stderr] 157 | ) -> Arc>, Arc)>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/trie.rs:156:20 [INFO] [stderr] | [INFO] [stderr] 156 | all_words: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/trie.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / fn walk( [INFO] [stderr] 203 | | node: &TrieNode, [INFO] [stderr] 204 | | seed: &mut Vec, [INFO] [stderr] 205 | | cc: &CharCount, [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trie.rs:282:18 [INFO] [stderr] | [INFO] [stderr] 282 | s += match c { [INFO] [stderr] | __________________^ [INFO] [stderr] 283 | | &Some(ref t) => { [INFO] [stderr] 284 | | s += size_of::>(); [INFO] [stderr] 285 | | t.size() [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | &None => size_of::>(), [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 282 | s += match *c { [INFO] [stderr] 283 | Some(ref t) => { [INFO] [stderr] 284 | s += size_of::>(); [INFO] [stderr] 285 | t.size() [INFO] [stderr] 286 | } [INFO] [stderr] 287 | None => size_of::>(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/trie.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | s += match c { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/trie.rs:284:21 [INFO] [stderr] | [INFO] [stderr] 284 | s += size_of::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `trie::TrieNodeBuilder` [INFO] [stderr] --> src/trie.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn new() -> TrieNodeBuilder { [INFO] [stderr] 310 | | TrieNodeBuilder { [INFO] [stderr] 311 | | terminal: false, [INFO] [stderr] 312 | | children: vec![], [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 301 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | if c > &0 { [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | accumulator = accumulator + value * p; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accumulator += value * p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:295:27 [INFO] [stderr] | [INFO] [stderr] 295 | pub fn snrt(&self, i: &usize) -> Option<&char> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/factory.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / fn work( [INFO] [stderr] 87 | | i: usize, [INFO] [stderr] 88 | | had: Arc, [INFO] [stderr] 89 | | belt: Arc>>, [INFO] [stderr] ... | [INFO] [stderr] 165 | | }).unwrap(); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/factory.rs:103:35 [INFO] [stderr] | [INFO] [stderr] 103 | let bob = Builder::new().name(format!("{}", i).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{}", i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/factory.rs:138:36 [INFO] [stderr] | [INFO] [stderr] 138 | if widgets.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!widgets.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/factory.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | let foo = workers.lock().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/factory.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let foo = workers.lock().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | pub cache: RwLock, Arc>, Arc)>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | empty_list: Arc>, Arc)>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/trie.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | p = p * 10; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `p *= 10` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:79:42 [INFO] [stderr] | [INFO] [stderr] 79 | fn index(key: &[usize], sorted_list: &Arc>, Arc)>>) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/trie.rs:114:20 [INFO] [stderr] | [INFO] [stderr] 114 | all_words: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/trie.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | let ref mut mutable = cc.clone(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^-------------- help: try: `let mutable = &mut cc.clone();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/trie.rs:157:10 [INFO] [stderr] | [INFO] [stderr] 157 | ) -> Arc>, Arc)>> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/trie.rs:156:20 [INFO] [stderr] | [INFO] [stderr] 156 | all_words: &bool, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/trie.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / fn walk( [INFO] [stderr] 203 | | node: &TrieNode, [INFO] [stderr] 204 | | seed: &mut Vec, [INFO] [stderr] 205 | | cc: &CharCount, [INFO] [stderr] ... | [INFO] [stderr] 253 | | } [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/trie.rs:282:18 [INFO] [stderr] | [INFO] [stderr] 282 | s += match c { [INFO] [stderr] | __________________^ [INFO] [stderr] 283 | | &Some(ref t) => { [INFO] [stderr] 284 | | s += size_of::>(); [INFO] [stderr] 285 | | t.size() [INFO] [stderr] 286 | | } [INFO] [stderr] 287 | | &None => size_of::>(), [INFO] [stderr] 288 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 282 | s += match *c { [INFO] [stderr] 283 | Some(ref t) => { [INFO] [stderr] 284 | s += size_of::>(); [INFO] [stderr] 285 | t.size() [INFO] [stderr] 286 | } [INFO] [stderr] 287 | None => size_of::>(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/trie.rs:282:13 [INFO] [stderr] | [INFO] [stderr] 282 | s += match c { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/trie.rs:284:21 [INFO] [stderr] | [INFO] [stderr] 284 | s += size_of::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `trie::TrieNodeBuilder` [INFO] [stderr] --> src/trie.rs:309:5 [INFO] [stderr] | [INFO] [stderr] 309 | / pub fn new() -> TrieNodeBuilder { [INFO] [stderr] 310 | | TrieNodeBuilder { [INFO] [stderr] 311 | | terminal: false, [INFO] [stderr] 312 | | children: vec![], [INFO] [stderr] 313 | | } [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 301 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/util.rs:129:20 [INFO] [stderr] | [INFO] [stderr] 129 | if c > &0 { [INFO] [stderr] | ^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/util.rs:132:21 [INFO] [stderr] | [INFO] [stderr] 132 | accumulator = accumulator + value * p; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `accumulator += value * p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/util.rs:295:27 [INFO] [stderr] | [INFO] [stderr] 295 | pub fn snrt(&self, i: &usize) -> Option<&char> { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/factory.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | / fn work( [INFO] [stderr] 87 | | i: usize, [INFO] [stderr] 88 | | had: Arc, [INFO] [stderr] 89 | | belt: Arc>>, [INFO] [stderr] ... | [INFO] [stderr] 165 | | }).unwrap(); [INFO] [stderr] 166 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/factory.rs:103:35 [INFO] [stderr] | [INFO] [stderr] 103 | let bob = Builder::new().name(format!("{}", i).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("{}", i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/factory.rs:138:36 [INFO] [stderr] | [INFO] [stderr] 138 | if widgets.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!widgets.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/factory.rs:184:21 [INFO] [stderr] | [INFO] [stderr] 184 | let foo = workers.lock().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/factory.rs:193:21 [INFO] [stderr] | [INFO] [stderr] 193 | let foo = workers.lock().unwrap(); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | let default_dir = if let Some(mut buf) = std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/main.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn main() { [INFO] [stderr] 21 | | // parse the options [INFO] [stderr] 22 | | let cpus = num_cpus::get().to_string(); [INFO] [stderr] 23 | | let default_dir = if let Some(mut buf) = std::env::home_dir() { [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | / match file.read_to_string(&mut strings) { [INFO] [stderr] 235 | | Err(why) => { [INFO] [stderr] 236 | | eprintln!( [INFO] [stderr] 237 | | "could not read words from dictionary: {}\n\n{}", [INFO] [stderr] ... | [INFO] [stderr] 243 | | Ok(_) => (), [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 234 | if let Err(why) = file.read_to_string(&mut strings) { [INFO] [stderr] 235 | eprintln!( [INFO] [stderr] 236 | "could not read words from dictionary: {}\n\n{}", [INFO] [stderr] 237 | why, [INFO] [stderr] 238 | opts.usage() [INFO] [stderr] 239 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:249:49 [INFO] [stderr] | [INFO] [stderr] 249 | let translator = Translator::new(normalize, words.iter().map(|s| *s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `words.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:23:46 [INFO] [stderr] | [INFO] [stderr] 23 | let default_dir = if let Some(mut buf) = std::env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/main.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn main() { [INFO] [stderr] 21 | | // parse the options [INFO] [stderr] 22 | | let cpus = num_cpus::get().to_string(); [INFO] [stderr] 23 | | let default_dir = if let Some(mut buf) = std::env::home_dir() { [INFO] [stderr] ... | [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | / match file.read_to_string(&mut strings) { [INFO] [stderr] 235 | | Err(why) => { [INFO] [stderr] 236 | | eprintln!( [INFO] [stderr] 237 | | "could not read words from dictionary: {}\n\n{}", [INFO] [stderr] ... | [INFO] [stderr] 243 | | Ok(_) => (), [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 234 | if let Err(why) = file.read_to_string(&mut strings) { [INFO] [stderr] 235 | eprintln!( [INFO] [stderr] 236 | "could not read words from dictionary: {}\n\n{}", [INFO] [stderr] 237 | why, [INFO] [stderr] 238 | opts.usage() [INFO] [stderr] 239 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:249:49 [INFO] [stderr] | [INFO] [stderr] 249 | let translator = Translator::new(normalize, words.iter().map(|s| *s)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `words.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.24s [INFO] running `"docker" "inspect" "451e472cab22a002c761bf8e83cd669115937966c5ab17252a54ef184fb2b1e3"` [INFO] running `"docker" "rm" "-f" "451e472cab22a002c761bf8e83cd669115937966c5ab17252a54ef184fb2b1e3"` [INFO] [stdout] 451e472cab22a002c761bf8e83cd669115937966c5ab17252a54ef184fb2b1e3