[INFO] crate rainbow 0.0.0 is already in cache [INFO] extracting crate rainbow 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/rainbow/0.0.0 [INFO] extracting crate rainbow 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rainbow/0.0.0 [INFO] validating manifest of rainbow-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rainbow-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rainbow-0.0.0 [INFO] finished frobbing rainbow-0.0.0 [INFO] frobbed toml for rainbow-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/rainbow/0.0.0/Cargo.toml [INFO] started frobbing rainbow-0.0.0 [INFO] finished frobbing rainbow-0.0.0 [INFO] frobbed toml for rainbow-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rainbow/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rainbow-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rainbow/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef665565cb1e80db5ec8d69a6def50bc4087da43b06236024fecaaa5c2b39399 [INFO] running `"docker" "start" "-a" "ef665565cb1e80db5ec8d69a6def50bc4087da43b06236024fecaaa5c2b39399"` [INFO] [stderr] Checking rainbow v0.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / return RGBA { [INFO] [stderr] 58 | | red: r, [INFO] [stderr] 59 | | green: g, [INFO] [stderr] 60 | | blue: b, [INFO] [stderr] 61 | | alpha: a, [INFO] [stderr] 62 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | RGBA { [INFO] [stderr] 58 | red: r, [INFO] [stderr] 59 | green: g, [INFO] [stderr] 60 | blue: b, [INFO] [stderr] 61 | alpha: a, [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return (red, green, blue, alpha); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(red, green, blue, alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return (self.red, self.green, self.blue, self.alpha); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.red, self.green, self.blue, self.alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / return RGB { [INFO] [stderr] 89 | | red: r, [INFO] [stderr] 90 | | green: g, [INFO] [stderr] 91 | | blue: b, [INFO] [stderr] 92 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 88 | RGB { [INFO] [stderr] 89 | red: r, [INFO] [stderr] 90 | green: g, [INFO] [stderr] 91 | blue: b, [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(RGB::new(red, green, blue)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RGB::new(red, green, blue))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return Some(16 * first_byte + second_byte); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(16 * first_byte + second_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return (red, green, blue, alpha); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(red, green, blue, alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return (self.red, self.green, self.blue, 255); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.red, self.green, self.blue, 255)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let red = self.red as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | let green = self.green as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | let blue = self.blue as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | let alpha = self.alpha as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | let red = self.red as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | let green = self.green as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | let blue = self.blue as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | / return RGBA { [INFO] [stderr] 58 | | red: r, [INFO] [stderr] 59 | | green: g, [INFO] [stderr] 60 | | blue: b, [INFO] [stderr] 61 | | alpha: a, [INFO] [stderr] 62 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 57 | RGBA { [INFO] [stderr] 58 | red: r, [INFO] [stderr] 59 | green: g, [INFO] [stderr] 60 | blue: b, [INFO] [stderr] 61 | alpha: a, [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:72:9 [INFO] [stderr] | [INFO] [stderr] 72 | return (red, green, blue, alpha); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(red, green, blue, alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | return (self.red, self.green, self.blue, self.alpha); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.red, self.green, self.blue, self.alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / return RGB { [INFO] [stderr] 89 | | red: r, [INFO] [stderr] 90 | | green: g, [INFO] [stderr] 91 | | blue: b, [INFO] [stderr] 92 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 88 | RGB { [INFO] [stderr] 89 | red: r, [INFO] [stderr] 90 | green: g, [INFO] [stderr] 91 | blue: b, [INFO] [stderr] 92 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | return Ok(RGB::new(red, green, blue)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RGB::new(red, green, blue))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return Some(16 * first_byte + second_byte); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(16 * first_byte + second_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | return (red, green, blue, alpha); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(red, green, blue, alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:145:9 [INFO] [stderr] | [INFO] [stderr] 145 | return (self.red, self.green, self.blue, 255); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.red, self.green, self.blue, 255)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let red = self.red as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | let green = self.green as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | let blue = self.blue as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:71:21 [INFO] [stderr] | [INFO] [stderr] 71 | let alpha = self.alpha as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.alpha)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:19 [INFO] [stderr] | [INFO] [stderr] 138 | let red = self.red as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(self.red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:21 [INFO] [stderr] | [INFO] [stderr] 139 | let green = self.green as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:140:20 [INFO] [stderr] | [INFO] [stderr] 140 | let blue = self.blue as f32 / 255.0f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(self.blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.74s [INFO] running `"docker" "inspect" "ef665565cb1e80db5ec8d69a6def50bc4087da43b06236024fecaaa5c2b39399"` [INFO] running `"docker" "rm" "-f" "ef665565cb1e80db5ec8d69a6def50bc4087da43b06236024fecaaa5c2b39399"` [INFO] [stdout] ef665565cb1e80db5ec8d69a6def50bc4087da43b06236024fecaaa5c2b39399