[INFO] crate radix-router 0.1.2 is already in cache [INFO] extracting crate radix-router 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/radix-router/0.1.2 [INFO] extracting crate radix-router 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radix-router/0.1.2 [INFO] validating manifest of radix-router-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of radix-router-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing radix-router-0.1.2 [INFO] finished frobbing radix-router-0.1.2 [INFO] frobbed toml for radix-router-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/radix-router/0.1.2/Cargo.toml [INFO] started frobbing radix-router-0.1.2 [INFO] finished frobbing radix-router-0.1.2 [INFO] frobbed toml for radix-router-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radix-router/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting radix-router-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/radix-router/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4313be907e5a0fdeb370547182a6aa3d79e4cb7dbd8fe91743a9bb33aa3bb142 [INFO] running `"docker" "start" "-a" "4313be907e5a0fdeb370547182a6aa3d79e4cb7dbd8fe91743a9bb33aa3bb142"` [INFO] [stderr] Checking radix-router v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router.rs:381:16 [INFO] [stderr] | [INFO] [stderr] 381 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 382 | | if self.handle_method_not_allowed { [INFO] [stderr] 383 | | let allow = self.allowed(req.uri().path(), req.method().as_str()); [INFO] [stderr] 384 | | [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 381 | } else if self.handle_method_not_allowed { [INFO] [stderr] 382 | let allow = self.allowed(req.uri().path(), req.method().as_str()); [INFO] [stderr] 383 | [INFO] [stderr] 384 | if allow.len() > 0 { [INFO] [stderr] 385 | let mut response = Response::builder() [INFO] [stderr] 386 | .header("Allow", allow.as_str()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:512:9 [INFO] [stderr] | [INFO] [stderr] 512 | return (None, p, tsr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, p, tsr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:557:17 [INFO] [stderr] | [INFO] [stderr] 557 | return (None, p, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, p, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:571:17 [INFO] [stderr] | [INFO] [stderr] 571 | return (self.handle.as_ref(), p, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.handle.as_ref(), p, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:820:17 [INFO] [stderr] | [INFO] [stderr] 820 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:824:17 [INFO] [stderr] | [INFO] [stderr] 824 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:813:24 [INFO] [stderr] | [INFO] [stderr] 813 | } else if fix_trailing_slash && self.children.len() == 1 { [INFO] [stderr] | ________________________^ [INFO] [stderr] 814 | | if self.children[0].path == [b'/'] && self.children[0].handle.is_some() { [INFO] [stderr] 815 | | ci_path.push(b'/'); [INFO] [stderr] 816 | | return true; [INFO] [stderr] 817 | | } [INFO] [stderr] 818 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 813 | } else if fix_trailing_slash && self.children.len() == 1 && self.children[0].path == [b'/'] && self.children[0].handle.is_some() { [INFO] [stderr] 814 | ci_path.push(b'/'); [INFO] [stderr] 815 | return true; [INFO] [stderr] 816 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/router.rs:381:16 [INFO] [stderr] | [INFO] [stderr] 381 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 382 | | if self.handle_method_not_allowed { [INFO] [stderr] 383 | | let allow = self.allowed(req.uri().path(), req.method().as_str()); [INFO] [stderr] 384 | | [INFO] [stderr] ... | [INFO] [stderr] 400 | | } [INFO] [stderr] 401 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 381 | } else if self.handle_method_not_allowed { [INFO] [stderr] 382 | let allow = self.allowed(req.uri().path(), req.method().as_str()); [INFO] [stderr] 383 | [INFO] [stderr] 384 | if allow.len() > 0 { [INFO] [stderr] 385 | let mut response = Response::builder() [INFO] [stderr] 386 | .header("Allow", allow.as_str()) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:512:9 [INFO] [stderr] | [INFO] [stderr] 512 | return (None, p, tsr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, p, tsr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:557:17 [INFO] [stderr] | [INFO] [stderr] 557 | return (None, p, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(None, p, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:571:17 [INFO] [stderr] | [INFO] [stderr] 571 | return (self.handle.as_ref(), p, false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.handle.as_ref(), p, false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:820:17 [INFO] [stderr] | [INFO] [stderr] 820 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tree.rs:824:17 [INFO] [stderr] | [INFO] [stderr] 824 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/tree.rs:813:24 [INFO] [stderr] | [INFO] [stderr] 813 | } else if fix_trailing_slash && self.children.len() == 1 { [INFO] [stderr] | ________________________^ [INFO] [stderr] 814 | | if self.children[0].path == [b'/'] && self.children[0].handle.is_some() { [INFO] [stderr] 815 | | ci_path.push(b'/'); [INFO] [stderr] 816 | | return true; [INFO] [stderr] 817 | | } [INFO] [stderr] 818 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 813 | } else if fix_trailing_slash && self.children.len() == 1 && self.children[0].path == [b'/'] && self.children[0].handle.is_some() { [INFO] [stderr] 814 | ci_path.push(b'/'); [INFO] [stderr] 815 | return true; [INFO] [stderr] 816 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | if !p.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | let mut trailing = n > 1 && p.ends_with("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::Params` [INFO] [stderr] --> src/router.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> Params { [INFO] [stderr] 81 | | Params(Vec::new()) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | / pub fn new() -> Router { [INFO] [stderr] 160 | | Router { [INFO] [stderr] 161 | | trees: BTreeMap::new(), [INFO] [stderr] 162 | | redirect_trailing_slash: true, [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router.rs:230:30 [INFO] [stderr] | [INFO] [stderr] 230 | if !path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router.rs:236:14 [INFO] [stderr] | [INFO] [stderr] 236 | .or_insert(Node::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/router.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | self.trees.get(method).map(|tree| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 276 | || let (handle, _, _) = tree.get_value(path); [INFO] [stderr] 277 | || [INFO] [stderr] 278 | || if handle.is_some() { [INFO] [stderr] ... || [INFO] [stderr] 285 | || } [INFO] [stderr] 286 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(tree) = self.trees.get(method) { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:290:12 [INFO] [stderr] | [INFO] [stderr] 290 | if allow.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!allow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router.rs:325:23 [INFO] [stderr] | [INFO] [stderr] 325 | } else if req.method() != &Method::CONNECT && req.uri().path() != "/" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Method::CONNECT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router.rs:326:31 [INFO] [stderr] | [INFO] [stderr] 326 | let code = if req.method() != &Method::GET { [INFO] [stderr] | ^^^^^^^^^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Method::GET` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router.rs:335:92 [INFO] [stderr] | [INFO] [stderr] 335 | let path = if req.uri().path().len() > 1 && req.uri().path().ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router.rs:371:12 [INFO] [stderr] | [INFO] [stderr] 371 | if req.method() == &Method::OPTIONS && self.handle_options { [INFO] [stderr] | ^^^^^^^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Method::OPTIONS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:373:16 [INFO] [stderr] | [INFO] [stderr] 373 | if allow.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!allow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:385:20 [INFO] [stderr] | [INFO] [stderr] 385 | if allow.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!allow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tree::Node` [INFO] [stderr] --> src/tree.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Node { [INFO] [stderr] 49 | | Node { [INFO] [stderr] 50 | | path: Vec::new(), [INFO] [stderr] 51 | | wild_child: false, [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for tree::Node { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tree.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | &self.indices[pos..pos + 1], // the index char we move [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `pos..=pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/tree.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let full_path = path.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 90 | let full_path = &(*path).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 90 | let full_path = &str::clone(path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if self.path.len() > 0 || self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | if self.path.len() > 0 || self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | fn is_wild_child(&mut self, mut num_params: u8, path: &[u8], full_path: &str, handle: T) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | / str::from_utf8(path) [INFO] [stderr] 244 | | .unwrap() [INFO] [stderr] 245 | | .splitn(2, '/') [INFO] [stderr] 246 | | .into_iter() [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 243 | str::from_utf8(path) [INFO] [stderr] 244 | .unwrap() [INFO] [stderr] 245 | .splitn(2, '/') [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:303:16 [INFO] [stderr] | [INFO] [stderr] 303 | if self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:387:20 [INFO] [stderr] | [INFO] [stderr] 387 | if self.path.len() > 0 && self.path[self.path.len() - 1] == b'/' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:537:24 [INFO] [stderr] | [INFO] [stderr] 537 | if self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/tree.rs:553:31 [INFO] [stderr] | [INFO] [stderr] 553 | let tsr = self.children[0].path == &[b'/'] && self.children[0].handle.is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[b'/']` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:612:17 [INFO] [stderr] | [INFO] [stderr] 612 | && (lo_n_path.len() == 0 || lo_path[1..lo_n_path.len()] == lo_n_path[1..]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lo_n_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:619:16 [INFO] [stderr] | [INFO] [stderr] 619 | if path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/tree.rs:620:30 [INFO] [stderr] | [INFO] [stderr] 620 | let lo_old = lo_path.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 620 | let lo_old = &(*lo_path).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 620 | let lo_old = &[u8]::clone(lo_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:792:24 [INFO] [stderr] | [INFO] [stderr] 792 | if self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `radix-router`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | if !p.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/path.rs:38:45 [INFO] [stderr] | [INFO] [stderr] 38 | let mut trailing = n > 1 && p.ends_with("/"); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::Params` [INFO] [stderr] --> src/router.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn new() -> Params { [INFO] [stderr] 81 | | Params(Vec::new()) [INFO] [stderr] 82 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 67 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `router::Router` [INFO] [stderr] --> src/router.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | / pub fn new() -> Router { [INFO] [stderr] 160 | | Router { [INFO] [stderr] 161 | | trees: BTreeMap::new(), [INFO] [stderr] 162 | | redirect_trailing_slash: true, [INFO] [stderr] ... | [INFO] [stderr] 169 | | } [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 105 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router.rs:230:30 [INFO] [stderr] | [INFO] [stderr] 230 | if !path.starts_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/router.rs:236:14 [INFO] [stderr] | [INFO] [stderr] 236 | .or_insert(Node::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Node::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/router.rs:275:17 [INFO] [stderr] | [INFO] [stderr] 275 | self.trees.get(method).map(|tree| { [INFO] [stderr] | _________________^ [INFO] [stderr] | |_________________| [INFO] [stderr] | || [INFO] [stderr] 276 | || let (handle, _, _) = tree.get_value(path); [INFO] [stderr] 277 | || [INFO] [stderr] 278 | || if handle.is_some() { [INFO] [stderr] ... || [INFO] [stderr] 285 | || } [INFO] [stderr] 286 | || }); [INFO] [stderr] | ||__________________^- help: try this: `if let Some(tree) = self.trees.get(method) { ... }` [INFO] [stderr] | |___________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:290:12 [INFO] [stderr] | [INFO] [stderr] 290 | if allow.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!allow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router.rs:325:23 [INFO] [stderr] | [INFO] [stderr] 325 | } else if req.method() != &Method::CONNECT && req.uri().path() != "/" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Method::CONNECT` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router.rs:326:31 [INFO] [stderr] | [INFO] [stderr] 326 | let code = if req.method() != &Method::GET { [INFO] [stderr] | ^^^^^^^^^^^^^^^^------------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Method::GET` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/router.rs:335:92 [INFO] [stderr] | [INFO] [stderr] 335 | let path = if req.uri().path().len() > 1 && req.uri().path().ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/router.rs:371:12 [INFO] [stderr] | [INFO] [stderr] 371 | if req.method() == &Method::OPTIONS && self.handle_options { [INFO] [stderr] | ^^^^^^^^^^^^^^^^---------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `Method::OPTIONS` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:373:16 [INFO] [stderr] | [INFO] [stderr] 373 | if allow.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!allow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/router.rs:385:20 [INFO] [stderr] | [INFO] [stderr] 385 | if allow.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!allow.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tree::Node` [INFO] [stderr] --> src/tree.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | / pub fn new() -> Node { [INFO] [stderr] 49 | | Node { [INFO] [stderr] 50 | | path: Vec::new(), [INFO] [stderr] 51 | | wild_child: false, [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | impl Default for tree::Node { [INFO] [stderr] 48 | fn default() -> Self { [INFO] [stderr] 49 | Self::new() [INFO] [stderr] 50 | } [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tree.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | &self.indices[pos..pos + 1], // the index char we move [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `pos..=pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/tree.rs:90:25 [INFO] [stderr] | [INFO] [stderr] 90 | let full_path = path.clone(); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 90 | let full_path = &(*path).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 90 | let full_path = &str::clone(path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:96:12 [INFO] [stderr] | [INFO] [stderr] 96 | if self.path.len() > 0 || self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:96:35 [INFO] [stderr] | [INFO] [stderr] 96 | if self.path.len() > 0 || self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tree.rs:219:22 [INFO] [stderr] | [INFO] [stderr] 219 | fn is_wild_child(&mut self, mut num_params: u8, path: &[u8], full_path: &str, handle: T) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/tree.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | / str::from_utf8(path) [INFO] [stderr] 244 | | .unwrap() [INFO] [stderr] 245 | | .splitn(2, '/') [INFO] [stderr] 246 | | .into_iter() [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 243 | str::from_utf8(path) [INFO] [stderr] 244 | .unwrap() [INFO] [stderr] 245 | .splitn(2, '/') [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:303:16 [INFO] [stderr] | [INFO] [stderr] 303 | if self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:387:20 [INFO] [stderr] | [INFO] [stderr] 387 | if self.path.len() > 0 && self.path[self.path.len() - 1] == b'/' { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:537:24 [INFO] [stderr] | [INFO] [stderr] 537 | if self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/tree.rs:553:31 [INFO] [stderr] | [INFO] [stderr] 553 | let tsr = self.children[0].path == &[b'/'] && self.children[0].handle.is_some(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `[b'/']` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:612:17 [INFO] [stderr] | [INFO] [stderr] 612 | && (lo_n_path.len() == 0 || lo_path[1..lo_n_path.len()] == lo_n_path[1..]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lo_n_path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:619:16 [INFO] [stderr] | [INFO] [stderr] 619 | if path.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!path.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/tree.rs:620:30 [INFO] [stderr] | [INFO] [stderr] 620 | let lo_old = lo_path.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 620 | let lo_old = &(*lo_path).clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 620 | let lo_old = &[u8]::clone(lo_path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/tree.rs:792:24 [INFO] [stderr] | [INFO] [stderr] 792 | if self.children.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/tree.rs:977:26 [INFO] [stderr] | [INFO] [stderr] 977 | count_params("/path/:param1/static/*catch-all".as_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"/path/:param1/static/*catch-all"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `radix-router`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4313be907e5a0fdeb370547182a6aa3d79e4cb7dbd8fe91743a9bb33aa3bb142"` [INFO] running `"docker" "rm" "-f" "4313be907e5a0fdeb370547182a6aa3d79e4cb7dbd8fe91743a9bb33aa3bb142"` [INFO] [stdout] 4313be907e5a0fdeb370547182a6aa3d79e4cb7dbd8fe91743a9bb33aa3bb142