[INFO] crate radix-heap 0.3.2 is already in cache [INFO] extracting crate radix-heap 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/radix-heap/0.3.2 [INFO] extracting crate radix-heap 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radix-heap/0.3.2 [INFO] validating manifest of radix-heap-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of radix-heap-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing radix-heap-0.3.2 [INFO] finished frobbing radix-heap-0.3.2 [INFO] frobbed toml for radix-heap-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/radix-heap/0.3.2/Cargo.toml [INFO] started frobbing radix-heap-0.3.2 [INFO] finished frobbing radix-heap-0.3.2 [INFO] frobbed toml for radix-heap-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radix-heap/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting radix-heap-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/radix-heap/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 98d64b2bc5dfc2bf69887c21dcefb4aa2e0d7de571cdd4a7ca72bcc732af7dc9 [INFO] running `"docker" "start" "-a" "98d64b2bc5dfc2bf69887c21dcefb4aa2e0d7de571cdd4a7ca72bcc732af7dc9"` [INFO] [stderr] Checking ieee754 v0.2.6 [INFO] [stderr] Checking radix-heap v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | buckets: (0..K::RADIX_BITS + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=K::RADIX_BITS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | buckets: (0..K::RADIX_BITS + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=K::RADIX_BITS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:628:13 [INFO] [stderr] | [INFO] [stderr] 628 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:659:13 [INFO] [stderr] | [INFO] [stderr] 659 | return TestResult::failed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TestResult::failed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:127:22 [INFO] [stderr] | [INFO] [stderr] 127 | buckets: (0..K::RADIX_BITS + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=K::RADIX_BITS)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:143:22 [INFO] [stderr] | [INFO] [stderr] 143 | buckets: (0..K::RADIX_BITS + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=K::RADIX_BITS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:579:17 [INFO] [stderr] | [INFO] [stderr] 579 | assert!(heap.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `heap.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:598:17 [INFO] [stderr] | [INFO] [stderr] 598 | assert!(heap.len() == 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `heap.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:646:53 [INFO] [stderr] | [INFO] [stderr] 646 | let mut xs: Vec<_> = xs.into_iter().map(|x| NotNaN::from(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NotNaN::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.32s [INFO] running `"docker" "inspect" "98d64b2bc5dfc2bf69887c21dcefb4aa2e0d7de571cdd4a7ca72bcc732af7dc9"` [INFO] running `"docker" "rm" "-f" "98d64b2bc5dfc2bf69887c21dcefb4aa2e0d7de571cdd4a7ca72bcc732af7dc9"` [INFO] [stdout] 98d64b2bc5dfc2bf69887c21dcefb4aa2e0d7de571cdd4a7ca72bcc732af7dc9