[INFO] crate radius-parser 0.1.1 is already in cache [INFO] extracting crate radius-parser 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/radius-parser/0.1.1 [INFO] extracting crate radius-parser 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radius-parser/0.1.1 [INFO] validating manifest of radius-parser-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of radius-parser-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing radius-parser-0.1.1 [INFO] finished frobbing radius-parser-0.1.1 [INFO] frobbed toml for radius-parser-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/radius-parser/0.1.1/Cargo.toml [INFO] started frobbing radius-parser-0.1.1 [INFO] finished frobbing radius-parser-0.1.1 [INFO] frobbed toml for radius-parser-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radius-parser/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting radius-parser-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/radius-parser/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 255c3573fdbd98a276f8e56461bc7daff8c9abad4d7df0a8c1addc7bd0d00ef6 [INFO] running `"docker" "start" "-a" "255c3573fdbd98a276f8e56461bc7daff8c9abad4d7df0a8c1addc7bd0d00ef6"` [INFO] [stderr] Checking radius-parser v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/radius.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn parse_radius_data(i:&[u8]) -> IResult<&[u8],RadiusData> { [INFO] [stderr] 41 | | do_parse!(i, [INFO] [stderr] 42 | | c: be_u8 >> [INFO] [stderr] 43 | | id: be_u8 >> [INFO] [stderr] ... | [INFO] [stderr] 58 | | ) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/radius_attr.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | 5 => map!(i, be_u32, |v| RadiusAttribute::NasPort(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RadiusAttribute::NasPort` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/radius.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn parse_radius_data(i:&[u8]) -> IResult<&[u8],RadiusData> { [INFO] [stderr] 41 | | do_parse!(i, [INFO] [stderr] 42 | | c: be_u8 >> [INFO] [stderr] 43 | | id: be_u8 >> [INFO] [stderr] ... | [INFO] [stderr] 58 | | ) [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/radius_attr.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | 5 => map!(i, be_u32, |v| RadiusAttribute::NasPort(v)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RadiusAttribute::NasPort` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.09s [INFO] running `"docker" "inspect" "255c3573fdbd98a276f8e56461bc7daff8c9abad4d7df0a8c1addc7bd0d00ef6"` [INFO] running `"docker" "rm" "-f" "255c3573fdbd98a276f8e56461bc7daff8c9abad4d7df0a8c1addc7bd0d00ef6"` [INFO] [stdout] 255c3573fdbd98a276f8e56461bc7daff8c9abad4d7df0a8c1addc7bd0d00ef6