[INFO] crate radiancy 0.1.2 is already in cache [INFO] extracting crate radiancy 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/radiancy/0.1.2 [INFO] extracting crate radiancy 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radiancy/0.1.2 [INFO] validating manifest of radiancy-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of radiancy-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing radiancy-0.1.2 [INFO] finished frobbing radiancy-0.1.2 [INFO] frobbed toml for radiancy-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/radiancy/0.1.2/Cargo.toml [INFO] started frobbing radiancy-0.1.2 [INFO] finished frobbing radiancy-0.1.2 [INFO] frobbed toml for radiancy-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/radiancy/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting radiancy-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/radiancy/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f6366f849b526c848a6d558af0af62c41f9198b5fde58c1a100056c1dc6984b8 [INFO] running `"docker" "start" "-a" "f6366f849b526c848a6d558af0af62c41f9198b5fde58c1a100056c1dc6984b8"` [INFO] [stderr] Checking base58 v0.1.0 [INFO] [stderr] Compiling secp256k1 v0.9.2 [INFO] [stderr] Checking args v2.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.7.1 [INFO] [stderr] Checking pagetable v0.0.3 [INFO] [stderr] Checking ripemd160 v0.7.0 [INFO] [stderr] Checking sled_sync v0.2.2 [INFO] [stderr] Checking historian v3.0.11 [INFO] [stderr] Checking pagecache v0.6.0 [INFO] [stderr] Checking sled v0.15.21 [INFO] [stderr] Checking radiancy v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/block.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | transactions: transactions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transactions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/block.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | prev_block_hash: prev_block_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_block_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | tip: tip, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cli/help.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tx/output.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | pubkey_hash: pubkey_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pubkey_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/block.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | transactions: transactions, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transactions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/block.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | prev_block_hash: prev_block_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prev_block_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blockchain/utils.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | tip: tip, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cli/help.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tx/output.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | pubkey_hash: pubkey_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pubkey_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return encode; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return hasher.result().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.result().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return decode.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decode.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return _block; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return new_block(vec![coinbase], Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_block(vec![coinbase], Vec::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return in_ms.to_string().into_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `in_ms.to_string().into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub mod blockchain; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/blockchain.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return bci; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `bci` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/blockchain.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return new_block; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/crypto.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return _tx.verify(_prev_txs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_tx.verify(_prev_txs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/tx.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return Transaction{ id: vec![], vin: vec![], vout: vec![] }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Transaction{ id: vec![], vin: vec![], vout: vec![] }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/tx.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return _utxo; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `_utxo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/iterator.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return (self.clone(), _block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.clone(), _block)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return _new_blockchain; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_new_blockchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub mod pow; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/pow.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return data_camp.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data_camp.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/pow.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return (nonce.to_string().into_bytes(), hash_int.to_bytes_be().1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(nonce.to_string().into_bytes(), hash_int.to_bytes_be().1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/pow.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return is_vaild; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_vaild` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/utils.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return pow; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub mod db; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db/db.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return Tree::start(config).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Tree::start(config).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db/db.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return Tree::start(config).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Tree::start(config).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub mod cli; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub mod tx; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return Transaction { [INFO] [stderr] 34 | | id: _hasher_result, [INFO] [stderr] 35 | | vin: self.vin.to_owned(), [INFO] [stderr] 36 | | vout: self.vout.to_owned() [INFO] [stderr] 37 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Transaction { [INFO] [stderr] 34 | id: _hasher_result, [INFO] [stderr] 35 | vin: self.vin.to_owned(), [INFO] [stderr] 36 | vout: self.vout.to_owned() [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return _tx_copy;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_tx_copy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/input.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return self.signature == unlocking_data.into_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.signature == unlocking_data.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/input.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return locking_hash.eq(&pubkey_hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `locking_hash.eq(&pubkey_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/inputs.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/inputs.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/output.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return self.pubkey_hash.eq(&_pubkey_hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pubkey_hash.eq(&_pubkey_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/output.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return TXOutput{ [INFO] [stderr] 22 | | value: self.value, [INFO] [stderr] 23 | | pubkey_hash: pubkey_hash, [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | TXOutput{ [INFO] [stderr] 22 | value: self.value, [INFO] [stderr] 23 | pubkey_hash: pubkey_hash, [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/output.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return self.pubkey_hash.eq(&_pubkey_hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pubkey_hash.eq(&_pubkey_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/outputs.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/outputs.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utils.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return tx; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utils.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return Some(_tx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(_tx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utxo_set.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return (_accumulated, _unspent_outputs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(_accumulated, _unspent_outputs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utxo_set.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return _utxos; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `_utxos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/account.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return address.into_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `address.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub mod wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return wallets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `wallets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return addresses; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `addresses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return _wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `_wallet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return account; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `account` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return _account; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_account` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return _actual_checksum.eq(&_target_checksum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_actual_checksum.eq(&_target_checksum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return address.into_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `address.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return pubkey_hash[1..20].to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pubkey_hash[1..20].to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return hasher.result().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.result().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return second_sha.result().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `second_sha.result().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | return (_priv_key.to_vec(), _public_key.serialize().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(_priv_key.to_vec(), _public_key.serialize().to_vec())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/wallet/utils.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/wallet/utils.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return encode; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `encode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return hasher.result().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.result().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return decode.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `decode.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return _block; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | return new_block(vec![coinbase], Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_block(vec![coinbase], Vec::new())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/block.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | return in_ms.to_string().into_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `in_ms.to_string().into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | pub mod blockchain; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/blockchain.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return bci; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `bci` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/blockchain.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return new_block; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/crypto.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return _tx.verify(_prev_txs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_tx.verify(_prev_txs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/tx.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return Transaction{ id: vec![], vin: vec![], vout: vec![] }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Transaction{ id: vec![], vin: vec![], vout: vec![] }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/tx.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return _utxo; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `_utxo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/iterator.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return (self.clone(), _block); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.clone(), _block)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/blockchain/utils.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return _new_blockchain; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_new_blockchain` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | pub mod pow; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/pow.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return data_camp.to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data_camp.to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/pow.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | return (nonce.to_string().into_bytes(), hash_int.to_bytes_be().1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(nonce.to_string().into_bytes(), hash_int.to_bytes_be().1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/pow.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | return is_vaild; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_vaild` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/pow/utils.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | return pow; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `pow` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | pub mod db; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db/db.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return Tree::start(config).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Tree::start(config).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/db/db.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return Tree::start(config).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Tree::start(config).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | pub mod cli; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | pub mod tx; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / return Transaction { [INFO] [stderr] 34 | | id: _hasher_result, [INFO] [stderr] 35 | | vin: self.vin.to_owned(), [INFO] [stderr] 36 | | vout: self.vout.to_owned() [INFO] [stderr] 37 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | Transaction { [INFO] [stderr] 34 | id: _hasher_result, [INFO] [stderr] 35 | vin: self.vin.to_owned(), [INFO] [stderr] 36 | vout: self.vout.to_owned() [INFO] [stderr] 37 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/tx.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | return _tx_copy;} [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_tx_copy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/input.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return self.signature == unlocking_data.into_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.signature == unlocking_data.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/input.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | return locking_hash.eq(&pubkey_hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `locking_hash.eq(&pubkey_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/inputs.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/inputs.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/output.rs:15:9 [INFO] [stderr] | [INFO] [stderr] 15 | return self.pubkey_hash.eq(&_pubkey_hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pubkey_hash.eq(&_pubkey_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/output.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / return TXOutput{ [INFO] [stderr] 22 | | value: self.value, [INFO] [stderr] 23 | | pubkey_hash: pubkey_hash, [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 21 | TXOutput{ [INFO] [stderr] 22 | value: self.value, [INFO] [stderr] 23 | pubkey_hash: pubkey_hash, [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/output.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return self.pubkey_hash.eq(&_pubkey_hash); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.pubkey_hash.eq(&_pubkey_hash)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/outputs.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/outputs.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | return _result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utils.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | return tx; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utils.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return Some(_tx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(_tx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utxo_set.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return (_accumulated, _unspent_outputs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(_accumulated, _unspent_outputs)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tx/utxo_set.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return _utxos; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `_utxos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/account.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return address.into_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `address.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/lib.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | pub mod wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | return wallets; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `wallets` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return addresses; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `addresses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | return _wallet; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `_wallet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/wallet.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return account; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `account` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return _account; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_account` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return _actual_checksum.eq(&_target_checksum); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_actual_checksum.eq(&_target_checksum)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return address.into_bytes() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `address.into_bytes()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | return pubkey_hash[1..20].to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `pubkey_hash[1..20].to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | return hasher.result().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `hasher.result().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:94:5 [INFO] [stderr] | [INFO] [stderr] 94 | return second_sha.result().to_vec(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `second_sha.result().to_vec()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/wallet/utils.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | return (_priv_key.to_vec(), _public_key.serialize().to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(_priv_key.to_vec(), _public_key.serialize().to_vec())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/wallet/utils.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/wallet/utils.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/block.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | since_the_epoch.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/blockchain.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if self.to_owned().verify_transaction(_tx) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.to_owned().verify_transaction(_tx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/blockchain.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | if _set_hash.is_ok() == false { panic!(_set_hash.unwrap()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_set_hash.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/blockchain.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | if _set_last.is_ok() == false { panic!(_set_last.unwrap()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_set_last.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/blockchain/tx.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | if _tx.id.eq(&_id) == true { return _tx }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `_tx.id.eq(&_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/blockchain/tx.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | if _block.prev_block_hash.len() == 0 { break; }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_block.prev_block_hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/tx.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | if tx.to_owned().is_coinbase() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!tx.to_owned().is_coinbase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/blockchain/tx.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if _block.prev_block_hash.len() == 0 {break;}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_block.prev_block_hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/utils.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if _store_hash.is_ok() == false { panic!(_store_hash.unwrap())} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_store_hash.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/utils.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if _store_last.is_ok() == false { panic!(_store_last.unwrap())}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_store_last.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cli/get_balance.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | balance = balance + &output.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `balance += &output.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/cli/get_balance.rs:31:27 [INFO] [stderr] | [INFO] [stderr] 31 | balance = balance + &output.value; [INFO] [stderr] | ^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `output.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tx/tx.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn is_coinbase(self) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/tx/tx.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / if self.id == vec![] { [INFO] [stderr] 22 | | return true; [INFO] [stderr] 23 | | }else{ [INFO] [stderr] 24 | | return false; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return self.id == vec![]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tx/tx.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | if _prev_tx.to_owned().is_coinbase() == true {return true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `_prev_tx.to_owned().is_coinbase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tx/tx.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if &self.vin[_in_id].signature.len() == &0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 79 | if self.vin[_in_id].signature.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tx/tx.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if _verify == false { return false; }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_verify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blockchain/block.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | since_the_epoch.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(since_the_epoch.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/blockchain.rs:36:16 [INFO] [stderr] | [INFO] [stderr] 36 | if self.to_owned().verify_transaction(_tx) == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.to_owned().verify_transaction(_tx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/blockchain.rs:44:12 [INFO] [stderr] | [INFO] [stderr] 44 | if _set_hash.is_ok() == false { panic!(_set_hash.unwrap()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_set_hash.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/blockchain.rs:46:12 [INFO] [stderr] | [INFO] [stderr] 46 | if _set_last.is_ok() == false { panic!(_set_last.unwrap()) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_set_last.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/blockchain/tx.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | if _tx.id.eq(&_id) == true { return _tx }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `_tx.id.eq(&_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/blockchain/tx.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | if _block.prev_block_hash.len() == 0 { break; }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_block.prev_block_hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/tx.rs:48:24 [INFO] [stderr] | [INFO] [stderr] 48 | if tx.to_owned().is_coinbase() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!tx.to_owned().is_coinbase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/blockchain/tx.rs:56:16 [INFO] [stderr] | [INFO] [stderr] 56 | if _block.prev_block_hash.len() == 0 {break;}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `_block.prev_block_hash.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/utils.rs:32:12 [INFO] [stderr] | [INFO] [stderr] 32 | if _store_hash.is_ok() == false { panic!(_store_hash.unwrap())} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_store_hash.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/blockchain/utils.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if _store_last.is_ok() == false { panic!(_store_last.unwrap())}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_store_last.is_ok()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/cli/get_balance.rs:31:17 [INFO] [stderr] | [INFO] [stderr] 31 | balance = balance + &output.value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `balance += &output.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/cli/get_balance.rs:31:27 [INFO] [stderr] | [INFO] [stderr] 31 | balance = balance + &output.value; [INFO] [stderr] | ^^^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `output.value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tx/utxo_set.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | if _tx.to_owned().is_coinbase() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_tx.to_owned().is_coinbase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: methods called `is_*` usually take self by reference or no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/tx/tx.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn is_coinbase(self) -> bool { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/tx/tx.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | / if self.id == vec![] { [INFO] [stderr] 22 | | return true; [INFO] [stderr] 23 | | }else{ [INFO] [stderr] 24 | | return false; [INFO] [stderr] 25 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `return self.id == vec![]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/tx/tx.rs:69:16 [INFO] [stderr] | [INFO] [stderr] 69 | if _prev_tx.to_owned().is_coinbase() == true {return true}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `_prev_tx.to_owned().is_coinbase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/tx/tx.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | if &self.vin[_in_id].signature.len() == &0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 79 | if self.vin[_in_id].signature.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tx/tx.rs:88:16 [INFO] [stderr] | [INFO] [stderr] 88 | if _verify == false { return false; }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_verify` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wallet/wallet.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | buf.write(&serialize(&self).unwrap())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/wallet/utils.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | if _exist == true { return;}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `_exist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `radiancy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/tx/utxo_set.rs:64:16 [INFO] [stderr] | [INFO] [stderr] 64 | if _tx.to_owned().is_coinbase() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!_tx.to_owned().is_coinbase()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/wallet/wallet.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | buf.write(&serialize(&self).unwrap())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/wallet/utils.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | if _exist == true { return;}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try simplifying it as shown: `_exist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `radiancy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f6366f849b526c848a6d558af0af62c41f9198b5fde58c1a100056c1dc6984b8"` [INFO] running `"docker" "rm" "-f" "f6366f849b526c848a6d558af0af62c41f9198b5fde58c1a100056c1dc6984b8"` [INFO] [stdout] f6366f849b526c848a6d558af0af62c41f9198b5fde58c1a100056c1dc6984b8