[INFO] crate rad1o-l0dable 0.0.0 is already in cache [INFO] extracting crate rad1o-l0dable 0.0.0 into work/ex/clippy-test-run/sources/stable/reg/rad1o-l0dable/0.0.0 [INFO] extracting crate rad1o-l0dable 0.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rad1o-l0dable/0.0.0 [INFO] validating manifest of rad1o-l0dable-0.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rad1o-l0dable-0.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rad1o-l0dable-0.0.0 [INFO] finished frobbing rad1o-l0dable-0.0.0 [INFO] frobbed toml for rad1o-l0dable-0.0.0 written to work/ex/clippy-test-run/sources/stable/reg/rad1o-l0dable/0.0.0/Cargo.toml [INFO] started frobbing rad1o-l0dable-0.0.0 [INFO] finished frobbing rad1o-l0dable-0.0.0 [INFO] frobbed toml for rad1o-l0dable-0.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rad1o-l0dable/0.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rad1o-l0dable-0.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rad1o-l0dable/0.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5f3b41eb726adbe51fe7c9b88550a130b3734a6fb610cd33db6d498be2d4943d [INFO] running `"docker" "start" "-a" "5f3b41eb726adbe51fe7c9b88550a130b3734a6fb610cd33db6d498be2d4943d"` [INFO] [stderr] Compiling cortex-m v0.5.8 [INFO] [stderr] Compiling lpc43xx v0.1.0 [INFO] [stderr] Compiling rad1o-l0dable v0.0.0 (/opt/crater/workdir) [INFO] [stderr] Checking r0 v0.2.2 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/table.rs:87:22 [INFO] [stderr] | [INFO] [stderr] 87 | let jump_table = 0x10000114 as *const Table; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0114` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lcd.rs:35:11 [INFO] [stderr] | [INFO] [stderr] 35 | while bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lcd.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | drop(buf); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type [u8; 16] [INFO] [stderr] --> src/lcd.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | drop(buf); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lcd.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | drop(buf); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type [u8; 2] [INFO] [stderr] --> src/lcd.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | drop(buf); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rad1o-l0dable`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/table.rs:87:22 [INFO] [stderr] | [INFO] [stderr] 87 | let jump_table = 0x10000114 as *const Table; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0114` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lcd.rs:35:11 [INFO] [stderr] | [INFO] [stderr] 35 | while bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lcd.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | drop(buf); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type [u8; 16] [INFO] [stderr] --> src/lcd.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | drop(buf); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/lcd.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | drop(buf); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type [u8; 2] [INFO] [stderr] --> src/lcd.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | drop(buf); [INFO] [stderr] | ^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rad1o-l0dable`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5f3b41eb726adbe51fe7c9b88550a130b3734a6fb610cd33db6d498be2d4943d"` [INFO] running `"docker" "rm" "-f" "5f3b41eb726adbe51fe7c9b88550a130b3734a6fb610cd33db6d498be2d4943d"` [INFO] [stdout] 5f3b41eb726adbe51fe7c9b88550a130b3734a6fb610cd33db6d498be2d4943d