[INFO] crate racer-cargo-metadata 0.1.1 is already in cache [INFO] extracting crate racer-cargo-metadata 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/racer-cargo-metadata/0.1.1 [INFO] extracting crate racer-cargo-metadata 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/racer-cargo-metadata/0.1.1 [INFO] validating manifest of racer-cargo-metadata-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of racer-cargo-metadata-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing racer-cargo-metadata-0.1.1 [INFO] finished frobbing racer-cargo-metadata-0.1.1 [INFO] frobbed toml for racer-cargo-metadata-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/racer-cargo-metadata/0.1.1/Cargo.toml [INFO] started frobbing racer-cargo-metadata-0.1.1 [INFO] finished frobbing racer-cargo-metadata-0.1.1 [INFO] frobbed toml for racer-cargo-metadata-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/racer-cargo-metadata/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting racer-cargo-metadata-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/racer-cargo-metadata/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb16139cb134a2c253e8b211a4cb0316b53acf59c55c840e4188f70808109501 [INFO] running `"docker" "start" "-a" "eb16139cb134a2c253e8b211a4cb0316b53acf59c55c840e4188f70808109501"` [INFO] [stderr] Checking serde_json v1.0.37 [INFO] [stderr] Checking racer-interner v0.1.0 [INFO] [stderr] Checking racer-cargo-metadata v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/metadata.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | const LIB_KINDS: [&'static str; 4] = ["lib", "rlib", "dylib", "proc-macro"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/metadata.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | const LIB_KINDS: [&'static str; 4] = ["lib", "rlib", "dylib", "proc-macro"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/mapping.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn from_str(s: &str) -> Self { [INFO] [stderr] 22 | | match s { [INFO] [stderr] 23 | | "2015" => Edition::Ed2015, [INFO] [stderr] 24 | | "2018" => Edition::Ed2018, [INFO] [stderr] 25 | | _ => unreachable!("got unexpected edition {}", s), [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mapping.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | self.id_to_idx.get(&id).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.id_to_idx.get(&id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mapping.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.manifest_to_idx.get(path).map(|&id| id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.manifest_to_idx.get(path).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/mapping.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn from_str(s: &str) -> Self { [INFO] [stderr] 22 | | match s { [INFO] [stderr] 23 | | "2015" => Edition::Ed2015, [INFO] [stderr] 24 | | "2018" => Edition::Ed2018, [INFO] [stderr] 25 | | _ => unreachable!("got unexpected edition {}", s), [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mapping.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | self.id_to_idx.get(&id).map(|&x| x) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.id_to_idx.get(&id).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mapping.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | self.manifest_to_idx.get(path).map(|&id| id) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.manifest_to_idx.get(path).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.40s [INFO] running `"docker" "inspect" "eb16139cb134a2c253e8b211a4cb0316b53acf59c55c840e4188f70808109501"` [INFO] running `"docker" "rm" "-f" "eb16139cb134a2c253e8b211a4cb0316b53acf59c55c840e4188f70808109501"` [INFO] [stdout] eb16139cb134a2c253e8b211a4cb0316b53acf59c55c840e4188f70808109501