[INFO] crate rabbit 0.1.0 is already in cache [INFO] extracting crate rabbit 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/rabbit/0.1.0 [INFO] extracting crate rabbit 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rabbit/0.1.0 [INFO] validating manifest of rabbit-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of rabbit-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing rabbit-0.1.0 [INFO] finished frobbing rabbit-0.1.0 [INFO] frobbed toml for rabbit-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/rabbit/0.1.0/Cargo.toml [INFO] started frobbing rabbit-0.1.0 [INFO] finished frobbing rabbit-0.1.0 [INFO] frobbed toml for rabbit-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/rabbit/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting rabbit-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/rabbit/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9fd563061ccf05de4f32b1c974cfd65e5902b15f8c8532dd29c567a05af9066c [INFO] running `"docker" "start" "-a" "9fd563061ccf05de4f32b1c974cfd65e5902b15f8c8532dd29c567a05af9066c"` [INFO] [stderr] Checking rabbit v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | master_state: master_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `master_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | rabbit: rabbit, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rabbit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:273:13 [INFO] [stderr] | [INFO] [stderr] 273 | master_state: master_state, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `master_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:274:13 [INFO] [stderr] | [INFO] [stderr] 274 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:347:13 [INFO] [stderr] | [INFO] [stderr] 347 | stream: stream, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:348:13 [INFO] [stderr] | [INFO] [stderr] 348 | rabbit: rabbit, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `rabbit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D34_D34D` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD34D_34D3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x34D3_4D34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:58 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D34_D34D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD34D_34D3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x34D3_4D34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:46 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D34_D34D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:58 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD34D_34D3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:164:33 [INFO] [stderr] | [INFO] [stderr] 164 | let i1 = (i0 >> 16) | (i2 & 0xFFFF0000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | let i3 = (i2 << 16) | (i0 & 0x0000FFFF); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D34_D34D` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD34D_34D3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:46 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x34D3_4D34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:15:58 [INFO] [stderr] | [INFO] [stderr] 15 | const A: [u32; 8] = [0x4D34D34D, 0xD34D34D3, 0x34D34D34, 0x4D34D34D, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D34_D34D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:22 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD34D_34D3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x34D3_4D34` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:46 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4D34_D34D` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:16:58 [INFO] [stderr] | [INFO] [stderr] 16 | 0xD34D34D3, 0x34D34D34, 0x4D34D34D, 0xD34D34D3]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xD34D_34D3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:164:33 [INFO] [stderr] | [INFO] [stderr] 164 | let i1 = (i0 >> 16) | (i2 & 0xFFFF0000); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:165:33 [INFO] [stderr] | [INFO] [stderr] 165 | let i3 = (i2 << 16) | (i0 & 0x0000FFFF); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:243:5 [INFO] [stderr] | [INFO] [stderr] 243 | return s; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `key[..16].clone_from_slice(&slice[..16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `iv` [INFO] [stderr] --> src/lib.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for (i, ) in iv.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `iv[..8].clone_from_slice(&slice[..8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | k[0] = (key[0x0] as u16) | ((key[0x1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:33 [INFO] [stderr] | [INFO] [stderr] 132 | k[0] = (key[0x0] as u16) | ((key[0x1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | k[1] = (key[0x2] as u16) | ((key[0x3] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:133:33 [INFO] [stderr] | [INFO] [stderr] 133 | k[1] = (key[0x2] as u16) | ((key[0x3] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:134:12 [INFO] [stderr] | [INFO] [stderr] 134 | k[2] = (key[0x4] as u16) | ((key[0x5] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:134:33 [INFO] [stderr] | [INFO] [stderr] 134 | k[2] = (key[0x4] as u16) | ((key[0x5] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | k[3] = (key[0x6] as u16) | ((key[0x7] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:135:33 [INFO] [stderr] | [INFO] [stderr] 135 | k[3] = (key[0x6] as u16) | ((key[0x7] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | k[4] = (key[0x8] as u16) | ((key[0x9] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | k[4] = (key[0x8] as u16) | ((key[0x9] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:12 [INFO] [stderr] | [INFO] [stderr] 137 | k[5] = (key[0xA] as u16) | ((key[0xB] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xA])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | k[5] = (key[0xA] as u16) | ((key[0xB] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xB])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:12 [INFO] [stderr] | [INFO] [stderr] 138 | k[6] = (key[0xC] as u16) | ((key[0xD] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xC])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | k[6] = (key[0xC] as u16) | ((key[0xD] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xD])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | k[7] = (key[0xE] as u16) | ((key[0xF] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xE])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | k[7] = (key[0xE] as u16) | ((key[0xF] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xF])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:143:36 [INFO] [stderr] | [INFO] [stderr] 143 | state.state_vars[j] = ((k[(j + 1) % 8] as u32) << 16) | (k[j] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 1) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:143:69 [INFO] [stderr] | [INFO] [stderr] 143 | state.state_vars[j] = ((k[(j + 1) % 8] as u32) << 16) | (k[j] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(k[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:38 [INFO] [stderr] | [INFO] [stderr] 144 | state.counter_vars[j] = ((k[(j + 4) % 8] as u32) << 16) | (k[(j + 5) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 4) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:71 [INFO] [stderr] | [INFO] [stderr] 144 | state.counter_vars[j] = ((k[(j + 4) % 8] as u32) << 16) | (k[(j + 5) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 5) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | state.state_vars[j] = ((k[(j + 5) % 8] as u32) << 16) | (k[(j + 4) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 5) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:146:69 [INFO] [stderr] | [INFO] [stderr] 146 | state.state_vars[j] = ((k[(j + 5) % 8] as u32) << 16) | (k[(j + 4) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 4) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:147:38 [INFO] [stderr] | [INFO] [stderr] 147 | state.counter_vars[j] = ((k[j] as u32) << 16) | (k[(j + 1) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(k[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:147:61 [INFO] [stderr] | [INFO] [stderr] 147 | state.counter_vars[j] = ((k[j] as u32) << 16) | (k[(j + 1) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 1) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | state.counter_vars[j] = state.counter_vars[j] ^ state.state_vars[(j + 4) % 8]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[j] ^= state.state_vars[(j + 4) % 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(iv[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:51 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:74 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(iv[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:51 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:74 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | state.counter_vars[0] = state.counter_vars[0] ^ i0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[0] ^= i0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | state.counter_vars[1] = state.counter_vars[1] ^ i1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[1] ^= i1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | state.counter_vars[2] = state.counter_vars[2] ^ i2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[2] ^= i2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | state.counter_vars[3] = state.counter_vars[3] ^ i3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[3] ^= i3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | state.counter_vars[4] = state.counter_vars[4] ^ i0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[4] ^= i0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | state.counter_vars[5] = state.counter_vars[5] ^ i1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[5] ^= i1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | state.counter_vars[6] = state.counter_vars[6] ^ i2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[6] ^= i2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | state.counter_vars[7] = state.counter_vars[7] ^ i3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[7] ^= i3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `A` [INFO] [stderr] --> src/lib.rs:182:14 [INFO] [stderr] | [INFO] [stderr] 182 | for j in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 182 | for (j, ) in A.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:183:20 [INFO] [stderr] | [INFO] [stderr] 183 | let temp = state.counter_vars[j] as u64 + A[j] as u64 + state.carry_bit as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.counter_vars[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:183:51 [INFO] [stderr] | [INFO] [stderr] 183 | let temp = state.counter_vars[j] as u64 + A[j] as u64 + state.carry_bit as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(A[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:183:65 [INFO] [stderr] | [INFO] [stderr] 183 | let temp = state.counter_vars[j] as u64 + A[j] as u64 + state.carry_bit as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.carry_bit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `g` [INFO] [stderr] --> src/lib.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | for j in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for (j, ) in g.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:195:24 [INFO] [stderr] | [INFO] [stderr] 195 | let u_plus_v = state.state_vars[j] as u64 + state.counter_vars[j] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.state_vars[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:195:53 [INFO] [stderr] | [INFO] [stderr] 195 | let u_plus_v = state.state_vars[j] as u64 + state.counter_vars[j] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.counter_vars[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data`. [INFO] [stderr] --> src/lib.rs:311:18 [INFO] [stderr] | [INFO] [stderr] 311 | for i in 0..data.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 311 | for in &mut data { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `extract` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:326:29 [INFO] [stderr] | [INFO] [stderr] 326 | let s = extract(&mut self.state); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:47:18 [INFO] [stderr] | [INFO] [stderr] 47 | for i in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `key[..16].clone_from_slice(&slice[..16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `iv` [INFO] [stderr] --> src/lib.rs:75:18 [INFO] [stderr] | [INFO] [stderr] 75 | for i in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 75 | for (i, ) in iv.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/lib.rs:92:18 [INFO] [stderr] | [INFO] [stderr] 92 | for i in 0..8 { [INFO] [stderr] | ^^^^ help: try replacing the loop by: `iv[..8].clone_from_slice(&slice[..8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | k[0] = (key[0x0] as u16) | ((key[0x1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:33 [INFO] [stderr] | [INFO] [stderr] 132 | k[0] = (key[0x0] as u16) | ((key[0x1] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:133:12 [INFO] [stderr] | [INFO] [stderr] 133 | k[1] = (key[0x2] as u16) | ((key[0x3] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:133:33 [INFO] [stderr] | [INFO] [stderr] 133 | k[1] = (key[0x2] as u16) | ((key[0x3] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:134:12 [INFO] [stderr] | [INFO] [stderr] 134 | k[2] = (key[0x4] as u16) | ((key[0x5] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:134:33 [INFO] [stderr] | [INFO] [stderr] 134 | k[2] = (key[0x4] as u16) | ((key[0x5] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:135:12 [INFO] [stderr] | [INFO] [stderr] 135 | k[3] = (key[0x6] as u16) | ((key[0x7] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:135:33 [INFO] [stderr] | [INFO] [stderr] 135 | k[3] = (key[0x6] as u16) | ((key[0x7] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:136:12 [INFO] [stderr] | [INFO] [stderr] 136 | k[4] = (key[0x8] as u16) | ((key[0x9] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:136:33 [INFO] [stderr] | [INFO] [stderr] 136 | k[4] = (key[0x8] as u16) | ((key[0x9] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0x9])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:12 [INFO] [stderr] | [INFO] [stderr] 137 | k[5] = (key[0xA] as u16) | ((key[0xB] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xA])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:137:33 [INFO] [stderr] | [INFO] [stderr] 137 | k[5] = (key[0xA] as u16) | ((key[0xB] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xB])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:12 [INFO] [stderr] | [INFO] [stderr] 138 | k[6] = (key[0xC] as u16) | ((key[0xD] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xC])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:138:33 [INFO] [stderr] | [INFO] [stderr] 138 | k[6] = (key[0xC] as u16) | ((key[0xD] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xD])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:12 [INFO] [stderr] | [INFO] [stderr] 139 | k[7] = (key[0xE] as u16) | ((key[0xF] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xE])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:139:33 [INFO] [stderr] | [INFO] [stderr] 139 | k[7] = (key[0xE] as u16) | ((key[0xF] as u16) << 8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(key[0xF])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:143:36 [INFO] [stderr] | [INFO] [stderr] 143 | state.state_vars[j] = ((k[(j + 1) % 8] as u32) << 16) | (k[j] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 1) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:143:69 [INFO] [stderr] | [INFO] [stderr] 143 | state.state_vars[j] = ((k[(j + 1) % 8] as u32) << 16) | (k[j] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(k[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:38 [INFO] [stderr] | [INFO] [stderr] 144 | state.counter_vars[j] = ((k[(j + 4) % 8] as u32) << 16) | (k[(j + 5) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 4) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:144:71 [INFO] [stderr] | [INFO] [stderr] 144 | state.counter_vars[j] = ((k[(j + 4) % 8] as u32) << 16) | (k[(j + 5) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 5) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:146:36 [INFO] [stderr] | [INFO] [stderr] 146 | state.state_vars[j] = ((k[(j + 5) % 8] as u32) << 16) | (k[(j + 4) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 5) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:146:69 [INFO] [stderr] | [INFO] [stderr] 146 | state.state_vars[j] = ((k[(j + 5) % 8] as u32) << 16) | (k[(j + 4) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 4) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:147:38 [INFO] [stderr] | [INFO] [stderr] 147 | state.counter_vars[j] = ((k[j] as u32) << 16) | (k[(j + 1) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(k[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:147:61 [INFO] [stderr] | [INFO] [stderr] 147 | state.counter_vars[j] = ((k[j] as u32) << 16) | (k[(j + 1) % 8] as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(k[(j + 1) % 8])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | state.counter_vars[j] = state.counter_vars[j] ^ state.state_vars[(j + 4) % 8]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[j] ^= state.state_vars[(j + 4) % 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:14 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(iv[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:29 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:51 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:74 [INFO] [stderr] | [INFO] [stderr] 162 | let i0 = iv[0] as u32 | (iv[1] as u32) << 8 | (iv[2] as u32) << 16 | (iv[3] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:14 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(iv[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:29 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:51 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:74 [INFO] [stderr] | [INFO] [stderr] 163 | let i2 = iv[4] as u32 | (iv[5] as u32) << 8 | (iv[6] as u32) << 16 | (iv[7] as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(iv[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:167:5 [INFO] [stderr] | [INFO] [stderr] 167 | state.counter_vars[0] = state.counter_vars[0] ^ i0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[0] ^= i0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | state.counter_vars[1] = state.counter_vars[1] ^ i1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[1] ^= i1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | state.counter_vars[2] = state.counter_vars[2] ^ i2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[2] ^= i2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:170:5 [INFO] [stderr] | [INFO] [stderr] 170 | state.counter_vars[3] = state.counter_vars[3] ^ i3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[3] ^= i3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | state.counter_vars[4] = state.counter_vars[4] ^ i0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[4] ^= i0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:172:5 [INFO] [stderr] | [INFO] [stderr] 172 | state.counter_vars[5] = state.counter_vars[5] ^ i1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[5] ^= i1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | state.counter_vars[6] = state.counter_vars[6] ^ i2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[6] ^= i2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | state.counter_vars[7] = state.counter_vars[7] ^ i3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `state.counter_vars[7] ^= i3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `A` [INFO] [stderr] --> src/lib.rs:182:14 [INFO] [stderr] | [INFO] [stderr] 182 | for j in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 182 | for (j, ) in A.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:183:20 [INFO] [stderr] | [INFO] [stderr] 183 | let temp = state.counter_vars[j] as u64 + A[j] as u64 + state.carry_bit as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.counter_vars[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:183:51 [INFO] [stderr] | [INFO] [stderr] 183 | let temp = state.counter_vars[j] as u64 + A[j] as u64 + state.carry_bit as u64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u64::from(A[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:183:65 [INFO] [stderr] | [INFO] [stderr] 183 | let temp = state.counter_vars[j] as u64 + A[j] as u64 + state.carry_bit as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.carry_bit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `g` [INFO] [stderr] --> src/lib.rs:194:14 [INFO] [stderr] | [INFO] [stderr] 194 | for j in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 194 | for (j, ) in g.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:195:24 [INFO] [stderr] | [INFO] [stderr] 195 | let u_plus_v = state.state_vars[j] as u64 + state.counter_vars[j] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.state_vars[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:195:53 [INFO] [stderr] | [INFO] [stderr] 195 | let u_plus_v = state.state_vars[j] as u64 + state.counter_vars[j] as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(state.counter_vars[j])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data`. [INFO] [stderr] --> src/lib.rs:311:18 [INFO] [stderr] | [INFO] [stderr] 311 | for i in 0..data.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 311 | for in &mut data { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: The function/method `extract` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:326:29 [INFO] [stderr] | [INFO] [stderr] 326 | let s = extract(&mut self.state); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "9fd563061ccf05de4f32b1c974cfd65e5902b15f8c8532dd29c567a05af9066c"` [INFO] running `"docker" "rm" "-f" "9fd563061ccf05de4f32b1c974cfd65e5902b15f8c8532dd29c567a05af9066c"` [INFO] [stdout] 9fd563061ccf05de4f32b1c974cfd65e5902b15f8c8532dd29c567a05af9066c