[INFO] crate r_i18n 1.0.1 is already in cache [INFO] extracting crate r_i18n 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/r_i18n/1.0.1 [INFO] extracting crate r_i18n 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/r_i18n/1.0.1 [INFO] validating manifest of r_i18n-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of r_i18n-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing r_i18n-1.0.1 [INFO] finished frobbing r_i18n-1.0.1 [INFO] frobbed toml for r_i18n-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/r_i18n/1.0.1/Cargo.toml [INFO] started frobbing r_i18n-1.0.1 [INFO] finished frobbing r_i18n-1.0.1 [INFO] frobbed toml for r_i18n-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/r_i18n/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting r_i18n-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/r_i18n/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 723df667b8e3c0cd13ac133f25309a0a9aff91f268b5feec09f41ac15d3d07d4 [INFO] running `"docker" "start" "-a" "723df667b8e3c0cd13ac133f25309a0a9aff91f268b5feec09f41ac15d3d07d4"` [INFO] [stderr] Checking r_i18n v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:54:39 [INFO] [stderr] | [INFO] [stderr] 54 | let mut i18n: I18n = I18n{config: config, current_lang: current_lang, translations: HashMap::new()}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:54:55 [INFO] [stderr] | [INFO] [stderr] 54 | let mut i18n: I18n = I18n{config: config, current_lang: current_lang, translations: HashMap::new()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_lang` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:54:39 [INFO] [stderr] | [INFO] [stderr] 54 | let mut i18n: I18n = I18n{config: config, current_lang: current_lang, translations: HashMap::new()}; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:54:55 [INFO] [stderr] | [INFO] [stderr] 54 | let mut i18n: I18n = I18n{config: config, current_lang: current_lang, translations: HashMap::new()}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_lang` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/i18n.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match self.config.locales.contains(&lang) { [INFO] [stderr] 84 | | true => self.current_lang = lang, [INFO] [stderr] 85 | | false => panic!("Please add {} to the list.", lang) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.config.locales.contains(&lang) { self.current_lang = lang } else { panic!("Please add {} to the list.", lang) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/i18n.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / match self.config.locales.contains(&lang) { [INFO] [stderr] 84 | | true => self.current_lang = lang, [INFO] [stderr] 85 | | false => panic!("Please add {} to the list.", lang) [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if self.config.locales.contains(&lang) { self.current_lang = lang } else { panic!("Please add {} to the list.", lang) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.02s [INFO] running `"docker" "inspect" "723df667b8e3c0cd13ac133f25309a0a9aff91f268b5feec09f41ac15d3d07d4"` [INFO] running `"docker" "rm" "-f" "723df667b8e3c0cd13ac133f25309a0a9aff91f268b5feec09f41ac15d3d07d4"` [INFO] [stdout] 723df667b8e3c0cd13ac133f25309a0a9aff91f268b5feec09f41ac15d3d07d4