[INFO] crate r2pipe 0.4.0 is already in cache [INFO] extracting crate r2pipe 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/r2pipe/0.4.0 [INFO] extracting crate r2pipe 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/r2pipe/0.4.0 [INFO] validating manifest of r2pipe-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of r2pipe-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing r2pipe-0.4.0 [INFO] finished frobbing r2pipe-0.4.0 [INFO] frobbed toml for r2pipe-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/r2pipe/0.4.0/Cargo.toml [INFO] started frobbing r2pipe-0.4.0 [INFO] finished frobbing r2pipe-0.4.0 [INFO] frobbed toml for r2pipe-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/r2pipe/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting r2pipe-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/r2pipe/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85fecebeb1ff89f6dfc6071555122320051e6fbca340475ed1cd92e9ecff3ff3 [INFO] running `"docker" "start" "-a" "85fecebeb1ff89f6dfc6071555122320051e6fbca340475ed1cd92e9ecff3ff3"` [INFO] [stderr] Checking r2pipe v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/r2.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | pipe: pipe, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pipe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/r2.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | pipe: pipe, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pipe` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/r2pipe.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | if let Some(_) = R2Pipe::in_session() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 150 | | return R2Pipe::open(); [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________- help: try this: `if R2Pipe::in_session().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/r2pipe.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | sout.read(&mut w).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/r2pipe.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | self.write.write(cmd.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/r2.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match R2Pipe::in_session() { [INFO] [stderr] 61 | | Some(_) => true, [INFO] [stderr] 62 | | None => false, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: try this: `R2Pipe::in_session().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `r2pipe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/r2pipe.rs:149:20 [INFO] [stderr] | [INFO] [stderr] 149 | if let Some(_) = R2Pipe::in_session() { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 150 | | return R2Pipe::open(); [INFO] [stderr] 151 | | } [INFO] [stderr] | |_____________- help: try this: `if R2Pipe::in_session().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/r2pipe.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | sout.read(&mut w).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/r2pipe.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | self.write.write(cmd.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/r2.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / match R2Pipe::in_session() { [INFO] [stderr] 61 | | Some(_) => true, [INFO] [stderr] 62 | | None => false, [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ help: try this: `R2Pipe::in_session().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `r2pipe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "85fecebeb1ff89f6dfc6071555122320051e6fbca340475ed1cd92e9ecff3ff3"` [INFO] running `"docker" "rm" "-f" "85fecebeb1ff89f6dfc6071555122320051e6fbca340475ed1cd92e9ecff3ff3"` [INFO] [stdout] 85fecebeb1ff89f6dfc6071555122320051e6fbca340475ed1cd92e9ecff3ff3