[INFO] crate r 0.0.9 is already in cache [INFO] extracting crate r 0.0.9 into work/ex/clippy-test-run/sources/stable/reg/r/0.0.9 [INFO] extracting crate r 0.0.9 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/r/0.0.9 [INFO] validating manifest of r-0.0.9 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of r-0.0.9 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing r-0.0.9 [INFO] removed 1 missing tests [INFO] finished frobbing r-0.0.9 [INFO] frobbed toml for r-0.0.9 written to work/ex/clippy-test-run/sources/stable/reg/r/0.0.9/Cargo.toml [INFO] started frobbing r-0.0.9 [INFO] removed 1 missing tests [INFO] finished frobbing r-0.0.9 [INFO] frobbed toml for r-0.0.9 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/r/0.0.9/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting r-0.0.9 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/r/0.0.9:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b2d152d98dfe3992ae8898d2fed2bebfb9e51dee0a953ae784f3871fa67e9da [INFO] running `"docker" "start" "-a" "8b2d152d98dfe3992ae8898d2fed2bebfb9e51dee0a953ae784f3871fa67e9da"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/tests.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking r v0.0.9 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ml::common::DataSet` [INFO] [stderr] --> src/ml/common.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> DataSet { [INFO] [stderr] 10 | | DataSet(Vec::new()) [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ml::eval::Eval` [INFO] [stderr] --> src/ml/eval/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Eval { [INFO] [stderr] 30 | | Eval { [INFO] [stderr] 31 | | tp_sz: AtomicIsize::new(0), [INFO] [stderr] 32 | | tn_sz: AtomicIsize::new(0), [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ml/eval/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match predicted { [INFO] [stderr] 42 | | true => [INFO] [stderr] 43 | | match actual { [INFO] [stderr] 44 | | true => [INFO] [stderr] ... | [INFO] [stderr] 55 | | }, [INFO] [stderr] 56 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 41 | if predicted { match actual { [INFO] [stderr] 42 | true => [INFO] [stderr] 43 | self.tp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 44 | false => [INFO] [stderr] 45 | self.fp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 46 | } } else { match actual { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ml/eval/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match actual { [INFO] [stderr] 44 | | true => [INFO] [stderr] 45 | | self.tp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 46 | | false => [INFO] [stderr] 47 | | self.fp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 48 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if actual { self.tp_sz.fetch_add(1, Ordering::SeqCst) } else { self.fp_sz.fetch_add(1, Ordering::SeqCst) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ml/eval/mod.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / match actual { [INFO] [stderr] 51 | | true => [INFO] [stderr] 52 | | self.fn_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 53 | | false => [INFO] [stderr] 54 | | self.tn_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 55 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if actual { self.fn_sz.fetch_add(1, Ordering::SeqCst) } else { self.tn_sz.fetch_add(1, Ordering::SeqCst) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ml::linear::Linear` [INFO] [stderr] --> src/ml/linear.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Linear { [INFO] [stderr] 12 | | Linear { [INFO] [stderr] 13 | | ds: DataSet::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for ml::linear::Linear { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ml::common::DataSet` [INFO] [stderr] --> src/ml/common.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | / pub fn new() -> DataSet { [INFO] [stderr] 10 | | DataSet(Vec::new()) [INFO] [stderr] 11 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ml::eval::Eval` [INFO] [stderr] --> src/ml/eval/mod.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Eval { [INFO] [stderr] 30 | | Eval { [INFO] [stderr] 31 | | tp_sz: AtomicIsize::new(0), [INFO] [stderr] 32 | | tn_sz: AtomicIsize::new(0), [INFO] [stderr] ... | [INFO] [stderr] 35 | | } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ml/eval/mod.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match predicted { [INFO] [stderr] 42 | | true => [INFO] [stderr] 43 | | match actual { [INFO] [stderr] 44 | | true => [INFO] [stderr] ... | [INFO] [stderr] 55 | | }, [INFO] [stderr] 56 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 41 | if predicted { match actual { [INFO] [stderr] 42 | true => [INFO] [stderr] 43 | self.tp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 44 | false => [INFO] [stderr] 45 | self.fp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 46 | } } else { match actual { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ml/eval/mod.rs:43:17 [INFO] [stderr] | [INFO] [stderr] 43 | / match actual { [INFO] [stderr] 44 | | true => [INFO] [stderr] 45 | | self.tp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 46 | | false => [INFO] [stderr] 47 | | self.fp_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 48 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if actual { self.tp_sz.fetch_add(1, Ordering::SeqCst) } else { self.fp_sz.fetch_add(1, Ordering::SeqCst) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/ml/eval/mod.rs:50:17 [INFO] [stderr] | [INFO] [stderr] 50 | / match actual { [INFO] [stderr] 51 | | true => [INFO] [stderr] 52 | | self.fn_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 53 | | false => [INFO] [stderr] 54 | | self.tn_sz.fetch_add(1, Ordering::SeqCst), [INFO] [stderr] 55 | | }, [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if actual { self.fn_sz.fetch_add(1, Ordering::SeqCst) } else { self.tn_sz.fetch_add(1, Ordering::SeqCst) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ml::linear::Linear` [INFO] [stderr] --> src/ml/linear.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Linear { [INFO] [stderr] 12 | | Linear { [INFO] [stderr] 13 | | ds: DataSet::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for ml::linear::Linear { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "8b2d152d98dfe3992ae8898d2fed2bebfb9e51dee0a953ae784f3871fa67e9da"` [INFO] running `"docker" "rm" "-f" "8b2d152d98dfe3992ae8898d2fed2bebfb9e51dee0a953ae784f3871fa67e9da"` [INFO] [stdout] 8b2d152d98dfe3992ae8898d2fed2bebfb9e51dee0a953ae784f3871fa67e9da