[INFO] crate quire 0.4.1 is already in cache [INFO] extracting crate quire 0.4.1 into work/ex/clippy-test-run/sources/stable/reg/quire/0.4.1 [INFO] extracting crate quire 0.4.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quire/0.4.1 [INFO] validating manifest of quire-0.4.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quire-0.4.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quire-0.4.1 [INFO] finished frobbing quire-0.4.1 [INFO] frobbed toml for quire-0.4.1 written to work/ex/clippy-test-run/sources/stable/reg/quire/0.4.1/Cargo.toml [INFO] started frobbing quire-0.4.1 [INFO] finished frobbing quire-0.4.1 [INFO] frobbed toml for quire-0.4.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quire/0.4.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quire-0.4.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quire/0.4.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4c4f26acc2522c402dcf6ed0f195415dfd59ff371c3802218f5000d1291a2fd9 [INFO] running `"docker" "start" "-a" "4c4f26acc2522c402dcf6ed0f195415dfd59ff371c3802218f5000d1291a2fd9"` [INFO] [stderr] Checking serde-humantime v0.1.1 [INFO] [stderr] Checking serde-transcode v1.1.0 [INFO] [stderr] Checking humannum v0.1.0 [INFO] [stderr] Checking quire v0.4.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | directives: directives, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:765:9 [INFO] [stderr] | [INFO] [stderr] 765 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | result: result, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer.rs:392:13 [INFO] [stderr] | [INFO] [stderr] 392 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | directives: directives, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:765:9 [INFO] [stderr] | [INFO] [stderr] 765 | root: root, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `root` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ast.rs:381:9 [INFO] [stderr] | [INFO] [stderr] 381 | err: err, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `err` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | / return ch == 0x09 || ch == 0x0A || ch == 0x0D [INFO] [stderr] 4 | | || 0x20 <= ch && ch <= 0x7E [INFO] [stderr] 5 | | || ch == 0x85 [INFO] [stderr] 6 | | || 0xA0 <= ch && ch <= 0xD7FF [INFO] [stderr] 7 | | || 0xE000 <= ch && ch <= 0xFFFD [INFO] [stderr] 8 | | || 0x10000 <= ch && ch <= 0x10FFFF; [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 3 | ch == 0x09 || ch == 0x0A || ch == 0x0D [INFO] [stderr] 4 | || 0x20 <= ch && ch <= 0x7E [INFO] [stderr] 5 | || ch == 0x85 [INFO] [stderr] 6 | || 0xA0 <= ch && ch <= 0xD7FF [INFO] [stderr] 7 | || 0xE000 <= ch && ch <= 0xFFFD [INFO] [stderr] 8 | || 0x10000 <= ch && ch <= 0x10FFFF [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chars.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | || 0x10000 <= ch && ch <= 0x10FFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return ch == ',' || ch == '[' || ch == ']' || ch == '{' || ch == '}'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch == ',' || ch == '[' || ch == ']' || ch == '{' || ch == '}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return ch == '\x20' || ch == '\x09' || ch == '\r' || ch == '\n'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch == '\x20' || ch == '\x09' || ch == '\r' || ch == '\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return !is_whitespace(ch) && !is_flow_indicator(ch); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!is_whitespace(ch) && !is_flow_indicator(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return '0' <= ch && ch <= '9'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `'0' <= ch && ch <= '9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return is_dec_digit(ch) || ch == '-' [INFO] [stderr] 29 | | || 'a' <= ch && ch <= 'z' || 'A' <= ch && ch <= 'Z'; [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | is_dec_digit(ch) || ch == '-' [INFO] [stderr] 29 | || 'a' <= ch && ch <= 'z' || 'A' <= ch && ch <= 'Z' [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / return ch == '%' || is_word_char(ch) [INFO] [stderr] 34 | | || ch == '#' [INFO] [stderr] 35 | | || ch == ';' || ch == '/' || ch == '?' || ch == ':' || ch == '@' [INFO] [stderr] 36 | | || ch == '&' || ch == '=' || ch == '+' || ch == '$' [INFO] [stderr] 37 | | || ch == '_' || ch == '.' || ch == '~' || ch == '*' [INFO] [stderr] 38 | | || ch == '\'' || ch == '(' || ch == ')'; [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | ch == '%' || is_word_char(ch) [INFO] [stderr] 34 | || ch == '#' [INFO] [stderr] 35 | || ch == ';' || ch == '/' || ch == '?' || ch == ':' || ch == '@' [INFO] [stderr] 36 | || ch == '&' || ch == '=' || ch == '+' || ch == '$' [INFO] [stderr] 37 | || ch == '_' || ch == '.' || ch == '~' || ch == '*' [INFO] [stderr] 38 | || ch == '\'' || ch == '(' || ch == ')' [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/errors.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return lst; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / return YamlIter { [INFO] [stderr] 123 | | buf: buf, [INFO] [stderr] 124 | | next_value: iter.next(), [INFO] [stderr] 125 | | chars: iter, [INFO] [stderr] ... | [INFO] [stderr] 135 | | error: None, [INFO] [stderr] 136 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | YamlIter { [INFO] [stderr] 123 | buf: buf, [INFO] [stderr] 124 | next_value: iter.next(), [INFO] [stderr] 125 | chars: iter, [INFO] [stderr] 126 | position: Pos { [INFO] [stderr] 127 | filename: filename, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | return Some((pos, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((pos, value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / return Tokenizer { [INFO] [stderr] 197 | | result: result, [INFO] [stderr] 198 | | data: data, [INFO] [stderr] 199 | | iter: YamlIter::new(name, data), [INFO] [stderr] ... | [INFO] [stderr] 203 | | doc_start: true, [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 196 | Tokenizer { [INFO] [stderr] 197 | result: result, [INFO] [stderr] 198 | data: data, [INFO] [stderr] 199 | iter: YamlIter::new(name, data), [INFO] [stderr] 200 | error: None, [INFO] [stderr] 201 | indent_levels: vec!(0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | return iter; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:706:9 [INFO] [stderr] | [INFO] [stderr] 706 | return self.error.clone().or(self.iter.error.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.error.clone().or(self.iter.error.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:715:5 [INFO] [stderr] | [INFO] [stderr] 715 | / return match Tokenizer::new(&mut result, name, data).tokenize() { [INFO] [stderr] 716 | | Some(err) => Err(err), [INFO] [stderr] 717 | | None => Ok(result), [INFO] [stderr] 718 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 715 | match Tokenizer::new(&mut result, name, data).tokenize() { [INFO] [stderr] 716 | Some(err) => Err(err), [INFO] [stderr] 717 | None => Ok(result), [INFO] [stderr] 718 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/options.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return Ast::void(pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::void(pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / return TokenIter { [INFO] [stderr] 30 | | index: 0, [INFO] [stderr] 31 | | tokens: &src[..], [INFO] [stderr] 32 | | eof_token: last, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | TokenIter { [INFO] [stderr] 30 | index: 0, [INFO] [stderr] 31 | tokens: &src[..], [INFO] [stderr] 32 | eof_token: last, [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return self.eof_token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.eof_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | return _compare(self, other); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_compare(self, other)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | return Some(_compare(self, other)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(_compare(self, other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | / return match (self, other) { [INFO] [stderr] 285 | | (&Scalar(_, _, ref a, _), &Scalar(_, _, ref b, _)) => a == b, [INFO] [stderr] 286 | | (&ImplicitNull(_, _, _), &Scalar(_, _, _, _)) => false, [INFO] [stderr] 287 | | (&Scalar(_, _, _, _), &ImplicitNull(_, _, _)) => false, [INFO] [stderr] 288 | | (&ImplicitNull(_, _, _), &ImplicitNull(_, _, _)) => true, [INFO] [stderr] 289 | | _ => unimplemented!(), [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 284 | match (self, other) { [INFO] [stderr] 285 | (&Scalar(_, _, ref a, _), &Scalar(_, _, ref b, _)) => a == b, [INFO] [stderr] 286 | (&ImplicitNull(_, _, _), &Scalar(_, _, _, _)) => false, [INFO] [stderr] 287 | (&Scalar(_, _, _, _), &ImplicitNull(_, _, _)) => false, [INFO] [stderr] 288 | (&ImplicitNull(_, _, _), &ImplicitNull(_, _, _)) => true, [INFO] [stderr] 289 | _ => unimplemented!(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | / return Ok(Seq(tag, anchor, children, [INFO] [stderr] 337 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 336 | Ok(Seq(tag, anchor, children, [INFO] [stderr] 337 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | / return Ok(Map(tag, anchor, children, [INFO] [stderr] 424 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 423 | Ok(Map(tag, anchor, children, [INFO] [stderr] 424 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | / return Ok(Seq(tag, anchor, children, [INFO] [stderr] 458 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 457 | Ok(Seq(tag, anchor, children, [INFO] [stderr] 458 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:522:5 [INFO] [stderr] | [INFO] [stderr] 522 | / return Ok(Map(tag, anchor, children, [INFO] [stderr] 523 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Map(tag, anchor, children, [INFO] [stderr] 523 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | return Ok(Scalar(tag, anchor, plain_value(tok)?, tok)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Scalar(tag, anchor, plain_value(tok)?, tok))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:560:13 [INFO] [stderr] | [INFO] [stderr] 560 | return parse_flow_list(tokiter, aliases, tag, anchor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_flow_list(tokiter, aliases, tag, anchor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | return parse_flow_map(tokiter, aliases, tag, anchor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_flow_map(tokiter, aliases, tag, anchor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:568:28 [INFO] [stderr] | [INFO] [stderr] 568 | Some(x) => return Ok(x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:570:21 [INFO] [stderr] | [INFO] [stderr] 570 | / return Err(Error::parse_error(&tok.start, [INFO] [stderr] 571 | | format!("Unknown alias {:?}", &tok.value[1..]))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 570 | Err(Error::parse_error(&tok.start, [INFO] [stderr] 571 | format!("Unknown alias {:?}", &tok.value[1..]))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:575:14 [INFO] [stderr] | [INFO] [stderr] 575 | _ => return Err(Error::parse_error(&tok.start, [INFO] [stderr] | ______________^ [INFO] [stderr] 576 | | "Expected plain string, sequence or mapping".to_string())), [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 575 | _ => Err(Error::parse_error(&tok.start, [INFO] [stderr] 576 | "Expected plain string, sequence or mapping".to_string())), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | return anchor; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `anchor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:603:5 [INFO] [stderr] | [INFO] [stderr] 603 | return tag; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:712:5 [INFO] [stderr] | [INFO] [stderr] 712 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:750:5 [INFO] [stderr] | [INFO] [stderr] 750 | return Ok((directives, res)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((directives, res))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:763:5 [INFO] [stderr] | [INFO] [stderr] 763 | / return Ok(Document { [INFO] [stderr] 764 | | directives: directives, [INFO] [stderr] 765 | | root: root, [INFO] [stderr] 766 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 763 | Ok(Document { [INFO] [stderr] 764 | directives: directives, [INFO] [stderr] 765 | root: root, [INFO] [stderr] 766 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:781:5 [INFO] [stderr] | [INFO] [stderr] 781 | return Ok(process(doc)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(process(doc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | return visitor.visit_none(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | return visitor.visit_some(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_some(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:464:17 [INFO] [stderr] | [INFO] [stderr] 464 | return visitor.visit_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:467:17 [INFO] [stderr] | [INFO] [stderr] 467 | return visitor.visit_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:470:17 [INFO] [stderr] | [INFO] [stderr] 470 | return visitor.visit_some(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_some(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:522:17 [INFO] [stderr] | [INFO] [stderr] 522 | return visitor.visit_seq(Vec::<()>::new().into_deserializer()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_seq(Vec::<()>::new().into_deserializer())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:525:17 [INFO] [stderr] | [INFO] [stderr] 525 | / return Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 526 | | format!("sequence expected, got {}", node))) [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 525 | Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 526 | format!("sequence expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:569:17 [INFO] [stderr] | [INFO] [stderr] 569 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:572:17 [INFO] [stderr] | [INFO] [stderr] 572 | / return visitor.visit_map( [INFO] [stderr] 573 | | BTreeMap::<(), ()>::new().into_deserializer()); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 572 | visitor.visit_map( [INFO] [stderr] 573 | BTreeMap::<(), ()>::new().into_deserializer()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:576:17 [INFO] [stderr] | [INFO] [stderr] 576 | / return Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 577 | | format!("mapping expected, got {}", node))) [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 576 | Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 577 | format!("mapping expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:610:9 [INFO] [stderr] | [INFO] [stderr] 610 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:631:21 [INFO] [stderr] | [INFO] [stderr] 631 | / return Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 632 | | format!("identifier (string, or tag) \ [INFO] [stderr] 633 | | expected, got {}", node))) [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 631 | Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 632 | format!("identifier (string, or tag) \ [INFO] [stderr] 633 | expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:691:17 [INFO] [stderr] | [INFO] [stderr] 691 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:694:17 [INFO] [stderr] | [INFO] [stderr] 694 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:713:17 [INFO] [stderr] | [INFO] [stderr] 713 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:727:9 [INFO] [stderr] | [INFO] [stderr] 727 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:753:17 [INFO] [stderr] | [INFO] [stderr] 753 | / return Err(Error::decode_error(&node.pos(), &self.0.path, [INFO] [stderr] 754 | | format!("nothing expected, got {}", node))); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 753 | Err(Error::decode_error(&node.pos(), &self.0.path, [INFO] [stderr] 754 | format!("nothing expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sky.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return err.into_result(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.into_result(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sky.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return err.into_result(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.into_result(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | return Map(pos, tag, mapping); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Map(pos, tag, mapping)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | return Seq(pos, tag, seq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Seq(pos, tag, seq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | / return self.options.include(&tok.start, [INFO] [stderr] 179 | | &Include::File { filename: val }, self.err); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | self.options.include(&tok.start, [INFO] [stderr] 179 | &Include::File { filename: val }, self.err) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | / return self.options.include(&tok.start, [INFO] [stderr] 183 | | &Include::Sequence { pattern: val }, self.err); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | self.options.include(&tok.start, [INFO] [stderr] 183 | &Include::Sequence { pattern: val }, self.err) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | / return self.options.include(&tok.start, [INFO] [stderr] 187 | | &Include::Mapping { pattern: val }, self.err); [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 186 | self.options.include(&tok.start, [INFO] [stderr] 187 | &Include::Mapping { pattern: val }, self.err) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | return Ast::Null(tok.start.clone(), tag, Explicit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Null(tok.start.clone(), tag, Explicit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:196:25 [INFO] [stderr] | [INFO] [stderr] 196 | return Ast::Scalar(pos, tag, Plain, val.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Scalar(pos, tag, Plain, val.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:199:21 [INFO] [stderr] | [INFO] [stderr] 199 | return Ast::Scalar(pos, tag, Quoted, val.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Scalar(pos, tag, Quoted, val.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | return Ast::Null(pos.clone(), tag, Implicit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Null(pos.clone(), tag, Implicit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | return self.process(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.process(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | return ctx.process(&doc.root); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ctx.process(&doc.root)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return A::Scalar(pos, T::NonSpecific, kind, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Scalar(pos, T::NonSpecific, kind, val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return A::Scalar(pos, T::NonSpecific, Plain, val.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Scalar(pos, T::NonSpecific, Plain, val.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | return A::Scalar(pos, T::NonSpecific, kind, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Scalar(pos, T::NonSpecific, kind, val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | return Some(A::Map(pos, T::NonSpecific, map)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(A::Map(pos, T::NonSpecific, map))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | return A::Map(pos, T::NonSpecific, map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Map(pos, T::NonSpecific, map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:482:9 [INFO] [stderr] | [INFO] [stderr] 482 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:529:9 [INFO] [stderr] | [INFO] [stderr] 529 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:565:9 [INFO] [stderr] | [INFO] [stderr] 565 | return Some(A::Map(pos, T::NonSpecific, BTreeMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(A::Map(pos, T::NonSpecific, BTreeMap::new()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:594:9 [INFO] [stderr] | [INFO] [stderr] 594 | return A::Map(pos, T::NonSpecific, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Map(pos, T::NonSpecific, res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:668:9 [INFO] [stderr] | [INFO] [stderr] 668 | return A::Seq(pos, T::NonSpecific, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Seq(pos, T::NonSpecific, res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:681:9 [INFO] [stderr] | [INFO] [stderr] 681 | return Some(A::Null(pos.clone(), T::NonSpecific, NullKind::Implicit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(A::Null(pos.clone(), T::NonSpecific, NullKind::Implicit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:684:9 [INFO] [stderr] | [INFO] [stderr] 684 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:696:9 [INFO] [stderr] | [INFO] [stderr] 696 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:704:9 [INFO] [stderr] | [INFO] [stderr] 704 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | / return ch == 0x09 || ch == 0x0A || ch == 0x0D [INFO] [stderr] 4 | | || 0x20 <= ch && ch <= 0x7E [INFO] [stderr] 5 | | || ch == 0x85 [INFO] [stderr] 6 | | || 0xA0 <= ch && ch <= 0xD7FF [INFO] [stderr] 7 | | || 0xE000 <= ch && ch <= 0xFFFD [INFO] [stderr] 8 | | || 0x10000 <= ch && ch <= 0x10FFFF; [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 3 | ch == 0x09 || ch == 0x0A || ch == 0x0D [INFO] [stderr] 4 | || 0x20 <= ch && ch <= 0x7E [INFO] [stderr] 5 | || ch == 0x85 [INFO] [stderr] 6 | || 0xA0 <= ch && ch <= 0xD7FF [INFO] [stderr] 7 | || 0xE000 <= ch && ch <= 0xFFFD [INFO] [stderr] 8 | || 0x10000 <= ch && ch <= 0x10FFFF [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/chars.rs:8:35 [INFO] [stderr] | [INFO] [stderr] 8 | || 0x10000 <= ch && ch <= 0x10FFFF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0010_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return ch == ',' || ch == '[' || ch == ']' || ch == '{' || ch == '}'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch == ',' || ch == '[' || ch == ']' || ch == '{' || ch == '}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return ch == '\x20' || ch == '\x09' || ch == '\r' || ch == '\n'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ch == '\x20' || ch == '\x09' || ch == '\r' || ch == '\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | return !is_whitespace(ch) && !is_flow_indicator(ch); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!is_whitespace(ch) && !is_flow_indicator(ch)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | return '0' <= ch && ch <= '9'; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `'0' <= ch && ch <= '9'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:28:5 [INFO] [stderr] | [INFO] [stderr] 28 | / return is_dec_digit(ch) || ch == '-' [INFO] [stderr] 29 | | || 'a' <= ch && ch <= 'z' || 'A' <= ch && ch <= 'Z'; [INFO] [stderr] | |____________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 28 | is_dec_digit(ch) || ch == '-' [INFO] [stderr] 29 | || 'a' <= ch && ch <= 'z' || 'A' <= ch && ch <= 'Z' [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chars.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / return ch == '%' || is_word_char(ch) [INFO] [stderr] 34 | | || ch == '#' [INFO] [stderr] 35 | | || ch == ';' || ch == '/' || ch == '?' || ch == ':' || ch == '@' [INFO] [stderr] 36 | | || ch == '&' || ch == '=' || ch == '+' || ch == '$' [INFO] [stderr] 37 | | || ch == '_' || ch == '.' || ch == '~' || ch == '*' [INFO] [stderr] 38 | | || ch == '\'' || ch == '(' || ch == ')'; [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 33 | ch == '%' || is_word_char(ch) [INFO] [stderr] 34 | || ch == '#' [INFO] [stderr] 35 | || ch == ';' || ch == '/' || ch == '?' || ch == ':' || ch == '@' [INFO] [stderr] 36 | || ch == '&' || ch == '=' || ch == '+' || ch == '$' [INFO] [stderr] 37 | || ch == '_' || ch == '.' || ch == '~' || ch == '*' [INFO] [stderr] 38 | || ch == '\'' || ch == '(' || ch == ')' [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/errors.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | return lst; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | / return YamlIter { [INFO] [stderr] 123 | | buf: buf, [INFO] [stderr] 124 | | next_value: iter.next(), [INFO] [stderr] 125 | | chars: iter, [INFO] [stderr] ... | [INFO] [stderr] 135 | | error: None, [INFO] [stderr] 136 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 122 | YamlIter { [INFO] [stderr] 123 | buf: buf, [INFO] [stderr] 124 | next_value: iter.next(), [INFO] [stderr] 125 | chars: iter, [INFO] [stderr] 126 | position: Pos { [INFO] [stderr] 127 | filename: filename, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:148:17 [INFO] [stderr] | [INFO] [stderr] 148 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | return Some((pos, value)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some((pos, value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | / return Tokenizer { [INFO] [stderr] 197 | | result: result, [INFO] [stderr] 198 | | data: data, [INFO] [stderr] 199 | | iter: YamlIter::new(name, data), [INFO] [stderr] ... | [INFO] [stderr] 203 | | doc_start: true, [INFO] [stderr] 204 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 196 | Tokenizer { [INFO] [stderr] 197 | result: result, [INFO] [stderr] 198 | data: data, [INFO] [stderr] 199 | iter: YamlIter::new(name, data), [INFO] [stderr] 200 | error: None, [INFO] [stderr] 201 | indent_levels: vec!(0), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | return iter; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:706:9 [INFO] [stderr] | [INFO] [stderr] 706 | return self.error.clone().or(self.iter.error.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.error.clone().or(self.iter.error.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:715:5 [INFO] [stderr] | [INFO] [stderr] 715 | / return match Tokenizer::new(&mut result, name, data).tokenize() { [INFO] [stderr] 716 | | Some(err) => Err(err), [INFO] [stderr] 717 | | None => Ok(result), [INFO] [stderr] 718 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 715 | match Tokenizer::new(&mut result, name, data).tokenize() { [INFO] [stderr] 716 | Some(err) => Err(err), [INFO] [stderr] 717 | None => Ok(result), [INFO] [stderr] 718 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | / return (&vec[0..(vec.len()-1)]).iter().map( [INFO] [stderr] 737 | | |ref tok| { [INFO] [stderr] 738 | | return (tok.kind, tok.value); [INFO] [stderr] 739 | | }).collect(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 736 | (&vec[0..(vec.len()-1)]).iter().map( [INFO] [stderr] 737 | |ref tok| { [INFO] [stderr] 738 | return (tok.kind, tok.value); [INFO] [stderr] 739 | }).collect() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/tokenizer.rs:738:17 [INFO] [stderr] | [INFO] [stderr] 738 | return (tok.kind, tok.value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(tok.kind, tok.value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/options.rs:55:5 [INFO] [stderr] | [INFO] [stderr] 55 | return Ast::void(pos); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::void(pos)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / return TokenIter { [INFO] [stderr] 30 | | index: 0, [INFO] [stderr] 31 | | tokens: &src[..], [INFO] [stderr] 32 | | eof_token: last, [INFO] [stderr] 33 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | TokenIter { [INFO] [stderr] 30 | index: 0, [INFO] [stderr] 31 | tokens: &src[..], [INFO] [stderr] 32 | eof_token: last, [INFO] [stderr] 33 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return self.eof_token; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.eof_token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | return Ok(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:271:9 [INFO] [stderr] | [INFO] [stderr] 271 | return _compare(self, other); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `_compare(self, other)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | return Some(_compare(self, other)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(_compare(self, other))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:284:9 [INFO] [stderr] | [INFO] [stderr] 284 | / return match (self, other) { [INFO] [stderr] 285 | | (&Scalar(_, _, ref a, _), &Scalar(_, _, ref b, _)) => a == b, [INFO] [stderr] 286 | | (&ImplicitNull(_, _, _), &Scalar(_, _, _, _)) => false, [INFO] [stderr] 287 | | (&Scalar(_, _, _, _), &ImplicitNull(_, _, _)) => false, [INFO] [stderr] 288 | | (&ImplicitNull(_, _, _), &ImplicitNull(_, _, _)) => true, [INFO] [stderr] 289 | | _ => unimplemented!(), [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 284 | match (self, other) { [INFO] [stderr] 285 | (&Scalar(_, _, ref a, _), &Scalar(_, _, ref b, _)) => a == b, [INFO] [stderr] 286 | (&ImplicitNull(_, _, _), &Scalar(_, _, _, _)) => false, [INFO] [stderr] 287 | (&Scalar(_, _, _, _), &ImplicitNull(_, _, _)) => false, [INFO] [stderr] 288 | (&ImplicitNull(_, _, _), &ImplicitNull(_, _, _)) => true, [INFO] [stderr] 289 | _ => unimplemented!(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:336:5 [INFO] [stderr] | [INFO] [stderr] 336 | / return Ok(Seq(tag, anchor, children, [INFO] [stderr] 337 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 336 | Ok(Seq(tag, anchor, children, [INFO] [stderr] 337 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:423:5 [INFO] [stderr] | [INFO] [stderr] 423 | / return Ok(Map(tag, anchor, children, [INFO] [stderr] 424 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 423 | Ok(Map(tag, anchor, children, [INFO] [stderr] 424 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:457:5 [INFO] [stderr] | [INFO] [stderr] 457 | / return Ok(Seq(tag, anchor, children, [INFO] [stderr] 458 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 457 | Ok(Seq(tag, anchor, children, [INFO] [stderr] 458 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:522:5 [INFO] [stderr] | [INFO] [stderr] 522 | / return Ok(Map(tag, anchor, children, [INFO] [stderr] 523 | | &tokiter.tokens[begin..tokiter.index])); [INFO] [stderr] | |________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 522 | Ok(Map(tag, anchor, children, [INFO] [stderr] 523 | &tokiter.tokens[begin..tokiter.index])) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | return Ok(Scalar(tag, anchor, plain_value(tok)?, tok)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Scalar(tag, anchor, plain_value(tok)?, tok))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:560:13 [INFO] [stderr] | [INFO] [stderr] 560 | return parse_flow_list(tokiter, aliases, tag, anchor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_flow_list(tokiter, aliases, tag, anchor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | return parse_flow_map(tokiter, aliases, tag, anchor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `parse_flow_map(tokiter, aliases, tag, anchor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:568:28 [INFO] [stderr] | [INFO] [stderr] 568 | Some(x) => return Ok(x.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(x.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:570:21 [INFO] [stderr] | [INFO] [stderr] 570 | / return Err(Error::parse_error(&tok.start, [INFO] [stderr] 571 | | format!("Unknown alias {:?}", &tok.value[1..]))); [INFO] [stderr] | |_________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 570 | Err(Error::parse_error(&tok.start, [INFO] [stderr] 571 | format!("Unknown alias {:?}", &tok.value[1..]))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:575:14 [INFO] [stderr] | [INFO] [stderr] 575 | _ => return Err(Error::parse_error(&tok.start, [INFO] [stderr] | ______________^ [INFO] [stderr] 576 | | "Expected plain string, sequence or mapping".to_string())), [INFO] [stderr] | |______________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 575 | _ => Err(Error::parse_error(&tok.start, [INFO] [stderr] 576 | "Expected plain string, sequence or mapping".to_string())), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | return anchor; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `anchor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:603:5 [INFO] [stderr] | [INFO] [stderr] 603 | return tag; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `tag` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:712:5 [INFO] [stderr] | [INFO] [stderr] 712 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:750:5 [INFO] [stderr] | [INFO] [stderr] 750 | return Ok((directives, res)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((directives, res))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:763:5 [INFO] [stderr] | [INFO] [stderr] 763 | / return Ok(Document { [INFO] [stderr] 764 | | directives: directives, [INFO] [stderr] 765 | | root: root, [INFO] [stderr] 766 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 763 | Ok(Document { [INFO] [stderr] 764 | directives: directives, [INFO] [stderr] 765 | root: root, [INFO] [stderr] 766 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:781:5 [INFO] [stderr] | [INFO] [stderr] 781 | return Ok(process(doc)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(process(doc))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | return visitor.visit_none(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:183:17 [INFO] [stderr] | [INFO] [stderr] 183 | return visitor.visit_some(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_some(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:464:17 [INFO] [stderr] | [INFO] [stderr] 464 | return visitor.visit_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:467:17 [INFO] [stderr] | [INFO] [stderr] 467 | return visitor.visit_none() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_none()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:470:17 [INFO] [stderr] | [INFO] [stderr] 470 | return visitor.visit_some(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_some(self)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:519:17 [INFO] [stderr] | [INFO] [stderr] 519 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:522:17 [INFO] [stderr] | [INFO] [stderr] 522 | return visitor.visit_seq(Vec::<()>::new().into_deserializer()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `visitor.visit_seq(Vec::<()>::new().into_deserializer())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:525:17 [INFO] [stderr] | [INFO] [stderr] 525 | / return Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 526 | | format!("sequence expected, got {}", node))) [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 525 | Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 526 | format!("sequence expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:569:17 [INFO] [stderr] | [INFO] [stderr] 569 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:572:17 [INFO] [stderr] | [INFO] [stderr] 572 | / return visitor.visit_map( [INFO] [stderr] 573 | | BTreeMap::<(), ()>::new().into_deserializer()); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 572 | visitor.visit_map( [INFO] [stderr] 573 | BTreeMap::<(), ()>::new().into_deserializer()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:576:17 [INFO] [stderr] | [INFO] [stderr] 576 | / return Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 577 | | format!("mapping expected, got {}", node))) [INFO] [stderr] | |_______________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 576 | Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 577 | format!("mapping expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:610:9 [INFO] [stderr] | [INFO] [stderr] 610 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:631:21 [INFO] [stderr] | [INFO] [stderr] 631 | / return Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 632 | | format!("identifier (string, or tag) \ [INFO] [stderr] 633 | | expected, got {}", node))) [INFO] [stderr] | |______________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 631 | Err(Error::decode_error(&node.pos(), &self.path, [INFO] [stderr] 632 | format!("identifier (string, or tag) \ [INFO] [stderr] 633 | expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:691:17 [INFO] [stderr] | [INFO] [stderr] 691 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:694:17 [INFO] [stderr] | [INFO] [stderr] 694 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:713:17 [INFO] [stderr] | [INFO] [stderr] 713 | return Ok(None); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(None)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:727:9 [INFO] [stderr] | [INFO] [stderr] 727 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/de.rs:753:17 [INFO] [stderr] | [INFO] [stderr] 753 | / return Err(Error::decode_error(&node.pos(), &self.0.path, [INFO] [stderr] 754 | | format!("nothing expected, got {}", node))); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 753 | Err(Error::decode_error(&node.pos(), &self.0.path, [INFO] [stderr] 754 | format!("nothing expected, got {}", node))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sky.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return err.into_result(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.into_result(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sky.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return err.into_result(res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `err.into_result(res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:167:17 [INFO] [stderr] | [INFO] [stderr] 167 | return Map(pos, tag, mapping); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Map(pos, tag, mapping)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:175:17 [INFO] [stderr] | [INFO] [stderr] 175 | return Seq(pos, tag, seq); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Seq(pos, tag, seq)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:178:17 [INFO] [stderr] | [INFO] [stderr] 178 | / return self.options.include(&tok.start, [INFO] [stderr] 179 | | &Include::File { filename: val }, self.err); [INFO] [stderr] | |________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 178 | self.options.include(&tok.start, [INFO] [stderr] 179 | &Include::File { filename: val }, self.err) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:182:17 [INFO] [stderr] | [INFO] [stderr] 182 | / return self.options.include(&tok.start, [INFO] [stderr] 183 | | &Include::Sequence { pattern: val }, self.err); [INFO] [stderr] | |___________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 182 | self.options.include(&tok.start, [INFO] [stderr] 183 | &Include::Sequence { pattern: val }, self.err) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:186:17 [INFO] [stderr] | [INFO] [stderr] 186 | / return self.options.include(&tok.start, [INFO] [stderr] 187 | | &Include::Mapping { pattern: val }, self.err); [INFO] [stderr] | |__________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 186 | self.options.include(&tok.start, [INFO] [stderr] 187 | &Include::Mapping { pattern: val }, self.err) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | return Ast::Null(tok.start.clone(), tag, Explicit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Null(tok.start.clone(), tag, Explicit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:196:25 [INFO] [stderr] | [INFO] [stderr] 196 | return Ast::Scalar(pos, tag, Plain, val.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Scalar(pos, tag, Plain, val.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:199:21 [INFO] [stderr] | [INFO] [stderr] 199 | return Ast::Scalar(pos, tag, Quoted, val.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Scalar(pos, tag, Quoted, val.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | return Ast::Null(pos.clone(), tag, Implicit); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ast::Null(pos.clone(), tag, Implicit)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:207:17 [INFO] [stderr] | [INFO] [stderr] 207 | return self.process(node); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.process(node)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ast.rs:383:5 [INFO] [stderr] | [INFO] [stderr] 383 | return ctx.process(&doc.root); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ctx.process(&doc.root)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:111:9 [INFO] [stderr] | [INFO] [stderr] 111 | return A::Scalar(pos, T::NonSpecific, kind, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Scalar(pos, T::NonSpecific, kind, val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:196:9 [INFO] [stderr] | [INFO] [stderr] 196 | return A::Scalar(pos, T::NonSpecific, Plain, val.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Scalar(pos, T::NonSpecific, Plain, val.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:286:9 [INFO] [stderr] | [INFO] [stderr] 286 | return A::Scalar(pos, T::NonSpecific, kind, val); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Scalar(pos, T::NonSpecific, kind, val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | return Some(A::Map(pos, T::NonSpecific, map)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(A::Map(pos, T::NonSpecific, map))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:396:9 [INFO] [stderr] | [INFO] [stderr] 396 | return A::Map(pos, T::NonSpecific, map); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Map(pos, T::NonSpecific, map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:482:9 [INFO] [stderr] | [INFO] [stderr] 482 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:529:9 [INFO] [stderr] | [INFO] [stderr] 529 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:565:9 [INFO] [stderr] | [INFO] [stderr] 565 | return Some(A::Map(pos, T::NonSpecific, BTreeMap::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(A::Map(pos, T::NonSpecific, BTreeMap::new()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:594:9 [INFO] [stderr] | [INFO] [stderr] 594 | return A::Map(pos, T::NonSpecific, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Map(pos, T::NonSpecific, res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:668:9 [INFO] [stderr] | [INFO] [stderr] 668 | return A::Seq(pos, T::NonSpecific, res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `A::Seq(pos, T::NonSpecific, res)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:681:9 [INFO] [stderr] | [INFO] [stderr] 681 | return Some(A::Null(pos.clone(), T::NonSpecific, NullKind::Implicit)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(A::Null(pos.clone(), T::NonSpecific, NullKind::Implicit))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:684:9 [INFO] [stderr] | [INFO] [stderr] 684 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:696:9 [INFO] [stderr] | [INFO] [stderr] 696 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/validate.rs:704:9 [INFO] [stderr] | [INFO] [stderr] 704 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/validate.rs:782:21 [INFO] [stderr] | [INFO] [stderr] 782 | intkey: 100000000, [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | loc=if let &Some(ref p) = pos { [INFO] [stderr] | _____________________^ [INFO] [stderr] 56 | | format!("{filename}:{line}:{offset}: ", [INFO] [stderr] 57 | | filename=p.0, line=p.1, offset=p.2) [INFO] [stderr] 58 | | } else { [INFO] [stderr] 59 | | "".to_string() [INFO] [stderr] 60 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | loc=if let Some(ref p) = *pos { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/errors.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn decode_error(pos: &Pos, path: &String, message: String) -> Error { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `errors::ErrorCollector` [INFO] [stderr] --> src/errors.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn new() -> ErrorCollector { [INFO] [stderr] 174 | | ErrorCollector(Rc::new(RefCell::new(Some(ErrorList { [INFO] [stderr] 175 | | errors: Vec::new() [INFO] [stderr] 176 | | })))) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 168 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/errors.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | pub fn into_fatal(&self, err: Error) -> ErrorList { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/errors.rs:193:27 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn into_result(&self, val: T) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/errors.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if lst.errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lst.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/errors.rs:208:37 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn add_info(pos: &Pos, path: &String, result: Result) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/errors.rs:213:48 [INFO] [stderr] | [INFO] [stderr] 213 | Err(Error::decode_error(pos, path, format!("{}", e))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokenizer.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / loop { [INFO] [stderr] 231 | | match self.iter.next_value { [INFO] [stderr] 232 | | Some((_, ch)) => match ch { [INFO] [stderr] 233 | | '[' | ']' | '{' | '}' | ',' if self.flow_level > 0 => { [INFO] [stderr] ... | [INFO] [stderr] 322 | | self.iter.next(); [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((_, ch)) = self.iter.next_value { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokenizer.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | / loop { [INFO] [stderr] 337 | | match self.iter.next() { [INFO] [stderr] 338 | | Some((pos, ch)) => match ch { [INFO] [stderr] 339 | | '\n' | '\r' => { [INFO] [stderr] ... | [INFO] [stderr] 354 | | } [INFO] [stderr] 355 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((pos, ch)) = self.iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tokenizer.rs:402:16 [INFO] [stderr] | [INFO] [stderr] 402 | if !self.error.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.error.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/tokenizer.rs:400:5 [INFO] [stderr] | [INFO] [stderr] 400 | / fn tokenize(&mut self) -> Option<(Pos, Error)> { [INFO] [stderr] 401 | | 'tokenloop: loop { [INFO] [stderr] 402 | | if !self.error.is_none() { [INFO] [stderr] 403 | | break; [INFO] [stderr] ... | [INFO] [stderr] 706 | | return self.error.clone().or(self.iter.error.clone()); [INFO] [stderr] 707 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer.rs:555:21 [INFO] [stderr] | [INFO] [stderr] 555 | / match self.iter.next_value { [INFO] [stderr] 556 | | Some((_, ':')) => { [INFO] [stderr] 557 | | self.iter.next(); [INFO] [stderr] 558 | | let mvalend = self.iter.position.clone(); [INFO] [stderr] ... | [INFO] [stderr] 561 | | _ => {} [INFO] [stderr] 562 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 555 | if let Some((_, ':')) = self.iter.next_value { [INFO] [stderr] 556 | self.iter.next(); [INFO] [stderr] 557 | let mvalend = self.iter.position.clone(); [INFO] [stderr] 558 | self.add_token(MappingValue, end, mvalend); [INFO] [stderr] 559 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:706:35 [INFO] [stderr] | [INFO] [stderr] 706 | return self.error.clone().or(self.iter.error.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.iter.error.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/options.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | format!("Includes are not supported"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Includes are not supported".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | fn new<'x>(src: &'x Vec>) -> TokenIter<'x> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Token<'x>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | let tok = self.tokens.get(idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.tokens[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | / match self { [INFO] [stderr] 297 | | &Scalar(_, _, ref a, _) => write!(fmt, "", a), [INFO] [stderr] 298 | | &ImplicitNull(_, _, _) => write!(fmt, ""), [INFO] [stderr] 299 | | _ => unimplemented!(), [INFO] [stderr] 300 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 296 | match *self { [INFO] [stderr] 297 | Scalar(_, _, ref a, _) => write!(fmt, "", a), [INFO] [stderr] 298 | ImplicitNull(_, _, _) => write!(fmt, ""), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:530:5 [INFO] [stderr] | [INFO] [stderr] 530 | / match &res { [INFO] [stderr] 531 | | &Map(_, Some(anchor), _, _) [INFO] [stderr] 532 | | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 533 | | &Map(_, None, _, _) => {} [INFO] [stderr] ... | [INFO] [stderr] 543 | | &Alias(_, _, _) => {} [INFO] [stderr] 544 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 530 | match res { [INFO] [stderr] 531 | Map(_, Some(anchor), _, _) [INFO] [stderr] 532 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 533 | Map(_, None, _, _) => {} [INFO] [stderr] 534 | Seq(_, Some(anchor), _, _) [INFO] [stderr] 535 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:583:5 [INFO] [stderr] | [INFO] [stderr] 583 | / match tok.kind { [INFO] [stderr] 584 | | T::Anchor => { [INFO] [stderr] 585 | | anchor = Some(&tok.value[1..]); [INFO] [stderr] 586 | | tokiter.next(); [INFO] [stderr] 587 | | } [INFO] [stderr] 588 | | _ => {} [INFO] [stderr] 589 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 583 | if let T::Anchor = tok.kind { [INFO] [stderr] 584 | anchor = Some(&tok.value[1..]); [INFO] [stderr] 585 | tokiter.next(); [INFO] [stderr] 586 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:596:5 [INFO] [stderr] | [INFO] [stderr] 596 | / match tok.kind { [INFO] [stderr] 597 | | T::Tag => { [INFO] [stderr] 598 | | tag = Some(tok.value); [INFO] [stderr] 599 | | tokiter.next(); [INFO] [stderr] 600 | | } [INFO] [stderr] 601 | | _ => {} [INFO] [stderr] 602 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 596 | if let T::Tag = tok.kind { [INFO] [stderr] 597 | tag = Some(tok.value); [INFO] [stderr] 598 | tokiter.next(); [INFO] [stderr] 599 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / match &res { [INFO] [stderr] 610 | | &Map(_, Some(anchor), _, _) [INFO] [stderr] 611 | | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 612 | | &Map(_, None, _, _) => {} [INFO] [stderr] ... | [INFO] [stderr] 622 | | &Alias(_, _, _) => {} [INFO] [stderr] 623 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 609 | match res { [INFO] [stderr] 610 | Map(_, Some(anchor), _, _) [INFO] [stderr] 611 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 612 | Map(_, None, _, _) => {} [INFO] [stderr] 613 | Seq(_, Some(anchor), _, _) [INFO] [stderr] 614 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/parser.rs:737:5 [INFO] [stderr] | [INFO] [stderr] 737 | / loop { [INFO] [stderr] 738 | | let tok = match tokiter.next() { [INFO] [stderr] 739 | | Some(tok) => tok, [INFO] [stderr] 740 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 748 | | } [INFO] [stderr] 749 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:737:5 [INFO] [stderr] | [INFO] [stderr] 737 | / loop { [INFO] [stderr] 738 | | let tok = match tokiter.next() { [INFO] [stderr] 739 | | Some(tok) => tok, [INFO] [stderr] 740 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 748 | | } [INFO] [stderr] 749 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(tok) = tokiter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:754:33 [INFO] [stderr] | [INFO] [stderr] 754 | pub fn parse_tokens<'x>(tokens: &'x Vec>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Token<'x>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/de.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn new<'x>(ast: &'x Ast) -> Deserializer<'x> { [INFO] [stderr] 41 | | Deserializer { [INFO] [stderr] 42 | | ast: &ast, [INFO] [stderr] 43 | | mode: Mode::Normal, [INFO] [stderr] 44 | | path: "".to_string(), [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ast.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn tag<'x>(&'x self) -> &'x Tag { [INFO] [stderr] 98 | | match *self { [INFO] [stderr] 99 | | Map(_, ref tag, _) => tag, [INFO] [stderr] 100 | | Seq(_, ref tag, _) => tag, [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/ast.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | / if !target.contains_key(&string_key) { [INFO] [stderr] 229 | | target.insert(string_key, value); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____________________^ help: consider using: `target.entry(string_key).or_insert(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ast.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | / match merge { [INFO] [stderr] 233 | | Some(node) => self.merge_mapping(target, node), [INFO] [stderr] 234 | | _ => {} [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(node) = merge { self.merge_mapping(target, node) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/ast.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | / if !target.contains_key(&k) { [INFO] [stderr] 269 | | // We don't make deep merging here, because other map [INFO] [stderr] 270 | | // is already merged [INFO] [stderr] 271 | | target.insert(k, v); [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____________________^ help: consider using: `target.entry(k).or_insert(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Scalar` [INFO] [stderr] --> src/validate.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Scalar { [INFO] [stderr] 52 | | Scalar { [INFO] [stderr] 53 | | optional: false, [INFO] [stderr] 54 | | default: None, [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | format!("Value must be scalar"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be scalar".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | self.min_length.map(|minl| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 100 | || if val.len() < minl { [INFO] [stderr] 101 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 102 | || format!("Value must be at least {} characters", minl))); [INFO] [stderr] 103 | || } [INFO] [stderr] 104 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(minl) = self.min_length { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | self.max_length.map(|maxl| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 106 | || if val.len() > maxl { [INFO] [stderr] 107 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 108 | || format!("Value must be at most {} characters", maxl))); [INFO] [stderr] 109 | || } [INFO] [stderr] 110 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(maxl) = self.max_length { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Numeric` [INFO] [stderr] --> src/validate.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn new() -> Numeric { [INFO] [stderr] 129 | | Numeric { [INFO] [stderr] 130 | | optional: false, [INFO] [stderr] 131 | | default: None, [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | format!("Value must be scalar"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be scalar".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | self.min.as_ref().map(|min| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 185 | || if val < *min { [INFO] [stderr] 186 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 187 | || format!("Value must be at least {}", min))); [INFO] [stderr] 188 | || } [INFO] [stderr] 189 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(min) = self.min.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | self.max.as_ref().map(|max| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 191 | || if val > *max { [INFO] [stderr] 192 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 193 | || format!("Value must be at most {}", max))); [INFO] [stderr] 194 | || } [INFO] [stderr] 195 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(max) = self.max.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Directory` [INFO] [stderr] --> src/validate.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / pub fn new() -> Directory { [INFO] [stderr] 213 | | Directory { [INFO] [stderr] 214 | | optional: false, [INFO] [stderr] 215 | | default: None, [INFO] [stderr] 216 | | absolute: None, [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | format!("Path expected"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Path expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:262:29 [INFO] [stderr] | [INFO] [stderr] 262 | format!("Path must be absolute"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Path must be absolute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:268:29 [INFO] [stderr] | [INFO] [stderr] 268 | format!("Path must not be absolute"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Path must not be absolute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:278:37 [INFO] [stderr] | [INFO] [stderr] 278 | format!("The /../ is not allowed in path"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The /../ is not allowed in path".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Structure<'a>` [INFO] [stderr] --> src/validate.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | / pub fn new() -> Structure<'a> { [INFO] [stderr] 308 | | Structure { [INFO] [stderr] 309 | | members: Vec::new(), [INFO] [stderr] 310 | | optional: false, [INFO] [stderr] 311 | | from_scalar: None, [INFO] [stderr] 312 | | } [INFO] [stderr] 313 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 300 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:362:21 [INFO] [stderr] | [INFO] [stderr] 362 | format!("Value must be mapping"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be mapping".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/validate.rs:368:18 [INFO] [stderr] | [INFO] [stderr] 368 | .or(map.remove(&k[..].replace("_", "-"))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| map.remove(&k[..].replace("_", "-")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/validate.rs:386:16 [INFO] [stderr] | [INFO] [stderr] 386 | keys = map.keys() [INFO] [stderr] | ________________^ [INFO] [stderr] 387 | | .filter(|s| !&s[..].starts_with("_")) [INFO] [stderr] 388 | | .map(|s| s.clone()).collect(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 386 | keys = map.keys() [INFO] [stderr] 387 | .filter(|s| !&s[..].starts_with("_")).cloned().collect(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/validate.rs:387:45 [INFO] [stderr] | [INFO] [stderr] 387 | .filter(|s| !&s[..].starts_with("_")) [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validate.rs:392:12 [INFO] [stderr] | [INFO] [stderr] 392 | if keys.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Enum<'a>` [INFO] [stderr] --> src/validate.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | / pub fn new() -> Enum<'a> { [INFO] [stderr] 427 | | Enum { [INFO] [stderr] 428 | | options: Vec::new(), [INFO] [stderr] 429 | | optional: false, [INFO] [stderr] ... | [INFO] [stderr] 433 | | } [INFO] [stderr] 434 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 417 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validate.rs:485:24 [INFO] [stderr] | [INFO] [stderr] 485 | let tag_name = match ast.tag() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 486 | | &T::LocalTag(ref tag_name) => { [INFO] [stderr] 487 | | Some(tag_name.clone()) [INFO] [stderr] 488 | | } [INFO] [stderr] ... | [INFO] [stderr] 516 | | _ => unimplemented!(), [INFO] [stderr] 517 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 485 | let tag_name = match *ast.tag() { [INFO] [stderr] 486 | T::LocalTag(ref tag_name) => { [INFO] [stderr] 487 | Some(tag_name.clone()) [INFO] [stderr] 488 | } [INFO] [stderr] 489 | T::NonSpecific => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/validate.rs:521:20 [INFO] [stderr] | [INFO] [stderr] 521 | if &k[..] == &tag_name[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 521 | if k[..] == tag_name[..] { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:580:21 [INFO] [stderr] | [INFO] [stderr] 580 | format!("Value must be mapping"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be mapping".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:654:21 [INFO] [stderr] | [INFO] [stderr] 654 | format!("Value must be sequence"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be sequence".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quire`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/errors.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | loc=if let &Some(ref p) = pos { [INFO] [stderr] | _____________________^ [INFO] [stderr] 56 | | format!("{filename}:{line}:{offset}: ", [INFO] [stderr] 57 | | filename=p.0, line=p.1, offset=p.2) [INFO] [stderr] 58 | | } else { [INFO] [stderr] 59 | | "".to_string() [INFO] [stderr] 60 | | }, [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 55 | loc=if let Some(ref p) = *pos { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/errors.rs:92:42 [INFO] [stderr] | [INFO] [stderr] 92 | pub fn decode_error(pos: &Pos, path: &String, message: String) -> Error { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `errors::ErrorCollector` [INFO] [stderr] --> src/errors.rs:173:5 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn new() -> ErrorCollector { [INFO] [stderr] 174 | | ErrorCollector(Rc::new(RefCell::new(Some(ErrorList { [INFO] [stderr] 175 | | errors: Vec::new() [INFO] [stderr] 176 | | })))) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 168 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/errors.rs:185:23 [INFO] [stderr] | [INFO] [stderr] 185 | pub fn into_fatal(&self, err: Error) -> ErrorList { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/errors.rs:193:27 [INFO] [stderr] | [INFO] [stderr] 193 | pub fn into_result(&self, val: T) -> Result { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/errors.rs:195:12 [INFO] [stderr] | [INFO] [stderr] 195 | if lst.errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!lst.errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/errors.rs:208:37 [INFO] [stderr] | [INFO] [stderr] 208 | pub fn add_info(pos: &Pos, path: &String, result: Result) [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/errors.rs:213:48 [INFO] [stderr] | [INFO] [stderr] 213 | Err(Error::decode_error(pos, path, format!("{}", e))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using .to_string(): `e.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokenizer.rs:230:9 [INFO] [stderr] | [INFO] [stderr] 230 | / loop { [INFO] [stderr] 231 | | match self.iter.next_value { [INFO] [stderr] 232 | | Some((_, ch)) => match ch { [INFO] [stderr] 233 | | '[' | ']' | '{' | '}' | ',' if self.flow_level > 0 => { [INFO] [stderr] ... | [INFO] [stderr] 322 | | self.iter.next(); [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((_, ch)) = self.iter.next_value { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/tokenizer.rs:336:9 [INFO] [stderr] | [INFO] [stderr] 336 | / loop { [INFO] [stderr] 337 | | match self.iter.next() { [INFO] [stderr] 338 | | Some((pos, ch)) => match ch { [INFO] [stderr] 339 | | '\n' | '\r' => { [INFO] [stderr] ... | [INFO] [stderr] 354 | | } [INFO] [stderr] 355 | | } [INFO] [stderr] | |_________^ help: try: `while let Some((pos, ch)) = self.iter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/tokenizer.rs:402:16 [INFO] [stderr] | [INFO] [stderr] 402 | if !self.error.is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `self.error.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 35 [INFO] [stderr] --> src/tokenizer.rs:400:5 [INFO] [stderr] | [INFO] [stderr] 400 | / fn tokenize(&mut self) -> Option<(Pos, Error)> { [INFO] [stderr] 401 | | 'tokenloop: loop { [INFO] [stderr] 402 | | if !self.error.is_none() { [INFO] [stderr] 403 | | break; [INFO] [stderr] ... | [INFO] [stderr] 706 | | return self.error.clone().or(self.iter.error.clone()); [INFO] [stderr] 707 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/tokenizer.rs:555:21 [INFO] [stderr] | [INFO] [stderr] 555 | / match self.iter.next_value { [INFO] [stderr] 556 | | Some((_, ':')) => { [INFO] [stderr] 557 | | self.iter.next(); [INFO] [stderr] 558 | | let mvalend = self.iter.position.clone(); [INFO] [stderr] ... | [INFO] [stderr] 561 | | _ => {} [INFO] [stderr] 562 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 555 | if let Some((_, ':')) = self.iter.next_value { [INFO] [stderr] 556 | self.iter.next(); [INFO] [stderr] 557 | let mvalend = self.iter.position.clone(); [INFO] [stderr] 558 | self.add_token(MappingValue, end, mvalend); [INFO] [stderr] 559 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/tokenizer.rs:706:35 [INFO] [stderr] | [INFO] [stderr] 706 | return self.error.clone().or(self.iter.error.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| self.iter.error.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1037:17 [INFO] [stderr] | [INFO] [stderr] 1037 | assert_eq!(&format!("{}", err)[..], ":1:2: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1044:17 [INFO] [stderr] | [INFO] [stderr] 1044 | assert_eq!(&format!("{}", err), ":1:1: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1047:17 [INFO] [stderr] | [INFO] [stderr] 1047 | assert_eq!(&format!("{}", err), ":2:3: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1060:17 [INFO] [stderr] | [INFO] [stderr] 1060 | assert_eq!(&format!("{}", err), ":1:1: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1066:17 [INFO] [stderr] | [INFO] [stderr] 1066 | assert_eq!(&format!("{}", err), ":1:1: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1072:17 [INFO] [stderr] | [INFO] [stderr] 1072 | assert_eq!(&format!("{}", err), ":2:3: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1078:17 [INFO] [stderr] | [INFO] [stderr] 1078 | assert_eq!(&format!("{}", err), ":2:1: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1084:17 [INFO] [stderr] | [INFO] [stderr] 1084 | assert_eq!(&format!("{}", err), ":1:2: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1100:17 [INFO] [stderr] | [INFO] [stderr] 1100 | assert_eq!(&format!("{}", err), ":1:6: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1117:17 [INFO] [stderr] | [INFO] [stderr] 1117 | assert_eq!(&format!("{}", err), ":1:6: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1143:17 [INFO] [stderr] | [INFO] [stderr] 1143 | assert_eq!(&format!("{}", err), ":1:3: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1154:17 [INFO] [stderr] | [INFO] [stderr] 1154 | assert_eq!(&format!("{}", err), ":1:3: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1157:17 [INFO] [stderr] | [INFO] [stderr] 1157 | assert_eq!(&format!("{}", err), ":1:1: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tokenizer.rs:1177:17 [INFO] [stderr] | [INFO] [stderr] 1177 | assert_eq!(&format!("{}", err), ":1:1: \ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/options.rs:54:9 [INFO] [stderr] | [INFO] [stderr] 54 | format!("Includes are not supported"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Includes are not supported".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:26:21 [INFO] [stderr] | [INFO] [stderr] 26 | fn new<'x>(src: &'x Vec>) -> TokenIter<'x> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Token<'x>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise [INFO] [stderr] --> src/parser.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | let tok = self.tokens.get(idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.tokens[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:296:9 [INFO] [stderr] | [INFO] [stderr] 296 | / match self { [INFO] [stderr] 297 | | &Scalar(_, _, ref a, _) => write!(fmt, "", a), [INFO] [stderr] 298 | | &ImplicitNull(_, _, _) => write!(fmt, ""), [INFO] [stderr] 299 | | _ => unimplemented!(), [INFO] [stderr] 300 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 296 | match *self { [INFO] [stderr] 297 | Scalar(_, _, ref a, _) => write!(fmt, "", a), [INFO] [stderr] 298 | ImplicitNull(_, _, _) => write!(fmt, ""), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:530:5 [INFO] [stderr] | [INFO] [stderr] 530 | / match &res { [INFO] [stderr] 531 | | &Map(_, Some(anchor), _, _) [INFO] [stderr] 532 | | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 533 | | &Map(_, None, _, _) => {} [INFO] [stderr] ... | [INFO] [stderr] 543 | | &Alias(_, _, _) => {} [INFO] [stderr] 544 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 530 | match res { [INFO] [stderr] 531 | Map(_, Some(anchor), _, _) [INFO] [stderr] 532 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 533 | Map(_, None, _, _) => {} [INFO] [stderr] 534 | Seq(_, Some(anchor), _, _) [INFO] [stderr] 535 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:583:5 [INFO] [stderr] | [INFO] [stderr] 583 | / match tok.kind { [INFO] [stderr] 584 | | T::Anchor => { [INFO] [stderr] 585 | | anchor = Some(&tok.value[1..]); [INFO] [stderr] 586 | | tokiter.next(); [INFO] [stderr] 587 | | } [INFO] [stderr] 588 | | _ => {} [INFO] [stderr] 589 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 583 | if let T::Anchor = tok.kind { [INFO] [stderr] 584 | anchor = Some(&tok.value[1..]); [INFO] [stderr] 585 | tokiter.next(); [INFO] [stderr] 586 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:596:5 [INFO] [stderr] | [INFO] [stderr] 596 | / match tok.kind { [INFO] [stderr] 597 | | T::Tag => { [INFO] [stderr] 598 | | tag = Some(tok.value); [INFO] [stderr] 599 | | tokiter.next(); [INFO] [stderr] 600 | | } [INFO] [stderr] 601 | | _ => {} [INFO] [stderr] 602 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 596 | if let T::Tag = tok.kind { [INFO] [stderr] 597 | tag = Some(tok.value); [INFO] [stderr] 598 | tokiter.next(); [INFO] [stderr] 599 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/parser.rs:609:5 [INFO] [stderr] | [INFO] [stderr] 609 | / match &res { [INFO] [stderr] 610 | | &Map(_, Some(anchor), _, _) [INFO] [stderr] 611 | | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 612 | | &Map(_, None, _, _) => {} [INFO] [stderr] ... | [INFO] [stderr] 622 | | &Alias(_, _, _) => {} [INFO] [stderr] 623 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 609 | match res { [INFO] [stderr] 610 | Map(_, Some(anchor), _, _) [INFO] [stderr] 611 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] 612 | Map(_, None, _, _) => {} [INFO] [stderr] 613 | Seq(_, Some(anchor), _, _) [INFO] [stderr] 614 | => { aliases.insert(anchor, res.clone()); } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/parser.rs:737:5 [INFO] [stderr] | [INFO] [stderr] 737 | / loop { [INFO] [stderr] 738 | | let tok = match tokiter.next() { [INFO] [stderr] 739 | | Some(tok) => tok, [INFO] [stderr] 740 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 748 | | } [INFO] [stderr] 749 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/parser.rs:737:5 [INFO] [stderr] | [INFO] [stderr] 737 | / loop { [INFO] [stderr] 738 | | let tok = match tokiter.next() { [INFO] [stderr] 739 | | Some(tok) => tok, [INFO] [stderr] 740 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 748 | | } [INFO] [stderr] 749 | | } [INFO] [stderr] | |_____^ help: try: `while let Some(tok) = tokiter.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:754:33 [INFO] [stderr] | [INFO] [stderr] 754 | pub fn parse_tokens<'x>(tokens: &'x Vec>) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[Token<'x>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/de.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | / pub fn new<'x>(ast: &'x Ast) -> Deserializer<'x> { [INFO] [stderr] 41 | | Deserializer { [INFO] [stderr] 42 | | ast: &ast, [INFO] [stderr] 43 | | mode: Mode::Normal, [INFO] [stderr] 44 | | path: "".to_string(), [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/ast.rs:97:5 [INFO] [stderr] | [INFO] [stderr] 97 | / pub fn tag<'x>(&'x self) -> &'x Tag { [INFO] [stderr] 98 | | match *self { [INFO] [stderr] 99 | | Map(_, ref tag, _) => tag, [INFO] [stderr] 100 | | Seq(_, ref tag, _) => tag, [INFO] [stderr] ... | [INFO] [stderr] 103 | | } [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/ast.rs:228:21 [INFO] [stderr] | [INFO] [stderr] 228 | / if !target.contains_key(&string_key) { [INFO] [stderr] 229 | | target.insert(string_key, value); [INFO] [stderr] 230 | | } [INFO] [stderr] | |_____________________^ help: consider using: `target.entry(string_key).or_insert(value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ast.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | / match merge { [INFO] [stderr] 233 | | Some(node) => self.merge_mapping(target, node), [INFO] [stderr] 234 | | _ => {} [INFO] [stderr] 235 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(node) = merge { self.merge_mapping(target, node) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `BTreeMap` [INFO] [stderr] --> src/ast.rs:268:21 [INFO] [stderr] | [INFO] [stderr] 268 | / if !target.contains_key(&k) { [INFO] [stderr] 269 | | // We don't make deep merging here, because other map [INFO] [stderr] 270 | | // is already merged [INFO] [stderr] 271 | | target.insert(k, v); [INFO] [stderr] 272 | | } [INFO] [stderr] | |_____________________^ help: consider using: `target.entry(k).or_insert(v)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Scalar` [INFO] [stderr] --> src/validate.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn new() -> Scalar { [INFO] [stderr] 52 | | Scalar { [INFO] [stderr] 53 | | optional: false, [INFO] [stderr] 54 | | default: None, [INFO] [stderr] ... | [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 43 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | format!("Value must be scalar"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be scalar".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | self.min_length.map(|minl| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 100 | || if val.len() < minl { [INFO] [stderr] 101 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 102 | || format!("Value must be at least {} characters", minl))); [INFO] [stderr] 103 | || } [INFO] [stderr] 104 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(minl) = self.min_length { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | self.max_length.map(|maxl| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 106 | || if val.len() > maxl { [INFO] [stderr] 107 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 108 | || format!("Value must be at most {} characters", maxl))); [INFO] [stderr] 109 | || } [INFO] [stderr] 110 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(maxl) = self.max_length { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Numeric` [INFO] [stderr] --> src/validate.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | / pub fn new() -> Numeric { [INFO] [stderr] 129 | | Numeric { [INFO] [stderr] 130 | | optional: false, [INFO] [stderr] 131 | | default: None, [INFO] [stderr] ... | [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 120 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:180:21 [INFO] [stderr] | [INFO] [stderr] 180 | format!("Value must be scalar"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be scalar".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:184:9 [INFO] [stderr] | [INFO] [stderr] 184 | self.min.as_ref().map(|min| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 185 | || if val < *min { [INFO] [stderr] 186 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 187 | || format!("Value must be at least {}", min))); [INFO] [stderr] 188 | || } [INFO] [stderr] 189 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(min) = self.min.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/validate.rs:190:9 [INFO] [stderr] | [INFO] [stderr] 190 | self.max.as_ref().map(|max| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 191 | || if val > *max { [INFO] [stderr] 192 | || err.add_error(Error::validation_error(&pos, [INFO] [stderr] 193 | || format!("Value must be at most {}", max))); [INFO] [stderr] 194 | || } [INFO] [stderr] 195 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(max) = self.max.as_ref() { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Directory` [INFO] [stderr] --> src/validate.rs:212:5 [INFO] [stderr] | [INFO] [stderr] 212 | / pub fn new() -> Directory { [INFO] [stderr] 213 | | Directory { [INFO] [stderr] 214 | | optional: false, [INFO] [stderr] 215 | | default: None, [INFO] [stderr] 216 | | absolute: None, [INFO] [stderr] 217 | | } [INFO] [stderr] 218 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:252:21 [INFO] [stderr] | [INFO] [stderr] 252 | format!("Path expected"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Path expected".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:262:29 [INFO] [stderr] | [INFO] [stderr] 262 | format!("Path must be absolute"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Path must be absolute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:268:29 [INFO] [stderr] | [INFO] [stderr] 268 | format!("Path must not be absolute"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Path must not be absolute".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:278:37 [INFO] [stderr] | [INFO] [stderr] 278 | format!("The /../ is not allowed in path"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The /../ is not allowed in path".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Structure<'a>` [INFO] [stderr] --> src/validate.rs:307:5 [INFO] [stderr] | [INFO] [stderr] 307 | / pub fn new() -> Structure<'a> { [INFO] [stderr] 308 | | Structure { [INFO] [stderr] 309 | | members: Vec::new(), [INFO] [stderr] 310 | | optional: false, [INFO] [stderr] 311 | | from_scalar: None, [INFO] [stderr] 312 | | } [INFO] [stderr] 313 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 300 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:362:21 [INFO] [stderr] | [INFO] [stderr] 362 | format!("Value must be mapping"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be mapping".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/validate.rs:368:18 [INFO] [stderr] | [INFO] [stderr] 368 | .or(map.remove(&k[..].replace("_", "-"))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_else(|| map.remove(&k[..].replace("_", "-")))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/validate.rs:386:16 [INFO] [stderr] | [INFO] [stderr] 386 | keys = map.keys() [INFO] [stderr] | ________________^ [INFO] [stderr] 387 | | .filter(|s| !&s[..].starts_with("_")) [INFO] [stderr] 388 | | .map(|s| s.clone()).collect(); [INFO] [stderr] | |_______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 386 | keys = map.keys() [INFO] [stderr] 387 | .filter(|s| !&s[..].starts_with("_")).cloned().collect(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/validate.rs:387:45 [INFO] [stderr] | [INFO] [stderr] 387 | .filter(|s| !&s[..].starts_with("_")) [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/validate.rs:392:12 [INFO] [stderr] | [INFO] [stderr] 392 | if keys.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keys.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `validate::Enum<'a>` [INFO] [stderr] --> src/validate.rs:426:5 [INFO] [stderr] | [INFO] [stderr] 426 | / pub fn new() -> Enum<'a> { [INFO] [stderr] 427 | | Enum { [INFO] [stderr] 428 | | options: Vec::new(), [INFO] [stderr] 429 | | optional: false, [INFO] [stderr] ... | [INFO] [stderr] 433 | | } [INFO] [stderr] 434 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 417 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/validate.rs:485:24 [INFO] [stderr] | [INFO] [stderr] 485 | let tag_name = match ast.tag() { [INFO] [stderr] | ________________________^ [INFO] [stderr] 486 | | &T::LocalTag(ref tag_name) => { [INFO] [stderr] 487 | | Some(tag_name.clone()) [INFO] [stderr] 488 | | } [INFO] [stderr] ... | [INFO] [stderr] 516 | | _ => unimplemented!(), [INFO] [stderr] 517 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 485 | let tag_name = match *ast.tag() { [INFO] [stderr] 486 | T::LocalTag(ref tag_name) => { [INFO] [stderr] 487 | Some(tag_name.clone()) [INFO] [stderr] 488 | } [INFO] [stderr] 489 | T::NonSpecific => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/validate.rs:521:20 [INFO] [stderr] | [INFO] [stderr] 521 | if &k[..] == &tag_name[..] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 521 | if k[..] == tag_name[..] { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:580:21 [INFO] [stderr] | [INFO] [stderr] 580 | format!("Value must be mapping"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be mapping".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:654:21 [INFO] [stderr] | [INFO] [stderr] 654 | format!("Value must be sequence"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Value must be sequence".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/validate.rs:1024:32 [INFO] [stderr] | [INFO] [stderr] 1024 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/validate.rs:1046:32 [INFO] [stderr] | [INFO] [stderr] 1046 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/validate.rs:1487:45 [INFO] [stderr] | [INFO] [stderr] 1487 | if !version.starts_with("v") { [INFO] [stderr] | ^^^ help: try using a char instead: `'v'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/validate.rs:1496:37 [INFO] [stderr] | [INFO] [stderr] 1496 | &ast.pos(), format!("Version must be a scalar value"))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Version must be a scalar value".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quire`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4c4f26acc2522c402dcf6ed0f195415dfd59ff371c3802218f5000d1291a2fd9"` [INFO] running `"docker" "rm" "-f" "4c4f26acc2522c402dcf6ed0f195415dfd59ff371c3802218f5000d1291a2fd9"` [INFO] [stdout] 4c4f26acc2522c402dcf6ed0f195415dfd59ff371c3802218f5000d1291a2fd9