[INFO] crate quinn-proto 0.1.0 is already in cache [INFO] extracting crate quinn-proto 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/quinn-proto/0.1.0 [INFO] extracting crate quinn-proto 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quinn-proto/0.1.0 [INFO] validating manifest of quinn-proto-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quinn-proto-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quinn-proto-0.1.0 [INFO] finished frobbing quinn-proto-0.1.0 [INFO] frobbed toml for quinn-proto-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/quinn-proto/0.1.0/Cargo.toml [INFO] started frobbing quinn-proto-0.1.0 [INFO] finished frobbing quinn-proto-0.1.0 [INFO] frobbed toml for quinn-proto-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quinn-proto/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quinn-proto-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quinn-proto/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 29c6184c7795c584bfaea23c280a1d34648ad2249750cd2e071e2e1092eb7eef [INFO] running `"docker" "start" "-a" "29c6184c7795c584bfaea23c280a1d34648ad2249750cd2e071e2e1092eb7eef"` [INFO] [stderr] Checking rustls v0.14.0 [INFO] [stderr] Checking blake2 v0.7.1 [INFO] [stderr] Checking quinn-proto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypto.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypto.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | cipher: cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypto.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | digest: digest, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `digest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/crypto.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | cipher: cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/connection.rs:422:17 [INFO] [stderr] | [INFO] [stderr] 422 | assert!(self.largest_sent_packet <= 2u64.pow(62) - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 422 | assert!(self.largest_sent_packet < 2u64.pow(62)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/tests.rs:164:16 [INFO] [stderr] | [INFO] [stderr] 164 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 165 | | if server_t != self.time { [INFO] [stderr] 166 | | self.time = self.time.max(server_t); [INFO] [stderr] 167 | | trace!(self.log, "advancing to {time} for server", time = self.time); [INFO] [stderr] 168 | | } [INFO] [stderr] 169 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 164 | } else if server_t != self.time { [INFO] [stderr] 165 | self.time = self.time.max(server_t); [INFO] [stderr] 166 | trace!(self.log, "advancing to {time} for server", time = self.time); [INFO] [stderr] 167 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/connection.rs:422:17 [INFO] [stderr] | [INFO] [stderr] 422 | assert!(self.largest_sent_packet <= 2u64.pow(62) - 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 422 | assert!(self.largest_sent_packet < 2u64.pow(62)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/crypto.rs:454:38 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!(PacketNumber::U32(0xa0bd197c).expand(0xa0bd197a), 0xa0bd197c); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa0bd_197c` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/crypto.rs:454:57 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!(PacketNumber::U32(0xa0bd197c).expand(0xa0bd197a), 0xa0bd197c); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa0bd_197a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/crypto.rs:454:70 [INFO] [stderr] | [INFO] [stderr] 454 | assert_eq!(PacketNumber::U32(0xa0bd197c).expand(0xa0bd197a), 0xa0bd197c); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa0bd_197c` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `range_set::RangeSet` [INFO] [stderr] --> src/range_set.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | RangeSet(BTreeMap::new()) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn was_reset(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | 0b00 => buf[0] as u64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | BigEndian::read_u16(&buf) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BigEndian::read_u16(&buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | BigEndian::read_u32(&buf) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BigEndian::read_u32(&buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/connection.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | pub set_idle: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/connection.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | pub set_loss_detection: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:287:37 [INFO] [stderr] | [INFO] [stderr] 287 | let max_remote_bi_streams = config.max_remote_bi_streams as u64 + match side { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.max_remote_bi_streams)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:298:32 [INFO] [stderr] | [INFO] [stderr] 298 | Stream::new_bi(config.stream_receive_window as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.stream_receive_window)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:321:29 [INFO] [stderr] | [INFO] [stderr] 321 | local_max_data: config.receive_window as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.receive_window)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:369:37 [INFO] [stderr] | [INFO] [stderr] 369 | max_remote_uni_streams: config.max_remote_uni_streams as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.max_remote_uni_streams)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:445:37 [INFO] [stderr] | [INFO] [stderr] 445 | self.bytes_in_flight += bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:513:37 [INFO] [stderr] | [INFO] [stderr] 513 | self.bytes_in_flight -= info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:518:47 [INFO] [stderr] | [INFO] [stderr] 518 | self.congestion_window += info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:522:46 [INFO] [stderr] | [INFO] [stderr] 522 | config.default_mss * info.bytes as u64 / self.congestion_window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:581:46 [INFO] [stderr] | [INFO] [stderr] 581 | delay_until_lost = (rtt + (rtt * config.time_reordering_fraction as u64)) >> 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.time_reordering_fraction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:593:63 [INFO] [stderr] | [INFO] [stderr] 593 | if time_since_sent >= delay_until_lost || delta > self.reordering_threshold as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reordering_threshold)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:609:41 [INFO] [stderr] | [INFO] [stderr] 609 | self.bytes_in_flight -= info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:618:47 [INFO] [stderr] | [INFO] [stderr] 618 | (self.congestion_window * config.loss_reduction_factor as u64) >> 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.loss_reduction_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:691:18 [INFO] [stderr] | [INFO] [stderr] 691 | let dt = cmp::min(config.idle_timeout, self.params.idle_timeout) as u64 * 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cmp::min(config.idle_timeout, self.params.idle_timeout))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/connection.rs:932:5 [INFO] [stderr] | [INFO] [stderr] 932 | / pub fn handle_connected_inner( [INFO] [stderr] 933 | | &mut self, [INFO] [stderr] 934 | | ctx: &mut Context, [INFO] [stderr] 935 | | now: u64, [INFO] [stderr] ... | [INFO] [stderr] 1387 | | } [INFO] [stderr] 1388 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:968:33 [INFO] [stderr] | [INFO] [stderr] 968 | number as u64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:991:76 [INFO] [stderr] | [INFO] [stderr] 991 | self.on_packet_authenticated(ctx, now, number as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:1055:33 [INFO] [stderr] | [INFO] [stderr] 1055 | number as u64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:1063:64 [INFO] [stderr] | [INFO] [stderr] 1063 | self.on_packet_authenticated(ctx, now, number as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:1114:75 [INFO] [stderr] | [INFO] [stderr] 1114 | self.handshake_pending.path_challenge(number as u64, value); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/connection.rs:1390:5 [INFO] [stderr] | [INFO] [stderr] 1390 | / pub fn process_payload( [INFO] [stderr] 1391 | | &mut self, [INFO] [stderr] 1392 | | ctx: &mut Context, [INFO] [stderr] 1393 | | now: u64, [INFO] [stderr] ... | [INFO] [stderr] 1713 | | Ok(false) [INFO] [stderr] 1714 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/connection.rs:1716:5 [INFO] [stderr] | [INFO] [stderr] 1716 | / pub fn next_packet(&mut self, log: &Logger, config: &Config, now: u64) -> Option> { [INFO] [stderr] 1717 | | let established = match *self.state.as_ref().unwrap() { [INFO] [stderr] 1718 | | State::Handshake(_) => false, [INFO] [stderr] 1719 | | State::Established(_) => true, [INFO] [stderr] ... | [INFO] [stderr] 2009 | | Some(buf) [INFO] [stderr] 2010 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2121:31 [INFO] [stderr] | [INFO] [stderr] 2121 | self.max_bi_streams = params.initial_max_streams_bidi as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_streams_bidi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2125:32 [INFO] [stderr] | [INFO] [stderr] 2125 | self.max_uni_streams = params.initial_max_streams_uni as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_streams_uni)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2126:25 [INFO] [stderr] | [INFO] [stderr] 2126 | self.max_data = params.initial_max_data as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2134:29 [INFO] [stderr] | [INFO] [stderr] 2134 | .max_data = params.initial_max_stream_data as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_stream_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2152:36 [INFO] [stderr] | [INFO] [stderr] 2152 | Stream::new_bi(config.stream_receive_window as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.stream_receive_window)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2159:47 [INFO] [stderr] | [INFO] [stderr] 2159 | stream.send_mut().unwrap().max_data = self.params.initial_max_stream_data as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.params.initial_max_stream_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2304:71 [INFO] [stderr] | [INFO] [stderr] 2304 | self.congestion_window.saturating_sub(self.bytes_in_flight) < self.mtu as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.mtu)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/connection.rs:2528:5 [INFO] [stderr] | [INFO] [stderr] 2528 | Handshake(state::Handshake), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 2528 | Handshake(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/frame.rs:519:14 [INFO] [stderr] | [INFO] [stderr] 519 | Some(largest - block..largest + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `largest - block..=largest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:105:34 [INFO] [stderr] | [INFO] [stderr] 105 | default_initial_rtt: EXPECTED_RTT as u64 * 1000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(EXPECTED_RTT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/endpoint.rs:510:5 [INFO] [stderr] | [INFO] [stderr] 510 | / fn handle_initial( [INFO] [stderr] 511 | | &mut self, [INFO] [stderr] 512 | | now: u64, [INFO] [stderr] 513 | | remote: SocketAddrV6, [INFO] [stderr] ... | [INFO] [stderr] 582 | | } [INFO] [stderr] 583 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:522:22 [INFO] [stderr] | [INFO] [stderr] 522 | .decrypt(packet_number as u64, header, &mut payload) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(packet_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | packet_number as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(packet_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:759:69 [INFO] [stderr] | [INFO] [stderr] 759 | self.connections[conn.0].bytes_in_flight -= info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:1102:20 [INFO] [stderr] | [INFO] [stderr] 1102 | crypto.encrypt(packet_number as u64, &mut buf, header_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(packet_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:78:11 [INFO] [stderr] | [INFO] [stderr] 78 | fn ty(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn encode(&self, w: &mut W) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:96:19 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn expand(&self, prev: u64) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | U8(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | U16(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | U32(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/transport_error.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | Error(0x100 | u8::from(ty) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(u8::from(ty))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn initiator(&self) -> Side { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:149:27 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn directionality(&self) -> Directionality { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn index(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `range_set::RangeSet` [INFO] [stderr] --> src/range_set.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Self { [INFO] [stderr] 13 | | RangeSet(BTreeMap::new()) [INFO] [stderr] 14 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/stream.rs:167:22 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn was_reset(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:293:21 [INFO] [stderr] | [INFO] [stderr] 293 | x.insert(0, (&b"123"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"123"[..])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:295:21 [INFO] [stderr] | [INFO] [stderr] 295 | x.insert(3, (&b"456"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"456"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:297:21 [INFO] [stderr] | [INFO] [stderr] 297 | x.insert(6, (&b"789"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"789"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:298:21 [INFO] [stderr] | [INFO] [stderr] 298 | x.insert(9, (&b"10"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"10"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:306:21 [INFO] [stderr] | [INFO] [stderr] 306 | x.insert(3, (&b"456"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"456"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:308:21 [INFO] [stderr] | [INFO] [stderr] 308 | x.insert(0, (&b"123"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"123"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:316:21 [INFO] [stderr] | [INFO] [stderr] 316 | x.insert(0, (&b"123"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"123"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:317:21 [INFO] [stderr] | [INFO] [stderr] 317 | x.insert(0, (&b"123"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"123"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | x.insert(0, (&b"12345"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"12345"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:326:21 [INFO] [stderr] | [INFO] [stderr] 326 | x.insert(1, (&b"234"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"234"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:334:21 [INFO] [stderr] | [INFO] [stderr] 334 | x.insert(1, (&b"234"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"234"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:335:21 [INFO] [stderr] | [INFO] [stderr] 335 | x.insert(0, (&b"12345"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"12345"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:343:21 [INFO] [stderr] | [INFO] [stderr] 343 | x.insert(0, (&b"123"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"123"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:344:21 [INFO] [stderr] | [INFO] [stderr] 344 | x.insert(1, (&b"234"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"234"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:352:21 [INFO] [stderr] | [INFO] [stderr] 352 | x.insert(0, (&b"1"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"1"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:353:21 [INFO] [stderr] | [INFO] [stderr] 353 | x.insert(2, (&b"3"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"3"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:354:21 [INFO] [stderr] | [INFO] [stderr] 354 | x.insert(4, (&b"5"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"5"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/stream.rs:355:21 [INFO] [stderr] | [INFO] [stderr] 355 | x.insert(0, (&b"123456"[..]).into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `(&b"123456"[..])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ | 128` can never be equal to `0` [INFO] [stderr] --> src/tests.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | assert!(packet[0] | 0x80 != 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/tests.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | assert!(&packet[1..14] == hex!("00000000 11 00000000 00000000")); [INFO] [stderr] | --------------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `packet[1..14]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | 0b00 => buf[0] as u64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(buf[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | BigEndian::read_u16(&buf) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BigEndian::read_u16(&buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/varint.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | BigEndian::read_u32(&buf) as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(BigEndian::read_u32(&buf))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/connection.rs:139:19 [INFO] [stderr] | [INFO] [stderr] 139 | pub set_idle: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/connection.rs:140:29 [INFO] [stderr] | [INFO] [stderr] 140 | pub set_loss_detection: Option>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:287:37 [INFO] [stderr] | [INFO] [stderr] 287 | let max_remote_bi_streams = config.max_remote_bi_streams as u64 + match side { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.max_remote_bi_streams)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:298:32 [INFO] [stderr] | [INFO] [stderr] 298 | Stream::new_bi(config.stream_receive_window as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.stream_receive_window)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:321:29 [INFO] [stderr] | [INFO] [stderr] 321 | local_max_data: config.receive_window as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.receive_window)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:369:37 [INFO] [stderr] | [INFO] [stderr] 369 | max_remote_uni_streams: config.max_remote_uni_streams as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.max_remote_uni_streams)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:445:37 [INFO] [stderr] | [INFO] [stderr] 445 | self.bytes_in_flight += bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:513:37 [INFO] [stderr] | [INFO] [stderr] 513 | self.bytes_in_flight -= info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:518:47 [INFO] [stderr] | [INFO] [stderr] 518 | self.congestion_window += info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:522:46 [INFO] [stderr] | [INFO] [stderr] 522 | config.default_mss * info.bytes as u64 / self.congestion_window; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:581:46 [INFO] [stderr] | [INFO] [stderr] 581 | delay_until_lost = (rtt + (rtt * config.time_reordering_fraction as u64)) >> 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.time_reordering_fraction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:593:63 [INFO] [stderr] | [INFO] [stderr] 593 | if time_since_sent >= delay_until_lost || delta > self.reordering_threshold as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.reordering_threshold)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:609:41 [INFO] [stderr] | [INFO] [stderr] 609 | self.bytes_in_flight -= info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:618:47 [INFO] [stderr] | [INFO] [stderr] 618 | (self.congestion_window * config.loss_reduction_factor as u64) >> 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.loss_reduction_factor)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:691:18 [INFO] [stderr] | [INFO] [stderr] 691 | let dt = cmp::min(config.idle_timeout, self.params.idle_timeout) as u64 * 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(cmp::min(config.idle_timeout, self.params.idle_timeout))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/connection.rs:932:5 [INFO] [stderr] | [INFO] [stderr] 932 | / pub fn handle_connected_inner( [INFO] [stderr] 933 | | &mut self, [INFO] [stderr] 934 | | ctx: &mut Context, [INFO] [stderr] 935 | | now: u64, [INFO] [stderr] ... | [INFO] [stderr] 1387 | | } [INFO] [stderr] 1388 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:968:33 [INFO] [stderr] | [INFO] [stderr] 968 | number as u64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:991:76 [INFO] [stderr] | [INFO] [stderr] 991 | self.on_packet_authenticated(ctx, now, number as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:1055:33 [INFO] [stderr] | [INFO] [stderr] 1055 | number as u64, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:1063:64 [INFO] [stderr] | [INFO] [stderr] 1063 | self.on_packet_authenticated(ctx, now, number as u64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:1114:75 [INFO] [stderr] | [INFO] [stderr] 1114 | self.handshake_pending.path_challenge(number as u64, value); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 39 [INFO] [stderr] --> src/connection.rs:1390:5 [INFO] [stderr] | [INFO] [stderr] 1390 | / pub fn process_payload( [INFO] [stderr] 1391 | | &mut self, [INFO] [stderr] 1392 | | ctx: &mut Context, [INFO] [stderr] 1393 | | now: u64, [INFO] [stderr] ... | [INFO] [stderr] 1713 | | Ok(false) [INFO] [stderr] 1714 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 45 [INFO] [stderr] --> src/connection.rs:1716:5 [INFO] [stderr] | [INFO] [stderr] 1716 | / pub fn next_packet(&mut self, log: &Logger, config: &Config, now: u64) -> Option> { [INFO] [stderr] 1717 | | let established = match *self.state.as_ref().unwrap() { [INFO] [stderr] 1718 | | State::Handshake(_) => false, [INFO] [stderr] 1719 | | State::Established(_) => true, [INFO] [stderr] ... | [INFO] [stderr] 2009 | | Some(buf) [INFO] [stderr] 2010 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2121:31 [INFO] [stderr] | [INFO] [stderr] 2121 | self.max_bi_streams = params.initial_max_streams_bidi as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_streams_bidi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2125:32 [INFO] [stderr] | [INFO] [stderr] 2125 | self.max_uni_streams = params.initial_max_streams_uni as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_streams_uni)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2126:25 [INFO] [stderr] | [INFO] [stderr] 2126 | self.max_data = params.initial_max_data as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2134:29 [INFO] [stderr] | [INFO] [stderr] 2134 | .max_data = params.initial_max_stream_data as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(params.initial_max_stream_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2152:36 [INFO] [stderr] | [INFO] [stderr] 2152 | Stream::new_bi(config.stream_receive_window as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.stream_receive_window)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2159:47 [INFO] [stderr] | [INFO] [stderr] 2159 | stream.send_mut().unwrap().max_data = self.params.initial_max_stream_data as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.params.initial_max_stream_data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/connection.rs:2304:71 [INFO] [stderr] | [INFO] [stderr] 2304 | self.congestion_window.saturating_sub(self.bytes_in_flight) < self.mtu as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(self.mtu)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/connection.rs:2528:5 [INFO] [stderr] | [INFO] [stderr] 2528 | Handshake(state::Handshake), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 2528 | Handshake(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/frame.rs:519:14 [INFO] [stderr] | [INFO] [stderr] 519 | Some(largest - block..largest + 1) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `largest - block..=largest` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/frame.rs:548:27 [INFO] [stderr] | [INFO] [stderr] 548 | ranges.insert(packet..packet + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `packet..=packet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:105:34 [INFO] [stderr] | [INFO] [stderr] 105 | default_initial_rtt: EXPECTED_RTT as u64 * 1000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(EXPECTED_RTT)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/endpoint.rs:510:5 [INFO] [stderr] | [INFO] [stderr] 510 | / fn handle_initial( [INFO] [stderr] 511 | | &mut self, [INFO] [stderr] 512 | | now: u64, [INFO] [stderr] 513 | | remote: SocketAddrV6, [INFO] [stderr] ... | [INFO] [stderr] 582 | | } [INFO] [stderr] 583 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:522:22 [INFO] [stderr] | [INFO] [stderr] 522 | .decrypt(packet_number as u64, header, &mut payload) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(packet_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:563:13 [INFO] [stderr] | [INFO] [stderr] 563 | packet_number as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(packet_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:759:69 [INFO] [stderr] | [INFO] [stderr] 759 | self.connections[conn.0].bytes_in_flight -= info.bytes as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(info.bytes)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/endpoint.rs:1102:20 [INFO] [stderr] | [INFO] [stderr] 1102 | crypto.encrypt(packet_number as u64, &mut buf, header_len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(packet_number)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:78:11 [INFO] [stderr] | [INFO] [stderr] 78 | fn ty(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:87:30 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn encode(&self, w: &mut W) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/packet.rs:96:19 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn expand(&self, prev: u64) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:106:22 [INFO] [stderr] | [INFO] [stderr] 106 | U8(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:107:23 [INFO] [stderr] | [INFO] [stderr] 107 | U16(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/packet.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | U32(x) => x as u64, [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/transport_error.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | Error(0x100 | u8::from(ty) as u16) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(u8::from(ty))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:141:22 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn initiator(&self) -> Side { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:149:27 [INFO] [stderr] | [INFO] [stderr] 149 | pub fn directionality(&self) -> Directionality { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:157:18 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn index(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quinn-proto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> examples/connect.rs:46:10 [INFO] [stderr] | [INFO] [stderr] 46 | .ok_or(format_err!("missing address argument"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("missing address argument"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> examples/connect.rs:70:18 [INFO] [stderr] | [INFO] [stderr] 70 | .ok_or(format_err!("couldn't resolve to an address"))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("couldn't resolve to an address"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> examples/connect.rs:104:30 [INFO] [stderr] | [INFO] [stderr] 104 | .ok_or(format_err!("no streams available"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("no streams available"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> examples/connect.rs:212:20 [INFO] [stderr] | [INFO] [stderr] 212 | time = dt.subsec_nanos() as u64 / 1000 + dt.as_secs() * 1000 * 1000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(dt.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "29c6184c7795c584bfaea23c280a1d34648ad2249750cd2e071e2e1092eb7eef"` [INFO] running `"docker" "rm" "-f" "29c6184c7795c584bfaea23c280a1d34648ad2249750cd2e071e2e1092eb7eef"` [INFO] [stdout] 29c6184c7795c584bfaea23c280a1d34648ad2249750cd2e071e2e1092eb7eef