[INFO] crate quill-delta 0.0.1 is already in cache [INFO] extracting crate quill-delta 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/quill-delta/0.0.1 [INFO] extracting crate quill-delta 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quill-delta/0.0.1 [INFO] validating manifest of quill-delta-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quill-delta-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quill-delta-0.0.1 [INFO] finished frobbing quill-delta-0.0.1 [INFO] frobbed toml for quill-delta-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/quill-delta/0.0.1/Cargo.toml [INFO] started frobbing quill-delta-0.0.1 [INFO] finished frobbing quill-delta-0.0.1 [INFO] frobbed toml for quill-delta-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quill-delta/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quill-delta-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quill-delta/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ec88c95781ae8e95aa8597e8e5e07a3d07b5267864b8e9c8c4a6dce6cf93f5a [INFO] running `"docker" "start" "-a" "4ec88c95781ae8e95aa8597e8e5e07a3d07b5267864b8e9c8c4a6dce6cf93f5a"` [INFO] [stderr] Checking quill-delta v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/lib.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | let op: DeltaOperation = serde_json::from_str(r#"{ "insert": "Hallo" }"#).unwrap(); [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/lib.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | let op: DeltaOperation = serde_json::from_str(r#"{ "retain": 10 }"#).unwrap(); [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/lib.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | let op: DeltaOperation = serde_json::from_str(r#"{ "delete": 10 }"#).unwrap(); [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `text` [INFO] [stderr] --> src/lib.rs:40:46 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn insert>(mut self, text: S, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^ help: consider using `_text` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `attributes` [INFO] [stderr] --> src/lib.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn insert>(mut self, text: S, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_attributes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn delete(mut self, length: usize) -> Self { [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn retain(mut self, length: usize, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `attributes` [INFO] [stderr] --> src/lib.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn retain(mut self, length: usize, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_attributes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/lib.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn push(mut self, op: DeltaOperation) -> Self { [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn insert>(mut self, text: S, attributes: Attributes) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn delete(mut self, length: usize) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn retain(mut self, length: usize, attributes: Attributes) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn push(mut self, op: DeltaOperation) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn chop(mut self) {} [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Delta` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> Self { [INFO] [stderr] 37 | | Delta { ops: Vec::new() } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | value.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `DeltaOperation` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | / impl DeltaOperation { [INFO] [stderr] 105 | | #[inline(always)] [INFO] [stderr] 106 | | pub fn insert>(value: V) -> Self { [INFO] [stderr] 107 | | DeltaOperation { [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: unused variable: `text` [INFO] [stderr] --> src/lib.rs:40:46 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn insert>(mut self, text: S, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^ help: consider using `_text` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `attributes` [INFO] [stderr] --> src/lib.rs:40:55 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn insert>(mut self, text: S, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_attributes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:44:29 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn delete(mut self, length: usize) -> Self { [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `length` [INFO] [stderr] --> src/lib.rs:48:29 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn retain(mut self, length: usize, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^^^ help: consider using `_length` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `attributes` [INFO] [stderr] --> src/lib.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn retain(mut self, length: usize, attributes: Attributes) -> Self { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_attributes` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op` [INFO] [stderr] --> src/lib.rs:52:27 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn push(mut self, op: DeltaOperation) -> Self { [INFO] [stderr] | ^^ help: consider using `_op` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn insert>(mut self, text: S, attributes: Attributes) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | pub fn delete(mut self, length: usize) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn retain(mut self, length: usize, attributes: Attributes) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | pub fn push(mut self, op: DeltaOperation) -> Self { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn chop(mut self) {} [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Delta` [INFO] [stderr] --> src/lib.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new() -> Self { [INFO] [stderr] 37 | | Delta { ops: Vec::new() } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | value.len() == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `DeltaOperation` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:104:1 [INFO] [stderr] | [INFO] [stderr] 104 | / impl DeltaOperation { [INFO] [stderr] 105 | | #[inline(always)] [INFO] [stderr] 106 | | pub fn insert>(value: V) -> Self { [INFO] [stderr] 107 | | DeltaOperation { [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.39s [INFO] running `"docker" "inspect" "4ec88c95781ae8e95aa8597e8e5e07a3d07b5267864b8e9c8c4a6dce6cf93f5a"` [INFO] running `"docker" "rm" "-f" "4ec88c95781ae8e95aa8597e8e5e07a3d07b5267864b8e9c8c4a6dce6cf93f5a"` [INFO] [stdout] 4ec88c95781ae8e95aa8597e8e5e07a3d07b5267864b8e9c8c4a6dce6cf93f5a