[INFO] crate quiet 0.1.0 is already in cache
[INFO] extracting crate quiet 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/quiet/0.1.0
[INFO] extracting crate quiet 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quiet/0.1.0
[INFO] validating manifest of quiet-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of quiet-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing quiet-0.1.0
[INFO] finished frobbing quiet-0.1.0
[INFO] frobbed toml for quiet-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/quiet/0.1.0/Cargo.toml
[INFO] started frobbing quiet-0.1.0
[INFO] finished frobbing quiet-0.1.0
[INFO] frobbed toml for quiet-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quiet/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting quiet-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quiet/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8b4b85bb39afecd37f44b83940d23fb6665c8f9c202615ab3ce55a436dd05218
[INFO] running `"docker" "start" "-a" "8b4b85bb39afecd37f44b83940d23fb6665c8f9c202615ab3ce55a436dd05218"`
[INFO] [stderr]     Checking quiet v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             buf: buf,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fec/convolutional/bit.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 |             buf: buf,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:434:13
[INFO] [stderr]     |
[INFO] [stderr] 434 |             keys: keys,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `keys`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:436:13
[INFO] [stderr]     |
[INFO] [stderr] 436 |             outputs: outputs,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `outputs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             rate: rate,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `rate`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             order: order,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             buf: buf,
[INFO] [stderr]    |             ^^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fec/convolutional/bit.rs:144:13
[INFO] [stderr]     |
[INFO] [stderr] 144 |             buf: buf,
[INFO] [stderr]     |             ^^^^^^^^ help: replace it with: `buf`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:434:13
[INFO] [stderr]     |
[INFO] [stderr] 434 |             keys: keys,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `keys`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:436:13
[INFO] [stderr]     |
[INFO] [stderr] 436 |             outputs: outputs,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `outputs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             rate: rate,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `rate`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:15:13
[INFO] [stderr]    |
[INFO] [stderr] 15 |             order: order,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `len`
[INFO] [stderr]    --> src/fec/convolutional/bit.rs:177:5
[INFO] [stderr]     |
[INFO] [stderr] 177 |     pub fn len(&self) -> usize {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:45:26
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let mut b: u16 = self.current_byte as u16;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.current_byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |             b |= *bit as u16;
[INFO] [stderr]    |                  ^^^^^^^^^^^ help: try: `u16::from(*bit)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:89:18
[INFO] [stderr]    |
[INFO] [stderr] 89 |             b |= *bit as u16;
[INFO] [stderr]    |                  ^^^^^^^^^^^ help: try: `u16::from(*bit)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `table`
[INFO] [stderr]    --> src/fec/convolutional/bit.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |         for i in 0..256 {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 126 |         for (i, <item>) in table.iter_mut().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:23:32
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let max_error = rate * u8::max_value() as u32;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::max_value())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let renorm = u16::max_value() as u32 / max_error;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16::max_value())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is used to index `errors`
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:58:26
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 for j in 0..(1 << (i + 1)) {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 for (j, <item>) in errors.iter_mut().enumerate().take((1 << (i + 1))) {
[INFO] [stderr]    |                     ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:78:18
[INFO] [stderr]    |
[INFO] [stderr] 78 |         for _ in (self.order - 1)..(num_decoded_bits - self.order + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((self.order - 1)..=num_decoded_bits - self.order)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:115:25
[INFO] [stderr]     |
[INFO] [stderr] 115 | /                         let successor: u8;
[INFO] [stderr] 116 | |                         if low_error <= high_error {
[INFO] [stderr] 117 | |                             error = low_error;
[INFO] [stderr] 118 | |                             successor = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 121 | |                             successor = 1;
[INFO] [stderr] 122 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let successor = if low_error <= high_error { ..; 0 } else { ..; 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:132:25
[INFO] [stderr]     |
[INFO] [stderr] 132 | /                         let successor: u8;
[INFO] [stderr] 133 | |                         if low_error <= high_error {
[INFO] [stderr] 134 | |                             error = low_error;
[INFO] [stderr] 135 | |                             successor = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 138 | |                             successor = 1;
[INFO] [stderr] 139 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let successor = if low_error <= high_error { ..; 0 } else { ..; 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:189:25
[INFO] [stderr]     |
[INFO] [stderr] 189 | /                         let successor: u8;
[INFO] [stderr] 190 | |                         if low_error <= high_error {
[INFO] [stderr] 191 | |                             error = low_error;
[INFO] [stderr] 192 | |                             successor = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 195 | |                             successor = 1;
[INFO] [stderr] 196 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let successor = if low_error <= high_error { ..; 0 } else { ..; 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:330:13
[INFO] [stderr]     |
[INFO] [stderr] 330 | /             let reg_bit: u16;
[INFO] [stderr] 331 | |             if bit == 0 {
[INFO] [stderr] 332 | |                 reg_bit = 0;
[INFO] [stderr] 333 | |             } else {
[INFO] [stderr] 334 | |                 reg_bit = self.highbit;
[INFO] [stderr] 335 | |             }
[INFO] [stderr]     | |_____________^ help: it is more idiomatic to write: `let reg_bit = if bit == 0 { 0 } else { self.highbit };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:424:32
[INFO] [stderr]     |
[INFO] [stderr] 424 |             let output: u32 = ((pairs[1] as u32) << rate) | pairs[0] as u32;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(pairs[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:424:61
[INFO] [stderr]     |
[INFO] [stderr] 424 |             let output: u32 = ((pairs[1] as u32) << rate) | pairs[0] as u32;
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^ help: try: `u32::from(pairs[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:426:13
[INFO] [stderr]     |
[INFO] [stderr] 426 | /             if !outputs_lookup.contains_key(&output) {
[INFO] [stderr] 427 | |                 outputs_lookup.insert(output, outputs.len() as u32);
[INFO] [stderr] 428 | |                 outputs.push(output);
[INFO] [stderr] 429 | |             }
[INFO] [stderr]     | |_____________^ help: consider using: `outputs_lookup.entry(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:448:17
[INFO] [stderr]     |
[INFO] [stderr] 448 |                 ((distances[second as usize]) as u32) << 16 | distances[first as usize] as u32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((distances[second as usize]))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:448:63
[INFO] [stderr]     |
[INFO] [stderr] 448 |                 ((distances[second as usize]) as u32) << 16 | distances[first as usize] as u32;
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(distances[first as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:35:31
[INFO] [stderr]    |
[INFO] [stderr] 35 |             shift_register |= bit_reader.read(1) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bit_reader.read(1))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:44:19
[INFO] [stderr]    |
[INFO] [stderr] 44 |         for _i in 0..self.order + 1 {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: use: `0..=self.order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `table`
[INFO] [stderr]   --> src/fec/convolutional/util.rs:12:14
[INFO] [stderr]    |
[INFO] [stderr] 12 |     for i in 0..num_states {
[INFO] [stderr]    |              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 12 |     for (i, <item>) in table.iter_mut().enumerate().take(num_states) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `len`
[INFO] [stderr]    --> src/fec/convolutional/bit.rs:177:5
[INFO] [stderr]     |
[INFO] [stderr] 177 |     pub fn len(&self) -> usize {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:45:26
[INFO] [stderr]    |
[INFO] [stderr] 45 |         let mut b: u16 = self.current_byte as u16;
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.current_byte)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:51:18
[INFO] [stderr]    |
[INFO] [stderr] 51 |             b |= *bit as u16;
[INFO] [stderr]    |                  ^^^^^^^^^^^ help: try: `u16::from(*bit)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/bit.rs:89:18
[INFO] [stderr]    |
[INFO] [stderr] 89 |             b |= *bit as u16;
[INFO] [stderr]    |                  ^^^^^^^^^^^ help: try: `u16::from(*bit)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `table`
[INFO] [stderr]    --> src/fec/convolutional/bit.rs:126:18
[INFO] [stderr]     |
[INFO] [stderr] 126 |         for i in 0..256 {
[INFO] [stderr]     |                  ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 126 |         for (i, <item>) in table.iter_mut().enumerate() {
[INFO] [stderr]     |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:23:32
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let max_error = rate * u8::max_value() as u32;
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u8::max_value())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:24:22
[INFO] [stderr]    |
[INFO] [stderr] 24 |         let renorm = u16::max_value() as u32 / max_error;
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(u16::max_value())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `j` is used to index `errors`
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:58:26
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 for j in 0..(1 << (i + 1)) {
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 58 |                 for (j, <item>) in errors.iter_mut().enumerate().take((1 << (i + 1))) {
[INFO] [stderr]    |                     ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/fec/convolutional/decoder.rs:78:18
[INFO] [stderr]    |
[INFO] [stderr] 78 |         for _ in (self.order - 1)..(num_decoded_bits - self.order + 1) {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `((self.order - 1)..=num_decoded_bits - self.order)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:115:25
[INFO] [stderr]     |
[INFO] [stderr] 115 | /                         let successor: u8;
[INFO] [stderr] 116 | |                         if low_error <= high_error {
[INFO] [stderr] 117 | |                             error = low_error;
[INFO] [stderr] 118 | |                             successor = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 121 | |                             successor = 1;
[INFO] [stderr] 122 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let successor = if low_error <= high_error { ..; 0 } else { ..; 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:132:25
[INFO] [stderr]     |
[INFO] [stderr] 132 | /                         let successor: u8;
[INFO] [stderr] 133 | |                         if low_error <= high_error {
[INFO] [stderr] 134 | |                             error = low_error;
[INFO] [stderr] 135 | |                             successor = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 138 | |                             successor = 1;
[INFO] [stderr] 139 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let successor = if low_error <= high_error { ..; 0 } else { ..; 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:189:25
[INFO] [stderr]     |
[INFO] [stderr] 189 | /                         let successor: u8;
[INFO] [stderr] 190 | |                         if low_error <= high_error {
[INFO] [stderr] 191 | |                             error = low_error;
[INFO] [stderr] 192 | |                             successor = 0;
[INFO] [stderr] ...   |
[INFO] [stderr] 195 | |                             successor = 1;
[INFO] [stderr] 196 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let successor = if low_error <= high_error { ..; 0 } else { ..; 1 };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:330:13
[INFO] [stderr]     |
[INFO] [stderr] 330 | /             let reg_bit: u16;
[INFO] [stderr] 331 | |             if bit == 0 {
[INFO] [stderr] 332 | |                 reg_bit = 0;
[INFO] [stderr] 333 | |             } else {
[INFO] [stderr] 334 | |                 reg_bit = self.highbit;
[INFO] [stderr] 335 | |             }
[INFO] [stderr]     | |_____________^ help: it is more idiomatic to write: `let reg_bit = if bit == 0 { 0 } else { self.highbit };`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:424:32
[INFO] [stderr]     |
[INFO] [stderr] 424 |             let output: u32 = ((pairs[1] as u32) << rate) | pairs[0] as u32;
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^ help: try: `u32::from(pairs[1])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:424:61
[INFO] [stderr]     |
[INFO] [stderr] 424 |             let output: u32 = ((pairs[1] as u32) << rate) | pairs[0] as u32;
[INFO] [stderr]     |                                                             ^^^^^^^^^^^^^^^ help: try: `u32::from(pairs[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:426:13
[INFO] [stderr]     |
[INFO] [stderr] 426 | /             if !outputs_lookup.contains_key(&output) {
[INFO] [stderr] 427 | |                 outputs_lookup.insert(output, outputs.len() as u32);
[INFO] [stderr] 428 | |                 outputs.push(output);
[INFO] [stderr] 429 | |             }
[INFO] [stderr]     | |_____________^ help: consider using: `outputs_lookup.entry(output)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:448:17
[INFO] [stderr]     |
[INFO] [stderr] 448 |                 ((distances[second as usize]) as u32) << 16 | distances[first as usize] as u32;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from((distances[second as usize]))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/fec/convolutional/decoder.rs:448:63
[INFO] [stderr]     |
[INFO] [stderr] 448 |                 ((distances[second as usize]) as u32) << 16 | distances[first as usize] as u32;
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(distances[first as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:35:31
[INFO] [stderr]    |
[INFO] [stderr] 35 |             shift_register |= bit_reader.read(1) as u32;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(bit_reader.read(1))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> src/fec/convolutional/encoder.rs:44:19
[INFO] [stderr]    |
[INFO] [stderr] 44 |         for _i in 0..self.order + 1 {
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^ help: use: `0..=self.order`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is used to index `table`
[INFO] [stderr]   --> src/fec/convolutional/util.rs:12:14
[INFO] [stderr]    |
[INFO] [stderr] 12 |     for i in 0..num_states {
[INFO] [stderr]    |              ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 12 |     for (i, <item>) in table.iter_mut().enumerate().take(num_states) {
[INFO] [stderr]    |         ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> examples/main.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 |     println!("");
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.00s
[INFO] running `"docker" "inspect" "8b4b85bb39afecd37f44b83940d23fb6665c8f9c202615ab3ce55a436dd05218"`
[INFO] running `"docker" "rm" "-f" "8b4b85bb39afecd37f44b83940d23fb6665c8f9c202615ab3ce55a436dd05218"`
[INFO] [stdout] 8b4b85bb39afecd37f44b83940d23fb6665c8f9c202615ab3ce55a436dd05218