[INFO] crate quickxml_to_serde 0.3.2 is already in cache [INFO] extracting crate quickxml_to_serde 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/quickxml_to_serde/0.3.2 [INFO] extracting crate quickxml_to_serde 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickxml_to_serde/0.3.2 [INFO] validating manifest of quickxml_to_serde-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quickxml_to_serde-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quickxml_to_serde-0.3.2 [INFO] finished frobbing quickxml_to_serde-0.3.2 [INFO] frobbed toml for quickxml_to_serde-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/quickxml_to_serde/0.3.2/Cargo.toml [INFO] started frobbing quickxml_to_serde-0.3.2 [INFO] finished frobbing quickxml_to_serde-0.3.2 [INFO] frobbed toml for quickxml_to_serde-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickxml_to_serde/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quickxml_to_serde-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quickxml_to_serde/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0d4be6febf3a352f9721663559eb1a7bd4600a1d41ee31054d2f396bebf400a [INFO] running `"docker" "start" "-a" "b0d4be6febf3a352f9721663559eb1a7bd4600a1d41ee31054d2f396bebf400a"` [INFO] [stderr] Checking quick-xml v0.12.4 [INFO] [stderr] Checking minidom v0.9.1 [INFO] [stderr] Checking quickxml_to_serde v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / match convert_node(child) { [INFO] [stderr] 55 | | Some(val) => { [INFO] [stderr] 56 | | let name = &child.name().to_string(); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 73 | | _ => (), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(val) = convert_node(child) { [INFO] [stderr] 55 | let name = &child.name().to_string(); [INFO] [stderr] 56 | [INFO] [stderr] 57 | if data.contains_key(name) { [INFO] [stderr] 58 | if data.get(name).unwrap_or(&Value::Null).is_array() { [INFO] [stderr] 59 | data.get_mut(name) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `serde_json::Value` [INFO] [stderr] --> src/lib.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | use serde_json::Value; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / match convert_node(child) { [INFO] [stderr] 55 | | Some(val) => { [INFO] [stderr] 56 | | let name = &child.name().to_string(); [INFO] [stderr] 57 | | [INFO] [stderr] ... | [INFO] [stderr] 73 | | _ => (), [INFO] [stderr] 74 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Some(val) = convert_node(child) { [INFO] [stderr] 55 | let name = &child.name().to_string(); [INFO] [stderr] 56 | [INFO] [stderr] 57 | if data.contains_key(name) { [INFO] [stderr] 58 | if data.get(name).unwrap_or(&Value::Null).is_array() { [INFO] [stderr] 59 | data.get_mut(name) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.89s [INFO] running `"docker" "inspect" "b0d4be6febf3a352f9721663559eb1a7bd4600a1d41ee31054d2f396bebf400a"` [INFO] running `"docker" "rm" "-f" "b0d4be6febf3a352f9721663559eb1a7bd4600a1d41ee31054d2f396bebf400a"` [INFO] [stdout] b0d4be6febf3a352f9721663559eb1a7bd4600a1d41ee31054d2f396bebf400a