[INFO] crate quickrandr 0.3.2 is already in cache [INFO] extracting crate quickrandr 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/quickrandr/0.3.2 [INFO] extracting crate quickrandr 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickrandr/0.3.2 [INFO] validating manifest of quickrandr-0.3.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quickrandr-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quickrandr-0.3.2 [INFO] finished frobbing quickrandr-0.3.2 [INFO] frobbed toml for quickrandr-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/quickrandr/0.3.2/Cargo.toml [INFO] started frobbing quickrandr-0.3.2 [INFO] finished frobbing quickrandr-0.3.2 [INFO] frobbed toml for quickrandr-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickrandr/0.3.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quickrandr-0.3.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quickrandr/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 61a63b56e63ae5c1ff8dc3271ef709c3864e7dc154e109c21a38153589f57a9e [INFO] running `"docker" "start" "-a" "61a63b56e63ae5c1ff8dc3271ef709c3864e7dc154e109c21a38153589f57a9e"` [INFO] [stderr] Checking quickrandr v0.3.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:250:21 [INFO] [stderr] | [INFO] [stderr] 250 | geometry: geometry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `geometry` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(s); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / let mut geometry = None; [INFO] [stderr] 204 | | if is_part_of_desktop { [INFO] [stderr] 205 | | // parse current screen config and orientation [INFO] [stderr] 206 | | let resolution = next; [INFO] [stderr] ... | [INFO] [stderr] 232 | | }); [INFO] [stderr] 233 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 203 | let geometry = if is_part_of_desktop { ..; Some(Geometry { [INFO] [stderr] 204 | orientation, [INFO] [stderr] 205 | width, [INFO] [stderr] 206 | height, [INFO] [stderr] 207 | x_offset, [INFO] [stderr] 208 | y_offset, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | buf_writer.write(contents.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quickrandr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:203:9 [INFO] [stderr] | [INFO] [stderr] 203 | / let mut geometry = None; [INFO] [stderr] 204 | | if is_part_of_desktop { [INFO] [stderr] 205 | | // parse current screen config and orientation [INFO] [stderr] 206 | | let resolution = next; [INFO] [stderr] ... | [INFO] [stderr] 232 | | }); [INFO] [stderr] 233 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 203 | let geometry = if is_part_of_desktop { ..; Some(Geometry { [INFO] [stderr] 204 | orientation, [INFO] [stderr] 205 | width, [INFO] [stderr] 206 | height, [INFO] [stderr] 207 | x_offset, [INFO] [stderr] 208 | y_offset, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | buf_writer.write(contents.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quickrandr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "61a63b56e63ae5c1ff8dc3271ef709c3864e7dc154e109c21a38153589f57a9e"` [INFO] running `"docker" "rm" "-f" "61a63b56e63ae5c1ff8dc3271ef709c3864e7dc154e109c21a38153589f57a9e"` [INFO] [stdout] 61a63b56e63ae5c1ff8dc3271ef709c3864e7dc154e109c21a38153589f57a9e