[INFO] crate quickcheck_seedable 0.3.1 is already in cache [INFO] extracting crate quickcheck_seedable 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/quickcheck_seedable/0.3.1 [INFO] extracting crate quickcheck_seedable 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickcheck_seedable/0.3.1 [INFO] validating manifest of quickcheck_seedable-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quickcheck_seedable-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quickcheck_seedable-0.3.1 [INFO] finished frobbing quickcheck_seedable-0.3.1 [INFO] frobbed toml for quickcheck_seedable-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/quickcheck_seedable/0.3.1/Cargo.toml [INFO] started frobbing quickcheck_seedable-0.3.1 [INFO] finished frobbing quickcheck_seedable-0.3.1 [INFO] frobbed toml for quickcheck_seedable-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickcheck_seedable/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quickcheck_seedable-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quickcheck_seedable/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 758676accab88a1dec5b60d76a9234b56c0bc1b3a801f60e4817d16790b365e1 [INFO] running `"docker" "start" "-a" "758676accab88a1dec5b60d76a9234b56c0bc1b3a801f60e4817d16790b365e1"` [INFO] [stderr] Checking quickcheck_seedable v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:236:13 [INFO] [stderr] | [INFO] [stderr] 236 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:237:13 [INFO] [stderr] | [INFO] [stderr] 237 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/arbitrary.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/arbitrary.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/arbitrary.rs:92:37 [INFO] [stderr] | [INFO] [stderr] 92 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/arbitrary.rs:92:45 [INFO] [stderr] | [INFO] [stderr] 92 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / fn new(seed: Vec) -> Box>> { [INFO] [stderr] 230 | | let es = match seed.get(0) { [INFO] [stderr] 231 | | Some(e) => e.shrink(), [INFO] [stderr] 232 | | None => return empty_shrinker() [INFO] [stderr] ... | [INFO] [stderr] 240 | | }) [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/arbitrary.rs:323:60 [INFO] [stderr] | [INFO] [stderr] 323 | impl Arbitrary for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 323 | impl Arbitrary for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/arbitrary.rs:361:46 [INFO] [stderr] | [INFO] [stderr] 361 | impl Arbitrary for HashSet { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 361 | impl Arbitrary for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:535:25 [INFO] [stderr] | [INFO] [stderr] 535 | s = s + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += 1` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:535:25 [INFO] [stderr] | [INFO] [stderr] 535 | s = s + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += 1` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 620 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 620 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 631 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 631 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tester::QuickCheck>` [INFO] [stderr] --> src/tester.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> QuickCheck> { [INFO] [stderr] 27 | | QuickCheck { [INFO] [stderr] 28 | | tests: 100, [INFO] [stderr] 29 | | max_tests: 10000, [INFO] [stderr] 30 | | gen: StdGen::new(rand::thread_rng(), 100), [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for tester::QuickCheck> { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:229:5 [INFO] [stderr] | [INFO] [stderr] 229 | / fn new(seed: Vec) -> Box>> { [INFO] [stderr] 230 | | let es = match seed.get(0) { [INFO] [stderr] 231 | | Some(e) => e.shrink(), [INFO] [stderr] 232 | | None => return empty_shrinker() [INFO] [stderr] ... | [INFO] [stderr] 240 | | }) [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/arbitrary.rs:323:60 [INFO] [stderr] | [INFO] [stderr] 323 | impl Arbitrary for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 323 | impl Arbitrary for HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashSet` should be generalized over different hashers [INFO] [stderr] --> src/arbitrary.rs:361:46 [INFO] [stderr] | [INFO] [stderr] 361 | impl Arbitrary for HashSet { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 361 | impl Arbitrary for HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:535:25 [INFO] [stderr] | [INFO] [stderr] 535 | s = s + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += 1` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:535:25 [INFO] [stderr] | [INFO] [stderr] 535 | s = s + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `s += 1` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:497:17 [INFO] [stderr] | [INFO] [stderr] 497 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 498 | | if x == 0 { [INFO] [stderr] 499 | | super::empty_shrinker() [INFO] [stderr] 500 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 507 | | } [INFO] [stderr] 508 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:516:25 [INFO] [stderr] | [INFO] [stderr] 516 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 548 | / unsigned_arbitrary! { [INFO] [stderr] 549 | | usize, u8, u16, u32, u64 [INFO] [stderr] 550 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 611 | / signed_arbitrary! { [INFO] [stderr] 612 | | isize, i8, i16, i32, i64 [INFO] [stderr] 613 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 620 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 620 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:561:17 [INFO] [stderr] | [INFO] [stderr] 561 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 562 | | if x == 0 { [INFO] [stderr] 563 | | super::empty_shrinker() [INFO] [stderr] 564 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 574 | | } [INFO] [stderr] 575 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 631 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:583:25 [INFO] [stderr] | [INFO] [stderr] 583 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 631 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tester::QuickCheck>` [INFO] [stderr] --> src/tester.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> QuickCheck> { [INFO] [stderr] 27 | | QuickCheck { [INFO] [stderr] 28 | | tests: 100, [INFO] [stderr] 29 | | max_tests: 10000, [INFO] [stderr] 30 | | gen: StdGen::new(rand::thread_rng(), 100), [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for tester::QuickCheck> { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tests.rs:130:21 [INFO] [stderr] | [INFO] [stderr] 130 | sieve(n) == (0..(n + 1)).filter(|&i| is_prime(i)).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sort.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return xs.iter().filter(|&x| *x < *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xs.iter().filter(|&x| *x < *pivot).map(|x| x.clone()).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sort.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return xs.iter().filter(|&x| *x > *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xs.iter().filter(|&x| *x > *pivot).map(|x| x.clone()).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> examples/sieve.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | sieve(n) == (0..(n + 1)).filter(|&i| is_prime(i)).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/sort.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | return xs.iter().filter(|&x| *x < *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `xs.iter().filter(|&x| *x < *pivot).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/sort.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | return xs.iter().filter(|&x| *x > *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `xs.iter().filter(|&x| *x > *pivot).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/sort.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | result.extend(last_part.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `last_part.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.68s [INFO] running `"docker" "inspect" "758676accab88a1dec5b60d76a9234b56c0bc1b3a801f60e4817d16790b365e1"` [INFO] running `"docker" "rm" "-f" "758676accab88a1dec5b60d76a9234b56c0bc1b3a801f60e4817d16790b365e1"` [INFO] [stdout] 758676accab88a1dec5b60d76a9234b56c0bc1b3a801f60e4817d16790b365e1