[INFO] crate quickcheck 0.7.2 is already in cache [INFO] extracting crate quickcheck 0.7.2 into work/ex/clippy-test-run/sources/stable/reg/quickcheck/0.7.2 [INFO] extracting crate quickcheck 0.7.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickcheck/0.7.2 [INFO] validating manifest of quickcheck-0.7.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quickcheck-0.7.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quickcheck-0.7.2 [INFO] finished frobbing quickcheck-0.7.2 [INFO] frobbed toml for quickcheck-0.7.2 written to work/ex/clippy-test-run/sources/stable/reg/quickcheck/0.7.2/Cargo.toml [INFO] started frobbing quickcheck-0.7.2 [INFO] finished frobbing quickcheck-0.7.2 [INFO] frobbed toml for quickcheck-0.7.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickcheck/0.7.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quickcheck-0.7.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quickcheck/0.7.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 00d5b6ebf61e8ece048e09228ee8f0c575c92e4cb5a51a998a876be635ea0d2f [INFO] running `"docker" "start" "-a" "00d5b6ebf61e8ece048e09228ee8f0c575c92e4cb5a51a998a876be635ea0d2f"` [INFO] [stderr] Checking quickcheck v0.7.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:84:56 [INFO] [stderr] | [INFO] [stderr] 84 | StdThreadGen(StdGen { rng: rand::thread_rng(), size: size }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tester.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | tests: tests, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tester.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | max_tests: max_tests, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tester.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | min_tests_passed: min_tests_passed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_tests_passed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:51:18 [INFO] [stderr] | [INFO] [stderr] 51 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:51:28 [INFO] [stderr] | [INFO] [stderr] 51 | StdGen { rng: rng, size: size } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:84:56 [INFO] [stderr] | [INFO] [stderr] 84 | StdThreadGen(StdGen { rng: rand::thread_rng(), size: size }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:326:13 [INFO] [stderr] | [INFO] [stderr] 326 | seed: seed, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/arbitrary.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tester.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | tests: tests, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tester.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | max_tests: max_tests, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tester.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | min_tests_passed: min_tests_passed, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_tests_passed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/arbitrary.rs:135:37 [INFO] [stderr] | [INFO] [stderr] 135 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/arbitrary.rs:135:45 [INFO] [stderr] | [INFO] [stderr] 135 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/arbitrary.rs:135:37 [INFO] [stderr] | [INFO] [stderr] 135 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/arbitrary.rs:135:45 [INFO] [stderr] | [INFO] [stderr] 135 | fn arbitrary(_: &mut G) -> () { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:319:5 [INFO] [stderr] | [INFO] [stderr] 319 | / fn new(seed: Vec) -> Box>> { [INFO] [stderr] 320 | | let es = match seed.get(0) { [INFO] [stderr] 321 | | Some(e) => e.shrink(), [INFO] [stderr] 322 | | None => return empty_shrinker() [INFO] [stderr] ... | [INFO] [stderr] 330 | | }) [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/arbitrary.rs:544:14 [INFO] [stderr] | [INFO] [stderr] 544 | .unwrap_or(PathBuf::from("/test/directory")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| PathBuf::from("/test/directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/arbitrary.rs:548:14 [INFO] [stderr] | [INFO] [stderr] 548 | .unwrap_or(PathBuf::from("/home/user")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("/home/user"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/arbitrary.rs:596:40 [INFO] [stderr] | [INFO] [stderr] 596 | Box::new(mystring.shrink().map(|s| OsString::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OsString::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 834 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 834 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 845 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 845 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tester::QuickCheck` [INFO] [stderr] --> src/tester.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> QuickCheck { [INFO] [stderr] 60 | | let gen_size = qc_gen_size(); [INFO] [stderr] 61 | | QuickCheck::with_gen(StdThreadGen::new(gen_size)) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for tester::QuickCheck { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:319:5 [INFO] [stderr] | [INFO] [stderr] 319 | / fn new(seed: Vec) -> Box>> { [INFO] [stderr] 320 | | let es = match seed.get(0) { [INFO] [stderr] 321 | | Some(e) => e.shrink(), [INFO] [stderr] 322 | | None => return empty_shrinker() [INFO] [stderr] ... | [INFO] [stderr] 330 | | }) [INFO] [stderr] 331 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/arbitrary.rs:544:14 [INFO] [stderr] | [INFO] [stderr] 544 | .unwrap_or(PathBuf::from("/test/directory")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| PathBuf::from("/test/directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/arbitrary.rs:548:14 [INFO] [stderr] | [INFO] [stderr] 548 | .unwrap_or(PathBuf::from("/home/user")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| PathBuf::from("/home/user"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/arbitrary.rs:596:40 [INFO] [stderr] | [INFO] [stderr] 596 | Box::new(mystring.shrink().map(|s| OsString::from(s))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OsString::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:699:17 [INFO] [stderr] | [INFO] [stderr] 699 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 700 | | if x == 0 { [INFO] [stderr] 701 | | super::empty_shrinker() [INFO] [stderr] 702 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 709 | | } [INFO] [stderr] 710 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:718:25 [INFO] [stderr] | [INFO] [stderr] 718 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 748 | / unsigned_arbitrary! { [INFO] [stderr] 749 | | usize, u8, u16, u32, u64 [INFO] [stderr] 750 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 821 | / signed_arbitrary! { [INFO] [stderr] 822 | | isize, i8, i16, i32, i64 [INFO] [stderr] 823 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 834 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 834 | signed_shrinker!(i32); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/arbitrary.rs:765:17 [INFO] [stderr] | [INFO] [stderr] 765 | / pub fn new(x: $ty) -> Box> { [INFO] [stderr] 766 | | if x == 0 { [INFO] [stderr] 767 | | super::empty_shrinker() [INFO] [stderr] 768 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 778 | | } [INFO] [stderr] 779 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 845 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/arbitrary.rs:787:25 [INFO] [stderr] | [INFO] [stderr] 787 | self.i = self.i / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.i /= 2` [INFO] [stderr] ... [INFO] [stderr] 845 | signed_shrinker!(i64); [INFO] [stderr] | ---------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `tester::QuickCheck` [INFO] [stderr] --> src/tester.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | / pub fn new() -> QuickCheck { [INFO] [stderr] 60 | | let gen_size = qc_gen_size(); [INFO] [stderr] 61 | | QuickCheck::with_gen(StdThreadGen::new(gen_size)) [INFO] [stderr] 62 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 49 | impl Default for tester::QuickCheck { [INFO] [stderr] 50 | fn default() -> Self { [INFO] [stderr] 51 | Self::new() [INFO] [stderr] 52 | } [INFO] [stderr] 53 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tests.rs:142:21 [INFO] [stderr] | [INFO] [stderr] 142 | sieve(n) == (0..(n + 1)).filter(|&i| is_prime(i)).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> examples/sieve.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | sieve(n) == (0..(n + 1)).filter(|&i| is_prime(i)).collect::>() [INFO] [stderr] | ^^^^^^^^^^^^ help: use: `(0..=n)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/tuples.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `quickcheck`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sort.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | return xs.iter().filter(|&x| *x < *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xs.iter().filter(|&x| *x < *pivot).map(|x| x.clone()).collect()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> examples/sort.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return xs.iter().filter(|&x| *x > *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `xs.iter().filter(|&x| *x > *pivot).map(|x| x.clone()).collect()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/sort.rs:9:12 [INFO] [stderr] | [INFO] [stderr] 9 | return xs.iter().filter(|&x| *x < *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `xs.iter().filter(|&x| *x < *pivot).cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/sort.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | return xs.iter().filter(|&x| *x > *pivot).map(|x| x.clone()).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `xs.iter().filter(|&x| *x > *pivot).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> examples/sort.rs:20:19 [INFO] [stderr] | [INFO] [stderr] 20 | result.extend(last_part.iter().map(|x| x.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `last_part.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "00d5b6ebf61e8ece048e09228ee8f0c575c92e4cb5a51a998a876be635ea0d2f"` [INFO] running `"docker" "rm" "-f" "00d5b6ebf61e8ece048e09228ee8f0c575c92e4cb5a51a998a876be635ea0d2f"` [INFO] [stdout] 00d5b6ebf61e8ece048e09228ee8f0c575c92e4cb5a51a998a876be635ea0d2f