[INFO] crate quickcfg 0.3.6 is already in cache [INFO] extracting crate quickcfg 0.3.6 into work/ex/clippy-test-run/sources/stable/reg/quickcfg/0.3.6 [INFO] extracting crate quickcfg 0.3.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickcfg/0.3.6 [INFO] validating manifest of quickcfg-0.3.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quickcfg-0.3.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quickcfg-0.3.6 [INFO] finished frobbing quickcfg-0.3.6 [INFO] frobbed toml for quickcfg-0.3.6 written to work/ex/clippy-test-run/sources/stable/reg/quickcfg/0.3.6/Cargo.toml [INFO] started frobbing quickcfg-0.3.6 [INFO] finished frobbing quickcfg-0.3.6 [INFO] frobbed toml for quickcfg-0.3.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quickcfg/0.3.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quickcfg-0.3.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quickcfg/0.3.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 558dc4ccd6fd7a301091c5cf80cf099ecfedc83956612505b55b22597dd17a48 [INFO] running `"docker" "start" "-a" "558dc4ccd6fd7a301091c5cf80cf099ecfedc83956612505b55b22597dd17a48"` [INFO] [stderr] Checking relative-path v0.4.0 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking ignore v0.4.6 [INFO] [stderr] Checking quickcfg v0.3.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packages/python.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/packages/python.rs:87:13 [INFO] [stderr] | [INFO] [stderr] 87 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/facts.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DISTRO: &'static str = "distro"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_utils.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(output) => return Ok(output.status.success()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output.status.success())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | _ => return Err(e.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hierarchy.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | const HEADER: &'static str = "quickcfg:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(m); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | Value::Mapping(m) => return Ok(m), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packages.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(Provider { default }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Provider { default })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/copy_dir.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/download_and_run.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/git_sync.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/install_packages.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/link_dir.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/facts.rs:13:20 [INFO] [stderr] | [INFO] [stderr] 13 | pub const DISTRO: &'static str = "distro"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/file_utils.rs:340:9 [INFO] [stderr] | [INFO] [stderr] 340 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:27:27 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(output) => return Ok(output.status.success()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(output.status.success())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/git.rs:30:22 [INFO] [stderr] | [INFO] [stderr] 30 | _ => return Err(e.into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(e.into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/hierarchy.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | const HEADER: &'static str = "quickcfg:"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:124:9 [INFO] [stderr] | [INFO] [stderr] 124 | return Ok(m); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/hierarchy.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | Value::Mapping(m) => return Ok(m), [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Ok(m)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/packages.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return Ok(Provider { default }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Provider { default })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/copy_dir.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/download_and_run.rs:90:9 [INFO] [stderr] | [INFO] [stderr] 90 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/git_sync.rs:112:9 [INFO] [stderr] | [INFO] [stderr] 112 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/install_packages.rs:113:9 [INFO] [stderr] | [INFO] [stderr] 113 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/system/link_dir.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | return Ok(units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/command.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | .split("\n") [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/file_utils.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | dirs.push(c.clone()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 150 | dirs.push(&(*c).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 150 | dirs.push(&std::path::Path::clone(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_utils.rs:335:49 [INFO] [stderr] | [INFO] [stderr] 335 | let m_time = FileTime::from_system_time(now.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_utils.rs:336:22 [INFO] [stderr] | [INFO] [stderr] 336 | let a_time = m_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `m_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/file_utils.rs:150:23 [INFO] [stderr] | [INFO] [stderr] 150 | dirs.push(c.clone()); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 150 | dirs.push(&(*c).clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 150 | dirs.push(&std::path::Path::clone(c)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_utils.rs:335:49 [INFO] [stderr] | [INFO] [stderr] 335 | let m_time = FileTime::from_system_time(now.clone()); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*now` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/file_utils.rs:336:22 [INFO] [stderr] | [INFO] [stderr] 336 | let a_time = m_time.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `m_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | for line in content.split("\n").take(5) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | for part in spec.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:93:45 [INFO] [stderr] | [INFO] [stderr] 93 | let mut it = part.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:78:35 [INFO] [stderr] | [INFO] [stderr] 78 | for line in content.split("\n").take(5) { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:86:36 [INFO] [stderr] | [INFO] [stderr] 86 | for part in spec.split(",") { [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/hierarchy.rs:93:45 [INFO] [stderr] | [INFO] [stderr] 93 | let mut it = part.splitn(2, ":"); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/debian.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/python.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/ruby.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/debian.rs:82:37 [INFO] [stderr] | [INFO] [stderr] 82 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/python.rs:46:37 [INFO] [stderr] | [INFO] [stderr] 46 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packages/ruby.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | let mut it = line.split(" "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/state.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn to_state<'c>(self, config: &'c Config, now: &'c SystemTime) -> State<'c> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/state.rs:34:25 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn to_state<'c>(self, config: &'c Config, now: &'c SystemTime) -> State<'c> { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | CopyDir { [INFO] [stderr] 11 | | #[doc="Where to copy from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | CopyDir { [INFO] [stderr] 11 | | #[doc="Where to copy from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | CopyDir { [INFO] [stderr] 11 | | #[doc="Where to copy from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/copy_dir.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / system_struct! { [INFO] [stderr] 10 | | CopyDir { [INFO] [stderr] 11 | | #[doc="Where to copy from."] [INFO] [stderr] 12 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | DownloadAndRun { [INFO] [stderr] 13 | | #[doc="URL to download."] [INFO] [stderr] 14 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | DownloadAndRun { [INFO] [stderr] 13 | | #[doc="URL to download."] [INFO] [stderr] 14 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | DownloadAndRun { [INFO] [stderr] 13 | | #[doc="URL to download."] [INFO] [stderr] 14 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/download_and_run.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | DownloadAndRun { [INFO] [stderr] 13 | | #[doc="URL to download."] [INFO] [stderr] 14 | | pub url: String, [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/git_sync.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | / system_struct! { [INFO] [stderr] 16 | | GitSync { [INFO] [stderr] 17 | | #[doc="Path to check out the repo."] [INFO] [stderr] 18 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | InstallPackages { [INFO] [stderr] 13 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 14 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | InstallPackages { [INFO] [stderr] 13 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 14 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | InstallPackages { [INFO] [stderr] 13 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 14 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/install_packages.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | / system_struct! { [INFO] [stderr] 12 | | InstallPackages { [INFO] [stderr] 13 | | #[doc="Hierarchy key to lookup for packages to install."] [INFO] [stderr] 14 | | #[serde(default = "default_key")] [INFO] [stderr] ... | [INFO] [stderr] 18 | | } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | Link { [INFO] [stderr] 10 | | #[doc="Where to create the symlink."] [INFO] [stderr] 11 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | Link { [INFO] [stderr] 10 | | #[doc="Where to create the symlink."] [INFO] [stderr] 11 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | Link { [INFO] [stderr] 10 | | #[doc="Where to create the symlink."] [INFO] [stderr] 11 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | Link { [INFO] [stderr] 10 | | #[doc="Where to create the symlink."] [INFO] [stderr] 11 | | pub path: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | LinkDir { [INFO] [stderr] 10 | | #[doc="Where to link files from."] [INFO] [stderr] 11 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | LinkDir { [INFO] [stderr] 10 | | #[doc="Where to link files from."] [INFO] [stderr] 11 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn id<'a>(&'a self) -> Option<&'a str> { [INFO] [stderr] 23 | | self.id.as_ref().map(|s| s.as_str()) [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | LinkDir { [INFO] [stderr] 10 | | #[doc="Where to link files from."] [INFO] [stderr] 11 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/macros.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn requires<'a>(&'a self) -> &[String] { [INFO] [stderr] 27 | | &self.requires [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/system/link_dir.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / system_struct! { [INFO] [stderr] 9 | | LinkDir { [INFO] [stderr] 10 | | #[doc="Where to link files from."] [INFO] [stderr] 11 | | pub from: Template, [INFO] [stderr] ... | [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / fn var<'s>( [INFO] [stderr] 79 | | input: &'s str, [INFO] [stderr] 80 | | mut it: impl Iterator, [INFO] [stderr] 81 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 91 | | bail!("missing closing '}'") [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / fn environ<'s>( [INFO] [stderr] 95 | | input: &'s str, [INFO] [stderr] 96 | | mut it: impl Iterator, [INFO] [stderr] 97 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 108 | | Ok((input.len(), &input[start..])) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/template.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | while let Some((index, c)) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for (index, c) in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / fn var<'s>( [INFO] [stderr] 79 | | input: &'s str, [INFO] [stderr] 80 | | mut it: impl Iterator, [INFO] [stderr] 81 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 91 | | bail!("missing closing '}'") [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/template.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | / fn environ<'s>( [INFO] [stderr] 95 | | input: &'s str, [INFO] [stderr] 96 | | mut it: impl Iterator, [INFO] [stderr] 97 | | ) -> Result<(usize, &'s str), Error> { [INFO] [stderr] ... | [INFO] [stderr] 108 | | Ok((input.len(), &input[start..])) [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/template.rs:100:42 [INFO] [stderr] | [INFO] [stderr] 100 | while let Some((index, c)) = it.next() { [INFO] [stderr] | ^^^^^^^^^ help: try: `for (index, c) in it { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quickcfg`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `quickcfg`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "558dc4ccd6fd7a301091c5cf80cf099ecfedc83956612505b55b22597dd17a48"` [INFO] running `"docker" "rm" "-f" "558dc4ccd6fd7a301091c5cf80cf099ecfedc83956612505b55b22597dd17a48"` [INFO] [stdout] 558dc4ccd6fd7a301091c5cf80cf099ecfedc83956612505b55b22597dd17a48