[INFO] crate quick-error 1.2.2 is already in cache [INFO] extracting crate quick-error 1.2.2 into work/ex/clippy-test-run/sources/stable/reg/quick-error/1.2.2 [INFO] extracting crate quick-error 1.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quick-error/1.2.2 [INFO] validating manifest of quick-error-1.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quick-error-1.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quick-error-1.2.2 [INFO] finished frobbing quick-error-1.2.2 [INFO] frobbed toml for quick-error-1.2.2 written to work/ex/clippy-test-run/sources/stable/reg/quick-error/1.2.2/Cargo.toml [INFO] started frobbing quick-error-1.2.2 [INFO] finished frobbing quick-error-1.2.2 [INFO] frobbed toml for quick-error-1.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quick-error/1.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quick-error-1.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quick-error/1.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7bc9a5490a86930cfb29b4d3fef990c96f99e85d75745dc2f7eb425aa5957e31 [INFO] running `"docker" "start" "-a" "7bc9a5490a86930cfb29b4d3fef990c96f99e85d75745dc2f7eb425aa5957e31"` [INFO] [stderr] Checking quick-error v1.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1221:48 [INFO] [stderr] | [INFO] [stderr] 1221 | let err = StructWrapper::ExcessComma { descr: descr }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `descr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1221:48 [INFO] [stderr] | [INFO] [stderr] 1221 | let err = StructWrapper::ExcessComma { descr: descr }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `descr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1103:46 [INFO] [stderr] | [INFO] [stderr] 1103 | from(err: FromUtf8Error) -> (err.utf8_error().clone(), err.into_bytes()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `err.utf8_error()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1138:56 [INFO] [stderr] | [INFO] [stderr] 1138 | let err: &Error = &TupleWrapper::FromUtf8Error(cause.clone(), invalid_utf8.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1157:47 [INFO] [stderr] | [INFO] [stderr] 1157 | let err = TupleWrapper::FromUtf8Error(cause.utf8_error().clone(), invalid_utf8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `cause.utf8_error()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:1165:40 [INFO] [stderr] | [INFO] [stderr] 1165 | assert_eq!(format!("{}", err), format!("Discard")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Discard".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:1166:42 [INFO] [stderr] | [INFO] [stderr] 1166 | assert_eq!(format!("{:?}", err), format!("Discard")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Discard".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:1174:40 [INFO] [stderr] | [INFO] [stderr] 1174 | assert_eq!(format!("{}", err), format!("Just a string")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Just a string".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:1175:42 [INFO] [stderr] | [INFO] [stderr] 1175 | assert_eq!(format!("{:?}", err), format!("Singleton")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Singleton".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1202:59 [INFO] [stderr] | [INFO] [stderr] 1202 | let err: &Error = &StructWrapper::Utf8Error{ err: cause.clone(), hint: Some("nonsense") }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lib.rs:1213:50 [INFO] [stderr] | [INFO] [stderr] 1213 | let err = StructWrapper::Utf8Error{ err: cause.clone(), hint: None }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `cause` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/context.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | let fname = try!(env::args().skip(1).next().ok_or(Error::NoFileName)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.29s [INFO] running `"docker" "inspect" "7bc9a5490a86930cfb29b4d3fef990c96f99e85d75745dc2f7eb425aa5957e31"` [INFO] running `"docker" "rm" "-f" "7bc9a5490a86930cfb29b4d3fef990c96f99e85d75745dc2f7eb425aa5957e31"` [INFO] [stdout] 7bc9a5490a86930cfb29b4d3fef990c96f99e85d75745dc2f7eb425aa5957e31