[INFO] crate quest 0.3.0 is already in cache [INFO] extracting crate quest 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/quest/0.3.0 [INFO] extracting crate quest 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quest/0.3.0 [INFO] validating manifest of quest-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quest-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quest-0.3.0 [INFO] finished frobbing quest-0.3.0 [INFO] frobbed toml for quest-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/quest/0.3.0/Cargo.toml [INFO] started frobbing quest-0.3.0 [INFO] finished frobbing quest-0.3.0 [INFO] frobbed toml for quest-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quest/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quest-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quest/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a8d224511e741cfaa7fea071f8c4bb9929854dc10ab087a4c50158bb6f846200 [INFO] running `"docker" "start" "-a" "a8d224511e741cfaa7fea071f8c4bb9929854dc10ab087a4c50158bb6f846200"` [INFO] [stderr] Checking quest v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interactive/unix.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | let mut new = old.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | assert!(items.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/interactive/unix.rs:11:23 [INFO] [stderr] | [INFO] [stderr] 11 | let mut new = old.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `old` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | assert!(items.len() > 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!items.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> examples/everything.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | / match loop { [INFO] [stderr] 45 | | quest::ask("Are you the one? [yN] "); [INFO] [stderr] 46 | | match quest::yesno(false)? { [INFO] [stderr] 47 | | Some(b) => break b, [INFO] [stderr] ... | [INFO] [stderr] 52 | | false => println!("I guess not."), [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 44 | if loop { [INFO] [stderr] 45 | quest::ask("Are you the one? [yN] "); [INFO] [stderr] 46 | match quest::yesno(false)? { [INFO] [stderr] 47 | Some(b) => break b, [INFO] [stderr] 48 | None => (), [INFO] [stderr] 49 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/everything.rs:46:9 [INFO] [stderr] | [INFO] [stderr] 46 | / match quest::yesno(false)? { [INFO] [stderr] 47 | | Some(b) => break b, [INFO] [stderr] 48 | | None => (), [INFO] [stderr] 49 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(b) = quest::yesno(false)? { break b }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.14s [INFO] running `"docker" "inspect" "a8d224511e741cfaa7fea071f8c4bb9929854dc10ab087a4c50158bb6f846200"` [INFO] running `"docker" "rm" "-f" "a8d224511e741cfaa7fea071f8c4bb9929854dc10ab087a4c50158bb6f846200"` [INFO] [stdout] a8d224511e741cfaa7fea071f8c4bb9929854dc10ab087a4c50158bb6f846200