[INFO] crate queryst 2.0.0 is already in cache
[INFO] extracting crate queryst 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/queryst/2.0.0
[INFO] extracting crate queryst 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/queryst/2.0.0
[INFO] validating manifest of queryst-2.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of queryst-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing queryst-2.0.0
[INFO] finished frobbing queryst-2.0.0
[INFO] frobbed toml for queryst-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/queryst/2.0.0/Cargo.toml
[INFO] started frobbing queryst-2.0.0
[INFO] finished frobbing queryst-2.0.0
[INFO] frobbed toml for queryst-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/queryst/2.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting queryst-2.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/queryst/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a0f3a610b370fd12f17f135a73dbca78df09d23554e7f3d782da4707af81fd69
[INFO] running `"docker" "start" "-a" "a0f3a610b370fd12f17f135a73dbca78df09d23554e7f3d782da4707af81fd69"`
[INFO] [stderr]     Checking queryst v2.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/merge.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |         return Some(new_obj);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(new_obj)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/merge.rs:162:38
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 &Value::String(_) => return Some(from.clone()),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(from.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/merge.rs:176:13
[INFO] [stderr]     |
[INFO] [stderr] 176 |             return merge_string_and_json(to, from)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `merge_string_and_json(to, from)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return Value::Array(vec);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Array(vec)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     return Ok(result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 |     return pairs
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `pairs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return Value::Object(tree)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Object(tree)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     return Value::Object(tree)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Object(tree)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 |             return new_array;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_array`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:118:21
[INFO] [stderr]     |
[INFO] [stderr] 118 |                     return item;
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: remove `return` as shown: `item`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:121:21
[INFO] [stderr]     |
[INFO] [stderr] 121 |                     return create_object_with_key(key.to_string(), apply_object(&keys[1..], val));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `create_object_with_key(key.to_string(), apply_object(&keys[1..], val))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 |         return val;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `val`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/merge.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         match merge_result {
[INFO] [stderr] 39 | |             Some(result) => { to_tree.insert(to_index, result); },
[INFO] [stderr] 40 | |             None => ()
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(result) = merge_result { to_tree.insert(to_index, result); }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/merge.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 | /             match to_tree.get(key) {
[INFO] [stderr] 56 | |                 Some(_) => true,
[INFO] [stderr] 57 | |                 None => false
[INFO] [stderr] 58 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `to_tree.get(key).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/merge.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 | /             match merge_result {
[INFO] [stderr] 64 | |                 Some(result) => { to_tree.insert(key.to_string(), result); },
[INFO] [stderr] 65 | |                 None => ()
[INFO] [stderr] 66 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(result) = merge_result { to_tree.insert(key.to_string(), result); }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/merge.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 | /         match merge_result {
[INFO] [stderr] 105 | |             Some(result) => {
[INFO] [stderr] 106 | |                 to_vec.remove(to_index);
[INFO] [stderr] 107 | |                 to_vec.insert(to_index, result);
[INFO] [stderr] 108 | |             },
[INFO] [stderr] 109 | |             None => ()
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if let Some(result) = merge_result {
[INFO] [stderr] 105 |     to_vec.remove(to_index);
[INFO] [stderr] 106 |     to_vec.insert(to_index, result);
[INFO] [stderr] 107 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/merge.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     match to {
[INFO] [stderr] 157 | |         &mut Value::Object(_) => {
[INFO] [stderr] 158 | |             match from {
[INFO] [stderr] 159 | |                 &Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] ...   |
[INFO] [stderr] 178 | |         _ => panic!("Unknown merge")
[INFO] [stderr] 179 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |     match *to {
[INFO] [stderr] 157 |         Value::Object(_) => {
[INFO] [stderr] 158 |             match from {
[INFO] [stderr] 159 |                 &Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] 160 |                 &Value::Object(_) if is_merger(from) => merge_object_and_merger(to, from),
[INFO] [stderr] 161 |                 &Value::Object(_) => merge_object_and_object(to, from),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/merge.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 | /             match from {
[INFO] [stderr] 159 | |                 &Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] 160 | |                 &Value::Object(_) if is_merger(from) => merge_object_and_merger(to, from),
[INFO] [stderr] 161 | |                 &Value::Object(_) => merge_object_and_object(to, from),
[INFO] [stderr] 162 | |                 &Value::String(_) => return Some(from.clone()),
[INFO] [stderr] 163 | |                 _ => panic!("Unknown merge")
[INFO] [stderr] 164 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 158 |             match *from {
[INFO] [stderr] 159 |                 Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] 160 |                 Value::Object(_) if is_merger(from) => merge_object_and_merger(to, from),
[INFO] [stderr] 161 |                 Value::Object(_) => merge_object_and_object(to, from),
[INFO] [stderr] 162 |                 Value::String(_) => return Some(from.clone()),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/merge.rs:167:13
[INFO] [stderr]     |
[INFO] [stderr] 167 | /             match from {
[INFO] [stderr] 168 | |                 &Value::Array(_) => merge_list_and_list(to, from),
[INFO] [stderr] 169 | |                 &Value::Object(_) if is_merger(from) => merge_list_and_merger(to, from),
[INFO] [stderr] 170 | |                 &Value::Object(_) => merge_list_and_object(to, from),
[INFO] [stderr] 171 | |                 &Value::String(_) => merge_list_and_string(to, from),
[INFO] [stderr] 172 | |                 _ => panic!("Unknown merge")
[INFO] [stderr] 173 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 167 |             match *from {
[INFO] [stderr] 168 |                 Value::Array(_) => merge_list_and_list(to, from),
[INFO] [stderr] 169 |                 Value::Object(_) if is_merger(from) => merge_list_and_merger(to, from),
[INFO] [stderr] 170 |                 Value::Object(_) => merge_list_and_object(to, from),
[INFO] [stderr] 171 |                 Value::String(_) => merge_list_and_string(to, from),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |     for part in body.split("&") {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:42:51
[INFO] [stderr]    |
[INFO] [stderr] 42 |                             .or_else(|| part.find("="));
[INFO] [stderr]    |                                                   ^^^ help: try using a char instead: `'='`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     match PARENT_REGEX.captures(key) {
[INFO] [stderr] 61 | |         Some(captures) => {
[INFO] [stderr] 62 | |             match decode_component(captures.get(1).unwrap().as_str()) {
[INFO] [stderr] 63 | |                 Ok(decoded_key) => keys.push(decoded_key),
[INFO] [stderr] ...  |
[INFO] [stderr] 67 | |         None => ()
[INFO] [stderr] 68 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 60 |     if let Some(captures) = PARENT_REGEX.captures(key) {
[INFO] [stderr] 61 |     match decode_component(captures.get(1).unwrap().as_str()) {
[INFO] [stderr] 62 |         Ok(decoded_key) => keys.push(decoded_key),
[INFO] [stderr] 63 |         Err(err_msg) => return Err(ParseError{ kind: ParseErrorKind::DecodingError, message: err_msg })
[INFO] [stderr] 64 |     }
[INFO] [stderr] 65 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:81:24
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if key.starts_with("[") && key.ends_with("]") {
[INFO] [stderr]    |                        ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:81:46
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if key.starts_with("[") && key.ends_with("]") {
[INFO] [stderr]    |                                              ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:103:8
[INFO] [stderr]     |
[INFO] [stderr] 103 |     if keys.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keys.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/parser.rs:104:19
[INFO] [stderr]     |
[INFO] [stderr] 104 |         let key = keys.get(0).unwrap();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try this: `&keys[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/merge.rs:118:9
[INFO] [stderr]     |
[INFO] [stderr] 118 |         return Some(new_obj);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(new_obj)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/merge.rs:162:38
[INFO] [stderr]     |
[INFO] [stderr] 162 |                 &Value::String(_) => return Some(from.clone()),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(from.clone())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/merge.rs:176:13
[INFO] [stderr]     |
[INFO] [stderr] 176 |             return merge_string_and_json(to, from)
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `merge_string_and_json(to, from)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/helpers.rs:46:5
[INFO] [stderr]    |
[INFO] [stderr] 46 |     return Value::Array(vec);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Array(vec)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     return Ok(result);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(result)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:54:5
[INFO] [stderr]    |
[INFO] [stderr] 54 |     return pairs
[INFO] [stderr]    |     ^^^^^^^^^^^^ help: remove `return` as shown: `pairs`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return Value::Object(tree)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Object(tree)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     return Value::Object(tree)
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Value::Object(tree)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 |             return new_array;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `new_array`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:118:21
[INFO] [stderr]     |
[INFO] [stderr] 118 |                     return item;
[INFO] [stderr]     |                     ^^^^^^^^^^^^ help: remove `return` as shown: `item`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:121:21
[INFO] [stderr]     |
[INFO] [stderr] 121 |                     return create_object_with_key(key.to_string(), apply_object(&keys[1..], val));
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `create_object_with_key(key.to_string(), apply_object(&keys[1..], val))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:127:9
[INFO] [stderr]     |
[INFO] [stderr] 127 |         return val;
[INFO] [stderr]     |         ^^^^^^^^^^^ help: remove `return` as shown: `val`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/merge.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 | /         match merge_result {
[INFO] [stderr] 39 | |             Some(result) => { to_tree.insert(to_index, result); },
[INFO] [stderr] 40 | |             None => ()
[INFO] [stderr] 41 | |         }
[INFO] [stderr]    | |_________^ help: try this: `if let Some(result) = merge_result { to_tree.insert(to_index, result); }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/merge.rs:55:13
[INFO] [stderr]    |
[INFO] [stderr] 55 | /             match to_tree.get(key) {
[INFO] [stderr] 56 | |                 Some(_) => true,
[INFO] [stderr] 57 | |                 None => false
[INFO] [stderr] 58 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `to_tree.get(key).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/merge.rs:63:13
[INFO] [stderr]    |
[INFO] [stderr] 63 | /             match merge_result {
[INFO] [stderr] 64 | |                 Some(result) => { to_tree.insert(key.to_string(), result); },
[INFO] [stderr] 65 | |                 None => ()
[INFO] [stderr] 66 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(result) = merge_result { to_tree.insert(key.to_string(), result); }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/merge.rs:104:9
[INFO] [stderr]     |
[INFO] [stderr] 104 | /         match merge_result {
[INFO] [stderr] 105 | |             Some(result) => {
[INFO] [stderr] 106 | |                 to_vec.remove(to_index);
[INFO] [stderr] 107 | |                 to_vec.insert(to_index, result);
[INFO] [stderr] 108 | |             },
[INFO] [stderr] 109 | |             None => ()
[INFO] [stderr] 110 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 104 |         if let Some(result) = merge_result {
[INFO] [stderr] 105 |     to_vec.remove(to_index);
[INFO] [stderr] 106 |     to_vec.insert(to_index, result);
[INFO] [stderr] 107 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/merge.rs:156:5
[INFO] [stderr]     |
[INFO] [stderr] 156 | /     match to {
[INFO] [stderr] 157 | |         &mut Value::Object(_) => {
[INFO] [stderr] 158 | |             match from {
[INFO] [stderr] 159 | |                 &Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] ...   |
[INFO] [stderr] 178 | |         _ => panic!("Unknown merge")
[INFO] [stderr] 179 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |     match *to {
[INFO] [stderr] 157 |         Value::Object(_) => {
[INFO] [stderr] 158 |             match from {
[INFO] [stderr] 159 |                 &Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] 160 |                 &Value::Object(_) if is_merger(from) => merge_object_and_merger(to, from),
[INFO] [stderr] 161 |                 &Value::Object(_) => merge_object_and_object(to, from),
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/merge.rs:158:13
[INFO] [stderr]     |
[INFO] [stderr] 158 | /             match from {
[INFO] [stderr] 159 | |                 &Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] 160 | |                 &Value::Object(_) if is_merger(from) => merge_object_and_merger(to, from),
[INFO] [stderr] 161 | |                 &Value::Object(_) => merge_object_and_object(to, from),
[INFO] [stderr] 162 | |                 &Value::String(_) => return Some(from.clone()),
[INFO] [stderr] 163 | |                 _ => panic!("Unknown merge")
[INFO] [stderr] 164 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 158 |             match *from {
[INFO] [stderr] 159 |                 Value::Array(_) => merge_object_and_array(to, from),
[INFO] [stderr] 160 |                 Value::Object(_) if is_merger(from) => merge_object_and_merger(to, from),
[INFO] [stderr] 161 |                 Value::Object(_) => merge_object_and_object(to, from),
[INFO] [stderr] 162 |                 Value::String(_) => return Some(from.clone()),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/merge.rs:167:13
[INFO] [stderr]     |
[INFO] [stderr] 167 | /             match from {
[INFO] [stderr] 168 | |                 &Value::Array(_) => merge_list_and_list(to, from),
[INFO] [stderr] 169 | |                 &Value::Object(_) if is_merger(from) => merge_list_and_merger(to, from),
[INFO] [stderr] 170 | |                 &Value::Object(_) => merge_list_and_object(to, from),
[INFO] [stderr] 171 | |                 &Value::String(_) => merge_list_and_string(to, from),
[INFO] [stderr] 172 | |                 _ => panic!("Unknown merge")
[INFO] [stderr] 173 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 167 |             match *from {
[INFO] [stderr] 168 |                 Value::Array(_) => merge_list_and_list(to, from),
[INFO] [stderr] 169 |                 Value::Object(_) if is_merger(from) => merge_list_and_merger(to, from),
[INFO] [stderr] 170 |                 Value::Object(_) => merge_list_and_object(to, from),
[INFO] [stderr] 171 |                 Value::String(_) => merge_list_and_string(to, from),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:39:28
[INFO] [stderr]    |
[INFO] [stderr] 39 |     for part in body.split("&") {
[INFO] [stderr]    |                            ^^^ help: try using a char instead: `'&'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:42:51
[INFO] [stderr]    |
[INFO] [stderr] 42 |                             .or_else(|| part.find("="));
[INFO] [stderr]    |                                                   ^^^ help: try using a char instead: `'='`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/parser.rs:60:5
[INFO] [stderr]    |
[INFO] [stderr] 60 | /     match PARENT_REGEX.captures(key) {
[INFO] [stderr] 61 | |         Some(captures) => {
[INFO] [stderr] 62 | |             match decode_component(captures.get(1).unwrap().as_str()) {
[INFO] [stderr] 63 | |                 Ok(decoded_key) => keys.push(decoded_key),
[INFO] [stderr] ...  |
[INFO] [stderr] 67 | |         None => ()
[INFO] [stderr] 68 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 60 |     if let Some(captures) = PARENT_REGEX.captures(key) {
[INFO] [stderr] 61 |     match decode_component(captures.get(1).unwrap().as_str()) {
[INFO] [stderr] 62 |         Ok(decoded_key) => keys.push(decoded_key),
[INFO] [stderr] 63 |         Err(err_msg) => return Err(ParseError{ kind: ParseErrorKind::DecodingError, message: err_msg })
[INFO] [stderr] 64 |     }
[INFO] [stderr] 65 | };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:81:24
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if key.starts_with("[") && key.ends_with("]") {
[INFO] [stderr]    |                        ^^^ help: try using a char instead: `'['`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/parser.rs:81:46
[INFO] [stderr]    |
[INFO] [stderr] 81 |     if key.starts_with("[") && key.ends_with("]") {
[INFO] [stderr]    |                                              ^^^ help: try using a char instead: `']'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/parser.rs:103:8
[INFO] [stderr]     |
[INFO] [stderr] 103 |     if keys.len() > 0 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!keys.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/parser.rs:104:19
[INFO] [stderr]     |
[INFO] [stderr] 104 |         let key = keys.get(0).unwrap();
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^ help: try this: `&keys[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.00s
[INFO] running `"docker" "inspect" "a0f3a610b370fd12f17f135a73dbca78df09d23554e7f3d782da4707af81fd69"`
[INFO] running `"docker" "rm" "-f" "a0f3a610b370fd12f17f135a73dbca78df09d23554e7f3d782da4707af81fd69"`
[INFO] [stdout] a0f3a610b370fd12f17f135a73dbca78df09d23554e7f3d782da4707af81fd69