[INFO] crate query_builder 0.3.1 is already in cache [INFO] extracting crate query_builder 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/query_builder/0.3.1 [INFO] extracting crate query_builder 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/query_builder/0.3.1 [INFO] validating manifest of query_builder-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of query_builder-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing query_builder-0.3.1 [INFO] removed 0 missing tests [INFO] finished frobbing query_builder-0.3.1 [INFO] frobbed toml for query_builder-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/query_builder/0.3.1/Cargo.toml [INFO] started frobbing query_builder-0.3.1 [INFO] removed 0 missing tests [INFO] finished frobbing query_builder-0.3.1 [INFO] frobbed toml for query_builder-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/query_builder/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting query_builder-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/query_builder/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 859472dc2041793aaa2e1980c756aec2aee196bb64a20f5bad9d2c62aa551f47 [INFO] running `"docker" "start" "-a" "859472dc2041793aaa2e1980c756aec2aee196bb64a20f5bad9d2c62aa551f47"` [INFO] [stderr] Checking query_builder v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:185:17 [INFO] [stderr] | [INFO] [stderr] 185 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:191:17 [INFO] [stderr] | [INFO] [stderr] 191 | cond: cond, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cond` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:357:16 [INFO] [stderr] | [INFO] [stderr] 357 | if let Some(_) = self.limit { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 358 | | return true; [INFO] [stderr] 359 | | } [INFO] [stderr] | |_________- help: try this: `if self.limit.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:518:20 [INFO] [stderr] | [INFO] [stderr] 518 | vals = format!("{}", key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `key.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:657:16 [INFO] [stderr] | [INFO] [stderr] 657 | if let Some(_) = self.order_by { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 658 | | true [INFO] [stderr] 659 | | } [INFO] [stderr] 660 | | else { [INFO] [stderr] 661 | | false [INFO] [stderr] 662 | | } [INFO] [stderr] | |_________- help: try this: `if self.order_by.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:793:16 [INFO] [stderr] | [INFO] [stderr] 793 | if let Some(_) = self.limit { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 794 | | return true; [INFO] [stderr] 795 | | } [INFO] [stderr] | |_________- help: try this: `if self.limit.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:357:16 [INFO] [stderr] | [INFO] [stderr] 357 | if let Some(_) = self.limit { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 358 | | return true; [INFO] [stderr] 359 | | } [INFO] [stderr] | |_________- help: try this: `if self.limit.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/lib.rs:518:20 [INFO] [stderr] | [INFO] [stderr] 518 | vals = format!("{}", key); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `key.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:657:16 [INFO] [stderr] | [INFO] [stderr] 657 | if let Some(_) = self.order_by { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 658 | | true [INFO] [stderr] 659 | | } [INFO] [stderr] 660 | | else { [INFO] [stderr] 661 | | false [INFO] [stderr] 662 | | } [INFO] [stderr] | |_________- help: try this: `if self.order_by.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/lib.rs:793:16 [INFO] [stderr] | [INFO] [stderr] 793 | if let Some(_) = self.limit { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 794 | | return true; [INFO] [stderr] 795 | | } [INFO] [stderr] | |_________- help: try this: `if self.limit.is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.59s [INFO] running `"docker" "inspect" "859472dc2041793aaa2e1980c756aec2aee196bb64a20f5bad9d2c62aa551f47"` [INFO] running `"docker" "rm" "-f" "859472dc2041793aaa2e1980c756aec2aee196bb64a20f5bad9d2c62aa551f47"` [INFO] [stdout] 859472dc2041793aaa2e1980c756aec2aee196bb64a20f5bad9d2c62aa551f47