[INFO] crate queen-io 0.1.6 is already in cache [INFO] extracting crate queen-io 0.1.6 into work/ex/clippy-test-run/sources/stable/reg/queen-io/0.1.6 [INFO] extracting crate queen-io 0.1.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/queen-io/0.1.6 [INFO] validating manifest of queen-io-0.1.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of queen-io-0.1.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing queen-io-0.1.6 [INFO] finished frobbing queen-io-0.1.6 [INFO] frobbed toml for queen-io-0.1.6 written to work/ex/clippy-test-run/sources/stable/reg/queen-io/0.1.6/Cargo.toml [INFO] started frobbing queen-io-0.1.6 [INFO] finished frobbing queen-io-0.1.6 [INFO] frobbed toml for queen-io-0.1.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/queen-io/0.1.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting queen-io-0.1.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/queen-io/0.1.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7cf30d3508b804cda591937ad1132e090d5ea3e4c66c3110ba1bc48c93366cd7 [INFO] running `"docker" "start" "-a" "7cf30d3508b804cda591937ad1132e090d5ea3e4c66c3110ba1bc48c93366cd7"` [INFO] [stderr] Checking queen-io v0.1.6 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/plus/timer.rs:103:32 [INFO] [stderr] | [INFO] [stderr] 103 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 104 | | if let Some(mut task) = tasks.pop() { [INFO] [stderr] 105 | | let mut queue = inner.queue.lock().unwrap(); [INFO] [stderr] 106 | | queue.push_back(task.clone()); [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 103 | } else if let Some(mut task) = tasks.pop() { [INFO] [stderr] 104 | let mut queue = inner.queue.lock().unwrap(); [INFO] [stderr] 105 | queue.push_back(task.clone()); [INFO] [stderr] 106 | [INFO] [stderr] 107 | if task.timespec.interval != Duration::default() { [INFO] [stderr] 108 | task.timespec.value += task.timespec.interval; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/plus/timer.rs:103:32 [INFO] [stderr] | [INFO] [stderr] 103 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 104 | | if let Some(mut task) = tasks.pop() { [INFO] [stderr] 105 | | let mut queue = inner.queue.lock().unwrap(); [INFO] [stderr] 106 | | queue.push_back(task.clone()); [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 103 | } else if let Some(mut task) = tasks.pop() { [INFO] [stderr] 104 | let mut queue = inner.queue.lock().unwrap(); [INFO] [stderr] 105 | queue.push_back(task.clone()); [INFO] [stderr] 106 | [INFO] [stderr] 107 | if task.timespec.interval != Duration::default() { [INFO] [stderr] 108 | task.timespec.value += task.timespec.interval; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `plus::timer::Timer` [INFO] [stderr] --> src/plus/timer.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Timer { [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | let inner = Arc::new(TimerInner { [INFO] [stderr] 80 | | tasks: Mutex::new(BinaryHeap::new()), [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | impl Default for plus::timer::Timer { [INFO] [stderr] 77 | fn default() -> Self { [INFO] [stderr] 78 | Self::new() [INFO] [stderr] 79 | } [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `plus::timer::Timer` [INFO] [stderr] --> src/plus/timer.rs:77:5 [INFO] [stderr] | [INFO] [stderr] 77 | / pub fn new() -> Timer { [INFO] [stderr] 78 | | [INFO] [stderr] 79 | | let inner = Arc::new(TimerInner { [INFO] [stderr] 80 | | tasks: Mutex::new(BinaryHeap::new()), [INFO] [stderr] ... | [INFO] [stderr] 129 | | } [INFO] [stderr] 130 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | impl Default for plus::timer::Timer { [INFO] [stderr] 77 | fn default() -> Self { [INFO] [stderr] 78 | Self::new() [INFO] [stderr] 79 | } [INFO] [stderr] 80 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.23s [INFO] running `"docker" "inspect" "7cf30d3508b804cda591937ad1132e090d5ea3e4c66c3110ba1bc48c93366cd7"` [INFO] running `"docker" "rm" "-f" "7cf30d3508b804cda591937ad1132e090d5ea3e4c66c3110ba1bc48c93366cd7"` [INFO] [stdout] 7cf30d3508b804cda591937ad1132e090d5ea3e4c66c3110ba1bc48c93366cd7