[INFO] crate quat 0.2.1 is already in cache [INFO] extracting crate quat 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/quat/0.2.1 [INFO] extracting crate quat 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quat/0.2.1 [INFO] validating manifest of quat-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quat-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quat-0.2.1 [INFO] finished frobbing quat-0.2.1 [INFO] frobbed toml for quat-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/quat/0.2.1/Cargo.toml [INFO] started frobbing quat-0.2.1 [INFO] finished frobbing quat-0.2.1 [INFO] frobbed toml for quat-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quat/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quat-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quat/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6d934095cce81ce6878e8da96f8b19f719c9f2c0ac15a19f3fe0ab223d22ee35 [INFO] running `"docker" "start" "-a" "6d934095cce81ce6878e8da96f8b19f719c9f2c0ac15a19f3fe0ab223d22ee35"` [INFO] [stderr] Checking vec4 v0.2.1 [INFO] [stderr] Checking quat v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/len.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - out[0] * out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/len.rs:41:46 [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - out[1] * out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/len.rs:41:66 [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - out[2] * out[2]) [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lerp.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | let mut tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/set.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn set_mat3_values<'out, T>( [INFO] [stderr] 52 | | out: &'out mut [T; 4], [INFO] [stderr] 53 | | m00: T, [INFO] [stderr] 54 | | m01: T, [INFO] [stderr] ... | [INFO] [stderr] 101 | | out [INFO] [stderr] 102 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/set.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn set_mat3_values<'out, T>( [INFO] [stderr] 52 | | out: &'out mut [T; 4], [INFO] [stderr] 53 | | m00: T, [INFO] [stderr] 54 | | m01: T, [INFO] [stderr] ... | [INFO] [stderr] 101 | | out [INFO] [stderr] 102 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn rotation_x<'out, T>(out: &[T; 4]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn rotation_y<'out, T>(out: &[T; 4]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn rotation_z<'out, T>(out: &[T; 4]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:113:15 [INFO] [stderr] | [INFO] [stderr] 113 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:147:15 [INFO] [stderr] | [INFO] [stderr] 147 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | let mut tmp_a = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:174:15 [INFO] [stderr] | [INFO] [stderr] 174 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/len.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - out[0] * out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/len.rs:41:46 [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - out[1] * out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/len.rs:41:66 [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - &out[2] * &out[2]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 41 | out[3] = (T::one() - &out[0] * &out[0] - &out[1] * &out[1] - out[2] * out[2]) [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lerp.rs:31:19 [INFO] [stderr] | [INFO] [stderr] 31 | let mut tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/set.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn set_mat3_values<'out, T>( [INFO] [stderr] 52 | | out: &'out mut [T; 4], [INFO] [stderr] 53 | | m00: T, [INFO] [stderr] 54 | | m01: T, [INFO] [stderr] ... | [INFO] [stderr] 101 | | out [INFO] [stderr] 102 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/set.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / pub fn set_mat3_values<'out, T>( [INFO] [stderr] 52 | | out: &'out mut [T; 4], [INFO] [stderr] 53 | | m00: T, [INFO] [stderr] 54 | | m01: T, [INFO] [stderr] ... | [INFO] [stderr] 101 | | out [INFO] [stderr] 102 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn rotation_x<'out, T>(out: &[T; 4]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn rotation_y<'out, T>(out: &[T; 4]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/transform.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn rotation_z<'out, T>(out: &[T; 4]) -> T [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:113:15 [INFO] [stderr] | [INFO] [stderr] 113 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:147:15 [INFO] [stderr] | [INFO] [stderr] 147 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:162:21 [INFO] [stderr] | [INFO] [stderr] 162 | let mut tmp_a = a.clone(); [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transform.rs:174:15 [INFO] [stderr] | [INFO] [stderr] 174 | let tmp = out.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.99s [INFO] running `"docker" "inspect" "6d934095cce81ce6878e8da96f8b19f719c9f2c0ac15a19f3fe0ab223d22ee35"` [INFO] running `"docker" "rm" "-f" "6d934095cce81ce6878e8da96f8b19f719c9f2c0ac15a19f3fe0ab223d22ee35"` [INFO] [stdout] 6d934095cce81ce6878e8da96f8b19f719c9f2c0ac15a19f3fe0ab223d22ee35