[INFO] crate quantiles 0.7.1 is already in cache [INFO] extracting crate quantiles 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/quantiles/0.7.1 [INFO] extracting crate quantiles 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quantiles/0.7.1 [INFO] validating manifest of quantiles-0.7.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quantiles-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quantiles-0.7.1 [INFO] finished frobbing quantiles-0.7.1 [INFO] frobbed toml for quantiles-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/quantiles/0.7.1/Cargo.toml [INFO] started frobbing quantiles-0.7.1 [INFO] finished frobbing quantiles-0.7.1 [INFO] frobbed toml for quantiles-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quantiles/0.7.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quantiles-0.7.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quantiles/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 183c0842486b3b3c3be6c6aeaede7cd191631fc367562cded01c49ba5ecec54b [INFO] running `"docker" "start" "-a" "183c0842486b3b3c3be6c6aeaede7cd191631fc367562cded01c49ba5ecec54b"` [INFO] [stderr] Checking quantiles v0.7.1 (/opt/crater/workdir) [INFO] [stderr] Checking quickcheck v0.5.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | g: g, [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | epsilon: epsilon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `epsilon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ckms/store.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ckms/store.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | inner_cap: inner_cap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ckms/mod.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | insert_threshold: insert_threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `insert_threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/histogram.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/ckms/store.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn insert(&mut self, element: T) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/histogram.rs:228:40 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn insert(&mut self, value: T) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/greenwald_khanna.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | assert!(self.summary.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.summary.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/ckms/store.rs:322:15 [INFO] [stderr] | [INFO] [stderr] 322 | while (self.data.len() >= 1) && (cur_outer_idx < (self.data.len() - 1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | v: v, [INFO] [stderr] | ^^^^ help: replace it with: `v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | g: g, [INFO] [stderr] | ^^^^ help: replace it with: `g` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:146:13 [INFO] [stderr] | [INFO] [stderr] 146 | delta: delta, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `delta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/greenwald_khanna.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | epsilon: epsilon, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `epsilon` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ckms/store.rs:113:13 [INFO] [stderr] | [INFO] [stderr] 113 | error: error, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ckms/store.rs:115:13 [INFO] [stderr] | [INFO] [stderr] 115 | inner_cap: inner_cap, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inner_cap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> benches/ckms.rs:14:24 [INFO] [stderr] | [INFO] [stderr] 14 | Xorshift { seed: seed } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `seed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ckms/mod.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | insert_threshold: insert_threshold, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `insert_threshold` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/histogram.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | bins: bins, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `bins` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/ckms.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `quantiles`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/ckms/store.rs:122:42 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn insert(&mut self, element: T) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ckms/store.rs:506:13 [INFO] [stderr] | [INFO] [stderr] 506 | return TestResult::passed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TestResult::passed()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ckms/mod.rs:301:9 [INFO] [stderr] | [INFO] [stderr] 301 | return data[idx]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `data[idx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ckms/mod.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | return TestResult::passed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TestResult::passed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ckms/mod.rs:352:13 [INFO] [stderr] | [INFO] [stderr] 352 | return TestResult::passed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TestResult::passed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/histogram.rs:228:40 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn insert(&mut self, value: T) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/misra_gries.rs:109:21 [INFO] [stderr] | [INFO] [stderr] 109 | assert_eq!(*counts.get(&1).unwrap() as u32, 3); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[&1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/misra_gries.rs:110:21 [INFO] [stderr] | [INFO] [stderr] 110 | assert_eq!(*counts.get(&2).unwrap() as u32, 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[&2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/misra_gries.rs:111:21 [INFO] [stderr] | [INFO] [stderr] 111 | assert_eq!(*counts.get(&3).unwrap() as u32, 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[&3]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/misra_gries.rs:112:21 [INFO] [stderr] | [INFO] [stderr] 112 | assert_eq!(*counts.get(&4).unwrap() as u32, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&counts[&4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/misra_gries.rs:131:34 [INFO] [stderr] | [INFO] [stderr] 131 | let exact = *exacts.get(i).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&exacts[i]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/greenwald_khanna.rs:223:17 [INFO] [stderr] | [INFO] [stderr] 223 | assert!(self.summary.len() >= 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.summary.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/greenwald_khanna.rs:336:16 [INFO] [stderr] | [INFO] [stderr] 336 | (phi * ((r.end - 1) - r.start) as f64).floor() as u32 + r.start [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((r.end - 1) - r.start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/greenwald_khanna.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | (phi as f64) / 100f64, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(phi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/ckms/store.rs:322:15 [INFO] [stderr] | [INFO] [stderr] 322 | while (self.data.len() >= 1) && (cur_outer_idx < (self.data.len() - 1)) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ckms/store.rs:491:38 [INFO] [stderr] | [INFO] [stderr] 491 | } else if inner_cap == 0 { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 492 | | return TestResult::discard(); [INFO] [stderr] 493 | | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ckms/store.rs:489:32 [INFO] [stderr] | [INFO] [stderr] 489 | if data.is_empty() { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 490 | | return TestResult::discard(); [INFO] [stderr] 491 | | } else if inner_cap == 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/store.rs:493:23 [INFO] [stderr] | [INFO] [stderr] 493 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_cmp_op_on_partial_ord)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/store.rs:493:40 [INFO] [stderr] | [INFO] [stderr] 493 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ckms/mod.rs:299:25 [INFO] [stderr] | [INFO] [stderr] 299 | fn percentile(data: &Vec, prcnt: f64) -> f64 { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ckms/mod.rs:309:54 [INFO] [stderr] | [INFO] [stderr] 309 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 310 | | return TestResult::discard(); [INFO] [stderr] 311 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ckms/mod.rs:307:32 [INFO] [stderr] | [INFO] [stderr] 307 | if data.is_empty() { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 308 | | return TestResult::discard(); [INFO] [stderr] 309 | | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:309:23 [INFO] [stderr] | [INFO] [stderr] 309 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:309:40 [INFO] [stderr] | [INFO] [stderr] 309 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:332:16 [INFO] [stderr] | [INFO] [stderr] 332 | if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:332:33 [INFO] [stderr] | [INFO] [stderr] 332 | if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ckms/mod.rs:364:38 [INFO] [stderr] | [INFO] [stderr] 364 | } else if data.len() < 1 { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 365 | | return TestResult::discard(); [INFO] [stderr] 366 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ckms/mod.rs:362:51 [INFO] [stderr] | [INFO] [stderr] 362 | if !(prcnt >= 0.0) || !(prcnt <= 1.0) { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 363 | | return TestResult::discard(); [INFO] [stderr] 364 | | } else if data.len() < 1 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:362:16 [INFO] [stderr] | [INFO] [stderr] 362 | if !(prcnt >= 0.0) || !(prcnt <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:362:35 [INFO] [stderr] | [INFO] [stderr] 362 | if !(prcnt >= 0.0) || !(prcnt <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/ckms/mod.rs:364:23 [INFO] [stderr] | [INFO] [stderr] 364 | } else if data.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ckms/mod.rs:396:54 [INFO] [stderr] | [INFO] [stderr] 396 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 397 | | return TestResult::discard(); [INFO] [stderr] 398 | | } else if (lhs.len() + rhs.len()) < 1 { [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ckms/mod.rs:394:51 [INFO] [stderr] | [INFO] [stderr] 394 | if !(prcnt >= 0.0) || !(prcnt <= 1.0) { [INFO] [stderr] | ___________________________________________________^ [INFO] [stderr] 395 | | return TestResult::discard(); [INFO] [stderr] 396 | | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:394:16 [INFO] [stderr] | [INFO] [stderr] 394 | if !(prcnt >= 0.0) || !(prcnt <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:394:35 [INFO] [stderr] | [INFO] [stderr] 394 | if !(prcnt >= 0.0) || !(prcnt <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:396:23 [INFO] [stderr] | [INFO] [stderr] 396 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: The use of negated comparison operators on partially ordered types produces code that is hard to read and refactor. Please consider using the `partial_cmp` method instead, to make it clear that the two values could be incomparable. [INFO] [stderr] --> src/ckms/mod.rs:396:40 [INFO] [stderr] | [INFO] [stderr] 396 | } else if !(err >= 0.0) || !(err <= 1.0) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_cmp_op_on_partial_ord [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/ckms/mod.rs:480:16 [INFO] [stderr] | [INFO] [stderr] 480 | if fs.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ckms/mod.rs:496:33 [INFO] [stderr] | [INFO] [stderr] 496 | let fdiv2 = (invariant(nphi, error) as f64) / 2.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(invariant(nphi, error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ckms/mod.rs:512:25 [INFO] [stderr] | [INFO] [stderr] 512 | ckms.insert(i as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ckms/mod.rs:515:9 [INFO] [stderr] | [INFO] [stderr] 515 | assert_eq!(0.0, ckms.samples[0].v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ckms/mod.rs:515:9 [INFO] [stderr] | [INFO] [stderr] 515 | assert_eq!(0.0, ckms.samples[0].v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ckms/mod.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | assert_eq!(1.0, ckms.samples[1].v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ckms/mod.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | assert_eq!(1.0, ckms.samples[1].v); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ckms/mod.rs:529:16 [INFO] [stderr] | [INFO] [stderr] 529 | if ckms.samples.len() == 0 && fsc.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ckms.samples.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ckms/mod.rs:529:43 [INFO] [stderr] | [INFO] [stderr] 529 | if ckms.samples.len() == 0 && fsc.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `fsc.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ckms/mod.rs:558:21 [INFO] [stderr] | [INFO] [stderr] 558 | let ref prev = ckms.samples[i - 1]; [INFO] [stderr] | ----^^^^^^^^----------------------- help: try: `let prev = &ckms.samples[i - 1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ckms/mod.rs:559:21 [INFO] [stderr] | [INFO] [stderr] 559 | let ref cur = ckms.samples[i]; [INFO] [stderr] | ----^^^^^^^------------------- help: try: `let cur = &ckms.samples[i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ckms/mod.rs:563:60 [INFO] [stderr] | [INFO] [stderr] 563 | let res = (cur.g + cur.delta) <= invariant(r as f64, error); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ckms/mod.rs:568:35 [INFO] [stderr] | [INFO] [stderr] 568 | invariant(r as f64, error) [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(r)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/ckms/mod.rs:614:16 [INFO] [stderr] | [INFO] [stderr] 614 | if !(s <= bound) && !((s - bound).abs() < 1_024) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s > bound && (s - bound).abs() >= 1_024` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/histogram.rs:455:25 [INFO] [stderr] | [INFO] [stderr] 455 | assert_eq!(res.sum().unwrap(), x.sum().unwrap() + y.sum().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/histogram.rs:455:25 [INFO] [stderr] | [INFO] [stderr] 455 | assert_eq!(res.sum().unwrap(), x.sum().unwrap() + y.sum().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/histogram.rs:458:25 [INFO] [stderr] | [INFO] [stderr] 458 | assert_eq!(res.sum().unwrap(), y.sum().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/histogram.rs:458:25 [INFO] [stderr] | [INFO] [stderr] 458 | assert_eq!(res.sum().unwrap(), y.sum().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/histogram.rs:461:25 [INFO] [stderr] | [INFO] [stderr] 461 | assert_eq!(res.sum().unwrap(), x.sum().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/histogram.rs:461:25 [INFO] [stderr] | [INFO] [stderr] 461 | assert_eq!(res.sum().unwrap(), x.sum().unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 690 | generate_tests!(u16, u16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 690 | generate_tests!(u16, u16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 690 | generate_tests!(u16, u16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 690 | generate_tests!(u16, u16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 690 | generate_tests!(u16, u16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 691 | generate_tests!(u32, u32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 691 | generate_tests!(u32, u32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 691 | generate_tests!(u32, u32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 691 | generate_tests!(u32, u32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 691 | generate_tests!(u32, u32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 692 | generate_tests!(i16, i16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 692 | generate_tests!(i16, i16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 692 | generate_tests!(i16, i16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 692 | generate_tests!(i16, i16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 692 | generate_tests!(i16, i16); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 693 | generate_tests!(i32, i32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 693 | generate_tests!(i32, i32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 693 | generate_tests!(i32, i32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 693 | generate_tests!(i32, i32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 693 | generate_tests!(i32, i32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 694 | generate_tests!(f32, f32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 694 | generate_tests!(f32, f32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 694 | generate_tests!(f32, f32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 694 | generate_tests!(f32, f32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 694 | generate_tests!(f32, f32); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/histogram.rs:532:43 [INFO] [stderr] | [INFO] [stderr] 532 | let mut sum: $t = 0 as $t; [INFO] [stderr] | ^ help: try: `f64::from(0)` [INFO] [stderr] ... [INFO] [stderr] 695 | generate_tests!(f64, f64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 695 | generate_tests!(f64, f64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 695 | generate_tests!(f64, f64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 695 | generate_tests!(f64, f64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 695 | generate_tests!(f64, f64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 695 | generate_tests!(f64, f64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 696 | generate_tests!(u64, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 696 | generate_tests!(u64, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 696 | generate_tests!(u64, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 696 | generate_tests!(u64, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 696 | generate_tests!(u64, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 697 | generate_tests!(i64, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 697 | generate_tests!(i64, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 697 | generate_tests!(i64, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 697 | generate_tests!(i64, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 697 | generate_tests!(i64, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 698 | generate_tests!(usize, usize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 698 | generate_tests!(usize, usize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 698 | generate_tests!(usize, usize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 698 | generate_tests!(usize, usize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 698 | generate_tests!(usize, usize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:564:52 [INFO] [stderr] | [INFO] [stderr] 564 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 699 | generate_tests!(isize, isize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:574:33 [INFO] [stderr] | [INFO] [stderr] 574 | / match b { [INFO] [stderr] 575 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 576 | | if v <= bnd { [INFO] [stderr] 577 | | below_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 584 | | } [INFO] [stderr] 585 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 699 | generate_tests!(isize, isize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:609:52 [INFO] [stderr] | [INFO] [stderr] 609 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 699 | generate_tests!(isize, isize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/histogram.rs:619:33 [INFO] [stderr] | [INFO] [stderr] 619 | / match b { [INFO] [stderr] 620 | | &Bound::Finite(ref bnd) => { [INFO] [stderr] 621 | | if v > bnd { [INFO] [stderr] 622 | | above_count += 1; [INFO] [stderr] ... | [INFO] [stderr] 625 | | &Bound::PosInf => {} [INFO] [stderr] 626 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] ... [INFO] [stderr] 699 | generate_tests!(isize, isize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/histogram.rs:650:51 [INFO] [stderr] | [INFO] [stderr] 650 | bounds.into_iter().map(|x| Bound::Finite(x)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Bound::Finite` [INFO] [stderr] ... [INFO] [stderr] 699 | generate_tests!(isize, isize); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 9 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `quantiles`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "183c0842486b3b3c3be6c6aeaede7cd191631fc367562cded01c49ba5ecec54b"` [INFO] running `"docker" "rm" "-f" "183c0842486b3b3c3be6c6aeaede7cd191631fc367562cded01c49ba5ecec54b"` [INFO] [stdout] 183c0842486b3b3c3be6c6aeaede7cd191631fc367562cded01c49ba5ecec54b