[INFO] crate quandl-v3 1.1.0 is already in cache [INFO] extracting crate quandl-v3 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/quandl-v3/1.1.0 [INFO] extracting crate quandl-v3 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quandl-v3/1.1.0 [INFO] validating manifest of quandl-v3-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of quandl-v3-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing quandl-v3-1.1.0 [INFO] finished frobbing quandl-v3-1.1.0 [INFO] frobbed toml for quandl-v3-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/quandl-v3/1.1.0/Cargo.toml [INFO] started frobbing quandl-v3-1.1.0 [INFO] finished frobbing quandl-v3-1.1.0 [INFO] frobbed toml for quandl-v3-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/quandl-v3/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting quandl-v3-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/quandl-v3/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 323d3b4a119487c07323d7fc591540cc3e5cad347c816415a9fb5f827f6b0158 [INFO] running `"docker" "start" "-a" "323d3b4a119487c07323d7fc591540cc3e5cad347c816415a9fb5f827f6b0158"` [INFO] [stderr] Checking has v0.1.0 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking quandl-v3 v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:316:25 [INFO] [stderr] | [INFO] [stderr] 316 | database_code: database_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `database_code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:317:25 [INFO] [stderr] | [INFO] [stderr] 317 | dataset_code: dataset_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dataset_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:316:25 [INFO] [stderr] | [INFO] [stderr] 316 | database_code: database_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `database_code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/query.rs:317:25 [INFO] [stderr] | [INFO] [stderr] 317 | dataset_code: dataset_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dataset_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::DatabaseSearch` [INFO] [stderr] --> src/query.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Self { [INFO] [stderr] 104 | | DatabaseSearch { [INFO] [stderr] 105 | | request_arguments: ApiArguments::default(), [INFO] [stderr] 106 | | search_arguments: SearchArguments::default(), [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `query::DatabaseSearch` [INFO] [stderr] --> src/query.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | / pub fn new() -> Self { [INFO] [stderr] 104 | | DatabaseSearch { [INFO] [stderr] 105 | | request_arguments: ApiArguments::default(), [INFO] [stderr] 106 | | search_arguments: SearchArguments::default(), [INFO] [stderr] 107 | | } [INFO] [stderr] 108 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `batch_query::BatchQuery` [INFO] [stderr] --> src/batch_query.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Self { [INFO] [stderr] 42 | | BatchQuery { [INFO] [stderr] 43 | | offset: 0, [INFO] [stderr] 44 | | limits: vec![], [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/batch_query.rs:157:63 [INFO] [stderr] | [INFO] [stderr] 157 | keys.write().unwrap().insert(key.clone(), Mutex::new(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/batch_query.rs:204:66 [INFO] [stderr] | [INFO] [stderr] 204 | ::std::thread::sleep(duration.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/batch_query.rs:211:40 [INFO] [stderr] | [INFO] [stderr] 211 | if let Err(_) = tx.send(api_call.send()) { [INFO] [stderr] | _________________________________- ^^^^^^ [INFO] [stderr] 212 | | panic!("Thread's communication channel closed prematurely."); [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________________________- help: try this: `if tx.send(api_call.send()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/batch_query.rs:224:62 [INFO] [stderr] | [INFO] [stderr] 224 | ::std::thread::sleep(duration.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/batch_query.rs:230:40 [INFO] [stderr] | [INFO] [stderr] 230 | if let Err(_) = tx.send(api_call.send()) { [INFO] [stderr] | _________________________________- ^^^^^^ [INFO] [stderr] 231 | | panic!("Thread's communication channel closed prematurely."); [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________________________________- help: try this: `if tx.send(api_call.send()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/batch_query.rs:262:35 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn try_next(&mut self) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `batch_query::BatchQuery` [INFO] [stderr] --> src/batch_query.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Self { [INFO] [stderr] 42 | | BatchQuery { [INFO] [stderr] 43 | | offset: 0, [INFO] [stderr] 44 | | limits: vec![], [INFO] [stderr] ... | [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicUsize instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/batch_query.rs:157:63 [INFO] [stderr] | [INFO] [stderr] 157 | keys.write().unwrap().insert(key.clone(), Mutex::new(self.offset)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / match self { [INFO] [stderr] 164 | | &Error::ApiCallFailed(_) => "Quandl's server responded with an error.", [INFO] [stderr] 165 | | &Error::DownloadFailed(_) => "Download failed.", [INFO] [stderr] 166 | | &Error::ParsingFailed(_) => "Parsing data failed.", [INFO] [stderr] 167 | | &Error::IoError(_) => "Underlying system I/O error.", [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | match *self { [INFO] [stderr] 164 | Error::ApiCallFailed(_) => "Quandl's server responded with an error.", [INFO] [stderr] 165 | Error::DownloadFailed(_) => "Download failed.", [INFO] [stderr] 166 | Error::ParsingFailed(_) => "Parsing data failed.", [INFO] [stderr] 167 | Error::IoError(_) => "Underlying system I/O error.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/batch_query.rs:204:66 [INFO] [stderr] | [INFO] [stderr] 204 | ::std::thread::sleep(duration.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*duration` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/batch_query.rs:211:40 [INFO] [stderr] | [INFO] [stderr] 211 | if let Err(_) = tx.send(api_call.send()) { [INFO] [stderr] | _________________________________- ^^^^^^ [INFO] [stderr] 212 | | panic!("Thread's communication channel closed prematurely."); [INFO] [stderr] 213 | | } [INFO] [stderr] | |_________________________________- help: try this: `if tx.send(api_call.send()).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/batch_query.rs:224:62 [INFO] [stderr] | [INFO] [stderr] 224 | ::std::thread::sleep(duration.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*duration` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/batch_query.rs:230:40 [INFO] [stderr] | [INFO] [stderr] 230 | if let Err(_) = tx.send(api_call.send()) { [INFO] [stderr] | _________________________________- ^^^^^^ [INFO] [stderr] 231 | | panic!("Thread's communication channel closed prematurely."); [INFO] [stderr] 232 | | } [INFO] [stderr] | |_________________________________- help: try this: `if tx.send(api_call.send()).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self { [INFO] [stderr] 175 | | &Error::ApiCallFailed(ref e) => { [INFO] [stderr] 176 | | if e.errors.is_some() && !e.errors.as_ref().unwrap().is_empty() { [INFO] [stderr] 177 | | let (object, what) = e.errors.as_ref().unwrap().iter().next().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 197 | | }, [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | match *self { [INFO] [stderr] 175 | Error::ApiCallFailed(ref e) => { [INFO] [stderr] 176 | if e.errors.is_some() && !e.errors.as_ref().unwrap().is_empty() { [INFO] [stderr] 177 | let (object, what) = e.errors.as_ref().unwrap().iter().next().unwrap(); [INFO] [stderr] 178 | [INFO] [stderr] 179 | write!(f, "{}", { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/batch_query.rs:262:35 [INFO] [stderr] | [INFO] [stderr] 262 | pub fn try_next(&mut self) -> Option> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | / match self { [INFO] [stderr] 164 | | &Error::ApiCallFailed(_) => "Quandl's server responded with an error.", [INFO] [stderr] 165 | | &Error::DownloadFailed(_) => "Download failed.", [INFO] [stderr] 166 | | &Error::ParsingFailed(_) => "Parsing data failed.", [INFO] [stderr] 167 | | &Error::IoError(_) => "Underlying system I/O error.", [INFO] [stderr] 168 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 163 | match *self { [INFO] [stderr] 164 | Error::ApiCallFailed(_) => "Quandl's server responded with an error.", [INFO] [stderr] 165 | Error::DownloadFailed(_) => "Download failed.", [INFO] [stderr] 166 | Error::ParsingFailed(_) => "Parsing data failed.", [INFO] [stderr] 167 | Error::IoError(_) => "Underlying system I/O error.", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | / match self { [INFO] [stderr] 175 | | &Error::ApiCallFailed(ref e) => { [INFO] [stderr] 176 | | if e.errors.is_some() && !e.errors.as_ref().unwrap().is_empty() { [INFO] [stderr] 177 | | let (object, what) = e.errors.as_ref().unwrap().iter().next().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 197 | | }, [INFO] [stderr] 198 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 174 | match *self { [INFO] [stderr] 175 | Error::ApiCallFailed(ref e) => { [INFO] [stderr] 176 | if e.errors.is_some() && !e.errors.as_ref().unwrap().is_empty() { [INFO] [stderr] 177 | let (object, what) = e.errors.as_ref().unwrap().iter().next().unwrap(); [INFO] [stderr] 178 | [INFO] [stderr] 179 | write!(f, "{}", { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.05s [INFO] running `"docker" "inspect" "323d3b4a119487c07323d7fc591540cc3e5cad347c816415a9fb5f827f6b0158"` [INFO] running `"docker" "rm" "-f" "323d3b4a119487c07323d7fc591540cc3e5cad347c816415a9fb5f827f6b0158"` [INFO] [stdout] 323d3b4a119487c07323d7fc591540cc3e5cad347c816415a9fb5f827f6b0158