[INFO] crate qrcodegen 1.4.0 is already in cache [INFO] extracting crate qrcodegen 1.4.0 into work/ex/clippy-test-run/sources/stable/reg/qrcodegen/1.4.0 [INFO] extracting crate qrcodegen 1.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qrcodegen/1.4.0 [INFO] validating manifest of qrcodegen-1.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qrcodegen-1.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qrcodegen-1.4.0 [INFO] finished frobbing qrcodegen-1.4.0 [INFO] frobbed toml for qrcodegen-1.4.0 written to work/ex/clippy-test-run/sources/stable/reg/qrcodegen/1.4.0/Cargo.toml [INFO] started frobbing qrcodegen-1.4.0 [INFO] finished frobbing qrcodegen-1.4.0 [INFO] frobbed toml for qrcodegen-1.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qrcodegen/1.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qrcodegen-1.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/qrcodegen/1.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6be6de51331970808bcfd7decb6e647ee179f174127790d0cd8234f991a15d3e [INFO] running `"docker" "start" "-a" "6be6de51331970808bcfd7decb6e647ee179f174127790d0cd8234f991a15d3e"` [INFO] [stderr] Checking qrcodegen v1.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1126:4 [INFO] [stderr] | [INFO] [stderr] 1126 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1127:4 [INFO] [stderr] | [INFO] [stderr] 1127 | numchars: numchars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `numchars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1128:4 [INFO] [stderr] | [INFO] [stderr] 1128 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1126:4 [INFO] [stderr] | [INFO] [stderr] 1126 | mode: mode, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `mode` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1127:4 [INFO] [stderr] | [INFO] [stderr] 1127 | numchars: numchars, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `numchars` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1128:4 [INFO] [stderr] | [INFO] [stderr] 1128 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:424:66 [INFO] [stderr] | [INFO] [stderr] 424 | let data: u32 = self.errorcorrectionlevel.format_bits() << 3 | (mask.value() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mask.value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:462:22 [INFO] [stderr] | [INFO] [stderr] 462 | let mut rem: u32 = self.version.value() as u32; // version is uint6, in the range [7, 40] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.version.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:466:19 [INFO] [stderr] | [INFO] [stderr] 466 | let bits: u32 = (self.version.value() as u32) << 12 | rem; // uint18 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.version.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:548:12 [INFO] [stderr] | [INFO] [stderr] 548 | for i in 0 .. shortblocklen + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=shortblocklen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `blocks` [INFO] [stderr] --> src/lib.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | for j in 0 .. numblocks { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 549 | for (j, ) in blocks.iter().enumerate().take(numblocks) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:578:40 [INFO] [stderr] | [INFO] [stderr] 578 | *self.module_mut(x, y) = get_bit(data[i >> 3] as u32, 7 - ((i & 7) as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[i >> 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:744:24 [INFO] [stderr] | [INFO] [stderr] 744 | let numalign: i32 = (ver as i32) / 7 + 2; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(ver)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:746:7 [INFO] [stderr] | [INFO] [stderr] 746 | {((ver as i32)*4 + numalign*2 + 1) / (numalign*2 - 2) * 2}; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(ver)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: constant `QrCode_MIN_VERSION` should have an upper case name such as `QR_CODE_MIN_VERSION` [INFO] [stderr] --> src/lib.rs:794:1 [INFO] [stderr] | [INFO] [stderr] 794 | pub const QrCode_MIN_VERSION: Version = Version( 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `QrCode_MAX_VERSION` should have an upper case name such as `QR_CODE_MAX_VERSION` [INFO] [stderr] --> src/lib.rs:797:1 [INFO] [stderr] | [INFO] [stderr] 797 | pub const QrCode_MAX_VERSION: Version = Version(40); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:846:13 [INFO] [stderr] | [INFO] [stderr] 846 | fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:858:17 [INFO] [stderr] | [INFO] [stderr] 858 | fn format_bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1023:19 [INFO] [stderr] | [INFO] [stderr] 1023 | bb.append_bits(*b as u32, 8); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1216:15 [INFO] [stderr] | [INFO] [stderr] 1216 | fn mode_bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1230:25 [INFO] [stderr] | [INFO] [stderr] 1230 | fn num_char_count_bits(&self, ver: Version) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1259:23 [INFO] [stderr] | [INFO] [stderr] 1259 | self.0.extend((0 .. len as i32).rev().map(|i| get_bit(val, i))); // Append bit by bit [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1309:15 [INFO] [stderr] | [INFO] [stderr] 1309 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1329:15 [INFO] [stderr] | [INFO] [stderr] 1329 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:424:66 [INFO] [stderr] | [INFO] [stderr] 424 | let data: u32 = self.errorcorrectionlevel.format_bits() << 3 | (mask.value() as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mask.value())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:462:22 [INFO] [stderr] | [INFO] [stderr] 462 | let mut rem: u32 = self.version.value() as u32; // version is uint6, in the range [7, 40] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.version.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:466:19 [INFO] [stderr] | [INFO] [stderr] 466 | let bits: u32 = (self.version.value() as u32) << 12 | rem; // uint18 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.version.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:548:12 [INFO] [stderr] | [INFO] [stderr] 548 | for i in 0 .. shortblocklen + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `0..=shortblocklen` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `blocks` [INFO] [stderr] --> src/lib.rs:549:13 [INFO] [stderr] | [INFO] [stderr] 549 | for j in 0 .. numblocks { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 549 | for (j, ) in blocks.iter().enumerate().take(numblocks) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:578:40 [INFO] [stderr] | [INFO] [stderr] 578 | *self.module_mut(x, y) = get_bit(data[i >> 3] as u32, 7 - ((i & 7) as i32)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(data[i >> 3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:744:24 [INFO] [stderr] | [INFO] [stderr] 744 | let numalign: i32 = (ver as i32) / 7 + 2; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(ver)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:746:7 [INFO] [stderr] | [INFO] [stderr] 746 | {((ver as i32)*4 + numalign*2 + 1) / (numalign*2 - 2) * 2}; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(ver)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: constant `QrCode_MIN_VERSION` should have an upper case name such as `QR_CODE_MIN_VERSION` [INFO] [stderr] --> src/lib.rs:794:1 [INFO] [stderr] | [INFO] [stderr] 794 | pub const QrCode_MIN_VERSION: Version = Version( 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_upper_case_globals)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant `QrCode_MAX_VERSION` should have an upper case name such as `QR_CODE_MAX_VERSION` [INFO] [stderr] --> src/lib.rs:797:1 [INFO] [stderr] | [INFO] [stderr] 797 | pub const QrCode_MAX_VERSION: Version = Version(40); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:846:13 [INFO] [stderr] | [INFO] [stderr] 846 | fn ordinal(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:858:17 [INFO] [stderr] | [INFO] [stderr] 858 | fn format_bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1023:19 [INFO] [stderr] | [INFO] [stderr] 1023 | bb.append_bits(*b as u32, 8); [INFO] [stderr] | ^^^^^^^^^ help: try: `u32::from(*b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1216:15 [INFO] [stderr] | [INFO] [stderr] 1216 | fn mode_bits(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1230:25 [INFO] [stderr] | [INFO] [stderr] 1230 | fn num_char_count_bits(&self, ver: Version) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1259:23 [INFO] [stderr] | [INFO] [stderr] 1259 | self.0.extend((0 .. len as i32).rev().map(|i| get_bit(val, i))); // Append bit by bit [INFO] [stderr] | ^^^^^^^^^^ help: try: `i32::from(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1309:15 [INFO] [stderr] | [INFO] [stderr] 1309 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1329:15 [INFO] [stderr] | [INFO] [stderr] 1329 | pub fn value(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> examples/qrcodegen-worker.rs:69:3 [INFO] [stderr] | [INFO] [stderr] 69 | let segs: Vec; [INFO] [stderr] | _________^ [INFO] [stderr] 70 | | if isascii { [INFO] [stderr] 71 | | let chrs: Vec = std::str::from_utf8(&data).unwrap().chars().collect(); [INFO] [stderr] 72 | | segs = QrSegment::make_segments(&chrs); [INFO] [stderr] 73 | | } else { [INFO] [stderr] 74 | | segs = vec![QrSegment::make_bytes(&data)]; [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let segs = if isascii { ..; QrSegment::make_segments(&chrs) } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> examples/qrcodegen-worker.rs:50:15 [INFO] [stderr] | [INFO] [stderr] 50 | assert_eq!((b as u8) as i16, b, "Byte value out of range"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i16::from((b as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> examples/qrcodegen-worker.rs:62:11 [INFO] [stderr] | [INFO] [stderr] 62 | assert!((qrcodegen::QrCode_MIN_VERSION.value() as i16) <= minversion [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(qrcodegen::QrCode_MIN_VERSION.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> examples/qrcodegen-worker.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | && maxversion <= (qrcodegen::QrCode_MAX_VERSION.value() as i16)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i16::from(qrcodegen::QrCode_MAX_VERSION.value())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.77s [INFO] running `"docker" "inspect" "6be6de51331970808bcfd7decb6e647ee179f174127790d0cd8234f991a15d3e"` [INFO] running `"docker" "rm" "-f" "6be6de51331970808bcfd7decb6e647ee179f174127790d0cd8234f991a15d3e"` [INFO] [stdout] 6be6de51331970808bcfd7decb6e647ee179f174127790d0cd8234f991a15d3e