[INFO] crate qmetaobject_impl 0.0.4 is already in cache [INFO] extracting crate qmetaobject_impl 0.0.4 into work/ex/clippy-test-run/sources/stable/reg/qmetaobject_impl/0.0.4 [INFO] extracting crate qmetaobject_impl 0.0.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qmetaobject_impl/0.0.4 [INFO] validating manifest of qmetaobject_impl-0.0.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qmetaobject_impl-0.0.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qmetaobject_impl-0.0.4 [INFO] finished frobbing qmetaobject_impl-0.0.4 [INFO] frobbed toml for qmetaobject_impl-0.0.4 written to work/ex/clippy-test-run/sources/stable/reg/qmetaobject_impl/0.0.4/Cargo.toml [INFO] started frobbing qmetaobject_impl-0.0.4 [INFO] finished frobbing qmetaobject_impl-0.0.4 [INFO] frobbed toml for qmetaobject_impl-0.0.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qmetaobject_impl/0.0.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qmetaobject_impl-0.0.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/qmetaobject_impl/0.0.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 928aa4ff6dc2d68d0360791a4e35af66181c623f5927e11b7ae0da6e3e4255ae [INFO] running `"docker" "start" "-a" "928aa4ff6dc2d68d0360791a4e35af66181c623f5927e11b7ae0da6e3e4255ae"` [INFO] [stderr] Checking syn v0.15.26 [INFO] [stderr] Checking qmetaobject_impl v0.0.4 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: lint name `unreadable_literal` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:23:45 [INFO] [stderr] | [INFO] [stderr] 23 | #![cfg_attr(feature = "cargo-clippy", allow(unreadable_literal))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::unreadable_literal` [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/qobject_impl.rs:277:1 [INFO] [stderr] | [INFO] [stderr] 277 | / pub fn generate(input: TokenStream, is_qobject: bool) -> TokenStream { [INFO] [stderr] 278 | | let ast = parse_macro_input!(input as syn::DeriveInput); [INFO] [stderr] 279 | | [INFO] [stderr] 280 | | let name = &ast.ident; [INFO] [stderr] ... | [INFO] [stderr] 882 | | body.into() [INFO] [stderr] 883 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/qobject_impl.rs:456:21 [INFO] [stderr] | [INFO] [stderr] 456 | / match x.name().to_string().as_ref() { [INFO] [stderr] 457 | | "qt_base_class" => { [INFO] [stderr] 458 | | if let syn::Meta::NameValue(mnv) = x { [INFO] [stderr] 459 | | if let syn::Lit::Str(s) = mnv.lit { [INFO] [stderr] ... | [INFO] [stderr] 470 | | _ => {} [INFO] [stderr] 471 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 456 | if let "qt_base_class" = x.name().to_string().as_ref() { [INFO] [stderr] 457 | if let syn::Meta::NameValue(mnv) = x { [INFO] [stderr] 458 | if let syn::Lit::Str(s) = mnv.lit { [INFO] [stderr] 459 | base = unwrap_parse_error!(syn::parse_str(&s.value())); [INFO] [stderr] 460 | base_prop = f.ident.clone().expect("base prop needs a name"); [INFO] [stderr] 461 | has_base_property = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 43 [INFO] [stderr] --> src/qobject_impl.rs:277:1 [INFO] [stderr] | [INFO] [stderr] 277 | / pub fn generate(input: TokenStream, is_qobject: bool) -> TokenStream { [INFO] [stderr] 278 | | let ast = parse_macro_input!(input as syn::DeriveInput); [INFO] [stderr] 279 | | [INFO] [stderr] 280 | | let name = &ast.ident; [INFO] [stderr] ... | [INFO] [stderr] 882 | | body.into() [INFO] [stderr] 883 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/qobject_impl.rs:456:21 [INFO] [stderr] | [INFO] [stderr] 456 | / match x.name().to_string().as_ref() { [INFO] [stderr] 457 | | "qt_base_class" => { [INFO] [stderr] 458 | | if let syn::Meta::NameValue(mnv) = x { [INFO] [stderr] 459 | | if let syn::Lit::Str(s) = mnv.lit { [INFO] [stderr] ... | [INFO] [stderr] 470 | | _ => {} [INFO] [stderr] 471 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 456 | if let "qt_base_class" = x.name().to_string().as_ref() { [INFO] [stderr] 457 | if let syn::Meta::NameValue(mnv) = x { [INFO] [stderr] 458 | if let syn::Lit::Str(s) = mnv.lit { [INFO] [stderr] 459 | base = unwrap_parse_error!(syn::parse_str(&s.value())); [INFO] [stderr] 460 | base_prop = f.ident.clone().expect("base prop needs a name"); [INFO] [stderr] 461 | has_base_property = true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.17s [INFO] running `"docker" "inspect" "928aa4ff6dc2d68d0360791a4e35af66181c623f5927e11b7ae0da6e3e4255ae"` [INFO] running `"docker" "rm" "-f" "928aa4ff6dc2d68d0360791a4e35af66181c623f5927e11b7ae0da6e3e4255ae"` [INFO] [stdout] 928aa4ff6dc2d68d0360791a4e35af66181c623f5927e11b7ae0da6e3e4255ae