[INFO] crate qapi-parser 0.2.1 is already in cache [INFO] extracting crate qapi-parser 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/qapi-parser/0.2.1 [INFO] extracting crate qapi-parser 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qapi-parser/0.2.1 [INFO] validating manifest of qapi-parser-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qapi-parser-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qapi-parser-0.2.1 [INFO] finished frobbing qapi-parser-0.2.1 [INFO] frobbed toml for qapi-parser-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/qapi-parser/0.2.1/Cargo.toml [INFO] started frobbing qapi-parser-0.2.1 [INFO] finished frobbing qapi-parser-0.2.1 [INFO] frobbed toml for qapi-parser-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qapi-parser/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qapi-parser-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/qapi-parser/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 35268b0c911c6207b3560e7a6c151c19560ef2c3404b43edb98206e643cefb46 [INFO] running `"docker" "start" "-a" "35268b0c911c6207b3560e7a6c151c19560ef2c3404b43edb98206e643cefb46"` [INFO] [stderr] Checking qapi-parser v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | repo: repo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:66:17 [INFO] [stderr] | [INFO] [stderr] 66 | ty: ty, [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:336:17 [INFO] [stderr] | [INFO] [stderr] 336 | repo: repo, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `repo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:58:51 [INFO] [stderr] | [INFO] [stderr] 58 | let (name, opt) = if name.starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:58:51 [INFO] [stderr] | [INFO] [stderr] 58 | let (name, opt) = if name.starts_with("*") { [INFO] [stderr] | ^^^ help: try using a char instead: `'*'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | / match self { [INFO] [stderr] 217 | | &DataOrType::Data(ref data) => data.fields.is_empty(), [INFO] [stderr] 218 | | &DataOrType::Type(..) => false, [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | match *self { [INFO] [stderr] 217 | DataOrType::Data(ref data) => data.fields.is_empty(), [INFO] [stderr] 218 | DataOrType::Type(..) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | / match self { [INFO] [stderr] 217 | | &DataOrType::Data(ref data) => data.fields.is_empty(), [INFO] [stderr] 218 | | &DataOrType::Type(..) => false, [INFO] [stderr] 219 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 216 | match *self { [INFO] [stderr] 217 | DataOrType::Data(ref data) => data.fields.is_empty(), [INFO] [stderr] 218 | DataOrType::Type(..) => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:270:47 [INFO] [stderr] | [INFO] [stderr] 270 | .filter(|l| !l.trim().starts_with("#") && !l.trim().is_empty()) [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:270:47 [INFO] [stderr] | [INFO] [stderr] 270 | .filter(|l| !l.trim().starts_with("#") && !l.trim().is_empty()) [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.84s [INFO] running `"docker" "inspect" "35268b0c911c6207b3560e7a6c151c19560ef2c3404b43edb98206e643cefb46"` [INFO] running `"docker" "rm" "-f" "35268b0c911c6207b3560e7a6c151c19560ef2c3404b43edb98206e643cefb46"` [INFO] [stdout] 35268b0c911c6207b3560e7a6c151c19560ef2c3404b43edb98206e643cefb46