[INFO] crate qair 0.2.0 is already in cache [INFO] extracting crate qair 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/qair/0.2.0 [INFO] extracting crate qair 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qair/0.2.0 [INFO] validating manifest of qair-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of qair-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing qair-0.2.0 [INFO] finished frobbing qair-0.2.0 [INFO] frobbed toml for qair-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/qair/0.2.0/Cargo.toml [INFO] started frobbing qair-0.2.0 [INFO] finished frobbing qair-0.2.0 [INFO] frobbed toml for qair-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/qair/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting qair-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/qair/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f54b7f0a59aa0d6b49bef8b16bb4875b923402367e83184c12349c42c10b2119 [INFO] running `"docker" "start" "-a" "f54b7f0a59aa0d6b49bef8b16bb4875b923402367e83184c12349c42c10b2119"` [INFO] [stderr] Checking checked_int_cast v1.0.0 [INFO] [stderr] Checking get_if_addrs v0.5.3 [INFO] [stderr] Checking crossterm v0.4.3 [INFO] [stderr] Checking tiny_http v0.5.9 [INFO] [stderr] Checking qrcode v0.9.0 [INFO] [stderr] Checking qair v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/console_barcode_renderer.rs:59:42 [INFO] [stderr] | [INFO] [stderr] 59 | fn print_barcode_vec(&mut self, vec: &Vec, vec_width: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[qrcode::types::Color]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/console_barcode_renderer.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | fn add_quiet_zone (vec: &Vec, vec_width: usize, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/console_barcode_renderer.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | let _ = ConsoleBarcodeRenderer::new().print_barcode_vec(&vec, 2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/console_barcode_renderer.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | / match actual_result { [INFO] [stderr] 242 | | Ok(_) => panic!(), [INFO] [stderr] 243 | | Err(_) => () [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Ok(_) = actual_result { panic!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/send.rs:46:73 [INFO] [stderr] | [INFO] [stderr] 46 | let basename_non_converted = try!(Path::new(&args.file).file_name().ok_or( [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 47 | | format!("Error: cannot strip directory name of `{:?}'", args.file))); [INFO] [stderr] | |___________________________________________________________________________^ help: try this: `ok_or_else(|| format!("Error: cannot strip directory name of `{:?}'", args.file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/send.rs:48:57 [INFO] [stderr] | [INFO] [stderr] 48 | let basename = try!(basename_non_converted.to_str().ok_or( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 49 | | "Error: cannot convert filename to UTF-8".to_string())); [INFO] [stderr] | |______________________________________________________________^ help: try this: `ok_or_else(|| "Error: cannot convert filename to UTF-8".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/send.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match request.method() { [INFO] [stderr] 63 | | &tiny_http::Method::Get => { [INFO] [stderr] 64 | | // Do not reuse file handle: support file overwrite [INFO] [stderr] 65 | | match File::open(filename) { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *request.method() { [INFO] [stderr] 63 | tiny_http::Method::Get => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/receive.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/console_barcode_renderer.rs:59:42 [INFO] [stderr] | [INFO] [stderr] 59 | fn print_barcode_vec(&mut self, vec: &Vec, vec_width: usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[qrcode::types::Color]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/console_barcode_renderer.rs:97:37 [INFO] [stderr] | [INFO] [stderr] 97 | fn add_quiet_zone (vec: &Vec, vec_width: usize, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/receive.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(_) = request.body_length() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 87 | | { [INFO] [stderr] 88 | | let mut reader = request.as_reader(); [INFO] [stderr] 89 | | let target = try!(search_target_filename().ok_or( [INFO] [stderr] ... | [INFO] [stderr] 98 | | let _ = request.respond(response); [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____- help: try this: `if request.body_length().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/receive.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | / match request.method() { [INFO] [stderr] 115 | | &tiny_http::Method::Get => do_get_request(request), [INFO] [stderr] 116 | | &tiny_http::Method::Put => do_put_request(request)?, [INFO] [stderr] 117 | | _ => () [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *request.method() { [INFO] [stderr] 115 | tiny_http::Method::Get => do_get_request(request), [INFO] [stderr] 116 | tiny_http::Method::Put => do_put_request(request)?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/send.rs:46:73 [INFO] [stderr] | [INFO] [stderr] 46 | let basename_non_converted = try!(Path::new(&args.file).file_name().ok_or( [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 47 | | format!("Error: cannot strip directory name of `{:?}'", args.file))); [INFO] [stderr] | |___________________________________________________________________________^ help: try this: `ok_or_else(|| format!("Error: cannot strip directory name of `{:?}'", args.file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/send.rs:48:57 [INFO] [stderr] | [INFO] [stderr] 48 | let basename = try!(basename_non_converted.to_str().ok_or( [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 49 | | "Error: cannot convert filename to UTF-8".to_string())); [INFO] [stderr] | |______________________________________________________________^ help: try this: `ok_or_else(|| "Error: cannot convert filename to UTF-8".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/send.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match request.method() { [INFO] [stderr] 63 | | &tiny_http::Method::Get => { [INFO] [stderr] 64 | | // Do not reuse file handle: support file overwrite [INFO] [stderr] 65 | | match File::open(filename) { [INFO] [stderr] ... | [INFO] [stderr] 93 | | } [INFO] [stderr] 94 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 62 | match *request.method() { [INFO] [stderr] 63 | tiny_http::Method::Get => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/receive.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | counter = counter + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/receive.rs:86:12 [INFO] [stderr] | [INFO] [stderr] 86 | if let Some(_) = request.body_length() { [INFO] [stderr] | _____- ^^^^^^^ [INFO] [stderr] 87 | | { [INFO] [stderr] 88 | | let mut reader = request.as_reader(); [INFO] [stderr] 89 | | let target = try!(search_target_filename().ok_or( [INFO] [stderr] ... | [INFO] [stderr] 98 | | let _ = request.respond(response); [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____- help: try this: `if request.body_length().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/receive.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | / match request.method() { [INFO] [stderr] 115 | | &tiny_http::Method::Get => do_get_request(request), [INFO] [stderr] 116 | | &tiny_http::Method::Put => do_put_request(request)?, [INFO] [stderr] 117 | | _ => () [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 114 | match *request.method() { [INFO] [stderr] 115 | tiny_http::Method::Get => do_get_request(request), [INFO] [stderr] 116 | tiny_http::Method::Put => do_put_request(request)?, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.51s [INFO] running `"docker" "inspect" "f54b7f0a59aa0d6b49bef8b16bb4875b923402367e83184c12349c42c10b2119"` [INFO] running `"docker" "rm" "-f" "f54b7f0a59aa0d6b49bef8b16bb4875b923402367e83184c12349c42c10b2119"` [INFO] [stdout] f54b7f0a59aa0d6b49bef8b16bb4875b923402367e83184c12349c42c10b2119