[INFO] crate pyro 0.2.4 is already in cache [INFO] extracting crate pyro 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/pyro/0.2.4 [INFO] extracting crate pyro 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pyro/0.2.4 [INFO] validating manifest of pyro-0.2.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pyro-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pyro-0.2.4 [INFO] finished frobbing pyro-0.2.4 [INFO] frobbed toml for pyro-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/pyro/0.2.4/Cargo.toml [INFO] started frobbing pyro-0.2.4 [INFO] finished frobbing pyro-0.2.4 [INFO] frobbed toml for pyro-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pyro/0.2.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pyro-0.2.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pyro/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ba3cfd387763012d6ac587bd5e46017dbb33cd446a49a5a74ae4d0e71afb1b6 [INFO] running `"docker" "start" "-a" "0ba3cfd387763012d6ac587bd5e46017dbb33cd446a49a5a74ae4d0e71afb1b6"` [INFO] [stderr] Checking typedef v0.3.2 [INFO] [stderr] Checking cgmath v0.16.1 [INFO] [stderr] Checking pyro v0.2.4 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `UnsafeStorage` [INFO] [stderr] --> src/lib.rs:798:5 [INFO] [stderr] | [INFO] [stderr] 798 | / pub fn new() -> Self { [INFO] [stderr] 799 | | UnsafeStorage(UnsafeCell::new(Vec::::new())) [INFO] [stderr] 800 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 796 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:801:39 [INFO] [stderr] | [INFO] [stderr] 801 | pub unsafe fn inner_mut(&self) -> &mut Vec { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:801:29 [INFO] [stderr] | [INFO] [stderr] 801 | pub unsafe fn inner_mut(&self) -> &mut Vec { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: trait `Storage` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/lib.rs:993:1 [INFO] [stderr] | [INFO] [stderr] 993 | / pub trait Storage: Sized { [INFO] [stderr] 994 | | fn len(&self) -> usize; [INFO] [stderr] 995 | | fn len_mut(&mut self) -> &mut usize; [INFO] [stderr] 996 | | fn id(&self) -> StorageId; [INFO] [stderr] ... | [INFO] [stderr] 1014 | | fn remove(&mut self, id: ComponentId) -> usize; [INFO] [stderr] 1015 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:1003:53 [INFO] [stderr] | [INFO] [stderr] 1003 | unsafe fn component_mut(&self) -> &mut [C]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:1003:43 [INFO] [stderr] | [INFO] [stderr] 1003 | unsafe fn component_mut(&self) -> &mut [C]; [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `pyro`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "0ba3cfd387763012d6ac587bd5e46017dbb33cd446a49a5a74ae4d0e71afb1b6"` [INFO] running `"docker" "rm" "-f" "0ba3cfd387763012d6ac587bd5e46017dbb33cd446a49a5a74ae4d0e71afb1b6"` [INFO] [stdout] 0ba3cfd387763012d6ac587bd5e46017dbb33cd446a49a5a74ae4d0e71afb1b6