[INFO] crate pyo3cls 0.5.2 is already in cache
[INFO] extracting crate pyo3cls 0.5.2 into work/ex/clippy-test-run/sources/stable/reg/pyo3cls/0.5.2
[INFO] extracting crate pyo3cls 0.5.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pyo3cls/0.5.2
[INFO] validating manifest of pyo3cls-0.5.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of pyo3cls-0.5.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing pyo3cls-0.5.2
[INFO] finished frobbing pyo3cls-0.5.2
[INFO] frobbed toml for pyo3cls-0.5.2 written to work/ex/clippy-test-run/sources/stable/reg/pyo3cls/0.5.2/Cargo.toml
[INFO] started frobbing pyo3cls-0.5.2
[INFO] finished frobbing pyo3cls-0.5.2
[INFO] frobbed toml for pyo3cls-0.5.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pyo3cls/0.5.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting pyo3cls-0.5.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pyo3cls/0.5.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 4cbc2c628c9b33181eebbb32722b18e08c4db7e3530719207df3cbf150572d71
[INFO] running `"docker" "start" "-a" "4cbc2c628c9b33181eebbb32722b18e08c4db7e3530719207df3cbf150572d71"`
[INFO] [stderr]     Checking pyo3-derive-backend v0.5.2
[INFO] [stderr]     Checking pyo3cls v0.5.2 (/opt/crater/workdir)
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 | /     let modname: syn::Ident;
[INFO] [stderr] 29 | |     if attr.is_empty() {
[INFO] [stderr] 30 | |         modname = ast.ident.clone();
[INFO] [stderr] 31 | |     } else {
[INFO] [stderr] 32 | |         modname = syn::parse(attr).expect("could not parse module name");
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let modname = if attr.is_empty() { ast.ident.clone() } else { syn::parse(attr).expect("could not parse module name") };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 | /     let modname: syn::Ident;
[INFO] [stderr] 58 | |     if attr.is_empty() {
[INFO] [stderr] 59 | |         modname = ast.ident.clone();
[INFO] [stderr] 60 | |     } else {
[INFO] [stderr] 61 | |         modname = syn::parse(attr).expect("could not parse module name");
[INFO] [stderr] 62 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let modname = if attr.is_empty() { ast.ident.clone() } else { syn::parse(attr).expect("could not parse module name") };`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `module::add_fn_to_module` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:155:45
[INFO] [stderr]     |
[INFO] [stderr] 155 |     let expanded = module::add_fn_to_module(&mut ast, &python_name, Vec::new());
[INFO] [stderr]     |                                             ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:28:5
[INFO] [stderr]    |
[INFO] [stderr] 28 | /     let modname: syn::Ident;
[INFO] [stderr] 29 | |     if attr.is_empty() {
[INFO] [stderr] 30 | |         modname = ast.ident.clone();
[INFO] [stderr] 31 | |     } else {
[INFO] [stderr] 32 | |         modname = syn::parse(attr).expect("could not parse module name");
[INFO] [stderr] 33 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let modname = if attr.is_empty() { ast.ident.clone() } else { syn::parse(attr).expect("could not parse module name") };`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]   --> src/lib.rs:57:5
[INFO] [stderr]    |
[INFO] [stderr] 57 | /     let modname: syn::Ident;
[INFO] [stderr] 58 | |     if attr.is_empty() {
[INFO] [stderr] 59 | |         modname = ast.ident.clone();
[INFO] [stderr] 60 | |     } else {
[INFO] [stderr] 61 | |         modname = syn::parse(attr).expect("could not parse module name");
[INFO] [stderr] 62 | |     }
[INFO] [stderr]    | |_____^ help: it is more idiomatic to write: `let modname = if attr.is_empty() { ast.ident.clone() } else { syn::parse(attr).expect("could not parse module name") };`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `module::add_fn_to_module` doesn't need a mutable reference
[INFO] [stderr]    --> src/lib.rs:155:45
[INFO] [stderr]     |
[INFO] [stderr] 155 |     let expanded = module::add_fn_to_module(&mut ast, &python_name, Vec::new());
[INFO] [stderr]     |                                             ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.05s
[INFO] running `"docker" "inspect" "4cbc2c628c9b33181eebbb32722b18e08c4db7e3530719207df3cbf150572d71"`
[INFO] running `"docker" "rm" "-f" "4cbc2c628c9b33181eebbb32722b18e08c4db7e3530719207df3cbf150572d71"`
[INFO] [stdout] 4cbc2c628c9b33181eebbb32722b18e08c4db7e3530719207df3cbf150572d71