[INFO] crate pylauncher 0.1.1 is already in cache [INFO] extracting crate pylauncher 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/pylauncher/0.1.1 [INFO] extracting crate pylauncher 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pylauncher/0.1.1 [INFO] validating manifest of pylauncher-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of pylauncher-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing pylauncher-0.1.1 [INFO] finished frobbing pylauncher-0.1.1 [INFO] frobbed toml for pylauncher-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/pylauncher/0.1.1/Cargo.toml [INFO] started frobbing pylauncher-0.1.1 [INFO] finished frobbing pylauncher-0.1.1 [INFO] frobbed toml for pylauncher-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/pylauncher/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting pylauncher-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/pylauncher/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a99609308d4c91a744152160e8153686e668c94d87c92c73dff791d948f68398 [INFO] running `"docker" "start" "-a" "a99609308d4c91a744152160e8153686e668c94d87c92c73dff791d948f68398"` [INFO] [stderr] Compiling dbg v1.0.4 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking exec v0.3.1 [INFO] [stderr] Checking pylauncher v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:65:63 [INFO] [stderr] | [INFO] [stderr] 65 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:74:59 [INFO] [stderr] | [INFO] [stderr] 74 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:103:45 [INFO] [stderr] | [INFO] [stderr] 103 | Self { dir: fs::read_dir(dir).ok(), order: order } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:134:45 [INFO] [stderr] | [INFO] [stderr] 134 | Self { dir: fs::read_dir(dir).ok(), order: order } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:65:45 [INFO] [stderr] | [INFO] [stderr] 65 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:65:63 [INFO] [stderr] | [INFO] [stderr] 65 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `location` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:74:59 [INFO] [stderr] | [INFO] [stderr] 74 | Some(Self { location: location, version: version, order: order }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:103:45 [INFO] [stderr] | [INFO] [stderr] 103 | Self { dir: fs::read_dir(dir).ok(), order: order } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/pythons.rs:134:45 [INFO] [stderr] | [INFO] [stderr] 134 | Self { dir: fs::read_dir(dir).ok(), order: order } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/pythons.rs:79:56 [INFO] [stderr] | [INFO] [stderr] 79 | specs::Spec::Major(x) => self.version.0 == (*x as i16), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i16::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/pythons.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | self.version.0 == (*x as i16) && self.version.1 == (*y as i16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i16::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/pythons.rs:81:68 [INFO] [stderr] | [INFO] [stderr] 81 | self.version.0 == (*x as i16) && self.version.1 == (*y as i16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i16::from(*y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/pythons.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | / match get_virtual() { [INFO] [stderr] 221 | | Some(v) => { return Some(v); }, [INFO] [stderr] 222 | | None => {}, [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(v) = get_virtual() { return Some(v); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `specs::parse_spec` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | match specs::parse_spec(&mut arg.as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/pythons.rs:79:56 [INFO] [stderr] | [INFO] [stderr] 79 | specs::Spec::Major(x) => self.version.0 == (*x as i16), [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i16::from(*x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/pythons.rs:81:35 [INFO] [stderr] | [INFO] [stderr] 81 | self.version.0 == (*x as i16) && self.version.1 == (*y as i16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i16::from(*x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i16 may become silently lossy if types change [INFO] [stderr] --> src/pythons.rs:81:68 [INFO] [stderr] | [INFO] [stderr] 81 | self.version.0 == (*x as i16) && self.version.1 == (*y as i16) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i16::from(*y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/pythons.rs:220:5 [INFO] [stderr] | [INFO] [stderr] 220 | / match get_virtual() { [INFO] [stderr] 221 | | Some(v) => { return Some(v); }, [INFO] [stderr] 222 | | None => {}, [INFO] [stderr] 223 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(v) = get_virtual() { return Some(v); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: The function/method `specs::parse_spec` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:37:29 [INFO] [stderr] | [INFO] [stderr] 37 | match specs::parse_spec(&mut arg.as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.71s [INFO] running `"docker" "inspect" "a99609308d4c91a744152160e8153686e668c94d87c92c73dff791d948f68398"` [INFO] running `"docker" "rm" "-f" "a99609308d4c91a744152160e8153686e668c94d87c92c73dff791d948f68398"` [INFO] [stdout] a99609308d4c91a744152160e8153686e668c94d87c92c73dff791d948f68398