[INFO] crate py_literal 0.2.0 is already in cache [INFO] extracting crate py_literal 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/py_literal/0.2.0 [INFO] extracting crate py_literal 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/py_literal/0.2.0 [INFO] validating manifest of py_literal-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of py_literal-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing py_literal-0.2.0 [INFO] finished frobbing py_literal-0.2.0 [INFO] frobbed toml for py_literal-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/py_literal/0.2.0/Cargo.toml [INFO] started frobbing py_literal-0.2.0 [INFO] finished frobbing py_literal-0.2.0 [INFO] frobbed toml for py_literal-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/py_literal/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting py_literal-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/py_literal/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ab774a754f9097d12757b4bbff1679d8a2927e5c5d390ed6bd229a6aaa889d9d [INFO] running `"docker" "start" "-a" "ab774a754f9097d12757b4bbff1679d8a2927e5c5d390ed6bd229a6aaa889d9d"` [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking py_literal v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | n @ 0...0xffffffff => write!(w, r"\U{:0>8x}", n)?, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const _GRAMMAR: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:230:54 [INFO] [stderr] | [INFO] [stderr] 230 | numb::BigInt::from_str_radix(&digits, 2).expect(&format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 231 | | "failure parsing binary integer with digits {}", [INFO] [stderr] 232 | | digits [INFO] [stderr] 233 | | )) [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("failure parsing binary integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:237:54 [INFO] [stderr] | [INFO] [stderr] 237 | numb::BigInt::from_str_radix(&digits, 8).expect(&format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 238 | | "failure parsing octal integer with digits {}", [INFO] [stderr] 239 | | digits [INFO] [stderr] 240 | | )) [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("failure parsing octal integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:244:55 [INFO] [stderr] | [INFO] [stderr] 244 | numb::BigInt::from_str_radix(&digits, 16).expect(&format!( [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 245 | | "failure parsing hexadecimal integer with digits {}", [INFO] [stderr] 246 | | digits [INFO] [stderr] 247 | | )) [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("failure parsing hexadecimal integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:253:18 [INFO] [stderr] | [INFO] [stderr] 253 | .expect(&format!("failure parsing integer with digits {}", digits)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failure parsing integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:292:26 [INFO] [stderr] | [INFO] [stderr] 292 | seq.into_inner().map(|elem| parse_value(elem)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `parse_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/format.rs:60:37 [INFO] [stderr] | [INFO] [stderr] 60 | n @ 0...0xffffffff => write!(w, r"\U{:0>8x}", n)?, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const _GRAMMAR: &'static str = include_str!("grammar.pest"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:230:54 [INFO] [stderr] | [INFO] [stderr] 230 | numb::BigInt::from_str_radix(&digits, 2).expect(&format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 231 | | "failure parsing binary integer with digits {}", [INFO] [stderr] 232 | | digits [INFO] [stderr] 233 | | )) [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("failure parsing binary integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:237:54 [INFO] [stderr] | [INFO] [stderr] 237 | numb::BigInt::from_str_radix(&digits, 8).expect(&format!( [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 238 | | "failure parsing octal integer with digits {}", [INFO] [stderr] 239 | | digits [INFO] [stderr] 240 | | )) [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("failure parsing octal integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:244:55 [INFO] [stderr] | [INFO] [stderr] 244 | numb::BigInt::from_str_radix(&digits, 16).expect(&format!( [INFO] [stderr] | _______________________________________________________^ [INFO] [stderr] 245 | | "failure parsing hexadecimal integer with digits {}", [INFO] [stderr] 246 | | digits [INFO] [stderr] 247 | | )) [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|_| panic!("failure parsing hexadecimal integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/parse.rs:253:18 [INFO] [stderr] | [INFO] [stderr] 253 | .expect(&format!("failure parsing integer with digits {}", digits)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("failure parsing integer with digits {}", digits))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/parse.rs:292:26 [INFO] [stderr] | [INFO] [stderr] 292 | seq.into_inner().map(|elem| parse_value(elem)).collect() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `parse_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/parse.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | assert_eq!(float, 351.46e-27); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/parse.rs:447:9 [INFO] [stderr] | [INFO] [stderr] 447 | assert_eq!(float, 351.46e-27); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `py_literal`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ab774a754f9097d12757b4bbff1679d8a2927e5c5d390ed6bd229a6aaa889d9d"` [INFO] running `"docker" "rm" "-f" "ab774a754f9097d12757b4bbff1679d8a2927e5c5d390ed6bd229a6aaa889d9d"` [INFO] [stdout] ab774a754f9097d12757b4bbff1679d8a2927e5c5d390ed6bd229a6aaa889d9d