[INFO] crate px4-ulog 0.1.1 is already in cache [INFO] extracting crate px4-ulog 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/px4-ulog/0.1.1 [INFO] extracting crate px4-ulog 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/px4-ulog/0.1.1 [INFO] validating manifest of px4-ulog-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of px4-ulog-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing px4-ulog-0.1.1 [INFO] finished frobbing px4-ulog-0.1.1 [INFO] frobbed toml for px4-ulog-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/px4-ulog/0.1.1/Cargo.toml [INFO] started frobbing px4-ulog-0.1.1 [INFO] finished frobbing px4-ulog-0.1.1 [INFO] frobbed toml for px4-ulog-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/px4-ulog/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting px4-ulog-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/px4-ulog/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2aa91b413f88588814879515dab33ecb524f3abb5879bcfaee7e72d4484f818f [INFO] running `"docker" "start" "-a" "2aa91b413f88588814879515dab33ecb524f3abb5879bcfaee7e72d4484f818f"` [INFO] [stderr] Checking px4-ulog v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models/data.rs:225:60 [INFO] [stderr] | [INFO] [stderr] 225 | "timestamp" => assert_eq!(DataType::UInt64(375408345), data), [INFO] [stderr] | ^^^^^^^^^ help: consider: `375_408_345` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models/data.rs:227:53 [INFO] [stderr] | [INFO] [stderr] 227 | "lat" => assert_eq!(DataType::Int32(407423012), data), [INFO] [stderr] | ^^^^^^^^^ help: consider: `407_423_012` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models/data.rs:228:54 [INFO] [stderr] | [INFO] [stderr] 228 | "lon" => assert_eq!(DataType::Int32(-741792999), data), [INFO] [stderr] | ^^^^^^^^^ help: consider: `741_792_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models/data.rs:233:53 [INFO] [stderr] | [INFO] [stderr] 233 | "eph" => assert_eq!(DataType::Float(0.29999998), data), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.299_999_98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/models/data.rs:234:53 [INFO] [stderr] | [INFO] [stderr] 234 | "epv" => assert_eq!(DataType::Float(0.39999998), data), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.399_999_98` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/models/data.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | .filter(|f| f.len() > 0 && !f.contains("_padding") && f.contains(" ")) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!f.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models/data.rs:85:78 [INFO] [stderr] | [INFO] [stderr] 85 | .filter(|f| f.len() > 0 && !f.contains("_padding") && f.contains(" ")) [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models/data.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | .map(|f| f.split(" ").last().unwrap().to_string()) [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models/data.rs:127:37 [INFO] [stderr] | [INFO] [stderr] 127 | let space = format.find(" ").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/dataset.rs:75:11 [INFO] [stderr] | [INFO] [stderr] 75 | while dataset.messages.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dataset.messages.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/dataset.rs:117:32 [INFO] [stderr] | [INFO] [stderr] 117 | let mut handle = file.take(message.size() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(message.size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/dataset.rs:133:41 [INFO] [stderr] | [INFO] [stderr] 133 | let parts: Vec<&str> = format.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/dataset.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | let types: Vec = parts[1].split(";").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/message.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | self.position += msg_size as u64 + 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(msg_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn as_u64_le(arr: &[u8; 8]) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/unpack/mod.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | .map(|(i, v)| (v.clone() as u64) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(v.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unpack/mod.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | .map(|(i, v)| (v.clone() as u64) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn as_u32_le(arr: &[u8; 4]) -> u32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/unpack/mod.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|(i, v)| (v.clone() as u32) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unpack/mod.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|(i, v)| (v.clone() as u32) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn as_i32_le(arr: &[u8; 4]) -> i32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn as_u16_le(arr: &[u8; 2]) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/unpack/mod.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(i, v)| (v.clone() as u16) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unpack/mod.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(i, v)| (v.clone() as u16) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn as_f32_le(arr: &[u8; 4]) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/models/data.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | .filter(|f| f.len() > 0 && !f.contains("_padding") && f.contains(" ")) [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!f.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models/data.rs:85:78 [INFO] [stderr] | [INFO] [stderr] 85 | .filter(|f| f.len() > 0 && !f.contains("_padding") && f.contains(" ")) [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models/data.rs:86:30 [INFO] [stderr] | [INFO] [stderr] 86 | .map(|f| f.split(" ").last().unwrap().to_string()) [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/models/data.rs:127:37 [INFO] [stderr] | [INFO] [stderr] 127 | let space = format.find(" ").unwrap(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> src/models/data.rs:202:5 [INFO] [stderr] | [INFO] [stderr] 202 | / fn it_parses_the_data() { [INFO] [stderr] 203 | | let filename = format!( [INFO] [stderr] 204 | | "{}/tests/fixtures/6ba1abc7-b433-4029-b8f5-3b2bb12d3b6c.ulg", [INFO] [stderr] 205 | | env!("CARGO_MANIFEST_DIR") [INFO] [stderr] ... | [INFO] [stderr] 254 | | } [INFO] [stderr] 255 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser/dataset.rs:75:11 [INFO] [stderr] | [INFO] [stderr] 75 | while dataset.messages.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dataset.messages.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/dataset.rs:117:32 [INFO] [stderr] | [INFO] [stderr] 117 | let mut handle = file.take(message.size() as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(message.size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/dataset.rs:133:41 [INFO] [stderr] | [INFO] [stderr] 133 | let parts: Vec<&str> = format.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser/dataset.rs:140:45 [INFO] [stderr] | [INFO] [stderr] 140 | let types: Vec = parts[1].split(";").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/parser/message.rs:68:26 [INFO] [stderr] | [INFO] [stderr] 68 | self.position += msg_size as u64 + 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(msg_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:13:23 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn as_u64_le(arr: &[u8; 8]) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/unpack/mod.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | .map(|(i, v)| (v.clone() as u64) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(v.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unpack/mod.rs:16:24 [INFO] [stderr] | [INFO] [stderr] 16 | .map(|(i, v)| (v.clone() as u64) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:29:23 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn as_u32_le(arr: &[u8; 4]) -> u32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/unpack/mod.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|(i, v)| (v.clone() as u32) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(v.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unpack/mod.rs:32:24 [INFO] [stderr] | [INFO] [stderr] 32 | .map(|(i, v)| (v.clone() as u32) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn as_i32_le(arr: &[u8; 4]) -> i32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:58:23 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn as_u16_le(arr: &[u8; 2]) -> u16 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/unpack/mod.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(i, v)| (v.clone() as u16) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(v.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/unpack/mod.rs:61:24 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(i, v)| (v.clone() as u16) << (8 * i)) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*v` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/unpack/mod.rs:74:23 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn as_f32_le(arr: &[u8; 4]) -> f32 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "2aa91b413f88588814879515dab33ecb524f3abb5879bcfaee7e72d4484f818f"` [INFO] running `"docker" "rm" "-f" "2aa91b413f88588814879515dab33ecb524f3abb5879bcfaee7e72d4484f818f"` [INFO] [stdout] 2aa91b413f88588814879515dab33ecb524f3abb5879bcfaee7e72d4484f818f